PluggableSchemaManagerFactory - Code Metrics - Inspection of "Removing run-time dependency on schema manager and..." - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#401)

by Sebastian

created 2017-10-18 16:34 UTC

PluggableSchemaManagerFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	0
loc	44
rs	10
c	0
b	0
f	0
wmc	3
lcom	1
cbo	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	addPluginManager()	0	3	1
A	getSchemaManager()	0	7	2

<?php

namespace Drupal\graphql\Plugin\GraphQL;

use Drupal\Component\Plugin\PluginManagerInterface;

class PluggableSchemaManagerFactory {

  /**
   * Static cache of created schema managers.
   *
   * @var \Drupal\graphql\Plugin\GraphQL\PluggableSchemaManagerInterface[]
   */
  protected $schemaManagers = [];

  /**
   * Plugin managers, used to collect GraphQL schema plugins.
   *
   * @var \Drupal\Component\Plugin\PluginManagerInterface[]
   */
  protected $pluginManagers = [];

  /**
   * Add a plugin manager.
   *
   * @param \Drupal\Component\Plugin\PluginManagerInterface $pluginManager
   *   The plugin manager to attach.
   */
  public function addPluginManager(PluginManagerInterface $pluginManager) {
    $this->pluginManagers[] = $pluginManager;
  }

  /**
   * Add a plugin manager.
   *
   * @param string $schema
   *   The name of the schema to fetch the schema manager for.
   *
   * @return \Drupal\graphql\Plugin\GraphQL\PluggableSchemaManagerInterface
   *   The dedicated pluggable schema manager instance for the given schema.
   */
  public function getSchemaManager($schema) {
    if (!isset($schemaManagers[$schema])) {

      $schemaManagers[$schema] = new PluggableSchemaManager($this->pluginManagers);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    }

    return $schemaManagers[$schema];
  }

}


1			<?php
2
3			namespace Drupal\graphql\Plugin\GraphQL;
4
5			use Drupal\Component\Plugin\PluginManagerInterface;
6
7			class PluggableSchemaManagerFactory {
8
9			/**
10			* Static cache of created schema managers.
11			*
12			* @var \Drupal\graphql\Plugin\GraphQL\PluggableSchemaManagerInterface[]
13			*/
14			protected $schemaManagers = [];
15
16			/**
17			* Plugin managers, used to collect GraphQL schema plugins.
18			*
19			* @var \Drupal\Component\Plugin\PluginManagerInterface[]
20			*/
21			protected $pluginManagers = [];
22
23			/**
24			* Add a plugin manager.
25			*
26			* @param \Drupal\Component\Plugin\PluginManagerInterface $pluginManager
27			* The plugin manager to attach.
28			*/
29			public function addPluginManager(PluginManagerInterface $pluginManager) {
30			$this->pluginManagers[] = $pluginManager;
31			}
32
33			/**
34			* Add a plugin manager.
35			*
36			* @param string $schema
37			* The name of the schema to fetch the schema manager for.
38			*
39			* @return \Drupal\graphql\Plugin\GraphQL\PluggableSchemaManagerInterface
40			* The dedicated pluggable schema manager instance for the given schema.
41			*/
42			public function getSchemaManager($schema) {
43			if (!isset($schemaManagers[$schema])) {
			0 ignored issues – show Bug introduced 2017-10-18 16:31 UTC by Report Bug Copy Issue Report The variable `$schemaManagers` seems only to be defined at a later point. As such the call to `isset()` seems to always evaluate to `false`. This check marks calls to `isset(...)` or `empty(...)` that are found before the variable itself is defined. These will always have the same result. This is likely the result of code being shifted around. Consider removing these calls. Loading history...
44			$schemaManagers[$schema] = new PluggableSchemaManager($this->pluginManagers);
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-18 16:31 UTC by Report Bug Copy Issue Report `$schemaManagers` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$schemaManagers = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
45			}
46
47			return $schemaManagers[$schema];
48			}
49
50			}
51

drupal-graphql / graphql

Pull Request — 8.x-3.x (#401)

PluggableSchemaManagerFactory A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like