Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class DeleteEntityTest extends GraphQLFileTestBase { |
||
16 | use ContentTypeCreationTrait; |
||
17 | use NodeCreationTrait; |
||
18 | |||
19 | /** |
||
20 | * {@inheritdoc} |
||
21 | */ |
||
22 | public static $modules = [ |
||
23 | 'node', |
||
24 | 'field', |
||
25 | 'text', |
||
26 | 'filter', |
||
27 | 'graphql_core', |
||
28 | ]; |
||
29 | |||
30 | /** |
||
31 | * {@inheritdoc} |
||
32 | */ |
||
33 | View Code Duplication | protected function setUp() { |
|
46 | |||
47 | /** |
||
48 | * Test deletion. |
||
49 | */ |
||
50 | public function testDeletion() { |
||
59 | |||
60 | /** |
||
61 | * Test deletion without the necessary permissions |
||
62 | */ |
||
63 | public function testDeletionWithoutPermission() { |
||
75 | |||
76 | /** |
||
77 | * Test deletion of a non-existent entity. |
||
78 | */ |
||
79 | public function testDeletionOfNonExistentEntity() { |
||
86 | |||
87 | } |
||
88 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.