SchemaLoader - Code Metrics - Inspection of "Implement query reducers." - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#519)

by Sebastian

created 2018-02-15 08:59 UTC

SchemaLoader A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	241
Duplicated Lines	2.9 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	28
lcom	1
cbo	2
dl	7
loc	241
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	1
D	getSchema()	0	32	9
C	getCacheMetadata()	0	30	7
B	extractCacheMetadata()	0	20	8
A	maxAgeToExpire()	7	7	2
A	getCacheIdentifier()	0	5	1

How to fix Duplicated Code

<?php

namespace Drupal\graphql\GraphQL\Schema;

use Drupal\graphql\GraphQL\CacheableEdgeInterface;
use Drupal\graphql\GraphQL\Utility\TypeCollector;
use Drupal\Core\Cache\Cache;
use Drupal\Core\Cache\CacheableDependencyInterface;
use Drupal\Core\Cache\CacheableMetadata;
use Drupal\Core\Cache\CacheBackendInterface;
use Drupal\Core\Cache\Context\CacheContextsManager;
use Drupal\graphql\Plugin\GraphQL\SchemaPluginManager;
use Symfony\Component\HttpFoundation\RequestStack;
use Youshido\GraphQL\Schema\AbstractSchema;
use Youshido\GraphQL\Type\InputObject\AbstractInputObjectType;
use Youshido\GraphQL\Type\InterfaceType\AbstractInterfaceType;
use Youshido\GraphQL\Type\Object\AbstractObjectType;

/**
 * Loads and caches a generated GraphQL schema.
 */
class SchemaLoader {

  /**
   * The cache contexts manager service.
   *
   * @var \Drupal\Core\Cache\Context\CacheContextsManager
   */
  protected $contextsManager;

  /**
   * The schema plugin manager service.
   *
   * @var \Drupal\graphql\Plugin\GraphQL\SchemaPluginManager
   */
  protected $schemaManager;

  /**
   * The schema cache backend.
   *
   * @var \Drupal\Core\Cache\CacheBackendInterface
   */
  protected $schemaCache;

  /**
   * The cache metadata cache.
   *
   * @var \Drupal\Core\Cache\CacheBackendInterface
   */
  protected $metadataCache;

  /**
   * The service configuration.
   *
   * @var array
   */
  protected $config;

  /**
   * The request stack service.
   *
   * @var \Symfony\Component\HttpFoundation\RequestStack
   */
  protected $requestStack;

  /**
   * Static cache of loaded schemas.
   *
   * @var \Youshido\GraphQL\Schema\AbstractSchema[]
   */
  protected $schemas = [];

  /**
   * Static cache of loaded cache metadata.
   *
   * @var \Drupal\Core\Cache\RefinableCacheableDependencyInterface[]
   */
  protected $metadata = [];

  /**
   * SchemaLoader constructor.
   *
   * @param \Drupal\Core\Cache\Context\CacheContextsManager $contextsManager
   *   The cache contexts manager service.
   * @param \Symfony\Component\HttpFoundation\RequestStack $requestStack
   *   The request stack service.
   * @param \Drupal\graphql\Plugin\GraphQL\SchemaPluginManager $schemaManager
   *   The schema plugin manager service.
   * @param \Drupal\Core\Cache\CacheBackendInterface $schemaCache
   *   The schema cache backend.
   * @param \Drupal\Core\Cache\CacheBackendInterface $metadataCache
   *   The metadata cache backend.
   * @param array $config
   *   The configuration provided through the services.yml.
   */
  public function __construct(
    CacheContextsManager $contextsManager,
    RequestStack $requestStack,
    SchemaPluginManager $schemaManager,
    CacheBackendInterface $schemaCache,
    CacheBackendInterface $metadataCache,
    array $config
  ) {
    $this->config = $config;
    $this->schemaManager = $schemaManager;
    $this->contextsManager = $contextsManager;
    $this->schemaCache = $schemaCache;
    $this->metadataCache = $metadataCache;
    $this->requestStack = $requestStack;
  }

  /**
   * Loads and caches the generated schema.
   *
   * @param string $name
   *   The name of the schema to load.
   *
   * @return \Youshido\GraphQL\Schema\AbstractSchema
   *   The generated GraphQL schema.
   */
  public function getSchema($name) {
    if (($schema = &$this->schemas[$name]) !== NULL) {
      return $schema;
    }

    $schemaCache = !empty($this->config['schema_cache']);
    if (!empty($schemaCache) && ($cache = $this->metadataCache->get($name)) && $cache->data) {
      $cid = $this->getCacheIdentifier($name, $cache->data);

      if (($cache = $this->schemaCache->get($cid)) && $cache->data) {
        return $schema = $cache->data;
      }
    }

    // Get the schema object from the plugin instance.
    $schema = $this->schemaManager->createInstance($name)->getSchema();
    if (empty($schemaCache)) {
      return $schema;
    }

    $metadata = $this->getCacheMetadata($name);
    if ($metadata->getCacheMaxAge() !== 0) {
      $tags = $metadata->getCacheTags();
      $expire = $this->maxAgeToExpire($metadata->getCacheMaxAge());
      $cid = $this->getCacheIdentifier($name, $metadata);

      // Write the cache entry for the schema cache entries.
      $this->schemaCache->set($cid, $schema, $expire, $tags);
    }

    return $schema;
  }

  /**
   * Retrieves the schema's cache metadata.
   *
   * @param string $name
   *   The name of the schema.
   * @return \Drupal\Core\Cache\RefinableCacheableDependencyInterface
   *   The cache metadata for the schema.
   */
  public function getCacheMetadata($name) {
    if (array_key_exists($name, $this->metadata)) {
      return $this->metadata[$name];
    }

    // The cache key is made up of all of the globally known cache contexts.
    if (!empty($this->config['schema_cache'])) {
      if (($metadataCache = $this->metadataCache->get($name)) && $metadataCache->data) {
        return $this->metadata[$name] = $metadataCache->data;
      }
    }

    /** @var \Drupal\Core\Cache\RefinableCacheableDependencyInterface $metadata */
    $schema = $this->getSchema($name);
    $metadata = $this->extractCacheMetadata($schema);
    $this->metadata[$name] = $metadata;
    if (empty($this->config['schema_cache'])) {
      return $this->metadata[$name];

    }

    if (($maxAge = $metadata->getCacheMaxAge()) !== 0) {
      $tags = $metadata->getCacheTags();
      $expire = $this->maxAgeToExpire($maxAge);

      // Write the cache entry for the schema cache metadata.
      $this->metadataCache->set($name, $metadata, $expire, $tags);
    }

    return $metadata;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
  }

  /**
   * Collects schema cache metadata from all types registered with the schema.
   *
   * The cache metadata is statically cached. This means that the schema may not
   * be modified after this method has been called.
   *
   * @param \Youshido\GraphQL\Schema\AbstractSchema $schema
   *   The schema to extract the cache metadata from.
   *
   * @return \Drupal\Core\Cache\CacheableMetadata
   *   The cache metadata collected from the schema's types.
   */
  protected function extractCacheMetadata(AbstractSchema $schema) {
    $metadata = new CacheableMetadata();
    $metadata->addCacheTags(['graphql_schema']);

    foreach (TypeCollector::collectTypes($schema) as $type) {
      if ($type instanceof CacheableEdgeInterface) {
        $metadata->addCacheableDependency($type->getSchemaCacheMetadata());
      }

      if ($type instanceof AbstractObjectType || $type instanceof AbstractInputObjectType || $type instanceof AbstractInterfaceType) {
        foreach ($type->getFields() as $field) {
          if ($field instanceof CacheableEdgeInterface) {
            $metadata->addCacheableDependency($field->getSchemaCacheMetadata());
          }
        }
      }
    }

    return $metadata;
  }

  /**
   * Maps a max age value to an "expire" value for the Cache API.
   *
   * @param int $maxAge
   *   A max age value.
   *
   * @return int
   *   A corresponding "expire" value.
   *
   * @see \Drupal\Core\Cache\CacheBackendInterface::set()
   */
  protected function maxAgeToExpire($maxAge) {

    if ($maxAge === Cache::PERMANENT) {
      return Cache::PERMANENT;
    }

    return (int) $this->requestStack->getMasterRequest()->server->get('REQUEST_TIME') + $maxAge;
  }

  /**
   * Generates a cache identifier for the passed cache contexts.
   *
   * @param string $name
   *   The name of the schema.
   * @param \Drupal\Core\Cache\CacheableDependencyInterface $metadata
   *   Optional array of cache context tokens.
   *
   * @return string The generated cache identifier.
   *   The generated cache identifier.
   */
  protected function getCacheIdentifier($name, CacheableDependencyInterface $metadata) {
    $tokens = $metadata->getCacheContexts();
    $keys = $this->contextsManager->convertTokensToKeys($tokens)->getKeys();
    return implode(':', array_merge(['graphql', $name], array_values($keys)));
  }

}


1		<?php
2
3		namespace Drupal\graphql\GraphQL\Schema;
4
5		use Drupal\graphql\GraphQL\CacheableEdgeInterface;
6		use Drupal\graphql\GraphQL\Utility\TypeCollector;
7		use Drupal\Core\Cache\Cache;
8		use Drupal\Core\Cache\CacheableDependencyInterface;
9		use Drupal\Core\Cache\CacheableMetadata;
10		use Drupal\Core\Cache\CacheBackendInterface;
11		use Drupal\Core\Cache\Context\CacheContextsManager;
12		use Drupal\graphql\Plugin\GraphQL\SchemaPluginManager;
13		use Symfony\Component\HttpFoundation\RequestStack;
14		use Youshido\GraphQL\Schema\AbstractSchema;
15		use Youshido\GraphQL\Type\InputObject\AbstractInputObjectType;
16		use Youshido\GraphQL\Type\InterfaceType\AbstractInterfaceType;
17		use Youshido\GraphQL\Type\Object\AbstractObjectType;
18
19		/**
20		* Loads and caches a generated GraphQL schema.
21		*/
22		class SchemaLoader {
23
24		/**
25		* The cache contexts manager service.
26		*
27		* @var \Drupal\Core\Cache\Context\CacheContextsManager
28		*/
29		protected $contextsManager;
30
31		/**
32		* The schema plugin manager service.
33		*
34		* @var \Drupal\graphql\Plugin\GraphQL\SchemaPluginManager
35		*/
36		protected $schemaManager;
37
38		/**
39		* The schema cache backend.
40		*
41		* @var \Drupal\Core\Cache\CacheBackendInterface
42		*/
43		protected $schemaCache;
44
45		/**
46		* The cache metadata cache.
47		*
48		* @var \Drupal\Core\Cache\CacheBackendInterface
49		*/
50		protected $metadataCache;
51
52		/**
53		* The service configuration.
54		*
55		* @var array
56		*/
57		protected $config;
58
59		/**
60		* The request stack service.
61		*
62		* @var \Symfony\Component\HttpFoundation\RequestStack
63		*/
64		protected $requestStack;
65
66		/**
67		* Static cache of loaded schemas.
68		*
69		* @var \Youshido\GraphQL\Schema\AbstractSchema[]
70		*/
71		protected $schemas = [];
72
73		/**
74		* Static cache of loaded cache metadata.
75		*
76		* @var \Drupal\Core\Cache\RefinableCacheableDependencyInterface[]
77		*/
78		protected $metadata = [];
79
80		/**
81		* SchemaLoader constructor.
82		*
83		* @param \Drupal\Core\Cache\Context\CacheContextsManager $contextsManager
84		* The cache contexts manager service.
85		* @param \Symfony\Component\HttpFoundation\RequestStack $requestStack
86		* The request stack service.
87		* @param \Drupal\graphql\Plugin\GraphQL\SchemaPluginManager $schemaManager
88		* The schema plugin manager service.
89		* @param \Drupal\Core\Cache\CacheBackendInterface $schemaCache
90		* The schema cache backend.
91		* @param \Drupal\Core\Cache\CacheBackendInterface $metadataCache
92		* The metadata cache backend.
93		* @param array $config
94		* The configuration provided through the services.yml.
95		*/
96		public function __construct(
97		CacheContextsManager $contextsManager,
98		RequestStack $requestStack,
99		SchemaPluginManager $schemaManager,
100		CacheBackendInterface $schemaCache,
101		CacheBackendInterface $metadataCache,
102		array $config
103		) {
104		$this->config = $config;
105		$this->schemaManager = $schemaManager;
106		$this->contextsManager = $contextsManager;
107		$this->schemaCache = $schemaCache;
108		$this->metadataCache = $metadataCache;
109		$this->requestStack = $requestStack;
110		}
111
112		/**
113		* Loads and caches the generated schema.
114		*
115		* @param string $name
116		* The name of the schema to load.
117		*
118		* @return \Youshido\GraphQL\Schema\AbstractSchema
119		* The generated GraphQL schema.
120		*/
121		public function getSchema($name) {
122		if (($schema = &$this->schemas[$name]) !== NULL) {
123		return $schema;
124		}
125
126		$schemaCache = !empty($this->config['schema_cache']);
127		if (!empty($schemaCache) && ($cache = $this->metadataCache->get($name)) && $cache->data) {
128		$cid = $this->getCacheIdentifier($name, $cache->data);
129
130		if (($cache = $this->schemaCache->get($cid)) && $cache->data) {
131		return $schema = $cache->data;
132		}
133		}
134
135		// Get the schema object from the plugin instance.
136		$schema = $this->schemaManager->createInstance($name)->getSchema();
137		if (empty($schemaCache)) {
138		return $schema;
139		}
140
141		$metadata = $this->getCacheMetadata($name);
142		if ($metadata->getCacheMaxAge() !== 0) {
143		$tags = $metadata->getCacheTags();
144		$expire = $this->maxAgeToExpire($metadata->getCacheMaxAge());
145		$cid = $this->getCacheIdentifier($name, $metadata);
146
147		// Write the cache entry for the schema cache entries.
148		$this->schemaCache->set($cid, $schema, $expire, $tags);
149		}
150
151		return $schema;
152		}
153
154		/**
155		* Retrieves the schema's cache metadata.
156		*
157		* @param string $name
158		* The name of the schema.
159		* @return \Drupal\Core\Cache\RefinableCacheableDependencyInterface
160		* The cache metadata for the schema.
161		*/
162		public function getCacheMetadata($name) {
163		if (array_key_exists($name, $this->metadata)) {
164		return $this->metadata[$name];
165		}
166
167		// The cache key is made up of all of the globally known cache contexts.
168		if (!empty($this->config['schema_cache'])) {
169		if (($metadataCache = $this->metadataCache->get($name)) && $metadataCache->data) {
170		return $this->metadata[$name] = $metadataCache->data;
171		}
172		}
173
174		/** @var \Drupal\Core\Cache\RefinableCacheableDependencyInterface $metadata */
175		$schema = $this->getSchema($name);
176		$metadata = $this->extractCacheMetadata($schema);
177		$this->metadata[$name] = $metadata;
178		if (empty($this->config['schema_cache'])) {
179		return $this->metadata[$name];
		0 ignored issues – show Bug Compatibility introduced 2018-02-15 09:01 UTC by Report Bug Copy Issue Report The expression `$this->metadata[$name];` of type `Drupal\Core\Cache\Refina...Cache\CacheableMetadata` adds the type `Drupal\Core\Cache\CacheableMetadata` to the return on line 179 which is incompatible with the return type documented by `Drupal\graphql\GraphQL\S...oader::getCacheMetadata` of type `Drupal\Core\Cache\Refina...ableDependencyInterface`. Loading history...
180		}
181
182		if (($maxAge = $metadata->getCacheMaxAge()) !== 0) {
183		$tags = $metadata->getCacheTags();
184		$expire = $this->maxAgeToExpire($maxAge);
185
186		// Write the cache entry for the schema cache metadata.
187		$this->metadataCache->set($name, $metadata, $expire, $tags);
188		}
189
190		return $metadata;
		0 ignored issues – show Bug Best Practice introduced 2018-02-15 09:01 UTC by Report Bug Copy Issue Report The return type of `return $metadata;` (`Drupal\Core\Cache\CacheableMetadata`) is incompatible with the return type documented by `Drupal\graphql\GraphQL\S...oader::getCacheMetadata` of type `Drupal\Core\Cache\Refina...ableDependencyInterface`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
191		}
192
193		/**
194		* Collects schema cache metadata from all types registered with the schema.
195		*
196		* The cache metadata is statically cached. This means that the schema may not
197		* be modified after this method has been called.
198		*
199		* @param \Youshido\GraphQL\Schema\AbstractSchema $schema
200		* The schema to extract the cache metadata from.
201		*
202		* @return \Drupal\Core\Cache\CacheableMetadata
203		* The cache metadata collected from the schema's types.
204		*/
205		protected function extractCacheMetadata(AbstractSchema $schema) {
206		$metadata = new CacheableMetadata();
207		$metadata->addCacheTags(['graphql_schema']);
208
209		foreach (TypeCollector::collectTypes($schema) as $type) {
210		if ($type instanceof CacheableEdgeInterface) {
211		$metadata->addCacheableDependency($type->getSchemaCacheMetadata());
212		}
213
214		if ($type instanceof AbstractObjectType \|\| $type instanceof AbstractInputObjectType \|\| $type instanceof AbstractInterfaceType) {
215		foreach ($type->getFields() as $field) {
216		if ($field instanceof CacheableEdgeInterface) {
217		$metadata->addCacheableDependency($field->getSchemaCacheMetadata());
218		}
219		}
220		}
221		}
222
223		return $metadata;
224		}
225
226		/**
227		* Maps a max age value to an "expire" value for the Cache API.
228		*
229		* @param int $maxAge
230		* A max age value.
231		*
232		* @return int
233		* A corresponding "expire" value.
234		*
235		* @see \Drupal\Core\Cache\CacheBackendInterface::set()
236		*/
237	View Code Duplication	protected function maxAgeToExpire($maxAge) {
		0 ignored issues – show Duplication introduced 2018-02-14 16:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
238		if ($maxAge === Cache::PERMANENT) {
239		return Cache::PERMANENT;
240		}
241
242		return (int) $this->requestStack->getMasterRequest()->server->get('REQUEST_TIME') + $maxAge;
243		}
244
245		/**
246		* Generates a cache identifier for the passed cache contexts.
247		*
248		* @param string $name
249		* The name of the schema.
250		* @param \Drupal\Core\Cache\CacheableDependencyInterface $metadata
251		* Optional array of cache context tokens.
252		*
253		* @return string The generated cache identifier.
254		* The generated cache identifier.
255		*/
256		protected function getCacheIdentifier($name, CacheableDependencyInterface $metadata) {
257		$tokens = $metadata->getCacheContexts();
258		$keys = $this->contextsManager->convertTokensToKeys($tokens)->getKeys();
259		return implode(':', array_merge(['graphql', $name], array_values($keys)));
260		}
261
262		}
263

drupal-graphql / graphql

Pull Request — 8.x-3.x (#519)

SchemaLoader A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like