EntityFieldValueTest::nodeValuesProvider() - Code Metrics - Inspection of "Refactoring towards webonyx/graphql-php." - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#525)

by Philipp

created 2018-03-06 07:30 UTC

EntityFieldValueTest::nodeValuesProvider() B

↳ Parent: EntityFieldValueTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	184
Code Lines	127

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	1
eloc	127
nc	1
nop	0
dl	0
loc	184
rs	8.2857
c	1
b	1
f	0

How to fix Long Method

<?php

namespace Drupal\Tests\graphql_core\Kernel\Entity;

use Drupal\file\Entity\File;
use Drupal\graphql\Utility\StringHelper;
use Drupal\node\Entity\Node;
use Drupal\Tests\graphql_core\Kernel\GraphQLContentTestBase;
use GraphQL\Server\OperationParams;

/**
 * Test basic entity fields.
 *
 * @group graphql_core
 */
class EntityFieldValueTest extends GraphQLContentTestBase {

  /**
   * @var File
   */
  protected $testFile;

  /**
   * @var File
   */
  protected $testImage;

  /**
   * {@inheritdoc}
   */
  public static $modules = [
    'link',
    'datetime',
    'image',
    'file',
  ];

  /**
   * {@inheritdoc}
   */
  protected function setUp() {
    parent::setUp();
  }

  /**
   * Test boolean fields.
   */
  public function testBoolean() {
    $this->addField('boolean', "field_boolean", FALSE);

    $this->mockNode([
      'field_boolean' => TRUE,
    ]);

    $this->assertGraphQLFields([
      ['NodeTest', 'fieldBoolean', 'Boolean'],
    ]);

    $query = <<<GQL
query {
  node {
    fieldBoolean
  }
}
GQL;

    $metadata = $this->defaultCacheMetaData();
    $metadata->addCacheTags([
      'config:field.storage.node.field_boolean',
      'entity_field_info',
    ]);

    $this->assertResults($query, [], [
      'node' => [
        'fieldBoolean' => TRUE,
      ],
    ], $metadata);
  }

  /**
   * Test a simple text field.
   */
  public function testText() {
    $this->addField('text', "field_text", FALSE);
    $this->mockNode([
      'field_text' => [
        'value' => 'Foo',
      ],
    ]);

    $this->assertGraphQLFields([
      ['NodeTest', 'fieldText', 'FieldNodeFieldText'],
      ['FieldNodeFieldText', 'value', 'String'],
      ['FieldNodeFieldText', 'processed', 'String'],
      ['FieldNodeFieldText', 'format', 'String'],
    ]);

    $query = <<<GQL
query {
  node {
    fieldText {
      value
      processed
      format
    }
  }
}
GQL;

    $metadata = $this->defaultCacheMetaData();
    $metadata->addCacheTags([
      'config:field.storage.node.field_text',
      'entity_field_info',
    ]);

    $this->assertResults($query, [], [
      'node' => [
        'fieldText' => [
          'value' => 'Foo',
          'processed' => "<p>Foo</p>\n",
          'format' => 'null',
        ],
      ],
    ], $metadata);

  }

  /**
   * Test filtered text fields.
   */
  public function testFilteredText() {
    $this->mockNode([
      'body' => [
        'value' => 'http://www.drupal.org',
        'format' => 'plain_text',
      ],
    ]);

    $this->assertGraphQLFields([
      ['NodeTest', 'body', 'FieldNodeBody'],
      ['FieldNodeBody', 'format', 'String'],
      ['FieldNodeBody', 'value', 'String'],
      ['FieldNodeBody', 'processed', 'String'],
      ['FieldNodeBody', 'summary', 'String'],
      ['FieldNodeBody', 'summaryProcessed', 'String'],
    ]);

    $query = <<<GQL
query {
  node {
    body {
      value
      processed
      summary
      summaryProcessed
    }
  }
}
GQL;

    $metadata = $this->defaultCacheMetaData();
    $metadata->addCacheTags([
      'config:field.storage.node.body',
      'entity_field_info',
    ]);

    $this->assertResults($query, [], [
      'node' => [
        'body' => [
          'value' => 'http://www.drupal.org',
          'processed' => "<p><a href=\"http://www.drupal.org\">http://www.drupal.org</a></p>\n",
          'summary' => 'null',
          'summaryProcessed' => '',
        ],
      ],
    ], $metadata);
  }

  /**
   * Test if the basic fields are available on the interface.
   *
   * @dataProvider nodeValuesProvider
   *
   * @param array $actualFieldValues
   * @param array $expectedFieldValues
   */
  public function testRawValues($actualFieldValues, $expectedFieldValues) {
    $this->installEntitySchema('file');
    $this->installSchema('file', ['file_usage']);
    $this->addField('text', "field_text");
    $this->addField('boolean', "field_boolean");
    $this->addField('link', "field_link");
    $this->addField('integer', "field_integer");
    $this->addField('float', "field_float");
    $this->addField('decimal', "field_decimal");
    $this->addField('datetime', "field_datetime");
    $this->addField('timestamp', "field_timestamp");
    $this->addField('email', "field_email");
    $this->addField('string', "field_string");
    $this->addField('entity_reference', 'field_reference');
    $this->addField('file', 'field_file');
    $this->addField('image', 'field_image');

    // File 1
    file_put_contents('public://example.txt', $this->randomMachineName());
    $this->testFile = File::create([
      'uri' => 'public://example.txt',
    ]);
    $this->testFile->save();

    // File 2
    file_put_contents('public://example.png', $this->randomMachineName());
    $this->testImage = File::create([
      'uri' => 'public://example.png',
    ]);
    $this->testImage->save();
    $values = [
      'title' => 'Test',
      'type' => 'test',
    ];

    $node = $this->createNode($values + $actualFieldValues);

    // Workaround for public file urls.
    $expectedFieldValues['fieldFile'][0]['entity']['url'] = file_create_url($this->testFile->getFileUri());
    $expectedFieldValues['fieldFile'][1]['entity']['url'] = file_create_url($this->testImage->getFileUri());
    $expectedFieldValues['fieldImage'][0]['entity']['url'] = file_create_url($this->testFile->getFileUri());
    $expectedFieldValues['fieldImage'][1]['entity']['url'] = file_create_url($this->testImage->getFileUri());

    $metadata = $this->defaultCacheMetaData();
    $metadata->addCacheTags([
      'config:field.storage.node.body',
      'config:field.storage.node.field_text',
      'config:field.storage.node.field_boolean',
      'config:field.storage.node.field_datetime',
      'config:field.storage.node.field_decimal',
      'config:field.storage.node.field_email',
      'config:field.storage.node.field_float',
      'config:field.storage.node.field_file',
      'config:field.storage.node.field_image',
      'config:field.storage.node.field_integer',
      'config:field.storage.node.field_link',
      'config:field.storage.node.field_string',
      'config:field.storage.node.field_timestamp',
      'config:field.storage.node.field_reference',
      'entity_field_info',
      'node:1',
      'file:1',
      'file:2',
    ]);

    $this->assertResults($this->getQueryFromFile('raw_field_values.gql'), [
      'path' => '/node/' . $node->id(),
    ], [
      'route' => ['entity' => $expectedFieldValues],
    ], $metadata);
  }

  /**
   * Data provider for testRawValues.
   *
   * @return array
   */
  public function nodeValuesProvider() {
    $fieldValues = [
      'body' => [
        'value' => 'test',
        'summary' => 'test summary',
      ],
      'field_text' => ['a', 'b', 'c'],
      'field_boolean' => [TRUE, FALSE],
      'field_link' => [
        [
          'title' => 'Internal link',
          'uri' => 'internal:/node/1',
          'options' => ['attributes' => ['_target' => 'blank']],
        ], [
          'title' => 'External link',
          'uri' => 'http://drupal.org',
          'options' => ['attributes' => ['_target' => 'blank']],
        ],
      ],
      'field_integer' => [10, -5],
      'field_float' => [3.14145, -8.8],
      'field_decimal' => [10.5, -17.22],
      'field_datetime' => ['2017-01-01', '1900-01-01'],
      'field_timestamp' => [0, 300],
      'field_email' => ['[email protected]'],
      'field_string' => ['test', '123'],
      'field_reference' =>  [
        ['target_id' => 1],
      ],
      'field_file' => [
        [
          'target_id' => 1,
          'display' => 0,
          'description' => 'description test 1',
        ],
        [
          'target_id' => 2,
          'display' => 1,
          'description' => 'description test 2',
        ],
      ],
      'field_image' => [
        [
          'target_id' => 1,
          'alt' => 'alt test 1',
          'title' => 'title test 1',
          'width' => 100,
          'height' => 50,
        ],
        [
          'target_id' => 2,
          'alt' => 'alt test 2',
          'title' => 'title test 2',
          'width' => 200,
          'height' => 100,
        ],
      ],
    ];

    $expected = [
      'nid' => 1,
      'vid' => 1,
      'langcode' => [
        'value' => 'en',
      ],
      'type' => [
        'targetId' => 'test',
      ],
      'uid' => [
        'targetId' => 0,
        'entity' => NULL,
      ],
      'title' => 'Test',
      'status' => TRUE,
      'promote' => TRUE,
      'sticky' => FALSE,
      'revisionTranslationAffected' => TRUE,
      'body' => [
        'value' => 'test',
        'summary' => 'test summary',
        'summaryProcessed' => "<p>test summary</p>\n",
        'processed' => "<p>test</p>\n",
        'format' => 'null',
      ],
      'fieldText' => [
        ['value' => 'a'],
        ['value' => 'b'],
        ['value' => 'c'],
      ],
      'fieldBoolean' => [
        TRUE,
        FALSE,
      ],
      'fieldLink' => [
        ['title' => 'Internal link', 'uri' => 'internal:/node/1', 'target' => 'blank', 'url' => ['internal' => '/node/1']],
        ['title' => 'External link', 'uri' => 'http://drupal.org', 'target' => 'blank', 'url' => ['external' => 'http://drupal.org']],
      ],
      'fieldInteger' => [
        10,
        -5,
      ],
      'fieldFloat' => [
        3.14145,
        -8.8,
      ],
      'fieldDecimal' => [
        10.5,
        -17.22,
      ],
      'fieldDatetime' => [
        ['value' => '2017-01-01'],
        ['value' => '1900-01-01'],
      ],
      'fieldTimestamp' => [
        0,
        300,
      ],
      'fieldEmail' => ['[email protected]'],
      'fieldString' => [
        'test',
        '123',
      ],
      'fieldReference' => [
        [
          'targetId' => 1,
          'entity' => [
            'title' => 'Test',
            'fieldReference' => [
              [
                'targetId' => 1,
                'entity' => [
                  'title' => 'Test',
                ],
              ],
            ],
          ],
        ],
      ],
      'fieldFile' => [
        [
          'targetId' => 1,
          'display' => 0,
          'description' => 'description test 1',
          'entity' => [
            'uri' => 'public://example.txt',
          ],
        ],
        [
          'targetId' => 2,
          'display' => 1,
          'description' => 'description test 2',
          'entity' => [
            'uri' => 'public://example.png',
          ],
        ],
      ],
      'fieldImage' => [
        [
          'targetId' => 1,
          'alt' => 'alt test 1',
          'title' => 'title test 1',
          'width' => 100,
          'height' => 50,
          'entity' => [
            'uri' => 'public://example.txt',
          ],
        ],
        [
          'targetId' => 2,
          'alt' => 'alt test 2',
          'title' => 'title test 2',
          'width' => 200,
          'height' => 100,
          'entity' => [
            'uri' => 'public://example.png',
          ],
        ],
      ],
    ];

    return [
      [$fieldValues, $expected],
    ];
  }

}


1			<?php
2
3			namespace Drupal\Tests\graphql_core\Kernel\Entity;
4
5			use Drupal\file\Entity\File;
6			use Drupal\graphql\Utility\StringHelper;
7			use Drupal\node\Entity\Node;
8			use Drupal\Tests\graphql_core\Kernel\GraphQLContentTestBase;
9			use GraphQL\Server\OperationParams;
10
11			/**
12			* Test basic entity fields.
13			*
14			* @group graphql_core
15			*/
16			class EntityFieldValueTest extends GraphQLContentTestBase {
17
18			/**
19			* @var File
20			*/
21			protected $testFile;
22
23			/**
24			* @var File
25			*/
26			protected $testImage;
27
28			/**
29			* {@inheritdoc}
30			*/
31			public static $modules = [
32			'link',
33			'datetime',
34			'image',
35			'file',
36			];
37
38			/**
39			* {@inheritdoc}
40			*/
41			protected function setUp() {
42			parent::setUp();
43			}
44
45			/**
46			* Test boolean fields.
47			*/
48			public function testBoolean() {
49			$this->addField('boolean', "field_boolean", FALSE);
50
51			$this->mockNode([
52			'field_boolean' => TRUE,
53			]);
54
55			$this->assertGraphQLFields([
56			['NodeTest', 'fieldBoolean', 'Boolean'],
57			]);
58
59			$query = <<<GQL
60			query {
61			node {
62			fieldBoolean
63			}
64			}
65			GQL;
66
67			$metadata = $this->defaultCacheMetaData();
68			$metadata->addCacheTags([
69			'config:field.storage.node.field_boolean',
70			'entity_field_info',
71			]);
72
73			$this->assertResults($query, [], [
74			'node' => [
75			'fieldBoolean' => TRUE,
76			],
77			], $metadata);
78			}
79
80			/**
81			* Test a simple text field.
82			*/
83			public function testText() {
84			$this->addField('text', "field_text", FALSE);
85			$this->mockNode([
86			'field_text' => [
87			'value' => 'Foo',
88			],
89			]);
90
91			$this->assertGraphQLFields([
92			['NodeTest', 'fieldText', 'FieldNodeFieldText'],
93			['FieldNodeFieldText', 'value', 'String'],
94			['FieldNodeFieldText', 'processed', 'String'],
95			['FieldNodeFieldText', 'format', 'String'],
96			]);
97
98			$query = <<<GQL
99			query {
100			node {
101			fieldText {
102			value
103			processed
104			format
105			}
106			}
107			}
108			GQL;
109
110			$metadata = $this->defaultCacheMetaData();
111			$metadata->addCacheTags([
112			'config:field.storage.node.field_text',
113			'entity_field_info',
114			]);
115
116			$this->assertResults($query, [], [
117			'node' => [
118			'fieldText' => [
119			'value' => 'Foo',
120			'processed' => "<p>Foo</p>\n",
121			'format' => 'null',
122			],
123			],
124			], $metadata);
125
126			}
127
128			/**
129			* Test filtered text fields.
130			*/
131			public function testFilteredText() {
132			$this->mockNode([
133			'body' => [
134			'value' => 'http://www.drupal.org',
135			'format' => 'plain_text',
136			],
137			]);
138
139			$this->assertGraphQLFields([
140			['NodeTest', 'body', 'FieldNodeBody'],
141			['FieldNodeBody', 'format', 'String'],
142			['FieldNodeBody', 'value', 'String'],
143			['FieldNodeBody', 'processed', 'String'],
144			['FieldNodeBody', 'summary', 'String'],
145			['FieldNodeBody', 'summaryProcessed', 'String'],
146			]);
147
148			$query = <<<GQL
149			query {
150			node {
151			body {
152			value
153			processed
154			summary
155			summaryProcessed
156			}
157			}
158			}
159			GQL;
160
161			$metadata = $this->defaultCacheMetaData();
162			$metadata->addCacheTags([
163			'config:field.storage.node.body',
164			'entity_field_info',
165			]);
166
167			$this->assertResults($query, [], [
168			'node' => [
169			'body' => [
170			'value' => 'http://www.drupal.org',
171			'processed' => "<p><a href=\"http://www.drupal.org\">http://www.drupal.org</a></p>\n",
172			'summary' => 'null',
173			'summaryProcessed' => '',
174			],
175			],
176			], $metadata);
177			}
178
179			/**
180			* Test if the basic fields are available on the interface.
181			*
182			* @dataProvider nodeValuesProvider
183			*
184			* @param array $actualFieldValues
185			* @param array $expectedFieldValues
186			*/
187			public function testRawValues($actualFieldValues, $expectedFieldValues) {
188			$this->installEntitySchema('file');
189			$this->installSchema('file', ['file_usage']);
190			$this->addField('text', "field_text");
191			$this->addField('boolean', "field_boolean");
192			$this->addField('link', "field_link");
193			$this->addField('integer', "field_integer");
194			$this->addField('float', "field_float");
195			$this->addField('decimal', "field_decimal");
196			$this->addField('datetime', "field_datetime");
197			$this->addField('timestamp', "field_timestamp");
198			$this->addField('email', "field_email");
199			$this->addField('string', "field_string");
200			$this->addField('entity_reference', 'field_reference');
201			$this->addField('file', 'field_file');
202			$this->addField('image', 'field_image');
203
204			// File 1
205			file_put_contents('public://example.txt', $this->randomMachineName());
206			$this->testFile = File::create([
207			'uri' => 'public://example.txt',
208			]);
209			$this->testFile->save();
210
211			// File 2
212			file_put_contents('public://example.png', $this->randomMachineName());
213			$this->testImage = File::create([
214			'uri' => 'public://example.png',
215			]);
216			$this->testImage->save();
217			$values = [
218			'title' => 'Test',
219			'type' => 'test',
220			];
221
222			$node = $this->createNode($values + $actualFieldValues);
223
224			// Workaround for public file urls.
225			$expectedFieldValues['fieldFile'][0]['entity']['url'] = file_create_url($this->testFile->getFileUri());
226			$expectedFieldValues['fieldFile'][1]['entity']['url'] = file_create_url($this->testImage->getFileUri());
227			$expectedFieldValues['fieldImage'][0]['entity']['url'] = file_create_url($this->testFile->getFileUri());
228			$expectedFieldValues['fieldImage'][1]['entity']['url'] = file_create_url($this->testImage->getFileUri());
229
230			$metadata = $this->defaultCacheMetaData();
231			$metadata->addCacheTags([
232			'config:field.storage.node.body',
233			'config:field.storage.node.field_text',
234			'config:field.storage.node.field_boolean',
235			'config:field.storage.node.field_datetime',
236			'config:field.storage.node.field_decimal',
237			'config:field.storage.node.field_email',
238			'config:field.storage.node.field_float',
239			'config:field.storage.node.field_file',
240			'config:field.storage.node.field_image',
241			'config:field.storage.node.field_integer',
242			'config:field.storage.node.field_link',
243			'config:field.storage.node.field_string',
244			'config:field.storage.node.field_timestamp',
245			'config:field.storage.node.field_reference',
246			'entity_field_info',
247			'node:1',
248			'file:1',
249			'file:2',
250			]);
251
252			$this->assertResults($this->getQueryFromFile('raw_field_values.gql'), [
253			'path' => '/node/' . $node->id(),
254			], [
255			'route' => ['entity' => $expectedFieldValues],
256			], $metadata);
257			}
258
259			/**
260			* Data provider for testRawValues.
261			*
262			* @return array
263			*/
264			public function nodeValuesProvider() {
265			$fieldValues = [
266			'body' => [
267			'value' => 'test',
268			'summary' => 'test summary',
269			],
270			'field_text' => ['a', 'b', 'c'],
271			'field_boolean' => [TRUE, FALSE],
272			'field_link' => [
273			[
274			'title' => 'Internal link',
275			'uri' => 'internal:/node/1',
276			'options' => ['attributes' => ['_target' => 'blank']],
277			], [
278			'title' => 'External link',
279			'uri' => 'http://drupal.org',
280			'options' => ['attributes' => ['_target' => 'blank']],
281			],
282			],
283			'field_integer' => [10, -5],
284			'field_float' => [3.14145, -8.8],
285			'field_decimal' => [10.5, -17.22],
286			'field_datetime' => ['2017-01-01', '1900-01-01'],
287			'field_timestamp' => [0, 300],
288			'field_email' => ['[email protected]'],
289			'field_string' => ['test', '123'],
290			'field_reference' => [
291			['target_id' => 1],
292			],
293			'field_file' => [
294			[
295			'target_id' => 1,
296			'display' => 0,
297			'description' => 'description test 1',
298			],
299			[
300			'target_id' => 2,
301			'display' => 1,
302			'description' => 'description test 2',
303			],
304			],
305			'field_image' => [
306			[
307			'target_id' => 1,
308			'alt' => 'alt test 1',
309			'title' => 'title test 1',
310			'width' => 100,
311			'height' => 50,
312			],
313			[
314			'target_id' => 2,
315			'alt' => 'alt test 2',
316			'title' => 'title test 2',
317			'width' => 200,
318			'height' => 100,
319			],
320			],
321			];
322
323			$expected = [
324			'nid' => 1,
325			'vid' => 1,
326			'langcode' => [
327			'value' => 'en',
328			],
329			'type' => [
330			'targetId' => 'test',
331			],
332			'uid' => [
333			'targetId' => 0,
334			'entity' => NULL,
335			],
336			'title' => 'Test',
337			'status' => TRUE,
338			'promote' => TRUE,
339			'sticky' => FALSE,
340			'revisionTranslationAffected' => TRUE,
341			'body' => [
342			'value' => 'test',
343			'summary' => 'test summary',
344			'summaryProcessed' => "<p>test summary</p>\n",
345			'processed' => "<p>test</p>\n",
346			'format' => 'null',
347			],
348			'fieldText' => [
349			['value' => 'a'],
350			['value' => 'b'],
351			['value' => 'c'],
352			],
353			'fieldBoolean' => [
354			TRUE,
355			FALSE,
356			],
357			'fieldLink' => [
358			['title' => 'Internal link', 'uri' => 'internal:/node/1', 'target' => 'blank', 'url' => ['internal' => '/node/1']],
359			['title' => 'External link', 'uri' => 'http://drupal.org', 'target' => 'blank', 'url' => ['external' => 'http://drupal.org']],
360			],
361			'fieldInteger' => [
362			10,
363			-5,
364			],
365			'fieldFloat' => [
366			3.14145,
367			-8.8,
368			],
369			'fieldDecimal' => [
370			10.5,
371			-17.22,
372			],
373			'fieldDatetime' => [
374			['value' => '2017-01-01'],
375			['value' => '1900-01-01'],
376			],
377			'fieldTimestamp' => [
378			0,
379			300,
380			],
381			'fieldEmail' => ['[email protected]'],
382			'fieldString' => [
383			'test',
384			'123',
385			],
386			'fieldReference' => [
387			[
388			'targetId' => 1,
389			'entity' => [
390			'title' => 'Test',
391			'fieldReference' => [
392			[
393			'targetId' => 1,
394			'entity' => [
395			'title' => 'Test',
396			],
397			],
398			],
399			],
400			],
401			],
402			'fieldFile' => [
403			[
404			'targetId' => 1,
405			'display' => 0,
406			'description' => 'description test 1',
407			'entity' => [
408			'uri' => 'public://example.txt',
409			],
410			],
411			[
412			'targetId' => 2,
413			'display' => 1,
414			'description' => 'description test 2',
415			'entity' => [
416			'uri' => 'public://example.png',
417			],
418			],
419			],
420			'fieldImage' => [
421			[
422			'targetId' => 1,
423			'alt' => 'alt test 1',
424			'title' => 'title test 1',
425			'width' => 100,
426			'height' => 50,
427			'entity' => [
428			'uri' => 'public://example.txt',
429			],
430			],
431			[
432			'targetId' => 2,
433			'alt' => 'alt test 2',
434			'title' => 'title test 2',
435			'width' => 200,
436			'height' => 100,
437			'entity' => [
438			'uri' => 'public://example.png',
439			],
440			],
441			],
442			];
443
444			return [
445			[$fieldValues, $expected],
446			];
447			}
448
449			}
450

drupal-graphql / graphql

Pull Request — 8.x-3.x (#525)

EntityFieldValueTest::nodeValuesProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like