drthomas246 /
novel_editor
| Conditions | 1 |
| Total Lines | 110 |
| Code Lines | 79 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | #!/usr/bin/env python3 |
||
| 79 | def create_event_character(self): |
||
| 80 | """キャラクター欄のイベント設定. |
||
| 81 | |||
| 82 | ・キャラクター関係のボックスにイベントを追加する。 |
||
| 83 | """ |
||
| 84 | # 開くダイアロクを表示する |
||
| 85 | self.app.EntryCallName.bind('<Control-Key-e>', self.app.fmc.open_file) |
||
| 86 | self.app.EntryName.bind('<Control-Key-e>', self.app.fmc.open_file) |
||
| 87 | self.app.EntryBirthday.bind('<Control-Key-e>', self.app.fmc.open_file) |
||
| 88 | self.app.TextboxBiography.bind('<Control-Key-e>', self.app.fmc.open_file) |
||
| 89 | # 保存ダイアロクを表示する |
||
| 90 | self.app.EntryCallName.bind('<Control-Key-w>', self.app.fmc.save_file) |
||
| 91 | self.app.EntryName.bind('<Control-Key-w>', self.app.fmc.save_file) |
||
| 92 | self.app.EntryBirthday.bind('<Control-Key-w>', self.app.fmc.save_file) |
||
| 93 | self.app.TextboxBiography.bind('<Control-Key-w>', self.app.fmc.save_file) |
||
| 94 | # 小説家になろうを開く |
||
| 95 | self.app.EntryCallName.bind( |
||
| 96 | '<Control-Key-u>', |
||
| 97 | self.app.pmc.open_becoming_novelist_page |
||
| 98 | ) |
||
| 99 | self.app.EntryName.bind( |
||
| 100 | '<Control-Key-u>', |
||
| 101 | self.app.pmc.open_becoming_novelist_page |
||
| 102 | ) |
||
| 103 | self.app.EntryBirthday.bind( |
||
| 104 | '<Control-Key-u>', |
||
| 105 | self.app.pmc.open_becoming_novelist_page |
||
| 106 | ) |
||
| 107 | self.app.TextboxBiography.bind( |
||
| 108 | '<Control-Key-u>', |
||
| 109 | self.app.pmc.open_becoming_novelist_page |
||
| 110 | ) |
||
| 111 | # 検索ダイアログを開く |
||
| 112 | self.app.EntryCallName.bind( |
||
| 113 | '<Control-Key-f>', |
||
| 114 | self.app.fpc.find_dialog |
||
| 115 | ) |
||
| 116 | self.app.EntryName.bind('<Control-Key-f>', self.app.fpc.find_dialog) |
||
| 117 | self.app.EntryCallName.bind( |
||
| 118 | '<Control-Key-f>', |
||
| 119 | self.app.fpc.find_dialog |
||
| 120 | ) |
||
| 121 | self.app.TextboxBiography.bind('<Control-Key-f>', self.app.fpc.find_dialog) |
||
| 122 | # 上書き保存する |
||
| 123 | self.app.EntryCallName.bind( |
||
| 124 | '<Control-Key-s>', |
||
| 125 | self.app.fmc.overwrite_save_file |
||
| 126 | ) |
||
| 127 | self.app.EntryName.bind( |
||
| 128 | '<Control-Key-s>', |
||
| 129 | self.app.fmc.overwrite_save_file |
||
| 130 | ) |
||
| 131 | self.app.EntryBirthday.bind( |
||
| 132 | '<Control-Key-s>', |
||
| 133 | self.app.fmc.overwrite_save_file |
||
| 134 | ) |
||
| 135 | self.app.TextboxBiography.bind( |
||
| 136 | '<Control-Key-s>', |
||
| 137 | self.app.fmc.overwrite_save_file |
||
| 138 | ) |
||
| 139 | # 新規作成する |
||
| 140 | self.app.EntryCallName.bind('<Control-Key-n>', self.app.fmc.new_open) |
||
| 141 | self.app.EntryName.bind('<Control-Key-n>', self.app.fmc.new_open) |
||
| 142 | self.app.EntryCallName.bind('<Control-Key-n>', self.app.fmc.new_open) |
||
| 143 | self.app.TextboxBiography.bind('<Control-Key-n>', self.app.fmc.new_open) |
||
| 144 | # helpページを開く |
||
| 145 | self.app.EntryCallName.bind('<Control-Key-h>', self.app.hmc.help) |
||
| 146 | self.app.EntryName.bind('<Control-Key-h>', self.app.hmc.help) |
||
| 147 | self.app.EntryBirthday.bind('<Control-Key-h>', self.app.hmc.help) |
||
| 148 | self.app.TextboxBiography.bind('<Control-Key-h>', self.app.hmc.help) |
||
| 149 | # Versionページを開く |
||
| 150 | self.app.EntryCallName.bind( |
||
| 151 | '<Control-Shift-Key-V>', |
||
| 152 | self.app.hmc.version |
||
| 153 | ) |
||
| 154 | self.app.EntryName.bind('<Control-Shift-Key-V>', self.app.hmc.version) |
||
| 155 | self.app.EntryBirthday.bind( |
||
| 156 | '<Control-Shift-Key-V>', |
||
| 157 | self.app.hmc.version |
||
| 158 | ) |
||
| 159 | self.app.EntryCallName.bind( |
||
| 160 | '<Control-Shift-Key-V>', |
||
| 161 | self.app.hmc.version |
||
| 162 | ) |
||
| 163 | # redo処理 |
||
| 164 | self.app.EntryCallName.bind('<Control-Shift-Key-Z>', self.app.emc.redo) |
||
| 165 | self.app.EntryName.bind('<Control-Shift-Key-Z>', self.app.emc.redo) |
||
| 166 | self.app.EntryBirthday.bind('<Control-Shift-Key-Z>', self.app.emc.redo) |
||
| 167 | self.app.TextboxBiography.bind('<Control-Shift-Key-Z>', self.app.emc.redo) |
||
| 168 | # undo処理 |
||
| 169 | self.app.EntryCallName.bind('<Control-Key-z>', self.app.emc.undo) |
||
| 170 | self.app.EntryName.bind('<Control-Key-z>', self.app.emc.undo) |
||
| 171 | self.app.EntryBirthday.bind('<Control-Key-z>', self.app.emc.undo) |
||
| 172 | self.app.TextboxBiography.bind('<Control-Key-z>', self.app.emc.undo) |
||
| 173 | # フォントサイズの変更 |
||
| 174 | self.app.EntryCallName.bind( |
||
| 175 | '<Control-Shift-Key-F>', |
||
| 176 | self.app.pmc.font_dialog |
||
| 177 | ) |
||
| 178 | self.app.EntryName.bind( |
||
| 179 | '<Control-Shift-Key-F>', |
||
| 180 | self.app.pmc.font_dialog |
||
| 181 | ) |
||
| 182 | self.app.EntryBirthday.bind( |
||
| 183 | '<Control-Shift-Key-F>', |
||
| 184 | self.app.pmc.font_dialog |
||
| 185 | ) |
||
| 186 | self.app.TextboxBiography.bind( |
||
| 187 | '<Control-Shift-Key-F>', |
||
| 188 | self.app.pmc.font_dialog |
||
| 189 | ) |
||
| 213 |
