Conditions | 1 |
Total Lines | 110 |
Code Lines | 79 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | #!/usr/bin/env python3 |
||
73 | def create_event_character(self): |
||
74 | """キャラクター欄のイベント設定. |
||
75 | |||
76 | ・キャラクター関係のボックスにイベントを追加する。 |
||
77 | """ |
||
78 | # 開くダイアロクを表示する |
||
79 | self.APP.txt_yobi_name.bind('<Control-Key-e>', self.APP.fmc.open_file) |
||
80 | self.APP.txt_name.bind('<Control-Key-e>', self.APP.fmc.open_file) |
||
81 | self.APP.txt_birthday.bind('<Control-Key-e>', self.APP.fmc.open_file) |
||
82 | self.APP.text_body.bind('<Control-Key-e>', self.APP.fmc.open_file) |
||
83 | # 保存ダイアロクを表示する |
||
84 | self.APP.txt_yobi_name.bind('<Control-Key-w>', self.APP.fmc.save_file) |
||
85 | self.APP.txt_name.bind('<Control-Key-w>', self.APP.fmc.save_file) |
||
86 | self.APP.txt_birthday.bind('<Control-Key-w>', self.APP.fmc.save_file) |
||
87 | self.APP.text_body.bind('<Control-Key-w>', self.APP.fmc.save_file) |
||
88 | # 小説家になろうを開く |
||
89 | self.APP.txt_yobi_name.bind( |
||
90 | '<Control-Key-u>', |
||
91 | self.APP.pmc.open_becoming_novelist_page |
||
92 | ) |
||
93 | self.APP.txt_name.bind( |
||
94 | '<Control-Key-u>', |
||
95 | self.APP.pmc.open_becoming_novelist_page |
||
96 | ) |
||
97 | self.APP.txt_birthday.bind( |
||
98 | '<Control-Key-u>', |
||
99 | self.APP.pmc.open_becoming_novelist_page |
||
100 | ) |
||
101 | self.APP.text_body.bind( |
||
102 | '<Control-Key-u>', |
||
103 | self.APP.pmc.open_becoming_novelist_page |
||
104 | ) |
||
105 | # 検索ダイアログを開く |
||
106 | self.APP.txt_yobi_name.bind( |
||
107 | '<Control-Key-f>', |
||
108 | self.APP.fpc.find_dialog |
||
109 | ) |
||
110 | self.APP.txt_name.bind('<Control-Key-f>', self.APP.fpc.find_dialog) |
||
111 | self.APP.txt_yobi_name.bind( |
||
112 | '<Control-Key-f>', |
||
113 | self.APP.fpc.find_dialog |
||
114 | ) |
||
115 | self.APP.text_body.bind('<Control-Key-f>', self.APP.fpc.find_dialog) |
||
116 | # 上書き保存する |
||
117 | self.APP.txt_yobi_name.bind( |
||
118 | '<Control-Key-s>', |
||
119 | self.APP.fmc.overwrite_save_file |
||
120 | ) |
||
121 | self.APP.txt_name.bind( |
||
122 | '<Control-Key-s>', |
||
123 | self.APP.fmc.overwrite_save_file |
||
124 | ) |
||
125 | self.APP.txt_birthday.bind( |
||
126 | '<Control-Key-s>', |
||
127 | self.APP.fmc.overwrite_save_file |
||
128 | ) |
||
129 | self.APP.text_body.bind( |
||
130 | '<Control-Key-s>', |
||
131 | self.APP.fmc.overwrite_save_file |
||
132 | ) |
||
133 | # 新規作成する |
||
134 | self.APP.txt_yobi_name.bind('<Control-Key-n>', self.APP.fmc.new_open) |
||
135 | self.APP.txt_name.bind('<Control-Key-n>', self.APP.fmc.new_open) |
||
136 | self.APP.txt_yobi_name.bind('<Control-Key-n>', self.APP.fmc.new_open) |
||
137 | self.APP.text_body.bind('<Control-Key-n>', self.APP.fmc.new_open) |
||
138 | # helpページを開く |
||
139 | self.APP.txt_yobi_name.bind('<Control-Key-h>', self.APP.hmc.help) |
||
140 | self.APP.txt_name.bind('<Control-Key-h>', self.APP.hmc.help) |
||
141 | self.APP.txt_birthday.bind('<Control-Key-h>', self.APP.hmc.help) |
||
142 | self.APP.text_body.bind('<Control-Key-h>', self.APP.hmc.help) |
||
143 | # Versionページを開く |
||
144 | self.APP.txt_yobi_name.bind( |
||
145 | '<Control-Shift-Key-V>', |
||
146 | self.APP.hmc.version |
||
147 | ) |
||
148 | self.APP.txt_name.bind('<Control-Shift-Key-V>', self.APP.hmc.version) |
||
149 | self.APP.txt_birthday.bind( |
||
150 | '<Control-Shift-Key-V>', |
||
151 | self.APP.hmc.version |
||
152 | ) |
||
153 | self.APP.txt_yobi_name.bind( |
||
154 | '<Control-Shift-Key-V>', |
||
155 | self.APP.hmc.version |
||
156 | ) |
||
157 | # redo処理 |
||
158 | self.APP.txt_yobi_name.bind('<Control-Shift-Key-Z>', self.APP.emc.redo) |
||
159 | self.APP.txt_name.bind('<Control-Shift-Key-Z>', self.APP.emc.redo) |
||
160 | self.APP.txt_birthday.bind('<Control-Shift-Key-Z>', self.APP.emc.redo) |
||
161 | self.APP.text_body.bind('<Control-Shift-Key-Z>', self.APP.emc.redo) |
||
162 | # undo処理 |
||
163 | self.APP.txt_yobi_name.bind('<Control-Key-z>', self.APP.emc.undo) |
||
164 | self.APP.txt_name.bind('<Control-Key-z>', self.APP.emc.undo) |
||
165 | self.APP.txt_birthday.bind('<Control-Key-z>', self.APP.emc.undo) |
||
166 | self.APP.text_body.bind('<Control-Key-z>', self.APP.emc.undo) |
||
167 | # フォントサイズの変更 |
||
168 | self.APP.txt_yobi_name.bind( |
||
169 | '<Control-Shift-Key-F>', |
||
170 | self.APP.pmc.font_dialog |
||
171 | ) |
||
172 | self.APP.txt_name.bind( |
||
173 | '<Control-Shift-Key-F>', |
||
174 | self.APP.pmc.font_dialog |
||
175 | ) |
||
176 | self.APP.txt_birthday.bind( |
||
177 | '<Control-Shift-Key-F>', |
||
178 | self.APP.pmc.font_dialog |
||
179 | ) |
||
180 | self.APP.text_body.bind( |
||
181 | '<Control-Shift-Key-F>', |
||
182 | self.APP.pmc.font_dialog |
||
183 | ) |
||
207 |