| Conditions | 1 |
| Total Lines | 71 |
| Code Lines | 51 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | #!/usr/bin/env python3 |
||
| 76 | def create_event_character(self): |
||
| 77 | """キャラクター欄のイベント設定. |
||
| 78 | |||
| 79 | ・キャラクター関係のボックスにイベントを追加する。 |
||
| 80 | """ |
||
| 81 | # 開くダイアロクを表示する |
||
| 82 | self.app.EntryCallName.bind("<Control-Key-e>", self.app.fmc.open_file) |
||
| 83 | self.app.EntryName.bind("<Control-Key-e>", self.app.fmc.open_file) |
||
| 84 | self.app.EntryBirthday.bind("<Control-Key-e>", self.app.fmc.open_file) |
||
| 85 | self.app.TextboxBiography.bind("<Control-Key-e>", self.app.fmc.open_file) |
||
| 86 | # 保存ダイアロクを表示する |
||
| 87 | self.app.EntryCallName.bind("<Control-Key-w>", self.app.fmc.save_file) |
||
| 88 | self.app.EntryName.bind("<Control-Key-w>", self.app.fmc.save_file) |
||
| 89 | self.app.EntryBirthday.bind("<Control-Key-w>", self.app.fmc.save_file) |
||
| 90 | self.app.TextboxBiography.bind("<Control-Key-w>", self.app.fmc.save_file) |
||
| 91 | # 小説家になろうを開く |
||
| 92 | self.app.EntryCallName.bind( |
||
| 93 | "<Control-Key-u>", self.app.pmc.open_becoming_novelist_page |
||
| 94 | ) |
||
| 95 | self.app.EntryName.bind( |
||
| 96 | "<Control-Key-u>", self.app.pmc.open_becoming_novelist_page |
||
| 97 | ) |
||
| 98 | self.app.EntryBirthday.bind( |
||
| 99 | "<Control-Key-u>", self.app.pmc.open_becoming_novelist_page |
||
| 100 | ) |
||
| 101 | self.app.TextboxBiography.bind( |
||
| 102 | "<Control-Key-u>", self.app.pmc.open_becoming_novelist_page |
||
| 103 | ) |
||
| 104 | # 検索ダイアログを開く |
||
| 105 | self.app.EntryCallName.bind("<Control-Key-f>", self.app.fpc.find_dialog) |
||
| 106 | self.app.EntryName.bind("<Control-Key-f>", self.app.fpc.find_dialog) |
||
| 107 | self.app.EntryCallName.bind("<Control-Key-f>", self.app.fpc.find_dialog) |
||
| 108 | self.app.TextboxBiography.bind("<Control-Key-f>", self.app.fpc.find_dialog) |
||
| 109 | # 上書き保存する |
||
| 110 | self.app.EntryCallName.bind("<Control-Key-s>", self.app.fmc.overwrite_save_file) |
||
| 111 | self.app.EntryName.bind("<Control-Key-s>", self.app.fmc.overwrite_save_file) |
||
| 112 | self.app.EntryBirthday.bind("<Control-Key-s>", self.app.fmc.overwrite_save_file) |
||
| 113 | self.app.TextboxBiography.bind( |
||
| 114 | "<Control-Key-s>", self.app.fmc.overwrite_save_file |
||
| 115 | ) |
||
| 116 | # 新規作成する |
||
| 117 | self.app.EntryCallName.bind("<Control-Key-n>", self.app.fmc.new_open) |
||
| 118 | self.app.EntryName.bind("<Control-Key-n>", self.app.fmc.new_open) |
||
| 119 | self.app.EntryCallName.bind("<Control-Key-n>", self.app.fmc.new_open) |
||
| 120 | self.app.TextboxBiography.bind("<Control-Key-n>", self.app.fmc.new_open) |
||
| 121 | # helpページを開く |
||
| 122 | self.app.EntryCallName.bind("<Control-Key-h>", self.app.hmc.help) |
||
| 123 | self.app.EntryName.bind("<Control-Key-h>", self.app.hmc.help) |
||
| 124 | self.app.EntryBirthday.bind("<Control-Key-h>", self.app.hmc.help) |
||
| 125 | self.app.TextboxBiography.bind("<Control-Key-h>", self.app.hmc.help) |
||
| 126 | # Versionページを開く |
||
| 127 | self.app.EntryCallName.bind("<Control-Shift-Key-V>", self.app.hmc.version) |
||
| 128 | self.app.EntryName.bind("<Control-Shift-Key-V>", self.app.hmc.version) |
||
| 129 | self.app.EntryBirthday.bind("<Control-Shift-Key-V>", self.app.hmc.version) |
||
| 130 | self.app.EntryCallName.bind("<Control-Shift-Key-V>", self.app.hmc.version) |
||
| 131 | # redo処理 |
||
| 132 | self.app.EntryCallName.bind("<Control-Shift-Key-Z>", self.app.emc.redo) |
||
| 133 | self.app.EntryName.bind("<Control-Shift-Key-Z>", self.app.emc.redo) |
||
| 134 | self.app.EntryBirthday.bind("<Control-Shift-Key-Z>", self.app.emc.redo) |
||
| 135 | self.app.TextboxBiography.bind("<Control-Shift-Key-Z>", self.app.emc.redo) |
||
| 136 | # undo処理 |
||
| 137 | self.app.EntryCallName.bind("<Control-Key-z>", self.app.emc.undo) |
||
| 138 | self.app.EntryName.bind("<Control-Key-z>", self.app.emc.undo) |
||
| 139 | self.app.EntryBirthday.bind("<Control-Key-z>", self.app.emc.undo) |
||
| 140 | self.app.TextboxBiography.bind("<Control-Key-z>", self.app.emc.undo) |
||
| 141 | # フォントサイズの変更 |
||
| 142 | self.app.EntryCallName.bind("<Control-Shift-Key-F>", self.app.pmc.font_dialog) |
||
| 143 | self.app.EntryName.bind("<Control-Shift-Key-F>", self.app.pmc.font_dialog) |
||
| 144 | self.app.EntryBirthday.bind("<Control-Shift-Key-F>", self.app.pmc.font_dialog) |
||
| 145 | self.app.TextboxBiography.bind( |
||
| 146 | "<Control-Shift-Key-F>", self.app.pmc.font_dialog |
||
| 147 | ) |
||
| 170 |