EaselDrawing\Color::newFromString()

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function newFromString(string $value)
    {
        $value = strtolower(substr($value, 0, 6));
        if (strlen($value) == 3) {
            $value = substr($value, 0, 1) . substr($value, 0, 1)
                . substr($value, 1, 1) . substr($value, 1, 1)
                . substr($value, 2, 1) . substr($value, 2, 1);
        }
        if (! preg_match('/^[[:xdigit:]]{6}$/', $value)) {
            throw new \InvalidArgumentException('A color must contain 3 or 6 hexadecimal characters');
        }
        $rgb = [];
        foreach (range(0, 2) as $index) {
            $rgb[$index] = substr($value, $index * 2, 2);
        }
        return new Color(hexdec($rgb[0]), hexdec($rgb[1]), hexdec($rgb[2]));

It seems like hexdec($rgb[2]) can also be of type double; however, parameter $blue of EaselDrawing\Color::__construct() does only seem to accept integer, maybe add an additional type check?

It seems like hexdec($rgb[1]) can also be of type double; however, parameter $green of EaselDrawing\Color::__construct() does only seem to accept integer, maybe add an additional type check?

It seems like hexdec($rgb[0]) can also be of type double; however, parameter $red of EaselDrawing\Color::__construct() does only seem to accept integer, maybe add an additional type check?

    }