Complex classes like MailChimp often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MailChimp, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
13 | class MailChimp |
||
14 | { |
||
15 | private $api_key; |
||
16 | private $api_endpoint = 'https://<dc>.api.mailchimp.com/3.0'; |
||
17 | |||
18 | const TIMEOUT = 10; |
||
19 | |||
20 | /* SSL Verification |
||
21 | Read before disabling: |
||
22 | http://snippets.webaware.com.au/howto/stop-turning-off-curlopt_ssl_verifypeer-and-fix-your-php-config/ |
||
23 | */ |
||
24 | public $verify_ssl = true; |
||
25 | |||
26 | private $request_successful = false; |
||
27 | private $last_error = ''; |
||
28 | private $last_response = array(); |
||
29 | private $last_request = array(); |
||
30 | |||
31 | /** |
||
32 | * Create a new instance |
||
33 | * |
||
34 | * @param string $api_key Your MailChimp API key |
||
35 | * @param string $api_endpoint Optional custom API endpoint |
||
36 | * |
||
37 | * @throws \Exception |
||
38 | */ |
||
39 | public function __construct($api_key, $api_endpoint = null) |
||
59 | |||
60 | /** |
||
61 | * Create a new instance of a Batch request. Optionally with the ID of an existing batch. |
||
62 | * |
||
63 | * @param string $batch_id Optional ID of an existing batch, if you need to check its status for example. |
||
64 | * |
||
65 | * @return Batch New Batch object. |
||
66 | */ |
||
67 | public function new_batch($batch_id = null) |
||
71 | |||
72 | /** |
||
73 | * @return string The url to the API endpoint |
||
74 | */ |
||
75 | public function getApiEndpoint() |
||
79 | |||
80 | /** |
||
81 | * @return bool A api key was set |
||
82 | */ |
||
83 | public function hasApiKey() |
||
87 | |||
88 | /** |
||
89 | * Convert an email address into a 'subscriber hash' for identifying the subscriber in a method URL |
||
90 | * |
||
91 | * @param string $email The subscriber's email address |
||
92 | * |
||
93 | * @return string Hashed version of the input |
||
94 | */ |
||
95 | public function subscriberHash($email) |
||
99 | |||
100 | /** |
||
101 | * Was the last request successful? |
||
102 | * |
||
103 | * @return bool True for success, false for failure |
||
104 | */ |
||
105 | public function success() |
||
109 | |||
110 | /** |
||
111 | * Get the last error returned by either the network transport, or by the API. |
||
112 | * If something didn't work, this should contain the string describing the problem. |
||
113 | * |
||
114 | * @return string|false describing the error |
||
115 | */ |
||
116 | public function getLastError() |
||
120 | |||
121 | /** |
||
122 | * Get an array containing the HTTP headers and the body of the API response. |
||
123 | * |
||
124 | * @return array Assoc array with keys 'headers' and 'body' |
||
125 | */ |
||
126 | public function getLastResponse() |
||
130 | |||
131 | /** |
||
132 | * Get an array containing the HTTP headers and the body of the API request. |
||
133 | * |
||
134 | * @return array Assoc array |
||
135 | */ |
||
136 | public function getLastRequest() |
||
140 | |||
141 | /** |
||
142 | * Make an HTTP DELETE request - for deleting data |
||
143 | * |
||
144 | * @param string $method URL of the API request method |
||
145 | * @param array $args Assoc array of arguments (if any) |
||
146 | * @param int $timeout Timeout limit for request in seconds |
||
147 | * |
||
148 | * @return array|false Assoc array of API response, decoded from JSON |
||
149 | */ |
||
150 | public function delete($method, $args = array(), $timeout = self::TIMEOUT) |
||
154 | |||
155 | /** |
||
156 | * Make an HTTP GET request - for retrieving data |
||
157 | * |
||
158 | * @param string $method URL of the API request method |
||
159 | * @param array $args Assoc array of arguments (usually your data) |
||
160 | * @param int $timeout Timeout limit for request in seconds |
||
161 | * |
||
162 | * @return array|false Assoc array of API response, decoded from JSON |
||
163 | */ |
||
164 | public function get($method, $args = array(), $timeout = self::TIMEOUT) |
||
168 | |||
169 | /** |
||
170 | * Make an HTTP PATCH request - for performing partial updates |
||
171 | * |
||
172 | * @param string $method URL of the API request method |
||
173 | * @param array $args Assoc array of arguments (usually your data) |
||
174 | * @param int $timeout Timeout limit for request in seconds |
||
175 | * |
||
176 | * @return array|false Assoc array of API response, decoded from JSON |
||
177 | */ |
||
178 | public function patch($method, $args = array(), $timeout = self::TIMEOUT) |
||
182 | |||
183 | /** |
||
184 | * Make an HTTP POST request - for creating and updating items |
||
185 | * |
||
186 | * @param string $method URL of the API request method |
||
187 | * @param array $args Assoc array of arguments (usually your data) |
||
188 | * @param int $timeout Timeout limit for request in seconds |
||
189 | * |
||
190 | * @return array|false Assoc array of API response, decoded from JSON |
||
191 | */ |
||
192 | public function post($method, $args = array(), $timeout = self::TIMEOUT) |
||
196 | |||
197 | /** |
||
198 | * Make an HTTP PUT request - for creating new items |
||
199 | * |
||
200 | * @param string $method URL of the API request method |
||
201 | * @param array $args Assoc array of arguments (usually your data) |
||
202 | * @param int $timeout Timeout limit for request in seconds |
||
203 | * |
||
204 | * @return array|false Assoc array of API response, decoded from JSON |
||
205 | */ |
||
206 | public function put($method, $args = array(), $timeout = self::TIMEOUT) |
||
210 | |||
211 | /** |
||
212 | * Performs the underlying HTTP request. Not very exciting. |
||
213 | * |
||
214 | * @param string $http_verb The HTTP verb to use: get, post, put, patch, delete |
||
215 | * @param string $method The API method to be called |
||
216 | * @param array $args Assoc array of parameters to be passed |
||
217 | * @param int $timeout |
||
218 | * |
||
219 | * @return array|false Assoc array of decoded result |
||
220 | */ |
||
221 | private function makeRequest($http_verb, $method, $args = array(), $timeout = self::TIMEOUT) |
||
290 | |||
291 | /** |
||
292 | * @param string $http_verb |
||
293 | * @param string $method |
||
294 | * @param string $url |
||
295 | * @param integer $timeout |
||
296 | * |
||
297 | * @return array |
||
298 | */ |
||
299 | private function prepareStateForRequest($http_verb, $method, $url, $timeout) |
||
321 | |||
322 | /** |
||
323 | * Get the HTTP headers as an array of header-name => header-value pairs. |
||
324 | * |
||
325 | * The "Link" header is parsed into an associative array based on the |
||
326 | * rel names it contains. The original value is available under |
||
327 | * the "_raw" key. |
||
328 | * |
||
329 | * @param string $headersAsString |
||
330 | * |
||
331 | * @return array |
||
332 | */ |
||
333 | private function getHeadersAsArray($headersAsString) |
||
361 | |||
362 | /** |
||
363 | * Extract all rel => URL pairs from the provided Link header value |
||
364 | * |
||
365 | * Mailchimp only implements the URI reference and relation type from |
||
366 | * RFC 5988, so the value of the header is something like this: |
||
367 | * |
||
368 | * 'https://us13.api.mailchimp.com/schema/3.0/Lists/Instance.json; rel="describedBy", |
||
369 | * <https://us13.admin.mailchimp.com/lists/members/?id=XXXX>; rel="dashboard"' |
||
370 | * |
||
371 | * @param string $linkHeaderAsString |
||
372 | * |
||
373 | * @return array |
||
374 | */ |
||
375 | private function getLinkHeaderAsArray($linkHeaderAsString) |
||
387 | |||
388 | /** |
||
389 | * Encode the data and attach it to the request |
||
390 | * |
||
391 | * @param resource $ch cURL session handle, used by reference |
||
392 | * @param array $data Assoc array of data to attach |
||
393 | */ |
||
394 | private function attachRequestPayload(&$ch, $data) |
||
400 | |||
401 | /** |
||
402 | * Decode the response and format any error messages for debugging |
||
403 | * |
||
404 | * @param array $response The response from the curl request |
||
405 | * |
||
406 | * @return array|false The JSON decoded into an array |
||
407 | */ |
||
408 | private function formatResponse($response) |
||
418 | |||
419 | /** |
||
420 | * Do post-request formatting and setting state from the response |
||
421 | * |
||
422 | * @param array $response The response from the curl request |
||
423 | * @param string $responseContent The body of the response from the curl request |
||
424 | * @param resource $ch The curl resource |
||
425 | * |
||
426 | * @return array The modified response |
||
427 | */ |
||
428 | private function setResponseState($response, $responseContent, $ch) |
||
446 | |||
447 | /** |
||
448 | * Check if the response was successful or a failure. If it failed, store the error. |
||
449 | * |
||
450 | * @param array $response The response from the curl request |
||
451 | * @param array|false $formattedResponse The response body payload from the curl request |
||
452 | * @param int $timeout The timeout supplied to the curl request. |
||
453 | * |
||
454 | * @return bool If the request was successful |
||
455 | */ |
||
456 | private function determineSuccess($response, $formattedResponse, $timeout) |
||
478 | |||
479 | /** |
||
480 | * Find the HTTP status code from the headers or API response body |
||
481 | * |
||
482 | * @param array $response The response from the curl request |
||
483 | * @param array|false $formattedResponse The response body payload from the curl request |
||
484 | * |
||
485 | * @return int HTTP status code |
||
486 | */ |
||
487 | private function findHTTPStatus($response, $formattedResponse) |
||
499 | } |
||
500 |