Doyo\UserBundle\Bridge\ORM\UserManager

Complexity

Total Complexity

10

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getRepository()	0	3	1
A	__construct()	0	9	1
A	deleteUser()	0	4	1
A	updateUser()	0	8	2
A	reloadUser()	0	3	1
A	findUserBy()	0	3	1
A	findUsers()	0	3	1
A	getClass()	0	8	2

<?php

Class found in ".php" file; use ".inc" extension instead

The PHP open tag does not have a corresponding PHP close tag

Filename "UserManager.php" doesn't match the expected filename "usermanager.php"

You must use "/**" style comments for a file comment

/*

You must use "/**" style comments for a file comment

 * This file is part of the DoyoUserBundle project.
 *
 * (c) Anthonius Munthi <me@itstoni.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Doyo\UserBundle\Bridge\ORM;

use Doctrine\Common\Persistence\ObjectManager;
use Doctrine\Common\Persistence\ObjectRepository;
use Doyo\UserBundle\Manager\AbstractUserManager;
use Doyo\UserBundle\Model\UserInterface;
use Doyo\UserBundle\Util\CanonicalFieldsUpdaterInterface;
use Doyo\UserBundle\Util\PasswordUpdaterInterface;

class UserManager extends AbstractUserManager

Missing doc comment for class UserManager

{

Opening brace should be on the same line as the declaration for class UserManager

    /**

Missing short description in doc comment

     * @var ObjectManager
     */
    private $objectManager;

Expected 1 blank line(s) before first member var; 0 found

Private member variable "objectManager" must contain a leading underscore

Private member variable "objectManager" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @var string
     */
    private $class;

Private member variable "class" must contain a leading underscore

Private member variable "class" must be prefixed with an underscore

    /**

Parameter $passwordUpdater should have a doc-comment as per coding-style.

Parameter $canonicalFieldsUpdater should have a doc-comment as per coding-style.

Parameter $manager should have a doc-comment as per coding-style.

     * UserManager constructor.
     *
     * @param string $class

Missing parameter comment

Doc comment for parameter $class does not match actual variable name $passwordUpdater

     */
    public function __construct(

Expected 2 blank lines before function; 1 found

        PasswordUpdaterInterface $passwordUpdater,
        CanonicalFieldsUpdaterInterface $canonicalFieldsUpdater,
        ObjectManager $manager,
        $class
    ) {

Opening brace should be on a new line

        $this->objectManager = $manager;
        $this->class         = $class;
        parent::__construct($passwordUpdater, $canonicalFieldsUpdater);
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end __construct()

    /**

Parameter $user should have a doc-comment as per coding-style.

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function deleteUser(UserInterface $user)
    {

Opening brace should be on the same line as the declaration

        $this->objectManager->remove($user);
        $this->objectManager->flush();
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end deleteUser()

    /**
     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function getClass()
    {

Opening brace should be on the same line as the declaration

        if (false !== strpos($this->class, ':')) {

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

            $metadata    = $this->objectManager->getClassMetadata($this->class);
            $this->class = $metadata->getName();
        }

        return $this->class;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end getClass()

    /**

Parameter $criteria should have a doc-comment as per coding-style.

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function findUserBy(array $criteria)
    {

Opening brace should be on the same line as the declaration

        return $this->getRepository()->findOneBy($criteria);
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end findUserBy()

    /**
     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function findUsers()
    {

Opening brace should be on the same line as the declaration

        return $this->getRepository()->findAll();

The expression return $this->getRepository()->findAll() returns the type array<mixed,object> which is incompatible with the return type mandated by Doyo\UserBundle\Manager\UserManagerInterface::findUsers() of Traversable.

    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end findUsers()

    /**

Parameter $user should have a doc-comment as per coding-style.

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function reloadUser(UserInterface $user)
    {

Opening brace should be on the same line as the declaration

        $this->objectManager->refresh($user);
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end reloadUser()

    /**

Parameter $user should have a doc-comment as per coding-style.

Parameter $andFlush should have a doc-comment as per coding-style.

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function updateUser(UserInterface $user, $andFlush = true)

Incorrect spacing between argument "$andFlush" and equals sign; expected 0 but found 1

Incorrect spacing between default value and equals sign for argument "$andFlush"; expected 0 but found 1

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

    {

Opening brace should be on the same line as the declaration

        $this->updateCanonicalFields($user);
        $this->updatePassword($user);

        $this->objectManager->persist($user);
        if ($andFlush) {
            $this->objectManager->flush();
        }
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end updateUser()

    /**

Missing short description in doc comment

     * @return ObjectRepository
     */
    protected function getRepository()
    {

Opening brace should be on the same line as the declaration

        return $this->objectManager->getRepository($this->getClass());
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end getRepository()

}

Expected //end class

As per coding style, files should not end with a newline character.