Doyo\UserBundle\Util\CanonicalFieldsUpdater

Complexity

Total Complexity

4

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Test Coverage

Coverage

80%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	updateCanonicalFields()	0	4	1
A	__construct()	0	4	1
A	canonicalizeUsername()	0	3	1
A	canonicalizeEmail()	0	3	1

<?php

Class found in ".php" file; use ".inc" extension instead

The PHP open tag does not have a corresponding PHP close tag

Filename "CanonicalFieldsUpdater.php" doesn't match the expected filename "canonicalfieldsupdater.php"

You must use "/**" style comments for a file comment

/*

You must use "/**" style comments for a file comment

 * This file is part of the DoyoUserBundle project.
 *
 * (c) Anthonius Munthi <me@itstoni.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Doyo\UserBundle\Util;

use Doyo\UserBundle\Model\UserInterface;

class CanonicalFieldsUpdater implements CanonicalFieldsUpdaterInterface

Missing doc comment for class CanonicalFieldsUpdater

{

Opening brace should be on the same line as the declaration for class CanonicalFieldsUpdater

    /**

Missing short description in doc comment

     * @var CanonicalizerInterface
     */
    private $usernameCanonicalizer;

Expected 1 blank line(s) before first member var; 0 found

Private member variable "usernameCanonicalizer" must contain a leading underscore

Private member variable "usernameCanonicalizer" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @var CanonicalizerInterface
     */
    private $emailCanonicalizer;

Private member variable "emailCanonicalizer" must contain a leading underscore

Private member variable "emailCanonicalizer" must be prefixed with an underscore

    /**

Parameter $usernameCanonicalizer should have a doc-comment as per coding-style.

Parameter $emailCanonicalizer should have a doc-comment as per coding-style.

     * CanonicalFieldsUpdater constructor.
     */
    public function __construct(CanonicalizerInterface $usernameCanonicalizer, CanonicalizerInterface $emailCanonicalizer)

Expected 2 blank lines before function; 1 found

This line exceeds maximum limit of 100 characters; contains 122 characters

    {

Opening brace should be on the same line as the declaration

        $this->usernameCanonicalizer = $usernameCanonicalizer;
        $this->emailCanonicalizer    = $emailCanonicalizer;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end __construct()

    public function updateCanonicalFields(UserInterface $user)

Missing doc comment for function updateCanonicalFields()

    {

Opening brace should be on the same line as the declaration

        $user->setUsernameCanonical($this->usernameCanonicalizer->canonicalize($user->getUsername()));

This line exceeds maximum limit of 100 characters; contains 102 characters

        $user->setEmailCanonical($this->emailCanonicalizer->canonicalize($user->getEmail()));
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end updateCanonicalFields()

    /**
     * Canonicalizes an email.
     *
     * @param string|null $email

Missing parameter comment

     *
     * @return string|null
     */
    public function canonicalizeEmail($email)
    {

Opening brace should be on the same line as the declaration

        return $this->emailCanonicalizer->canonicalize($email);
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end canonicalizeEmail()

    /**
     * Canonicalizes a username.
     *
     * @param string|null $username

Missing parameter comment

     *
     * @return string|null
     */
    public function canonicalizeUsername($username)
    {

Opening brace should be on the same line as the declaration

        return $this->usernameCanonicalizer->canonicalize($username);
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end canonicalizeUsername()

}

Expected //end class

As per coding style, files should not end with a newline character.