Doyo\UserBundle\Manager\AbstractUserManager

Complexity

Total Complexity

10

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	findUserByUsername()	0	3	1
A	__construct()	0	4	1
A	findUserByEmail()	0	3	1
A	findUserByConfirmationToken()	0	3	1
A	findUserByUsernameOrEmail()	0	10	3
A	createUser()	0	5	1
A	updateCanonicalFields()	0	3	1
A	updatePassword()	0	3	1

<?php

Class found in ".php" file; use ".inc" extension instead

The PHP open tag does not have a corresponding PHP close tag

Filename "AbstractUserManager.php" doesn't match the expected filename "abstractusermanager.php"

You must use "/**" style comments for a file comment

/*

You must use "/**" style comments for a file comment

 * This file is part of the DoyoUserBundle project.
 *
 * (c) Anthonius Munthi <me@itstoni.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Doyo\UserBundle\Manager;

use Doyo\UserBundle\Model\UserInterface;
use Doyo\UserBundle\Util\CanonicalFieldsUpdaterInterface;
use Doyo\UserBundle\Util\PasswordUpdaterInterface;

/**
 * Abstract User Manager implementation which can be used as base class for your
 * concrete manager.
 *
 * This class is taken from friendsofsymfony/user-bundle
 *
 * @author Johannes M. Schmitt <schmittjoh@gmail.com>

@author tag is not allowed in class comment

 * @author Anthonius Munthi <me@itstoni.com>

@author tag is not allowed in class comment

 */

Missing @category tag in class comment

Missing @package tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

abstract class AbstractUserManager implements UserManagerInterface
{

Opening brace should be on the same line as the declaration for class AbstractUserManager

    private $passwordUpdater;

Expected 1 blank line(s) before first member var; 0 found

Private member variable "passwordUpdater" must contain a leading underscore

Missing member variable doc comment

Private member variable "passwordUpdater" must be prefixed with an underscore

    private $canonicalFieldsUpdater;

Expected 1 blank line(s) before member var; 0 found

Private member variable "canonicalFieldsUpdater" must contain a leading underscore

Missing member variable doc comment

Private member variable "canonicalFieldsUpdater" must be prefixed with an underscore

    public function __construct(PasswordUpdaterInterface $passwordUpdater, CanonicalFieldsUpdaterInterface $canonicalFieldsUpdater)

Expected 2 blank lines before function; 1 found

Missing doc comment for function __construct()

This line exceeds maximum limit of 100 characters; contains 131 characters

    {

Opening brace should be on the same line as the declaration

        $this->passwordUpdater        = $passwordUpdater;
        $this->canonicalFieldsUpdater = $canonicalFieldsUpdater;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end __construct()

    /**
     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function createUser()
    {

Opening brace should be on the same line as the declaration

        $class = $this->getClass();

        return new $class();
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end createUser()

    /**

Parameter $email should have a doc-comment as per coding-style.

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function findUserByEmail($email)
    {

Opening brace should be on the same line as the declaration

        return $this->findUserBy(['emailCanonical' => $this->canonicalFieldsUpdater->canonicalizeEmail($email)]);

Short array syntax is not allowed

This line exceeds maximum limit of 100 characters; contains 113 characters

    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end findUserByEmail()

    /**

Parameter $username should have a doc-comment as per coding-style.

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function findUserByUsername($username)
    {

Opening brace should be on the same line as the declaration

        return $this->findUserBy(['usernameCanonical' => $this->canonicalFieldsUpdater->canonicalizeUsername($username)]);

Short array syntax is not allowed

This line exceeds maximum limit of 100 characters; contains 122 characters

    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end findUserByUsername()

    /**

Parameter $usernameOrEmail should have a doc-comment as per coding-style.

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function findUserByUsernameOrEmail($usernameOrEmail)
    {

Opening brace should be on the same line as the declaration

        if (preg_match('/^.+\@\S+\.\S+$/', $usernameOrEmail)) {
            $user = $this->findUserByEmail($usernameOrEmail);
            if (null !== $user) {

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

                return $user;
            }
        }

        return $this->findUserByUsername($usernameOrEmail);
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end findUserByUsernameOrEmail()

    /**

Parameter $token should have a doc-comment as per coding-style.

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function findUserByConfirmationToken($token)
    {

Opening brace should be on the same line as the declaration

        return $this->findUserBy(['confirmationToken' => $token]);

Short array syntax is not allowed

    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end findUserByConfirmationToken()

    /**

Parameter $user should have a doc-comment as per coding-style.

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function updateCanonicalFields(UserInterface $user)
    {

Opening brace should be on the same line as the declaration

        $this->canonicalFieldsUpdater->updateCanonicalFields($user);
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end updateCanonicalFields()

    /**

Parameter $user should have a doc-comment as per coding-style.

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function updatePassword(UserInterface $user)
    {

Opening brace should be on the same line as the declaration

        $this->passwordUpdater->hashPassword($user);
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end updatePassword()

}

Expected //end class

As per coding style, files should not end with a newline character.