doyolabs / code-coverage

src/bridge/Controller/RemoteController.php

<?php

/*
 * This file is part of the doyo/code-coverage project.
 *
 * (c) Anthonius Munthi <https://itstoni.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Doyo\Bridge\CodeCoverage\Controller;

use Doyo\Bridge\CodeCoverage\Session\RemoteSession;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

class RemoteController
{
    const SERIALIZED_OBJECT_CONTENT_TYPE = 'application/php-serialized-object';

    /**
     * @return static
     */
    public static function create()
    {
        return new static();
    }

    /**
     * @return Response
     */
    public function getResponse()
    {
        $request  = Request::createFromGlobals();
        $action   = $request->get('action').'Action';
        $callable = [$this, $action];

        if (!method_exists($this, $action)) {
            $callable = [$this, 'notFoundAction'];
        }

        return \call_user_func_array($callable, [$request]);
    }

    /**
     * @return JsonResponse
     */
    public function notFoundAction()
    {
        $data = [
            'message' => 'The page you requested is not exists',
        ];

        return new JsonResponse($data, 404);
    }

    public function unsupportedMethodAction(Request $request, $supportedMethod)
    {
        $data = [
            'message' => sprintf(
                'action: %s not support method: %s. Supported method: %s',
                $request->get('action'),
                $request->getMethod(),
                $supportedMethod
            ),
        ];

        return new JsonResponse($data, Response::HTTP_METHOD_NOT_ALLOWED);
    }

    public function initAction(Request $request)
    {
        if (!$request->isMethod(Request::METHOD_POST)) {
            return $this->unsupportedMethodAction($request, 'POST');
        }
        $name   = $request->get('session');
        $config = $request->getContent();
        $config = json_decode($config, true);
        $error  = 'Failed to create session: <comment>'.$name.'</comment>';

        try {
            $session = new RemoteSession($name);

It seems like $name can also be of type null; however, parameter $name of Doyo\Bridge\CodeCoverage\Session\RemoteSession::__construct() does only seem to accept string, maybe add an additional type check?

            $session->init($config);
            $created = true;
        } catch (\Exception $e) {
            $error   = $e->getMessage();
            $created = false;
        }

        $status = Response::HTTP_ACCEPTED;
        if ($created) {
            $data = [
                'message' => 'coverage session: '.$name.' initialized.',
            ];
        } else {
            $data = [
                'message' => $error,
            ];
        }

        return new JsonResponse($data, $status);
    }

    public function readAction(Request $request)
    {
        if (!$request->isMethod(Request::METHOD_GET)) {
            return $this->unsupportedMethodAction($request, Request::METHOD_GET);
        }

        if (!$request->get('session')) {
            $data = [
                'message' => 'code coverage session not exists',
            ];

            return new JsonResponse($data, Response::HTTP_NOT_FOUND);
        }

        $session = $request->get('session');
        $session = new RemoteSession($session);

It seems like $session can also be of type null; however, parameter $name of Doyo\Bridge\CodeCoverage\Session\RemoteSession::__construct() does only seem to accept string, maybe add an additional type check?

        if (null === $session->getProcessor()) {
            $data = [
                'message' => 'Session '.$session->getName().' is not initialized.',
            ];

            return new JsonResponse($data, Response::HTTP_NOT_FOUND);
        }

        $data    = serialize($session);

        $response =  new Response($data, Response::HTTP_OK);
        $response->headers->set('Content-Type', static::SERIALIZED_OBJECT_CONTENT_TYPE);

        return $response;
    }
}