| Conditions | 1 |
| Paths | 1 |
| Total Lines | 63 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 56 |
| CRAP Score | 1 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 23 | 1 | protected function tt_gränser(): void { |
|
| 24 | 1 | $this->db_preferenser->validera_indata( |
|
| 25 | 1 | 'tt_odds_rätt_min', |
|
| 26 | 1 | 0, |
|
| 27 | 1 | self::TT_MATCHANTAL, |
|
|
|
|||
| 28 | 1 | self::TT_ODDS_RÄTT_MIN, |
|
| 29 | 1 | 'topptips.odds_rätt_min' |
|
| 30 | 1 | ); |
|
| 31 | |||
| 32 | 1 | $this->db_preferenser->validera_indata( |
|
| 33 | 1 | 'tt_odds_rätt_max', |
|
| 34 | 1 | 0, |
|
| 35 | 1 | self::TT_MATCHANTAL, |
|
| 36 | 1 | self::TT_ODDS_RÄTT_MAX, |
|
| 37 | 1 | 'topptips.odds_rätt_max' |
|
| 38 | 1 | ); |
|
| 39 | |||
| 40 | 1 | $this->db_preferenser->validera_indata( |
|
| 41 | 1 | 'tt_antal_1_min', |
|
| 42 | 1 | 0, |
|
| 43 | 1 | self::TT_MATCHANTAL, |
|
| 44 | 1 | self::TT_ANTAL_1_MIN, |
|
| 45 | 1 | 'topptips.antal_1_min' |
|
| 46 | 1 | ); |
|
| 47 | |||
| 48 | 1 | $this->db_preferenser->validera_indata( |
|
| 49 | 1 | 'tt_antal_1_max', |
|
| 50 | 1 | 0, |
|
| 51 | 1 | self::TT_MATCHANTAL, |
|
| 52 | 1 | self::TT_ANTAL_1_MAX, |
|
| 53 | 1 | 'topptips.antal_1_max' |
|
| 54 | 1 | ); |
|
| 55 | |||
| 56 | 1 | $this->db_preferenser->validera_indata( |
|
| 57 | 1 | 'tt_antal_X_min', |
|
| 58 | 1 | 0, |
|
| 59 | 1 | self::TT_MATCHANTAL, |
|
| 60 | 1 | self::TT_ANTAL_X_MIN, |
|
| 61 | 1 | 'topptips.antal_X_min' |
|
| 62 | 1 | ); |
|
| 63 | |||
| 64 | 1 | $this->db_preferenser->validera_indata( |
|
| 65 | 1 | 'tt_antal_X_max', |
|
| 66 | 1 | 0, |
|
| 67 | 1 | self::TT_MATCHANTAL, |
|
| 68 | 1 | self::TT_ANTAL_X_MAX, |
|
| 69 | 1 | 'topptips.antal_X_max' |
|
| 70 | 1 | ); |
|
| 71 | |||
| 72 | 1 | $this->db_preferenser->validera_indata( |
|
| 73 | 1 | 'tt_antal_2_min', |
|
| 74 | 1 | 0, |
|
| 75 | 1 | self::TT_MATCHANTAL, |
|
| 76 | 1 | self::TT_ANTAL_2_MIN, |
|
| 77 | 1 | 'topptips.antal_2_min' |
|
| 78 | 1 | ); |
|
| 79 | |||
| 80 | 1 | $this->db_preferenser->validera_indata( |
|
| 81 | 1 | 'tt_antal_2_max', |
|
| 82 | 1 | 0, |
|
| 83 | 1 | self::TT_MATCHANTAL, |
|
| 84 | 1 | self::TT_ANTAL_2_MAX, |
|
| 85 | 1 | 'topptips.antal_2_max' |
|
| 86 | 1 | ); |
|
| 89 |