Hamta::hämta_system() - Code Metrics - Inspection of "v. 0.8.0.12, Scrutinizer, buggfixar" - dougherty-dev/Tips - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( d29be2...38376b )

by N.

created 2025-06-19 05:50 UTC

Hamta::hämta_system() B

↳ Parent: Hamta

Complexity

Conditions	7
Paths	20

Size

Total Lines	52
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	8.2746

Importance

Changes

Metric	Value
cc	7
eloc	25
nc	20
nop	0
dl	0
loc	52
ccs	19
cts	27
cp	0.7037
crap	8.2746
rs	8.5866
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * Klass Hamta.
 * @author Niklas Dougherty
 */

declare(strict_types=1);

namespace Tips\Moduler\System;

use PDO;

/**
 * Klass Hamta.
 * Hämta garderingar från databas och packa upp.
 */
class Hamta extends Preferenser {
	/**
	 * @var array<int, string[]> $reduktion
	 */
	public array $reduktion;

	/**
	 * Hämta garderingar från databas
	 */
	protected function hämta_system(): void {
		$garderingar = '';
		$andel_garderingar = '';
		$sats = $this->odds->spel->db->instans->prepare('SELECT `garderingar`, `andel_garderingar`
			FROM `system` WHERE `omgång`=:omgang AND `speltyp`=:speltyp AND `sekvens`=:sekvens LIMIT 1');
		$sats->bindValue(':omgang', $this->odds->spel->omgång, PDO::PARAM_INT);
		$sats->bindValue(':speltyp', $this->odds->spel->speltyp->value, PDO::PARAM_INT);
		$sats->bindValue(':sekvens', $this->odds->spel->sekvens, PDO::PARAM_INT);
		$sats->bindColumn('garderingar', $garderingar, PDO::PARAM_STR);
		$sats->bindColumn('andel_garderingar', $andel_garderingar, PDO::PARAM_STR);
		$sats->execute();

		/**
		 * Packa upp garderingar.
		 */
		if ($sats->fetch()) {
			if ($garderingar) {
				$this->garderingar = array_chunk(array_chunk(explode(',', $garderingar), 3), MATCHANTAL);

			}

			if ($andel_garderingar) {
				$this->andel_garderingar = array_map('intval', explode(',', $andel_garderingar));
			}
		}

		/**
		 * Extrahera halvgarderingar.
		 */
		foreach ($this->garderingar as $index => $gardering) {
			foreach ($gardering as $tecken) {
				/**
				 * Halvgardering = en ruta tom.
				 */
				if (!in_array('', $tecken, true)) {
					$this->antal_garderingar[(int) $tecken]++;
				}
			}

			$this->antal_garderingar[$index] = min($this->andel_garderingar[$index], $this->antal_garderingar[$index]);
		}

		$reduktion = $this->db_preferenser->hämta_preferens("system.reduktion");

		/**
		 * Finns reduktion i preferenser är allt väl.
		 * Annars sparas en tom datastruktur.
		 */
		match ($reduktion !== '') {
			true => $this->reduktion = array_chunk(explode(',', $reduktion), 3),
			false => $this->db_preferenser->spara_preferens(
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
				"system.reduktion",
				implode(',', array_merge([], ...array_fill(0, MATCHANTAL, TOM_STRÄNGVEKTOR)))

			)
		};
	}
}


1		<?php
2
3		/**
4		* Klass Hamta.
5		* @author Niklas Dougherty
6		*/
7
8		declare(strict_types=1);
9
10		namespace Tips\Moduler\System;
11
12		use PDO;
13
14		/**
15		* Klass Hamta.
16		* Hämta garderingar från databas och packa upp.
17		*/
18		class Hamta extends Preferenser {
19		/**
20		* @var array<int, string[]> $reduktion
21		*/
22		public array $reduktion;
23
24		/**
25		* Hämta garderingar från databas
26		*/
27	3	protected function hämta_system(): void {
28	3	$garderingar = '';
29	3	$andel_garderingar = '';
30	3	$sats = $this->odds->spel->db->instans->prepare('SELECT `garderingar`, `andel_garderingar`
31	3	FROM `system` WHERE `omgång`=:omgang AND `speltyp`=:speltyp AND `sekvens`=:sekvens LIMIT 1');
32	3	$sats->bindValue(':omgang', $this->odds->spel->omgång, PDO::PARAM_INT);
33	3	$sats->bindValue(':speltyp', $this->odds->spel->speltyp->value, PDO::PARAM_INT);
34	3	$sats->bindValue(':sekvens', $this->odds->spel->sekvens, PDO::PARAM_INT);
35	3	$sats->bindColumn('garderingar', $garderingar, PDO::PARAM_STR);
36	3	$sats->bindColumn('andel_garderingar', $andel_garderingar, PDO::PARAM_STR);
37	3	$sats->execute();
38
39		/**
40		* Packa upp garderingar.
41		*/
42	3	if ($sats->fetch()) {
43		if ($garderingar) {
44		$this->garderingar = array_chunk(array_chunk(explode(',', $garderingar), 3), MATCHANTAL);
		0 ignored issues – show Bug introduced 2025-06-18 12:19 UTC by Report Bug Copy Issue Report The constant `Tips\Moduler\System\MATCHANTAL` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
45		}
46
47		if ($andel_garderingar) {
48		$this->andel_garderingar = array_map('intval', explode(',', $andel_garderingar));
49		}
50		}
51
52		/**
53		* Extrahera halvgarderingar.
54		*/
55	3	foreach ($this->garderingar as $index => $gardering) {
56	3	foreach ($gardering as $tecken) {
57		/**
58		* Halvgardering = en ruta tom.
59		*/
60	3	if (!in_array('', $tecken, true)) {
61		$this->antal_garderingar[(int) $tecken]++;
62		}
63		}
64
65	3	$this->antal_garderingar[$index] = min($this->andel_garderingar[$index], $this->antal_garderingar[$index]);
66		}
67
68	3	$reduktion = $this->db_preferenser->hämta_preferens("system.reduktion");
69
70		/**
71		* Finns reduktion i preferenser är allt väl.
72		* Annars sparas en tom datastruktur.
73		*/
74	3	match ($reduktion !== '') {
75	3	true => $this->reduktion = array_chunk(explode(',', $reduktion), 3),
76		false => $this->db_preferenser->spara_preferens(
		0 ignored issues – show Bug introduced 2025-06-18 14:59 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->db_preferenser->s...m\TOM_STRÄNGVEKTOR))))` targeting `Tips\Klasser\DBPreferens...nOut::spara_preferens()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
77		"system.reduktion",
78		implode(',', array_merge([], ...array_fill(0, MATCHANTAL, TOM_STRÄNGVEKTOR)))
		0 ignored issues – show Bug introduced 2025-06-18 12:19 UTC by Report Bug Copy Issue Report The constant `Tips\Moduler\System\TOM_STRÄNGVEKTOR` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
79		)
80	3	};
81		}
82		}
83

dougherty-dev / Tips

Push — main ( d29be2...38376b )

Hamta::hämta_system() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like