Issues (15)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Metadata/Driver/YamlDriver.php (7 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
namespace Dontdrinkandroot\RestBundle\Metadata\Driver;
4
5
use Dontdrinkandroot\RestBundle\Metadata\Annotation\Method;
6
use Dontdrinkandroot\RestBundle\Metadata\Annotation\Postable;
7
use Dontdrinkandroot\RestBundle\Metadata\Annotation\Puttable;
8
use Dontdrinkandroot\RestBundle\Metadata\ClassMetadata;
9
use Dontdrinkandroot\RestBundle\Metadata\PropertyMetadata;
10
use Metadata\Driver\AbstractFileDriver;
11
use Metadata\Driver\DriverInterface;
12
use Metadata\Driver\FileLocatorInterface;
13
use Symfony\Component\Yaml\Yaml;
14
15
class YamlDriver extends AbstractFileDriver
16
{
17
    /**
18
     * @var DriverInterface
19
     */
20
    private $doctrineDriver;
21
22 90
    public function __construct(FileLocatorInterface $locator, DriverInterface $doctrineDriver)
23
    {
24 90
        parent::__construct($locator);
25 90
        $this->doctrineDriver = $doctrineDriver;
26 90
    }
27
28
    /**
29
     * {@inheritdoc}
30
     */
31 54
    protected function loadMetadataFromFile(\ReflectionClass $class, $file)
32
    {
33
        /** @var ClassMetadata $ddrRestClassMetadata */
34 54
        $classMetadata = $this->doctrineDriver->loadMetadataForClass($class);
35 54
        if (null === $classMetadata) {
36
            $classMetadata = new ClassMetadata($class->getName());
37
        }
38
39 54
        $config = Yaml::parse(file_get_contents($file));
40 54
        $className = key($config);
41
42 54
        if ($className !== $class->name) {
43
            throw new \RuntimeException(
44
                sprintf('Class definition mismatch for "%s" in "%s": %s', $class->getName(), $file, key($config))
45
            );
46
        }
47
48 54
        $config = $config[$className];
49 54
        if (!is_array($config)) {
50
            $config = [];
51
        }
52
53 54
        if (array_key_exists('rootResource', $config) && true === $config['rootResource']) {
54 54
            $classMetadata->setRestResource(true);
55
        }
56 54
        if (array_key_exists('controller', $config)) {
57
            $classMetadata->controller = $config['controller'];
0 ignored issues
show
The property controller does not seem to exist in Metadata\ClassMetadata.

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
58
        }
59 54
        if (array_key_exists('idField', $config)) {
60
            $classMetadata->idField = $config['idField'];
0 ignored issues
show
The property idField does not seem to exist in Metadata\ClassMetadata.

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
61
        }
62 54
        if (array_key_exists('pathPrefix', $config)) {
63
            $classMetadata->pathPrefix = $config['pathPrefix'];
0 ignored issues
show
The property pathPrefix does not seem to exist in Metadata\ClassMetadata.

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
64
        }
65 54
        if (array_key_exists('namePrefix', $config)) {
66
            $classMetadata->namePrefix = $config['namePrefix'];
0 ignored issues
show
The property namePrefix does not seem to exist in Metadata\ClassMetadata.

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
67
        }
68
69 54
        $classMetadata->setMethods($this->parseMethods($config));
70
71 54
        $fieldConfigs = [];
72 54
        if (array_key_exists('fields', $config)) {
73 54
            $fieldConfigs = $config['fields'];
74
        }
75
76 54
        foreach ($class->getProperties() as $reflectionProperty) {
77
78 54
            $propertyName = $reflectionProperty->getName();
79 54
            $propertyMetadata = $this->getOrCreatePropertyMetadata($classMetadata, $propertyName);
0 ignored issues
show
$classMetadata of type object<Metadata\ClassMetadata> is not a sub-type of object<Dontdrinkandroot\...Metadata\ClassMetadata>. It seems like you assume a child class of the class Metadata\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
80
81 54
            if (array_key_exists($propertyName, $fieldConfigs)) {
82 54
                $fieldConfig = $fieldConfigs[$propertyName];
83 54
                $this->parseFieldConfig($propertyName, $fieldConfig, $propertyMetadata);
84 54
                unset($fieldConfigs[$propertyName]);
85
            }
86
87 54
            $classMetadata->addPropertyMetadata($propertyMetadata);
88
        }
89
90
        /* Parse unbacked field definitions */
91 54
        foreach ($fieldConfigs as $name => $fieldConfig) {
92 32
            $propertyMetadata = $this->getOrCreatePropertyMetadata($classMetadata, $name);
0 ignored issues
show
$classMetadata of type object<Metadata\ClassMetadata> is not a sub-type of object<Dontdrinkandroot\...Metadata\ClassMetadata>. It seems like you assume a child class of the class Metadata\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
93 32
            $this->parseFieldConfig($name, $fieldConfig, $propertyMetadata);
94 32
            $classMetadata->addPropertyMetadata($propertyMetadata);
95
        }
96
97 54
        return $classMetadata;
98
    }
99
100 54
    protected function parseFieldConfig(string $name, array $fieldConfig, PropertyMetadata $propertyMetadata): void
101
    {
102 54
        $propertyMetadata->setPostable(Postable::parse($fieldConfig['postable'] ?? null));
103 54
        $propertyMetadata->setPuttable(Puttable::parse($fieldConfig['puttable'] ?? null));
104
105 54
        if (null !== $value = $fieldConfig['type'] ?? null) {
106
            $propertyMetadata->setType($value);
107
        }
108
109 54
        if (null !== $value = $this->getBool('excluded', $fieldConfig)) {
110 32
            $propertyMetadata->setExcluded($value);
111
        }
112
113 54
        if (null !== $value = $this->getBool('virtual', $fieldConfig)) {
114 30
            $propertyMetadata->setVirtual($value);
115
        }
116
117 54
        if (null !== $subResourceConfig = $fieldConfig['subResource'] ?? null) {
118 52
            $propertyMetadata->setSubResource(true);
119 52
            $propertyMetadata->setMethods($this->parseMethods($subResourceConfig));
0 ignored issues
show
$this->parseMethods($subResourceConfig) is of type null|array, but the function expects a array<integer,object<Don...ata\Annotation\Method>>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
120
        }
121
122 54
        if (array_key_exists('includable', $fieldConfig)) {
123 52
            $value = $fieldConfig['includable'];
124 52
            if (is_array($value)) {
125 34
                $propertyMetadata->setIncludable(true);
126 34
                $propertyMetadata->setIncludablePaths($value);
127 52
            } elseif (true === $value) {
128 52
                $propertyMetadata->setIncludable(true);
129 52
                $propertyMetadata->setIncludablePaths([$name]);
130
            }
131
        }
132 54
    }
133
134 54
    private function getBool(string $key, array $haystack, bool $required = false)
135
    {
136 54
        $value = $this->getArrayValue($key, $haystack, $required);
137 54
        if (null === $value) {
138 54
            return null;
139
        }
140
141 32
        if (!is_bool($value)) {
142
            throw new \RuntimeException(sprintf('Value %s must be of type bool', $key));
143
        }
144
145 32
        return $value;
146
    }
147
148 54
    private function getArrayValue(string $key, array $haystack, bool $required = false)
149
    {
150 54
        if (!array_key_exists($key, $haystack)) {
151 54
            if ($required) {
152
                throw new \RuntimeException(sprintf('Value %s is required', $key));
153
            }
154
155 54
            return null;
156
        }
157
158 32
        return $haystack[$key];
159
    }
160
161
    /**
162
     * {@inheritdoc}
163
     */
164 90
    protected function getExtension()
165
    {
166 90
        return 'rest.yml';
167
    }
168
169 54
    protected function getOrCreatePropertyMetadata(ClassMetadata $classMetadata, $propertyName): PropertyMetadata
170
    {
171 54
        $propertyMetadata = $classMetadata->getPropertyMetadata($propertyName);
172 54
        if (null === $propertyMetadata) {
173 32
            $propertyMetadata = new PropertyMetadata($classMetadata->name, $propertyName);
174
175 32
            return $propertyMetadata;
176
        }
177
178 52
        return $propertyMetadata;
179
    }
180
181
    /**
182
     * @param array $config
183
     *
184
     * @return Method[]
185
     */
186 54
    private function parseMethods(array $config)
187
    {
188 54
        if (!array_key_exists('methods', $config)) {
189
            return null;
190
        }
191
192 54
        $methods = [];
193 54
        $methodsConfig = $config['methods'];
194 54
        foreach ($methodsConfig as $name => $config) {
195 54
            $method = Method::parse($name, $config);
196 54
            $methods[$method->name] = $method;
197
        }
198
199 54
        return $methods;
200
    }
201
}
202