Issues in BaseAcceptanceTest.php - New Issues - Inspection of "Upgrading to Symfony 4.3" - dontdrinkandroot/gitki.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fc7027...e72ab1 )

by Philip

created 2019-06-03 21:32 UTC

tests/Acceptance/BaseAcceptanceTest.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Tests\Acceptance;

use App\Entity\User;
use App\Tests\Integration\BaseIntegrationTest;
use Symfony\Component\BrowserKit\AbstractBrowser;
use Symfony\Component\BrowserKit\Cookie;
use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;

abstract class BaseAcceptanceTest extends BaseIntegrationTest
{
    /**
     * @param User $user
     */
    protected function logIn(AbstractBrowser $client, User $user)
    {
        $session = $client->getContainer()->get('session');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $firewall = 'main';
        $token = new UsernamePasswordToken($user, null, $firewall, $user->getRoles());
        $session->set('_security_' . $firewall, serialize($token));
        $session->save();

        $cookie = new Cookie($session->getName(), $session->getId());
        $client->getCookieJar()->set($cookie);
    }

    protected function logOut(AbstractBrowser $client)
    {
        $session = $client->getContainer()->get('session');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $session->clear();
        $session->save();

        $client->getCookieJar()->clear();
    }
}


Push — master ( fc7027...e72ab1 )

tests/Acceptance/BaseAcceptanceTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Tests\Acceptance;
4
5			use App\Entity\User;
6			use App\Tests\Integration\BaseIntegrationTest;
7			use Symfony\Component\BrowserKit\AbstractBrowser;
8			use Symfony\Component\BrowserKit\Cookie;
9			use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
10
11			abstract class BaseAcceptanceTest extends BaseIntegrationTest
12			{
13			/**
14			* @param User $user
15			*/
16			protected function logIn(AbstractBrowser $client, User $user)
17			{
18			$session = $client->getContainer()->get('session');
			0 ignored issues – show Bug introduced 2019-06-03 21:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `Symfony\Component\BrowserKit\AbstractBrowser` as the method `getContainer()` does only exist in the following sub-classes of `Symfony\Component\BrowserKit\AbstractBrowser`: `Liip\FunctionalTestBundle\QueryCountClient`, `Symfony\Bundle\FrameworkBundle\Client`, `Symfony\Bundle\FrameworkBundle\KernelBrowser`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
19
20			$firewall = 'main';
21			$token = new UsernamePasswordToken($user, null, $firewall, $user->getRoles());
22			$session->set('_security_' . $firewall, serialize($token));
23			$session->save();
24
25			$cookie = new Cookie($session->getName(), $session->getId());
26			$client->getCookieJar()->set($cookie);
27			}
28
29			protected function logOut(AbstractBrowser $client)
30			{
31			$session = $client->getContainer()->get('session');
			0 ignored issues – show Bug introduced 2019-06-03 21:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `Symfony\Component\BrowserKit\AbstractBrowser` as the method `getContainer()` does only exist in the following sub-classes of `Symfony\Component\BrowserKit\AbstractBrowser`: `Liip\FunctionalTestBundle\QueryCountClient`, `Symfony\Bundle\FrameworkBundle\Client`, `Symfony\Bundle\FrameworkBundle\KernelBrowser`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
32			$session->clear();
33			$session->save();
34
35			$client->getCookieJar()->clear();
36			}
37			}
38

dontdrinkandroot / gitki.php

Push — master ( fc7027...e72ab1 )

tests/Acceptance/BaseAcceptanceTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like