App\Tests\Acceptance\IndexFileTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getFixtureClasses()	0	4	1
A	testIndexFileShown()	0	24	1

<?php

namespace App\Tests\Acceptance;

use App\DataFixtures\UserReferenceTrait;
use App\DataFixtures\Users;

class IndexFileTest extends BaseAcceptanceTest
{
    use UserReferenceTrait;

    /**
     * {@inheritdoc}
     */
    protected function getFixtureClasses()
    {
        return [Users::class];
    }

    public function testIndexFileShown()
    {
        $referenceRepository = $this->loadClientAndFixtures([Users::class]);

        $this->login($this->getUser(Users::COMMITTER, $referenceRepository));

        $crawler = $this->client->request('GET', '/');

$crawler is not used, you could remove the assignment.

//        $this->assertStatusCode(302, $client);
        $this->assertEquals(302, $this->client->getResponse()->getStatusCode());

        $location = $this->client->getResponse()->headers->get('Location');
        $this->assertEquals('/browse/?action=index', $location);
        $crawler = $this->client->request('GET', $location);

$crawler is not used, you could remove the assignment.

It seems like $location defined by $this->client->getResponse()->headers->get('Location') on line 30 can also be of type array or null; however, Symfony\Component\BrowserKit\Client::request() does only seem to accept string, maybe add an additional type check?

//        $this->assertStatusCode(302, $client);

        $this->assertEquals(302, $this->client->getResponse()->getStatusCode());
        $location = $this->client->getResponse()->headers->get('Location');
        $this->assertEquals('/browse/index.md', $location);
        $crawler = $this->client->request('GET', $location);

It seems like $location defined by $this->client->getResponse()->headers->get('Location') on line 36 can also be of type array or null; however, Symfony\Component\BrowserKit\Client::request() does only seem to accept string, maybe add an additional type check?

//        $this->assertStatusCode(200, $client);

        $this->assertEquals(200, $this->client->getResponse()->getStatusCode());
        $this->assertEquals('Welcome', $crawler->filter('h1')->text());
    }
}