App\Command\UserEditCommand

Complexity

Total Complexity

10

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	6	1
B	execute()	0	53	9

<?php

namespace App\Command;

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ChoiceQuestion;
use Symfony\Component\Console\Question\ConfirmationQuestion;

class UserEditCommand extends AbstractUserCommand
{
    const FIELD_PASSWORD = 'Password';
    const FIELD_REAL_NAME = 'Real Name';

    protected function configure()
    {
        $this
            ->setName('gitki:user:edit')
            ->setDescription('Edits an existing user');
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $userManager = $this->getUserManager();
        $questionHelper = $this->getQuestionHelper();

        $user = $this->selectUser($input, $output);

        $fields = [
            self::FIELD_REAL_NAME,
            'Email',
            'Role',
            self::FIELD_PASSWORD,
            'Github Login',
            'Google Login',
            'Done'
        ];

        $fieldQuestion = new ChoiceQuestion(
            'Select Field: ',
            $fields
        );
        do {
            $this->printUser($user, $output);
            $field = $questionHelper->ask($input, $output, $fieldQuestion);
            switch ($field) {
                case self::FIELD_REAL_NAME:
                    $user = $this->editRealName($input, $output, $user, $questionHelper);
                    break;
                case 'Email':
                    $user = $this->editEmail($input, $output, $user, $questionHelper);
                    break;
                case 'Role':
                    $user = $this->editRole($input, $output, $user, $questionHelper);
                    break;
                case self::FIELD_PASSWORD:
                    $user = $this->editPassword($input, $output, $user, $questionHelper, $userManager);

It seems like $userManager defined by $this->getUserManager() on line 24 can be null; however, App\Command\AbstractUserCommand::editPassword() does not accept null, maybe add an additional type check?

                    break;
                case 'Github Login':
                    $user = $this->editGithubId($input, $output, $user, $questionHelper);
                    break;
                case 'Google Login':
                    $user = $this->editGoogleId($input, $output, $user, $questionHelper);
                    break;
            }
        } while ('Done' !== $field);

        $this->printUser($user, $output);

        $saveQuestion = new ConfirmationQuestion('Save? ', false);
        if ($questionHelper->ask($input, $output, $saveQuestion)) {
            $userManager->updateUser($user);
        }
    }
}