TransactionalCrudRepository::findAll() - Code Metrics - Inspection of "Deprecating Crud Repository methods, refactoring T..." - dontdrinkandroot/doctrine.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d6e4db...4ab9f9 )

by Philip

created 2020-01-21 21:05 UTC

TransactionalCrudRepository::findAll() A

↳ Parent: TransactionalCrudRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

namespace Dontdrinkandroot\Repository;

use Doctrine\Common\Collections\Criteria;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Mapping;
use Doctrine\ORM\Tools\Pagination\Paginator;

/**
 * @author Philip Washington Sorst <[email protected]>
 */
class TransactionalCrudRepository extends CrudRepository
{
    /** @var TransactionManager */
    private $transactionManager;

    public function __construct(
        EntityManagerInterface $em,
        Mapping\ClassMetadata $class,
        ?TransactionManager $transactionManager = null
    ) {
        parent::__construct($em, $class);
        if (null === $transactionManager) {
            $this->transactionManager = new TransactionManager($this->getEntityManager());
        } else {
            $this->transactionManager = $transactionManager;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function find($id, $lockMode = null, $lockVersion = null)
    {
        return $this->transactionManager->transactional(
            function () use ($id, $lockMode, $lockVersion) {
                return parent::find($id, $lockMode = null, $lockVersion = null);
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
            }
        );
    }

    /**
     * {@inheritdoc}
     */
    public function findAll()
    {
        return $this->transactionManager->transactional(
            function () {
                return parent::findAll();
            }
        );
    }

    /**
     * {@inheritdoc}
     */
    public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
    {
        return $this->transactionManager->transactional(
            function () use ($criteria, $orderBy, $limit, $offset) {
                return parent::findBy($criteria, $orderBy, $limit, $offset);
            }
        );
    }

    /**
     * {@inheritdoc}
     */
    public function findOneBy(array $criteria, array $orderBy = null)
    {
        return $this->transactionManager->transactional(
            function () use ($criteria, $orderBy) {
                return parent::findOneBy($criteria, $orderBy);
            }
        );
    }

    /**
     * {@inheritdoc}
     */
    public function persist(object $entity, bool $flush = true): object
    {
        return $this->transactionManager->transactional(
            function () use ($entity) {
                $this->getEntityManager()->persist($entity);

                return $entity;
            },
            $flush
        );
    }

    /**
     * {@inheritdoc}
     */
    public function merge(object $entity, $flush = false): object
    {
        return $this->transactionManager->transactional(
            function () use ($entity) {
                $this->getEntityManager()->merge($entity);
            },
            $flush
        );
    }

    /**
     * {@inheritdoc}
     */
    public function remove(object $entity, bool $flush = false): void
    {
        $this->transactionManager->transactional(
            function () use ($entity): void {
                $this->getEntityManager()->remove($entity);
            },
            $flush
        );
    }

    /**
     * {@inheritdoc}
     */
    public function removeById($id, bool $flush = false): void
    {
        $this->transactionManager->transactional(
            function () use ($id, $flush): void {
                $entity = $this->find($id);
                if (null !== $entity) {
                    $this->remove($entity, $flush);
                }
            }
        );
    }

    /**
     * {@inheritdoc}
     */
    public function count(array $criteria)
    {
        return $this->transactionManager->transactional(
            function () use ($criteria) {
                return parent::count($criteria);
            }
        );
    }

    /**
     * {@inheritdoc}
     */
    public function matching(Criteria $criteria)
    {
        return $this->transactionManager->transactional(
            function () use ($criteria) {
                return parent::matching($criteria);
            }
        );
    }

    /**
     * {@inheritdoc}
     */
    public function removeAll(bool $flush = false, bool $iterate = true): void
    {
        $this->transactionManager->transactional(
            function () use ($iterate): void {
                parent::removeAll(false, $iterate);
            },
            $flush
        );
    }

    /**
     * {@inheritdoc}
     */
    public function findPaginatedBy(
        int $page = 1,
        int $perPage = 10,
        array $criteria = [],
        array $orderBy = null
    ): Paginator {
        return $this->transactionManager->transactional(
            function () use ($page, $perPage, $criteria, $orderBy): Paginator {
                return parent::findPaginatedBy($page, $perPage, $criteria, $orderBy);
            }
        );
    }

    /**
     * {@inheritdoc}
     */
    public function countAll(): int
    {
        return $this->transactionManager->transactional(
            function (): int {
                return parent::countAll();
            }
        );
    }

    public function getTransactionManager(): TransactionManager
    {
        return $this->transactionManager;
    }

    public function setTransactionManager(TransactionManager $transactionManager): void
    {
        $this->transactionManager = $transactionManager;
    }
}


Push — master ( d6e4db...4ab9f9 )

TransactionalCrudRepository::findAll() A

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

Change not visible in outer-scope

Change visible in outer-scope

1		<?php
2
3		namespace Dontdrinkandroot\Repository;
4
5		use Doctrine\Common\Collections\Criteria;
6		use Doctrine\ORM\EntityManagerInterface;
7		use Doctrine\ORM\Mapping;
8		use Doctrine\ORM\Tools\Pagination\Paginator;
9
10		/**
11		* @author Philip Washington Sorst <[email protected]>
12		*/
13		class TransactionalCrudRepository extends CrudRepository
14		{
15		/** @var TransactionManager */
16		private $transactionManager;
17
18	16	public function __construct(
19		EntityManagerInterface $em,
20		Mapping\ClassMetadata $class,
21		?TransactionManager $transactionManager = null
22		) {
23	16	parent::__construct($em, $class);
24	16	if (null === $transactionManager) {
25	16	$this->transactionManager = new TransactionManager($this->getEntityManager());
26		} else {
27		$this->transactionManager = $transactionManager;
28		}
29	16	}
30
31		/**
32		* {@inheritdoc}
33		*/
34	2	public function find($id, $lockMode = null, $lockVersion = null)
35		{
36	2	return $this->transactionManager->transactional(
37		function () use ($id, $lockMode, $lockVersion) {
38	2	return parent::find($id, $lockMode = null, $lockVersion = null);
		0 ignored issues – show Bug introduced 2020-01-21 21:08 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$lockMode`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history... Bug introduced 2020-01-21 21:08 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$lockVersion`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
39	2	}
40		);
41		}
42
43		/**
44		* {@inheritdoc}
45		*/
46	2	public function findAll()
47		{
48	2	return $this->transactionManager->transactional(
49		function () {
50	2	return parent::findAll();
51	2	}
52		);
53		}
54
55		/**
56		* {@inheritdoc}
57		*/
58	2	public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
59		{
60	2	return $this->transactionManager->transactional(
61		function () use ($criteria, $orderBy, $limit, $offset) {
62	2	return parent::findBy($criteria, $orderBy, $limit, $offset);
63	2	}
64		);
65		}
66
67		/**
68		* {@inheritdoc}
69		*/
70		public function findOneBy(array $criteria, array $orderBy = null)
71		{
72		return $this->transactionManager->transactional(
73		function () use ($criteria, $orderBy) {
74		return parent::findOneBy($criteria, $orderBy);
75		}
76		);
77		}
78
79		/**
80		* {@inheritdoc}
81		*/
82	2	public function persist(object $entity, bool $flush = true): object
83		{
84	2	return $this->transactionManager->transactional(
85		function () use ($entity) {
86	2	$this->getEntityManager()->persist($entity);
87
88	2	return $entity;
89	2	},
90	2	$flush
91		);
92		}
93
94		/**
95		* {@inheritdoc}
96		*/
97		public function merge(object $entity, $flush = false): object
98		{
99		return $this->transactionManager->transactional(
100		function () use ($entity) {
101		$this->getEntityManager()->merge($entity);
102		},
103		$flush
104		);
105		}
106
107		/**
108		* {@inheritdoc}
109		*/
110	6	public function remove(object $entity, bool $flush = false): void
111		{
112	6	$this->transactionManager->transactional(
113		function () use ($entity): void {
114	6	$this->getEntityManager()->remove($entity);
115	6	},
116	6	$flush
117		);
118	6	}
119
120		/**
121		* {@inheritdoc}
122		*/
123	2	public function removeById($id, bool $flush = false): void
124		{
125	2	$this->transactionManager->transactional(
126		function () use ($id, $flush): void {
127	2	$entity = $this->find($id);
128	2	if (null !== $entity) {
129	2	$this->remove($entity, $flush);
130		}
131	2	}
132		);
133	2	}
134
135		/**
136		* {@inheritdoc}
137		*/
138		public function count(array $criteria)
139		{
140		return $this->transactionManager->transactional(
141		function () use ($criteria) {
142		return parent::count($criteria);
143		}
144		);
145		}
146
147		/**
148		* {@inheritdoc}
149		*/
150		public function matching(Criteria $criteria)
151		{
152		return $this->transactionManager->transactional(
153		function () use ($criteria) {
154		return parent::matching($criteria);
155		}
156		);
157		}
158
159		/**
160		* {@inheritdoc}
161		*/
162	4	public function removeAll(bool $flush = false, bool $iterate = true): void
163		{
164	4	$this->transactionManager->transactional(
165		function () use ($iterate): void {
166	4	parent::removeAll(false, $iterate);
167	4	},
168	4	$flush
169		);
170	4	}
171
172		/**
173		* {@inheritdoc}
174		*/
175	2	public function findPaginatedBy(
176		int $page = 1,
177		int $perPage = 10,
178		array $criteria = [],
179		array $orderBy = null
180		): Paginator {
181	2	return $this->transactionManager->transactional(
182		function () use ($page, $perPage, $criteria, $orderBy): Paginator {
183	2	return parent::findPaginatedBy($page, $perPage, $criteria, $orderBy);
184	2	}
185		);
186		}
187
188		/**
189		* {@inheritdoc}
190		*/
191	6	public function countAll(): int
192		{
193	6	return $this->transactionManager->transactional(
194		function (): int {
195	6	return parent::countAll();
196	6	}
197		);
198		}
199
200	6	public function getTransactionManager(): TransactionManager
201		{
202	6	return $this->transactionManager;
203		}
204
205		public function setTransactionManager(TransactionManager $transactionManager): void
206		{
207		$this->transactionManager = $transactionManager;
208		}
209		}
210

dontdrinkandroot / doctrine.php

Push — master ( d6e4db...4ab9f9 )

TransactionalCrudRepository::findAll() A

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like