Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class Table { |
||
10 | |||
11 | use Traits\EscapeTrait; |
||
12 | use CharsetAndCollationTrait; |
||
13 | |||
14 | /** |
||
15 | * Table constructor. |
||
16 | * |
||
17 | * @param string $name |
||
18 | */ |
||
19 | public function __construct( $name ) { |
||
22 | |||
23 | /** |
||
24 | * Table Name |
||
25 | * |
||
26 | * @var string |
||
27 | */ |
||
28 | protected $name; |
||
29 | |||
30 | /** |
||
31 | * Table Comment |
||
32 | * |
||
33 | * @var string |
||
34 | */ |
||
35 | protected $comment = ''; |
||
36 | |||
37 | protected $engine = null; |
||
38 | |||
39 | /** |
||
40 | * @return Columns\AbstractColumn[] |
||
41 | */ |
||
42 | public function getColumns() { |
||
45 | |||
46 | /** |
||
47 | * @return string |
||
48 | */ |
||
49 | public function getComment() { |
||
52 | |||
53 | /** |
||
54 | * @param string $comment |
||
55 | */ |
||
56 | public function setComment( $comment ) { |
||
59 | |||
60 | /** |
||
61 | * @return null |
||
62 | */ |
||
63 | public function getEngine() { |
||
66 | |||
67 | /** |
||
68 | * @param null $engine |
||
69 | */ |
||
70 | public function setEngine( $engine ) { |
||
73 | |||
74 | /** |
||
75 | * @return string |
||
76 | */ |
||
77 | public function getName() { |
||
80 | |||
81 | /** |
||
82 | * @param string $name |
||
83 | */ |
||
84 | public function setName( $name ) { |
||
87 | |||
88 | /** |
||
89 | * @var AbstractIntegerColumn|null |
||
90 | */ |
||
91 | protected $autoIncrement = null; |
||
92 | |||
93 | public function addAutoIncrement( AbstractIntegerColumn $column ) { |
||
98 | |||
99 | /** |
||
100 | * @param \donatj\MySqlSchema\Columns\Numeric\AbstractIntegerColumn $column |
||
101 | * @return bool |
||
102 | */ |
||
103 | public function isAutoIncrement( AbstractIntegerColumn $column ) { |
||
106 | |||
107 | /** |
||
108 | * @var AbstractColumn[] |
||
109 | */ |
||
110 | protected $primaryKeys = [ ]; |
||
111 | |||
112 | public function addPrimaryKey( AbstractColumn $column ) { |
||
117 | |||
118 | /** |
||
119 | * @param \donatj\MySqlSchema\Columns\AbstractColumn $column |
||
120 | * @return bool |
||
121 | */ |
||
122 | public function isPrimaryKey( AbstractColumn $column ) { |
||
125 | |||
126 | protected $keys = [ ]; |
||
127 | |||
128 | public function addKeyColumn( $keyName, AbstractColumn $column, $index = null, $type = 'NORMAL', $method = '' ) { |
||
145 | |||
146 | protected $foreignKeys = [ ]; |
||
147 | |||
148 | public function addForeignKey( AbstractColumn $local, AbstractColumn $remote ) { |
||
154 | |||
155 | /** |
||
156 | * @var Columns\AbstractColumn[] |
||
157 | */ |
||
158 | protected $columns = [ ]; |
||
159 | |||
160 | public function addColumn( AbstractColumn $column ) { |
||
164 | |||
165 | public function toString() { |
||
261 | } |
||
262 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.