| Conditions | 10 | 
| Paths | 7 | 
| Total Lines | 24 | 
| Code Lines | 12 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php | ||
| 22 | public static function filter($value, $allowNull = false, \DateTimeZone $timezone = null) | ||
| 23 |     { | ||
| 24 |         if ($allowNull !== false && $allowNull !== true) { | ||
| 25 |             throw new \InvalidArgumentException('$allowNull was not a boolean value'); | ||
| 26 | } | ||
| 27 | |||
| 28 |         if ($value === null && $allowNull) { | ||
| 29 | return null; | ||
| 30 | } | ||
| 31 | |||
| 32 |         if ($value instanceof \DateTime) { | ||
| 33 | return $value; | ||
| 34 | } | ||
| 35 | |||
| 36 |         if (is_int($value) || ctype_digit($value)) { | ||
| 37 |             $value = "@{$value}"; | ||
| 38 | } | ||
| 39 | |||
| 40 |         if (!is_string($value) || trim($value) == '') { | ||
| 41 |             throw new \Exception('$value is not a non-empty string'); | ||
| 42 | } | ||
| 43 | |||
| 44 | return new \DateTime($value, $timezone); | ||
| 45 | } | ||
| 46 | |||
| 66 |