Isign\Login\AbstractSmartIdQuery

Complexity

Total Complexity

4

Size/Duplication

Total Lines	61
Duplicated Lines	19.67 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getFields()	0	9	1
A	getValidationConstraints()	12	12	1
A	getMethod()	0	4	1

<?php
namespace Isign\Login;

use Isign\QueryInterface;
use Isign\Validator\Constraints\Code;
use Isign\Validator\Constraints\Phone;
use Symfony\Component\Validator\Constraints as Assert;

/**
 * Absctract smartId query.
 */
abstract class AbstractSmartIdQuery implements QueryInterface
{
    /** @var string user personal code */
    private $code;

    /** @var string Country related to personal code. Example EE */
    private $country;

    /**
     * @param string $code
     * @param string $country
     * @return self

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(
        $code,
        $country
    ) {
        $this->code = $code;
        $this->country = $country;
    }

    /**
     * Field and values association used in query
     * @return array
     */
    public function getFields()
    {
        $return = [
            'code' => $this->code,
            'country' => $this->country,
        ];

        return $return;
    }

    /**
     * Validation constraints for request data validation
     * @return Assert\Collection
     */
    public function getValidationConstraints()

This method seems to be duplicated in your project.

    {
        return new Assert\Collection([

The return type of return new \Symfony\Component\Validator\Constraints\Collection(array('code' => new \Symfony\Component\Validator\Constraints\Required(array(new \Symfony\Component\Validator\Constraints\NotBlank(), new \Isign\Validator\Constraints\Code())), 'country' => new \Symfony\Component\Validator\Constraints\Required(array(new \Symfony\Component\Validator\Constraints\NotBlank())))); (Symfony\Component\Validator\Constraints\Collection) is incompatible with the return type declared by the interface Isign\QueryInterface::getValidationConstraints of type Isign\Symfony\Component\Validator\Constraints\Collection.

            'code' => new Assert\Required([
                new Assert\NotBlank(),
                new Code()
            ]),
            'country' => new Assert\Required([
                new Assert\NotBlank(),
            ]),
        ]);
    }

    /**
     * HTTP method to use
     * @return string
     */
    public function getMethod()
    {
        return QueryInterface::POST;
    }
}