AbstractSmartIdQuery::getValidationConstraints() - Code Metrics - Inspection of "Allow referencing Code and Phone constraints in An..." - dokobit/ws-api-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — develop (#12)

unknown

created 2018-03-19 12:18 UTC

AbstractSmartIdQuery::getValidationConstraints() A

↳ Parent: AbstractSmartIdQuery

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	12
Ratio	100 %

Importance

Changes

Metric	Value
dl	12
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0

<?php
namespace Isign\Login;

use Isign\QueryInterface;
use Isign\Validator\Constraints\Code;
use Isign\Validator\Constraints\Phone;
use Symfony\Component\Validator\Constraints as Assert;

/**
 * Absctract smartId query.
 */
abstract class AbstractSmartIdQuery implements QueryInterface
{
    /** @var string user personal code */
    private $code;

    /** @var string Country related to personal code. Example EE */
    private $country;

    /**
     * @param string $code
     * @param string $country
     * @return self

     */
    public function __construct(
        $code,
        $country
    ) {
        $this->code = $code;
        $this->country = $country;
    }

    /**
     * Field and values association used in query
     * @return array
     */
    public function getFields()
    {
        $return = [
            'code' => $this->code,
            'country' => $this->country,
        ];

        return $return;
    }

    /**
     * Validation constraints for request data validation
     * @return Assert\Collection
     */
    public function getValidationConstraints()

    {
        return new Assert\Collection([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'code' => new Assert\Required([
                new Assert\NotBlank(),
                new Code()
            ]),
            'country' => new Assert\Required([
                new Assert\NotBlank(),
            ]),
        ]);
    }

    /**
     * HTTP method to use
     * @return string
     */
    public function getMethod()
    {
        return QueryInterface::POST;
    }
}


1		<?php
2		namespace Isign\Login;
3
4		use Isign\QueryInterface;
5		use Isign\Validator\Constraints\Code;
6		use Isign\Validator\Constraints\Phone;
7		use Symfony\Component\Validator\Constraints as Assert;
8
9		/**
10		* Absctract smartId query.
11		*/
12		abstract class AbstractSmartIdQuery implements QueryInterface
13		{
14		/** @var string user personal code */
15		private $code;
16
17		/** @var string Country related to personal code. Example EE */
18		private $country;
19
20		/**
21		* @param string $code
22		* @param string $country
23		* @return self
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-04-13 13:50 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
24		*/
25		public function __construct(
26		$code,
27		$country
28		) {
29		$this->code = $code;
30		$this->country = $country;
31		}
32
33		/**
34		* Field and values association used in query
35		* @return array
36		*/
37		public function getFields()
38		{
39		$return = [
40		'code' => $this->code,
41		'country' => $this->country,
42		];
43
44		return $return;
45		}
46
47		/**
48		* Validation constraints for request data validation
49		* @return Assert\Collection
50		*/
51	View Code Duplication	public function getValidationConstraints()
		0 ignored issues – show Duplication introduced 2018-03-12 15:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		{
53		return new Assert\Collection([
		0 ignored issues – show Bug Best Practice introduced 2017-04-13 14:06 UTC by Report Bug Copy Issue Report The return type of `return new \Symfony\Comp...traints\NotBlank()))));` (`Symfony\Component\Validator\Constraints\Collection`) is incompatible with the return type declared by the interface `Isign\QueryInterface::getValidationConstraints` of type `Isign\Symfony\Component\...\Constraints\Collection`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
54		'code' => new Assert\Required([
55		new Assert\NotBlank(),
56		new Code()
57		]),
58		'country' => new Assert\Required([
59		new Assert\NotBlank(),
60		]),
61		]);
62		}
63
64		/**
65		* HTTP method to use
66		* @return string
67		*/
68		public function getMethod()
69		{
70		return QueryInterface::POST;
71		}
72		}
73

dokobit / ws-api-sdk-php

Pull Request — develop (#12)

AbstractSmartIdQuery::getValidationConstraints() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like