Dokobit\Gateway\Tests\Validator\Constraints\PhoneValidatorTest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	93
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getInvalidPhones()	0	15	1
A	testInvalidPhones()	0	12	2
A	getApiVersion()	0	3	1
A	testEmptyStringIsValid()	0	5	1
A	testValidPhones()	0	5	1
A	createValidator()	0	3	1
A	testExpectsStringCompatibleType()	0	4	1
A	getValidPhones()	0	16	1
A	testNullIsValid()	0	5	1

<?php

namespace Dokobit\Gateway\Tests\Validator\Constraints;

use Dokobit\Gateway\Validator\Constraints\Phone;
use Dokobit\Gateway\Validator\Constraints\PhoneValidator;
use Symfony\Component\Validator\Test\ConstraintValidatorTestCase;
use Symfony\Component\Validator\Validation;

class PhoneValidatorTest extends ConstraintValidatorTestCase
{
    protected function getApiVersion()
    {
        return Validation::API_VERSION_2_5;

The constant Symfony\Component\Validator\Validation::API_VERSION_2_5 was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    protected function createValidator()
    {
        return new PhoneValidator(false);

The call to Dokobit\Gateway\Validator\Constraints\PhoneValidator::__construct() has too many arguments starting with false.

    }

    public function testNullIsValid()
    {
        $this->validator->validate(null, new Phone());

        $this->assertNoViolation();
    }

    public function testEmptyStringIsValid()
    {
        $this->validator->validate('', new Phone());

        $this->assertNoViolation();
    }

    public function testExpectsStringCompatibleType()
    {
        $this->expectException(\Symfony\Component\Validator\Exception\UnexpectedTypeException::class);
        $this->validator->validate(new \stdClass(), new Phone());
    }

    /**
     * @dataProvider getValidPhones
     */
    public function testValidPhones($phone)
    {
        $this->validator->validate($phone, new Phone());

        $this->assertNoViolation();
    }

    public function getValidPhones()
    {
        return array(
            // Lithuania
            array('+37060000000'),
            // Estonia
            array('+3720000000'),
            array('+37200000000'),
            // // Finland
            array('+358409999'),
            array('+3584099999'),
            array('+35840999999'),
            array('+358409999999'),
            array('+3584099999999'),
            array('+3584579999'),
            array('+358509999'),
        );
    }

    /**
     * @dataProvider getInvalidPhones
     */
    public function testInvalidPhones($phone)
    {
        $constraint = new Phone(array(
            'message' => 'myMessage',
        ));

        $this->validator->validate($phone, $constraint);

        $this->buildViolation('myMessage')
            ->setParameter('{{ value }}', '"'.$phone.'"')
            ->setCode(defined('Dokobit\Gateway\Validator\Constraints\Phone::REGEX_FAILED_ERROR')?Phone::REGEX_FAILED_ERROR:null)

It seems like defined('Dokobit\Gateway\Validator\Constraints\Phone::REGEX_FAILED_ERROR') ? Dokobit\Gateway\Validator\Constraints\Phone::REGEX_FAILED_ERROR : null can also be of type null; however, parameter $code of Symfony\Component\Validator\Test\ConstraintViolationAssertion::setCode() does only seem to accept string, maybe add an additional type check?

            ->assertRaised();
    }

    public function getInvalidPhones()
    {
        return array(
            array('1'), // too short
            array('personal_cde'), // random crap
            array('+00000000000'), // invalid
            // Lithuania
            array('+37000000000'), // invalid
            array('+3706000000000'), // invalid
            // Estonia
            array('+372000000'),
            array('+372000000000'),
            // // Finland
            array('+35840999'),
            array('+35840999999999'),
        );
    }
}