CampaignPublished - Code Metrics - Inspection of "Crud básico e ajustes no setup do docker implement..." - doesangueorg/doesangue-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( aa3faf...1831fb )

by José

created 2016-12-21 18:42 UTC

CampaignPublished A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	3
dl	0
loc	31
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	build()	0	10	1

<?php

namespace DoeSangue\Mail;

use DoeSangue\Models\Campaign;
use Illuminate\Bus\Queueable;
use Illuminate\Mail\Mailable;
use Illuminate\Queue\SerializesModels;
use Illuminate\Contracts\Queue\ShouldQueue;

class CampaignPublished extends Mailable
{
    use Queueable, SerializesModels;

    protected $campaign;
    /**
     * Create a new message instance.
     *
     * @return void

     */
    public function __construct(Campaign $campaign)
    {
        $this->campaign = $campaign;
    }

    /**
     * Build the message.
     *
     * @return $this
     */
    public function build()
    {
        return $this->view('email.campaign-published')
            ->with(
                [
                        'title' => $this->campaign->title,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        'expires' => $this->campaign->expires,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        ]
            );
    }
}


1			<?php
2
3			namespace DoeSangue\Mail;
4
5			use DoeSangue\Models\Campaign;
6			use Illuminate\Bus\Queueable;
7			use Illuminate\Mail\Mailable;
8			use Illuminate\Queue\SerializesModels;
9			use Illuminate\Contracts\Queue\ShouldQueue;
10
11			class CampaignPublished extends Mailable
12			{
13			use Queueable, SerializesModels;
14
15			protected $campaign;
16			/**
17			* Create a new message instance.
18			*
19			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-12-21 18:47 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
20			*/
21			public function __construct(Campaign $campaign)
22			{
23			$this->campaign = $campaign;
24			}
25
26			/**
27			* Build the message.
28			*
29			* @return $this
30			*/
31			public function build()
32			{
33			return $this->view('email.campaign-published')
34			->with(
35			[
36			'title' => $this->campaign->title,
			0 ignored issues – show Documentation introduced 2016-12-21 18:47 UTC by Report Bug Copy Issue Report The property `title` does not exist on `object<DoeSangue\Models\Campaign>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
37			'expires' => $this->campaign->expires,
			0 ignored issues – show Documentation introduced 2016-12-21 18:47 UTC by Report Bug Copy Issue Report The property `expires` does not exist on `object<DoeSangue\Models\Campaign>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38			]
39			);
40			}
41			}
42

doesangueorg / doesangue-core

Scrutinizer GitHub App not installed

Push — development ( aa3faf...1831fb )

CampaignPublished A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like