DonorController - Code Metrics - Inspection of "Corrigindo erro de sintaxe no controller DonorCont..." - doesangueorg/doesangue-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( 0f1776...2ed88e )

by José

created 2016-12-03 13:25 UTC

DonorController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	7
c	2
b	0
f	0
lcom	0
cbo	3
dl	0
loc	105
rs	10

7 Methods

Rating	Name	Size	Complexity
A	index()	6	1
A	create()	4	1
A	store()	17	1
A	show()	6	1
A	edit()	4	1
A	update()	10	1
A	destroy()	3	1

<?php

namespace DoeSangue\Http\Controllers;

use DoeSangue\Models\Donor;
use Illuminate\Http\Request;

class DonorController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $donors = Donor::orderBy('id', 'desc')->get();

        return view('donors.index', compact('donors'));
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('donors.create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $this->validate(
            $request,
            [
            'user_id' => 'required',
            'blood_type_id' => 'required',
            ]
        );

        $donor = new Donor();
        $donor->user_id = $request['user_id'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $donor->blood_type_id = $request['blood_type_id'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $donor->save();

        return redirect()->route('user.profile');
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $donor = Donor::find($id);

        return view('donors.Show', compact('donor'));
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

    {
        return view('donors.edit');
    }

    /**
     * Update the specified resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param int                      $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $this->validate(
            $request,
            [
              ''
            ]
        );
        $donor = Donor::find($id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

    {
    }
}


1			<?php
2
3			namespace DoeSangue\Http\Controllers;
4
5			use DoeSangue\Models\Donor;
6			use Illuminate\Http\Request;
7
8			class DonorController extends Controller
9			{
10			/**
11			* Display a listing of the resource.
12			*
13			* @return \Illuminate\Http\Response
14			*/
15			public function index()
16			{
17			$donors = Donor::orderBy('id', 'desc')->get();
18
19			return view('donors.index', compact('donors'));
20			}
21
22			/**
23			* Show the form for creating a new resource.
24			*
25			* @return \Illuminate\Http\Response
26			*/
27			public function create()
28			{
29			return view('donors.create');
30			}
31
32			/**
33			* Store a newly created resource in storage.
34			*
35			* @param \Illuminate\Http\Request $request
36			*
37			* @return \Illuminate\Http\Response
38			*/
39			public function store(Request $request)
40			{
41			$this->validate(
42			$request,
43			[
44			'user_id' => 'required',
45			'blood_type_id' => 'required',
46			]
47			);
48
49			$donor = new Donor();
50			$donor->user_id = $request['user_id'];
			0 ignored issues – show Documentation introduced 2016-12-03 13:28 UTC by Report Bug Copy Issue Report The property `user_id` does not exist on `object<DoeSangue\Models\Donor>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51			$donor->blood_type_id = $request['blood_type_id'];
			0 ignored issues – show Documentation introduced 2016-12-03 13:28 UTC by Report Bug Copy Issue Report The property `blood_type_id` does not exist on `object<DoeSangue\Models\Donor>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
52			$donor->save();
53
54			return redirect()->route('user.profile');
55			}
56
57			/**
58			* Display the specified resource.
59			*
60			* @param int $id
61			*
62			* @return \Illuminate\Http\Response
63			*/
64			public function show($id)
65			{
66			$donor = Donor::find($id);
67
68			return view('donors.Show', compact('donor'));
69			}
70
71			/**
72			* Show the form for editing the specified resource.
73			*
74			* @param int $id
75			*
76			* @return \Illuminate\Http\Response
77			*/
78			public function edit($id)
			0 ignored issues – show Unused Code introduced 2016-11-25 06:57 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
79			{
80			return view('donors.edit');
81			}
82
83			/**
84			* Update the specified resource in storage.
85			*
86			* @param \Illuminate\Http\Request $request
87			* @param int $id
88			*
89			* @return \Illuminate\Http\Response
90			*/
91			public function update(Request $request, $id)
92			{
93			$this->validate(
94			$request,
95			[
96			''
97			]
98			);
99			$donor = Donor::find($id);
			0 ignored issues – show Unused Code introduced 2016-12-03 13:28 UTC by Report Bug Copy Issue Report `$donor` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
100			}
101
102			/**
103			* Remove the specified resource from storage.
104			*
105			* @param int $id
106			*
107			* @return \Illuminate\Http\Response
108			*/
109			public function destroy($id)
			0 ignored issues – show Unused Code introduced 2016-11-25 06:57 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
110			{
111			}
112			}
113

doesangueorg / doesangue-core

Scrutinizer GitHub App not installed

Push — development ( 0f1776...2ed88e )

DonorController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like