CampaignController::show() - Code Metrics - Inspection of ":muscle: fix #47: Add campaign API resources" - doesangueorg/doesangue-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — development (65354c)

by José

created 2017-11-05 06:38 UTC

CampaignController::show() A

↳ Parent: CampaignController

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	6
ccs	0
cts	2
cp	0
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

namespace DoeSangue\Http\Controllers\API\V1;

use DoeSangue\Http\Controllers\Controller;
use DoeSangue\Models\Campaign;
use DoeSangue\Http\Resources\Campaign as CampaignResource;
use DoeSangue\Http\Resources\CampaignCollection;


class CampaignController extends Controller
{
    /**
     * Initialize the class
     * and set the middleware
     */
    public function __construct()
    {
        $this->middleware('jwt.auth', [ 'except' => [ 'index', 'show' ] ]);
    }

    /**
     * Get all campaigns
     * 20 queries per page
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function index()
    {
        return new CampaignCollection(Campaign::paginate(30));
    }

    /**
     * Get all details of a campaign
     *
     * @param  integer $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\JsonResponse
     */
    public function show($campaign)
    {

       return new CampaignResource(Campaign::find($campaign));

    }

}


1		<?php
2
3		namespace DoeSangue\Http\Controllers\API\V1;
4
5		use DoeSangue\Http\Controllers\Controller;
6		use DoeSangue\Models\Campaign;
7		use DoeSangue\Http\Resources\Campaign as CampaignResource;
8		use DoeSangue\Http\Resources\CampaignCollection;
9
10
11		class CampaignController extends Controller
12		{
13		/**
14		* Initialize the class
15		* and set the middleware
16		*/
17	1	public function __construct()
18		{
19	1	$this->middleware('jwt.auth', [ 'except' => [ 'index', 'show' ] ]);
20	1	}
21
22		/**
23		* Get all campaigns
24		* 20 queries per page
25		*
26		* @return \Illuminate\Http\JsonResponse
27		*/
28	1	public function index()
29		{
30	1	return new CampaignCollection(Campaign::paginate(30));
31		}
32
33		/**
34		* Get all details of a campaign
35		*
36		* @param integer $id
		0 ignored issues – show Bug introduced 2017-11-04 22:42 UTC by Report Bug Copy Issue Report There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
37		* @return \Illuminate\Http\JsonResponse
38		*/
39		public function show($campaign)
40		{
41
42		return new CampaignResource(Campaign::find($campaign));
43
44		}
45
46		}
47

doesangueorg / doesangue-core

Scrutinizer GitHub App not installed

Branch — development (65354c)

CampaignController::show() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like