PasswordResetController::recover() - Code Metrics - Inspection of "Laravel 58" - doesangueorg/doesangue-core - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — development (#68)

by José

created 2019-03-08 14:39 UTC

PasswordResetController::recover() A

↳ Parent: PasswordResetController

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	27
rs	9.488
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

namespace GiveBlood\Units\Authentication\Http\Controllers\Auth;

use Illuminate\Http\Request;
use GiveBlood\Support\Http\Controllers\Controller;
use GiveBlood\Modules\Users\User;
use Illuminate\Support\Facades\Password;

class PasswordResetController extends Controller
{
    /**
     * Password recover
     *
     * @param  Request $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function recover(Request $request)
    {
        $user = User::where('email', $request->email)->first();
        if (!$user) {
            $error_message = "Your email address was not found.";
            return response()->json([ 'success' => false, 'error' => [ 'email' => $error_message ] ], 401);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        try {
            Password::sendResetLink(
                $request->only('email'), function (Message $message) {

                    $message->subject('Your Password Reset Link');
                }
            );
        } catch (Exception $e) {

            // Return with error
            $error_message = $e->getMessage();
            return response()->json([ 'success' => false, 'error' => $error_message ], 401);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        return response()->json(
            [
            'success' => true,
            'data' => [ 'message' => 'A reset email has been sent! Please check your email.' ]
            ]
        );
    }
}


Scrutinizer GitHub App not installed

Pull Request — development (#68)

PasswordResetController::recover() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace GiveBlood\Units\Authentication\Http\Controllers\Auth;
4
5			use Illuminate\Http\Request;
6			use GiveBlood\Support\Http\Controllers\Controller;
7			use GiveBlood\Modules\Users\User;
8			use Illuminate\Support\Facades\Password;
9
10			class PasswordResetController extends Controller
11			{
12			/**
13			* Password recover
14			*
15			* @param Request $request
16			* @return \Illuminate\Http\JsonResponse
17			*/
18			public function recover(Request $request)
19			{
20			$user = User::where('email', $request->email)->first();
21			if (!$user) {
22			$error_message = "Your email address was not found.";
23			return response()->json([ 'success' => false, 'error' => [ 'email' => $error_message ] ], 401);
			0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
24			}
25
26			try {
27			Password::sendResetLink(
28			$request->only('email'), function (Message $message) {
			0 ignored issues – show Unused Code introduced 2019-03-08 14:45 UTC by Report Bug Copy Issue Report The call to `Password::sendResetLink()` has too many arguments starting with `function (\GiveBlood\Uni...assword Reset Link'); }`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
29			$message->subject('Your Password Reset Link');
30			}
31			);
32			} catch (Exception $e) {
			0 ignored issues – show Bug introduced 2019-03-08 14:45 UTC by Report Bug Copy Issue Report The class `GiveBlood\Units\Authenti...trollers\Auth\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
33			// Return with error
34			$error_message = $e->getMessage();
35			return response()->json([ 'success' => false, 'error' => $error_message ], 401);
			0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
36			}
37
38			return response()->json(
39			[
40			'success' => true,
41			'data' => [ 'message' => 'A reset email has been sent! Please check your email.' ]
42			]
43			);
44			}
45			}
46

doesangueorg / doesangue-core

Scrutinizer GitHub App not installed

Pull Request — development (#68)

PasswordResetController::recover() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like