CommentsController::destroy() - Code Metrics - Inspection of "Laravel 58" - doesangueorg/doesangue-core - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — development (#68)

by José

created 2019-03-08 14:39 UTC

CommentsController::destroy() A

↳ Parent: CommentsController

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	34
Ratio	100 %

Importance

Changes

Metric	Value
dl	34
loc	34
rs	9.376
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

namespace GiveBlood\Support\Http\Controllers;

use Illuminate\Http\Request;
use GiveBlood\Support\Http\Controllers\Controller;
use GiveBlood\Modules\Campaign\Comment;
use GiveBlood\Modules\Campaign\Campaign;
use Tymon\JWTAuth\Facades\JWTAuth;
use Carbon\Carbon;

class CommentsController extends Controller
{
    public function __construct()
    {
        $this->middleware('jwt.auth', [ 'except' => [ 'index', 'show' ] ]);
    }

    public function index($campaign)
    {
        $comments = Comment::where('campaign_id', $campaign)->get();

        return response()->json($comments, 200);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function create(Request $request, $campaign)
    {

        $user = JWTAuth::parseToken()->authenticate();

        //$campaign = Campaign::find($id);
        $camp = Campaign::find($campaign);
        $comment = new Comment();
        $comment->id = str_random();

        $comment->comment = $request[ 'comment' ];
        $comment->user_id = $user->id;
        $comment->campaign_id = $camp->id;
        // $comment->created_at = Carbon::now();
        $comment->save();

        //  return response()->json($comment);
        return response()->json(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            [
            'status_code' => 201,
            'message' => 'Comment added!'
            ], 201
        );

    }

    public function update($id, Request $request)
    {
        $comment = Comment::find($id);

        $user = JWTAuth::parseToken()->authenticate();

        if ($user->id !== $comment->user_id) {
            return response()->json(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                [
                  'status_code' => 401,
                  'message' => 'You haven\'t permission to update this entry'
                ], 401
            );
        }

        $comment->comment = $request[ 'comment' ];

        if (!$comment) {
            return response()->json(
                [
                    'error_code' => 404,
                    'error_message' => 'Comment not found!'
                ], 404
            );
        }

        $comment->save();

        return response()->json(
            [
            'status_code' => 200,
            'message' => 'Comment updated!'
            ], 200
        );
    }

    public function destroy($id)
    {
        $comment = Comment::find($id);

        $user = JWTAuth::parseToken()->authenticate();

        if ($user->id !== $comment->user_id) {
            return response()->json(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                [
                  'status_code' => 401,
                  'message' => 'You haven\'t permission to update this entry'
                ], 401
            );
        }

          // Notify error in not found
        if (!$comment) {
            return response()->json(
                [
                  'error_code' => 404,
                  'message' => 'Comment not found!'
                ], 404
            );
        }

        $Comment->delete();


        return response()->json(
            [
              'status_code' => 204,
              'message' => 'Comment deleted'
            ], 204
        );
    }
}


1		<?php
2
3		namespace GiveBlood\Support\Http\Controllers;
4
5		use Illuminate\Http\Request;
6		use GiveBlood\Support\Http\Controllers\Controller;
7		use GiveBlood\Modules\Campaign\Comment;
8		use GiveBlood\Modules\Campaign\Campaign;
9		use Tymon\JWTAuth\Facades\JWTAuth;
10		use Carbon\Carbon;
11
12		class CommentsController extends Controller
13		{
14		public function __construct()
15		{
16		$this->middleware('jwt.auth', [ 'except' => [ 'index', 'show' ] ]);
17		}
18
19		public function index($campaign)
20		{
21		$comments = Comment::where('campaign_id', $campaign)->get();
22
23		return response()->json($comments, 200);
		0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
24		}
25
26		public function create(Request $request, $campaign)
27		{
28
29		$user = JWTAuth::parseToken()->authenticate();
30
31		//$campaign = Campaign::find($id);
32		$camp = Campaign::find($campaign);
33		$comment = new Comment();
34		$comment->id = str_random();
		0 ignored issues – show Deprecated Code introduced 2019-03-08 14:45 UTC by Report Bug Copy Issue Report The function `str_random()` has been deprecated with message: Str::random() should be used directly instead. Will be removed in Laravel 5.9. This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
35		$comment->comment = $request[ 'comment' ];
36		$comment->user_id = $user->id;
37		$comment->campaign_id = $camp->id;
38		// $comment->created_at = Carbon::now();
39		$comment->save();
40
41		// return response()->json($comment);
42		return response()->json(
		0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
43		[
44		'status_code' => 201,
45		'message' => 'Comment added!'
46		], 201
47		);
48
49		}
50
51	View Code Duplication	public function update($id, Request $request)
52		{
53		$comment = Comment::find($id);
54
55		$user = JWTAuth::parseToken()->authenticate();
56
57		if ($user->id !== $comment->user_id) {
58		return response()->json(
		0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
59		[
60		'status_code' => 401,
61		'message' => 'You haven\'t permission to update this entry'
62		], 401
63		);
64		}
65
66		$comment->comment = $request[ 'comment' ];
67
68		if (!$comment) {
69		return response()->json(
70		[
71		'error_code' => 404,
72		'error_message' => 'Comment not found!'
73		], 404
74		);
75		}
76
77		$comment->save();
78
79		return response()->json(
80		[
81		'status_code' => 200,
82		'message' => 'Comment updated!'
83		], 200
84		);
85		}
86
87	View Code Duplication	public function destroy($id)
88		{
89		$comment = Comment::find($id);
90
91		$user = JWTAuth::parseToken()->authenticate();
92
93		if ($user->id !== $comment->user_id) {
94		return response()->json(
		0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
95		[
96		'status_code' => 401,
97		'message' => 'You haven\'t permission to update this entry'
98		], 401
99		);
100		}
101
102		// Notify error in not found
103		if (!$comment) {
104		return response()->json(
105		[
106		'error_code' => 404,
107		'message' => 'Comment not found!'
108		], 404
109		);
110		}
111
112		$Comment->delete();
		0 ignored issues – show Bug introduced 2017-07-28 22:20 UTC by Report Bug Copy Issue Report The variable `$Comment` does not exist. Did you mean `$comment`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
113
114		return response()->json(
115		[
116		'status_code' => 204,
117		'message' => 'Comment deleted'
118		], 204
119		);
120		}
121		}
122

doesangueorg / doesangue-core

Scrutinizer GitHub App not installed

Pull Request — development (#68)

CommentsController::destroy() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like