AuthenticateController::userInfo() - Code Metrics - Inspection of "Scrutinizer Auto-Fixes" - doesangueorg/doesangue-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — development (#39)

by José

created 2017-09-27 21:42 UTC

AuthenticateController::userInfo() A

↳ Parent: AuthenticateController

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	9

Duplication

Lines	18
Ratio	100 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	18
loc	18
rs	9.4285
cc	2
eloc	9
nc	2
nop	0

<?php

namespace DoeSangue\Http\Controllers\Auth;

use JWTAuth;
use Tymon\JWTAuth\Exceptions\JWTException;
use DoeSangue\Http\Controllers\Controller;
use Illuminate\Http\Request;
use DoeSangue\Http\Requests\RegisterUserRequest;
use DoeSangue\Mail\UserCreated;
use Illuminate\Support\Facades\Mail;
use DoeSangue\Models\User;
use DoeSangue\Models\Donor;

class AuthenticateController extends Controller
{
      /**
       * Authenticate the user
       *
       * @param Request $request
       * @return void
      */
    public function authenticate(Request $request)
    {
        // grab credentials from the request
        $credentials = $request->only('email', 'password');

        try {
            // attempt to verify the credentials and create a token for the user
            if (!$token = JWTAuth::attempt($credentials)) {
                return response()->json([ 'error' => 'invalid_credentials' ], 401);
            }
        } catch (JWTException $e) {
            // something went wrong whilst attempting to encode the token
            return response()->json([ 'error' => 'could_not_create_token' ], 500);
        }

        // all good so return the token
        return response()->json(
            [
              'access_token' => $token,
              'token_type' => 'Bearer'
            ], 200
        );
    }

    // Register a new user
    public function register(RegisterUserRequest $request)
    {
        $user = User::create(

            [
            'first_name' => $request->first_name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'last_name' => $request->last_name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'email' => $request->email,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            // create the username based on first_name and last_name
            // if not provided
            /*$userName = trim(strtolower($request->first_name.'-'.$request->last_name)),

            'username' => $userName,*/
            'username' => $request->username,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'phone' => $request->phone,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'bio' => $request->bio,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'birthdate' => $request->birthdate,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'password' => bcrypt($request->password),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ]
        );

        if ($user) {
            $donor = new Donor();
            $donor->user_id = $user->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $donor->blood_type_id = null;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $donor->save();
        }

        // Send mail to user
        Mail::to($user->email)->send(new UserCreated($user));



        $token = JWTAuth::attempt($request->only('email', 'password'));

        // all good so return the token
        return response()->json(
            [
            'access_token' => $token,
            'token_type' => 'Bearer'
            ], 201
        );
    }

    /**
     * Invalidate and log out the user
     *
     * @return void
     *
     */
    public function logout()
    {
        //
    }
    /**
     * Get the current user (logged in) information
     *
     * @return void
     */
    public function userInfo()

    {
        $user = JWTAuth::parseToken()->authenticate();

        // If the token is invalid
        if (!$user) {
            return response()->json([ 'invalid_user' ], 401);
        }

        return response()->json(
            [
              'first_name' => $user->first_name,
              'last_name' => $user->last_name,
            //   'email' => $user->email,

              'username' => $user->username
            ], 200
        );
    }
}


1		<?php
2
3		namespace DoeSangue\Http\Controllers\Auth;
4
5		use JWTAuth;
6		use Tymon\JWTAuth\Exceptions\JWTException;
7		use DoeSangue\Http\Controllers\Controller;
8		use Illuminate\Http\Request;
9		use DoeSangue\Http\Requests\RegisterUserRequest;
10		use DoeSangue\Mail\UserCreated;
11		use Illuminate\Support\Facades\Mail;
12		use DoeSangue\Models\User;
13		use DoeSangue\Models\Donor;
14
15		class AuthenticateController extends Controller
16		{
17		/**
18		* Authenticate the user
19		*
20		* @param Request $request
21		* @return void
22		*/
23		public function authenticate(Request $request)
24		{
25		// grab credentials from the request
26		$credentials = $request->only('email', 'password');
27
28		try {
29		// attempt to verify the credentials and create a token for the user
30		if (!$token = JWTAuth::attempt($credentials)) {
31		return response()->json([ 'error' => 'invalid_credentials' ], 401);
32		}
33		} catch (JWTException $e) {
34		// something went wrong whilst attempting to encode the token
35		return response()->json([ 'error' => 'could_not_create_token' ], 500);
36		}
37
38		// all good so return the token
39		return response()->json(
40		[
41		'access_token' => $token,
42		'token_type' => 'Bearer'
43		], 200
44		);
45		}
46
47		// Register a new user
48		public function register(RegisterUserRequest $request)
49		{
50		$user = User::create(
		0 ignored issues – show Bug introduced 2017-07-28 22:20 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `DoeSangue\Models\User`. Did you maybe mean `created()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
51		[
52		'first_name' => $request->first_name,
		0 ignored issues – show Documentation introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report The property `first_name` does not exist on `object<DoeSangue\Http\Re...ts\RegisterUserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
53		'last_name' => $request->last_name,
		0 ignored issues – show Documentation introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report The property `last_name` does not exist on `object<DoeSangue\Http\Re...ts\RegisterUserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
54		'email' => $request->email,
		0 ignored issues – show Documentation introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report The property `email` does not exist on `object<DoeSangue\Http\Re...ts\RegisterUserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
55		// create the username based on first_name and last_name
56		// if not provided
57		/*$userName = trim(strtolower($request->first_name.'-'.$request->last_name)),
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58		'username' => $userName,*/
59		'username' => $request->username,
		0 ignored issues – show Documentation introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report The property `username` does not exist on `object<DoeSangue\Http\Re...ts\RegisterUserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
60		'phone' => $request->phone,
		0 ignored issues – show Documentation introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report The property `phone` does not exist on `object<DoeSangue\Http\Re...ts\RegisterUserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
61		'bio' => $request->bio,
		0 ignored issues – show Documentation introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report The property `bio` does not exist on `object<DoeSangue\Http\Re...ts\RegisterUserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
62		'birthdate' => $request->birthdate,
		0 ignored issues – show Documentation introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report The property `birthdate` does not exist on `object<DoeSangue\Http\Re...ts\RegisterUserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
63		'password' => bcrypt($request->password),
		0 ignored issues – show Documentation introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report The property `password` does not exist on `object<DoeSangue\Http\Re...ts\RegisterUserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
64		]
65		);
66
67		if ($user) {
68		$donor = new Donor();
69		$donor->user_id = $user->id;
		0 ignored issues – show Documentation introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report The property `user_id` does not exist on `object<DoeSangue\Models\Donor>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
70		$donor->blood_type_id = null;
		0 ignored issues – show Documentation introduced 2017-05-28 13:37 UTC by Report Bug Copy Issue Report The property `blood_type_id` does not exist on `object<DoeSangue\Models\Donor>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
71		$donor->save();
72		}
73
74		// Send mail to user
75		Mail::to($user->email)->send(new UserCreated($user));
76
77
78
79		$token = JWTAuth::attempt($request->only('email', 'password'));
80
81		// all good so return the token
82		return response()->json(
83		[
84		'access_token' => $token,
85		'token_type' => 'Bearer'
86		], 201
87		);
88		}
89
90		/**
91		* Invalidate and log out the user
92		*
93		* @return void
94		*
95		*/
96		public function logout()
97		{
98		//
99		}
100		/**
101		* Get the current user (logged in) information
102		*
103		* @return void
104		*/
105	View Code Duplication	public function userInfo()
		0 ignored issues – show Duplication introduced 2017-09-27 21:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		{
107		$user = JWTAuth::parseToken()->authenticate();
108
109		// If the token is invalid
110		if (!$user) {
111		return response()->json([ 'invalid_user' ], 401);
112		}
113
114		return response()->json(
115		[
116		'first_name' => $user->first_name,
117		'last_name' => $user->last_name,
118		// 'email' => $user->email,
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-09-27 10:41 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
119		'username' => $user->username
120		], 200
121		);
122		}
123		}
124

doesangueorg / doesangue-core

Scrutinizer GitHub App not installed

Pull Request — development (#39)

AuthenticateController::userInfo() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like