CampaignController::destroy() - Code Metrics - doesangueorg/doesangue-core - Measure and Improve Code Quality continuously with Scrutinizer

CampaignController::destroy() A
last analyzed 2019-03-08 14:47 UTC

↳ Parent: CampaignController

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	32
ccs	0
cts	15
cp	0
rs	9.408
c	0
b	0
f	0
cc	3
nc	3
nop	1
crap	12

<?php

namespace DoeSangue\Http\Controllers\API\V1\User;

use DoeSangue\Http\Controllers\Controller;

use DoeSangue\Models\Campaign;

class CampaignController extends Controller
{

    /**
     * Get all campaigns from current logged-in user.
     *
     * @return \Illuminate\Http\JsonResponse|null
     */
    public function all()
    {

        $user = JWTAuth::parseToken()->authenticate();

          // If the token is invalid
        if (!$user) {
            return response()->json([ 'invalid_user' ], 401);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        $campaigns = $user->campaigns()->get();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    /**
     * Create a new campaign
     *
     * @param  CreateCampaignRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(CreateCampaignRequest $request)
    {

        $user = JWTAuth::parseToken()->authenticate();

        $campaign = new Campaign();
        $campaign->title = $request[ 'title' ];
        $campaign->description = $request[ 'description' ];
        $campaign->expires = $request[ 'expires' ];
        //        $campaign->user_id = $request[ 'user_id' ];
        // use auth guard instead of $request['user_id'].
        $campaign->user_id = $user->id;
        $campaign->created_at = Carbon::now();
        $campaign->save();

        // Send mail to users about the new campaign.
        //       Mail::to($campaign->owner->email)->send(new CampaignPublished($campaign));

        return response()->json(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            [
            'status_code' => 201,
            'message' => 'Campaign added!'
            ], 201
        );

    }

    /**
     * Update details of a campaign
     *
     * @param  UpdateCampaignRequest $request
     * @param  integer               $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function update(UpdateCampaignRequest $request, $id)
    {
        $campaign = Campaign::find($id);

        $user = JWTAuth::parseToken()->authenticate();

        if ($user->id !== $campaign->user_id) {
            return response()->json(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                [
                'message' => 'You haven\'t permission to update this entry'
                ], 401
            );
        }

        $campaign->title = $request[ 'title' ];
        $campaign->expires = $request[ 'expires' ];
        $campaign->description = $request[ 'description' ];
        $campaign->updated_at = Carbon::now();

        // Notify error in not found
        if (!$campaign) {
            return response()->json(
                [
                  'error_code' => '404',
                  'message' => 'Campaign not found!'
                ], 404
            );
        }

        // If validation pass: update the entry.
        $campaign->save();

        return response()->json(
            [
            'title' => $campaign->title,
            'owner' => [
              'first_name' => $campaign->owner->first_name,
              'last_name' => $campaign->owner->last_name,
              // 'email' => $campaign->owner->email,
              // 'username' => $campaign->owner->username
            ],
            'dates' => [
            'start_at' => $campaign->created_at->format('d-m-Y h:m:s'),
            'finish_at' => $campaign->expires->format('d-m-Y h:m:s')
            ]
            ], 200
        );
    }

    /**
     * Delete the campaign from platform.
     *
     * @param  integer $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy($id)
    {
        $campaign = Campaign::find($id);

        $user = JWTAuth::parseToken()->authenticate();

        if ($user->id !== $campaign->user_id) {
            return response()->json(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                [
                'message' => 'You haven\'t permission to delete this entry'
                ], 401
            );
        }

        // Notify error in not found
        if (!$campaign) {
            return response()->json(
                [
                  'error_code' => 404,
                  'message' => 'Campaign not found!'
                ], 404
            );
        }

        $campaign->delete();

        return response()->json(
            [
            'message' => 'Campaign deleted'
            ], 204
        );
    }

}


1			<?php
2
3			namespace DoeSangue\Http\Controllers\API\V1\User;
4
5			use DoeSangue\Http\Controllers\Controller;
6
7			use DoeSangue\Models\Campaign;
8
9			class CampaignController extends Controller
10			{
11
12			/**
13			* Get all campaigns from current logged-in user.
14			*
15			* @return \Illuminate\Http\JsonResponse\|null
16			*/
17			public function all()
18			{
19
20			$user = JWTAuth::parseToken()->authenticate();
21
22			// If the token is invalid
23			if (!$user) {
24			return response()->json([ 'invalid_user' ], 401);
			0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
25			}
26
27			$campaigns = $user->campaigns()->get();
			0 ignored issues – show Unused Code introduced 2017-10-18 06:57 UTC by Report Bug Copy Issue Report `$campaigns` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
28			}
29
30			/**
31			* Create a new campaign
32			*
33			* @param CreateCampaignRequest $request
34			* @return \Illuminate\Http\JsonResponse
35			*/
36			public function store(CreateCampaignRequest $request)
37			{
38
39			$user = JWTAuth::parseToken()->authenticate();
40
41			$campaign = new Campaign();
42			$campaign->title = $request[ 'title' ];
43			$campaign->description = $request[ 'description' ];
44			$campaign->expires = $request[ 'expires' ];
45			// $campaign->user_id = $request[ 'user_id' ];
46			// use auth guard instead of $request['user_id'].
47			$campaign->user_id = $user->id;
48			$campaign->created_at = Carbon::now();
49			$campaign->save();
50
51			// Send mail to users about the new campaign.
52			// Mail::to($campaign->owner->email)->send(new CampaignPublished($campaign));
53
54			return response()->json(
			0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
55			[
56			'status_code' => 201,
57			'message' => 'Campaign added!'
58			], 201
59			);
60
61			}
62
63			/**
64			* Update details of a campaign
65			*
66			* @param UpdateCampaignRequest $request
67			* @param integer $id
68			* @return \Illuminate\Http\JsonResponse
69			*/
70			public function update(UpdateCampaignRequest $request, $id)
71			{
72			$campaign = Campaign::find($id);
73
74			$user = JWTAuth::parseToken()->authenticate();
75
76			if ($user->id !== $campaign->user_id) {
77			return response()->json(
			0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
78			[
79			'message' => 'You haven\'t permission to update this entry'
80			], 401
81			);
82			}
83
84			$campaign->title = $request[ 'title' ];
85			$campaign->expires = $request[ 'expires' ];
86			$campaign->description = $request[ 'description' ];
87			$campaign->updated_at = Carbon::now();
88
89			// Notify error in not found
90			if (!$campaign) {
91			return response()->json(
92			[
93			'error_code' => '404',
94			'message' => 'Campaign not found!'
95			], 404
96			);
97			}
98
99			// If validation pass: update the entry.
100			$campaign->save();
101
102			return response()->json(
103			[
104			'title' => $campaign->title,
105			'owner' => [
106			'first_name' => $campaign->owner->first_name,
107			'last_name' => $campaign->owner->last_name,
108			// 'email' => $campaign->owner->email,
109			// 'username' => $campaign->owner->username
110			],
111			'dates' => [
112			'start_at' => $campaign->created_at->format('d-m-Y h:m:s'),
113			'finish_at' => $campaign->expires->format('d-m-Y h:m:s')
114			]
115			], 200
116			);
117			}
118
119			/**
120			* Delete the campaign from platform.
121			*
122			* @param integer $id
123			* @return \Illuminate\Http\JsonResponse
124			*/
125			public function destroy($id)
126			{
127			$campaign = Campaign::find($id);
128
129			$user = JWTAuth::parseToken()->authenticate();
130
131			if ($user->id !== $campaign->user_id) {
132			return response()->json(
			0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
133			[
134			'message' => 'You haven\'t permission to delete this entry'
135			], 401
136			);
137			}
138
139			// Notify error in not found
140			if (!$campaign) {
141			return response()->json(
142			[
143			'error_code' => 404,
144			'message' => 'Campaign not found!'
145			], 404
146			);
147			}
148
149			$campaign->delete();
150
151			return response()->json(
152			[
153			'message' => 'Campaign deleted'
154			], 204
155			);
156			}
157
158			}
159

doesangueorg / doesangue-core

Scrutinizer GitHub App not installed

CampaignController::destroy() A last analyzed 2019-03-08 14:47 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

CampaignController::destroy() A
last analyzed 2019-03-08 14:47 UTC