AccountController::userInfo() - Code Metrics - doesangueorg/doesangue-core - Measure and Improve Code Quality continuously with Scrutinizer

AccountController::userInfo() A
last analyzed 2019-03-08 14:47 UTC

↳ Parent: AccountController

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	0
cts	15
cp	0
rs	9.536
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	6

<?php

namespace DoeSangue\Http\Controllers\API\V1\User;

use JWTAuth;
use Illuminate\Http\Request;
use DoeSangue\Http\Controllers\Controller;

class AccountController extends Controller
{
    /**
     * Get Logged in User information.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function userInfo()
    {
        $user = JWTAuth::parseToken()->authenticate();

        // If the token is invalid
        if (!$user) {
            return response()->json([ 'invalid_user' ], 401);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }
        // Return the user data in json.
        return response()->json(
            [
            'first_name' =>   $user->first_name,
            'last_name'  =>   $user->last_name,
            'email'      =>   $user->email,
            'username'   =>   $user->username,
            'blood_type' =>   $user->donor->bloodType->code,
            'avatar'     =>   '', //$user->avatar,
            'birthdate'  =>   $user->birthdate,
            'phone'      =>   $user->phone,
            'bio'        =>   $user->bio
            ], 200
        );

    }

    public function updateProfile(Request $data)

    {
        //
    }
}


Scrutinizer GitHub App not installed

AccountController::userInfo() A
last analyzed 2019-03-08 14:47 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

1			<?php
2
3			namespace DoeSangue\Http\Controllers\API\V1\User;
4
5			use JWTAuth;
6			use Illuminate\Http\Request;
7			use DoeSangue\Http\Controllers\Controller;
8
9			class AccountController extends Controller
10			{
11			/**
12			* Get Logged in User information.
13			*
14			* @return \Illuminate\Http\JsonResponse
15			*/
16			public function userInfo()
17			{
18			$user = JWTAuth::parseToken()->authenticate();
19
20			// If the token is invalid
21			if (!$user) {
22			return response()->json([ 'invalid_user' ], 401);
			0 ignored issues – show Bug introduced 2019-03-03 06:57 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
23			}
24			// Return the user data in json.
25			return response()->json(
26			[
27			'first_name' => $user->first_name,
28			'last_name' => $user->last_name,
29			'email' => $user->email,
30			'username' => $user->username,
31			'blood_type' => $user->donor->bloodType->code,
32			'avatar' => '', //$user->avatar,
33			'birthdate' => $user->birthdate,
34			'phone' => $user->phone,
35			'bio' => $user->bio
36			], 200
37			);
38
39			}
40
41			public function updateProfile(Request $data)
			0 ignored issues – show Unused Code introduced 2017-10-18 06:57 UTC by Report Bug Copy Issue Report The parameter `$data` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
42			{
43			//
44			}
45			}
46

doesangueorg / doesangue-core

Scrutinizer GitHub App not installed

AccountController::userInfo() A last analyzed 2019-03-08 14:47 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

AccountController::userInfo() A
last analyzed 2019-03-08 14:47 UTC