BasicObjectDataRepository::find() - Code Metrics - Inspection of "Modernize" - doctrine/skeleton-mapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#15)

by Jonathan

created 2018-09-18 23:18 UTC

BasicObjectDataRepository::find() A

↳ Parent: BasicObjectDataRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	11
ccs	6
cts	6
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Doctrine\SkeletonMapper\DataRepository;

use Doctrine\SkeletonMapper\ObjectManagerInterface;
use function array_combine;
use function assert;
use function is_array;

abstract class BasicObjectDataRepository extends ObjectDataRepository
{
    /** @var ObjectManagerInterface */
    protected $objectManager;

    /** @var string */
    protected $className;

    public function __construct(ObjectManagerInterface $objectManager, string $className)
    {
        $this->objectManager = $objectManager;
        $this->className     = $className;
    }

    public function getClassName() : string
    {
        return $this->className;
    }

    public function setClassName(string $className) : void
    {
        $this->className = $className;
    }

    /**
     * @param mixed $id
     *
     * @return mixed[]
     */
    public function find($id) : ?array
    {
        $identifier = $this->getIdentifier();

        $identifierValues = is_array($id) ? $id : [$id];

        $criteria = array_combine($identifier, $identifierValues);

        assert($criteria !== false);

        return $this->findOneBy($criteria);
    }

    /**
     * @return mixed[]
     */
    protected function getIdentifier() : array
    {
        return $this->objectManager
            ->getClassMetadata($this->getClassName())
            ->getIdentifier();
    }

    /**
     * @param object $object
     *
     * @return mixed[]
     */
    protected function getObjectIdentifier($object) : array
    {
        return $this->objectManager
            ->getRepository($this->getClassName())
            ->getObjectIdentifier($object);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\SkeletonMapper\DataRepository;
6
7		use Doctrine\SkeletonMapper\ObjectManagerInterface;
8		use function array_combine;
9		use function assert;
10		use function is_array;
11
12		abstract class BasicObjectDataRepository extends ObjectDataRepository
13		{
14		/** @var ObjectManagerInterface */
15		protected $objectManager;
16
17		/** @var string */
18		protected $className;
19
20	27	public function __construct(ObjectManagerInterface $objectManager, string $className)
21		{
22	27	$this->objectManager = $objectManager;
23	27	$this->className = $className;
24	27	}
25
26	20	public function getClassName() : string
27		{
28	20	return $this->className;
29		}
30
31		public function setClassName(string $className) : void
32		{
33		$this->className = $className;
34		}
35
36		/**
37		* @param mixed $id
38		*
39		* @return mixed[]
40		*/
41	19	public function find($id) : ?array
42		{
43	19	$identifier = $this->getIdentifier();
44
45	19	$identifierValues = is_array($id) ? $id : [$id];
46
47	19	$criteria = array_combine($identifier, $identifierValues);
48
49	19	assert($criteria !== false);
50
51	19	return $this->findOneBy($criteria);
52		}
53
54		/**
55		* @return mixed[]
56		*/
57	19	protected function getIdentifier() : array
58		{
59	19	return $this->objectManager
60	19	->getClassMetadata($this->getClassName())
61	19	->getIdentifier();
62		}
63
64		/**
65		* @param object $object
66		*
67		* @return mixed[]
68		*/
69		protected function getObjectIdentifier($object) : array
70		{
71		return $this->objectManager
72		->getRepository($this->getClassName())
73		->getObjectIdentifier($object);
74		}
75		}
76

doctrine / skeleton-mapper

Pull Request — master (#15)

BasicObjectDataRepository::find() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like