Doctrine\SkeletonMapper\Persister\ArrayObjectPersister

Complexity

Total Complexity

9

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	removeObject()	0	6	1
A	persistObject()	0	13	2
A	generateNextId()	0	8	3
A	__construct()	0	8	1
A	updateObject()	0	16	2

<?php

declare(strict_types=1);

namespace Doctrine\SkeletonMapper\Persister;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\SkeletonMapper\Mapping\ClassMetadataInterface;
use Doctrine\SkeletonMapper\ObjectManagerInterface;
use Doctrine\SkeletonMapper\UnitOfWork\ChangeSet;
use function max;

class ArrayObjectPersister extends BasicObjectPersister
{
    /** @var ArrayCollection */
    protected $objects;

    public function __construct(
        ObjectManagerInterface $objectManager,
        ArrayCollection $objects,
        string $className
    ) {
        parent::__construct($objectManager, $className);

        $this->objects = $objects;
    }

    /**
     * @param object $object
     *
     * @return mixed[]
     */
    public function persistObject($object) : array
    {
        $data = $this->preparePersistChangeSet($object);

        $class = $this->getClassMetadata();

        if (! isset($data[$class->getIdentifier()[0]])) {
            $data[$class->getIdentifier()[0]] = $this->generateNextId($class);
        }

        $this->objects[$data[$class->getIdentifier()[0]]] = $data;

        return $data;
    }

    /**
     * @param object $object
     *
     * @return mixed[]
     */
    public function updateObject($object, ChangeSet $changeSet) : array
    {
        $changeSet = $this->prepareUpdateChangeSet($object, $changeSet);

        $class      = $this->getClassMetadata();
        $identifier = $this->getObjectIdentifier($object);

        $objectData = $this->objects[$identifier[$class->getIdentifier()[0]]];

        foreach ($changeSet as $key => $value) {
            $objectData[$key] = $value;
        }

        $this->objects[$objectData[$class->getIdentifier()[0]]] = $objectData;

        return $objectData;

The expression return $objectData could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param object $object
     */
    public function removeObject($object) : void
    {
        $class      = $this->getClassMetadata();
        $identifier = $this->getObjectIdentifier($object);

        unset($this->objects[$identifier[$class->getIdentifier()[0]]]);
    }

    private function generateNextId(ClassMetadataInterface $class) : int
    {
        $ids = [];
        foreach ($this->objects as $objectData) {
            $ids[] = $objectData[$class->getIdentifier()[0]];
        }

        return $ids !== [] ? (int) (max($ids) + 1) : 1;
    }
}