RuntimeReflectionService::__construct() - Code Metrics - Inspection of "Add further check if TypedNoDefaultReflectionPrope..." - doctrine/persistence - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — add_typed_no_default_reflectio... ( d3ea32 )

by Benjamin

created 2020-01-16 08:56 UTC

RuntimeReflectionService::__construct() A

↳ Parent: RuntimeReflectionService

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	2
c	1
b	0
f	0
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
cc	1
nc	1
nop	0
crap	1

<?php

declare(strict_types=1);

namespace Doctrine\Persistence\Mapping;

use Doctrine\Common\Reflection\RuntimePublicReflectionProperty;
use Doctrine\Common\Reflection\TypedNoDefaultReflectionProperty;
use ReflectionClass;
use ReflectionException;
use ReflectionMethod;
use ReflectionProperty;
use function array_key_exists;
use function class_exists;
use function class_parents;

/**
 * PHP Runtime Reflection Service.
 */
class RuntimeReflectionService implements ReflectionService
{
    private $supportsTypedPropertiesWorkaround;


    public function __construct()
    {
        $this->supportsTypedPropertiesWorkaround =
            version_compare(phpversion(), '7.4.0') >= 0;

    }

    /**
     * {@inheritDoc}
     */
    public function getParentClasses(string $class)
    {
        if (! class_exists($class)) {
            throw MappingException::nonExistingClass($class);
        }

        return class_parents($class);
    }

    /**
     * {@inheritDoc}
     */
    public function getClassShortName(string $class)
    {
        $reflectionClass = new ReflectionClass($class);

        return $reflectionClass->getShortName();
    }

    /**
     * {@inheritDoc}
     */
    public function getClassNamespace(string $class)
    {
        $reflectionClass = new ReflectionClass($class);

        return $reflectionClass->getNamespaceName();
    }

    /**
     * {@inheritDoc}
     */
    public function getClass(string $class)
    {
        return new ReflectionClass($class);
    }

    /**
     * {@inheritDoc}
     */
    public function getAccessibleProperty(string $class, string $property)
    {
        $reflectionProperty = new ReflectionProperty($class, $property);

        if ($this->supportsTypedPropertiesWorkaround && ! array_key_exists($property, $this->getClass($class)->getDefaultProperties())) {
            $reflectionProperty = new TypedNoDefaultReflectionProperty($class, $property);
        } elseif ($reflectionProperty->isPublic()) {
            $reflectionProperty = new RuntimePublicReflectionProperty($class, $property);
        }

        $reflectionProperty->setAccessible(true);

        return $reflectionProperty;
    }

    /**
     * {@inheritDoc}
     */
    public function hasPublicMethod(string $class, string $method)
    {
        try {
            $reflectionMethod = new ReflectionMethod($class, $method);
        } catch (ReflectionException $e) {
            return false;
        }

        return $reflectionMethod->isPublic();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\Persistence\Mapping;
6
7		use Doctrine\Common\Reflection\RuntimePublicReflectionProperty;
8		use Doctrine\Common\Reflection\TypedNoDefaultReflectionProperty;
9		use ReflectionClass;
10		use ReflectionException;
11		use ReflectionMethod;
12		use ReflectionProperty;
13		use function array_key_exists;
14		use function class_exists;
15		use function class_parents;
16
17		/**
18		* PHP Runtime Reflection Service.
19		*/
20		class RuntimeReflectionService implements ReflectionService
21		{
22		private $supportsTypedPropertiesWorkaround;
		0 ignored issues – show introduced 2020-01-16 09:01 UTC by Report Bug Copy Issue Report Property \Doctrine\Persistence\Mapping\RuntimeReflectionService::$supportsTypedPropertiesWorkaround does not have @var annotation. Loading history...
23
24	7	public function __construct()
25		{
26	7	$this->supportsTypedPropertiesWorkaround =
27	7	version_compare(phpversion(), '7.4.0') >= 0;
		0 ignored issues – show introduced 2020-01-16 09:01 UTC by Report Bug Copy Issue Report Function version_compare() should not be referenced via a fallback global name, but via a use statement. Loading history... introduced 2020-01-16 09:01 UTC by Report Bug Copy Issue Report Function phpversion() should not be referenced via a fallback global name, but via a use statement. Loading history...
28	7	}
29
30		/**
31		* {@inheritDoc}
32		*/
33	2	public function getParentClasses(string $class)
34		{
35	2	if (! class_exists($class)) {
36	1	throw MappingException::nonExistingClass($class);
37		}
38
39	1	return class_parents($class);
40		}
41
42		/**
43		* {@inheritDoc}
44		*/
45	1	public function getClassShortName(string $class)
46		{
47	1	$reflectionClass = new ReflectionClass($class);
48
49	1	return $reflectionClass->getShortName();
50		}
51
52		/**
53		* {@inheritDoc}
54		*/
55	1	public function getClassNamespace(string $class)
56		{
57	1	$reflectionClass = new ReflectionClass($class);
58
59	1	return $reflectionClass->getNamespaceName();
60		}
61
62		/**
63		* {@inheritDoc}
64		*/
65	1	public function getClass(string $class)
66		{
67	1	return new ReflectionClass($class);
68		}
69
70		/**
71		* {@inheritDoc}
72		*/
73	1	public function getAccessibleProperty(string $class, string $property)
74		{
75	1	$reflectionProperty = new ReflectionProperty($class, $property);
76
77	1	if ($this->supportsTypedPropertiesWorkaround && ! array_key_exists($property, $this->getClass($class)->getDefaultProperties())) {
78		$reflectionProperty = new TypedNoDefaultReflectionProperty($class, $property);
79	1	} elseif ($reflectionProperty->isPublic()) {
80	1	$reflectionProperty = new RuntimePublicReflectionProperty($class, $property);
81		}
82
83	1	$reflectionProperty->setAccessible(true);
84
85	1	return $reflectionProperty;
86		}
87
88		/**
89		* {@inheritDoc}
90		*/
91	1	public function hasPublicMethod(string $class, string $method)
92		{
93		try {
94	1	$reflectionMethod = new ReflectionMethod($class, $method);
95	1	} catch (ReflectionException $e) {
96	1	return false;
97		}
98
99	1	return $reflectionMethod->isPublic();
100		}
101		}
102

doctrine / persistence

Push — add_typed_no_default_reflectio... ( d3ea32 )

RuntimeReflectionService::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like