Power::__construct() - Code Metrics - Inspection of "null values in cached entity fix for 2.6" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 2.6 (#7750)

unknown

created 2019-06-25 11:21 UTC

Power::__construct() A

↳ Parent: Power

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
c	1
b	0
f	0
nop	3
dl	0
loc	5
rs	10
nc	1

<?php
namespace Doctrine\Tests\Models\Issue7735;

use Doctrine\ORM\Mapping\Cache;
use Doctrine\ORM\Mapping\Column;
use Doctrine\ORM\Mapping\Entity;
use Doctrine\ORM\Mapping\GeneratedValue;
use Doctrine\ORM\Mapping\Id;
use Doctrine\ORM\Mapping\JoinColumn;
use Doctrine\ORM\Mapping\OneToOne;
use Doctrine\ORM\Mapping\Table;

/**
 * @Entity
 * @Table(name="power")
 * @Cache(usage="READ_ONLY", region="power")
 */
class Power
{
    /**
     * @Id
     * @Column(type="integer")
     * @GeneratedValue(strategy="IDENTITY")
     */
    private $id;


    /**
     * @var integer
     * @Column(name="horse_power", type="integer", nullable=false)
     */
    protected $horsePower;

    /**
     * @var integer
     * @Column(name="kilowatt", type="integer", nullable=false)
     */
    protected $kilowatt;

    /**
     * @var Engine
     * @OneToOne(targetEntity="Engine")
     * @Cache("READ_ONLY")
     * @JoinColumn(name="engine_id", referencedColumnName="id", onDelete="CASCADE")
     */
    protected $engine;

    /**
     * Power constructor.
     * @param int $horsePower
     * @param int $kilowatt
     * @param Engine $engine
     */
    public function __construct(int $horsePower, int $kilowatt, Engine $engine)
    {
        $this->horsePower = $horsePower;
        $this->kilowatt = $kilowatt;
        $this->engine = $engine;
    }

    /**
     * @return int
     */
    public function getHorsePower(): int
    {
        return $this->horsePower;
    }

    /**
     * @return int
     */
    public function getKilowatt(): int
    {
        return $this->kilowatt;
    }

    /**
     * @return Engine
     */
    public function getEngine(): Engine
    {
        return $this->engine;
    }
}


1			<?php
2			namespace Doctrine\Tests\Models\Issue7735;
3
4			use Doctrine\ORM\Mapping\Cache;
5			use Doctrine\ORM\Mapping\Column;
6			use Doctrine\ORM\Mapping\Entity;
7			use Doctrine\ORM\Mapping\GeneratedValue;
8			use Doctrine\ORM\Mapping\Id;
9			use Doctrine\ORM\Mapping\JoinColumn;
10			use Doctrine\ORM\Mapping\OneToOne;
11			use Doctrine\ORM\Mapping\Table;
12
13			/**
14			* @Entity
15			* @Table(name="power")
16			* @Cache(usage="READ_ONLY", region="power")
17			*/
18			class Power
19			{
20			/**
21			* @Id
22			* @Column(type="integer")
23			* @GeneratedValue(strategy="IDENTITY")
24			*/
25			private $id;
			0 ignored issues – show introduced 2018-12-23 12:49 UTC by Report Bug Copy Issue Report The private property `$id` is not used, and could be removed. Loading history...
26
27			/**
28			* @var integer
29			* @Column(name="horse_power", type="integer", nullable=false)
30			*/
31			protected $horsePower;
32
33			/**
34			* @var integer
35			* @Column(name="kilowatt", type="integer", nullable=false)
36			*/
37			protected $kilowatt;
38
39			/**
40			* @var Engine
41			* @OneToOne(targetEntity="Engine")
42			* @Cache("READ_ONLY")
43			* @JoinColumn(name="engine_id", referencedColumnName="id", onDelete="CASCADE")
44			*/
45			protected $engine;
46
47			/**
48			* Power constructor.
49			* @param int $horsePower
50			* @param int $kilowatt
51			* @param Engine $engine
52			*/
53			public function __construct(int $horsePower, int $kilowatt, Engine $engine)
54			{
55			$this->horsePower = $horsePower;
56			$this->kilowatt = $kilowatt;
57			$this->engine = $engine;
58			}
59
60			/**
61			* @return int
62			*/
63			public function getHorsePower(): int
64			{
65			return $this->horsePower;
66			}
67
68			/**
69			* @return int
70			*/
71			public function getKilowatt(): int
72			{
73			return $this->kilowatt;
74			}
75
76			/**
77			* @return Engine
78			*/
79			public function getEngine(): Engine
80			{
81			return $this->engine;
82			}
83			}
84

doctrine / orm

Pull Request — 2.6 (#7750)

Power::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like