Doctrine\ORM\Utility\HierarchyDiscriminatorResolver

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	resolveDiscriminatorsForClass()	0	19	3

<?php

namespace Doctrine\ORM\Utility;

use Doctrine\Common\Persistence\Mapping\ClassMetadata;
use Doctrine\ORM\EntityManagerInterface;

/**
 * Class HierarchyDiscriminatorResolver
 * @package Doctrine\ORM\Utility
 * @internal This class exists only to avoid code duplication, do not reuse it externally
 */
class HierarchyDiscriminatorResolver
{
    public static function resolveDiscriminatorsForClass(
        ClassMetadata $rootClassMetadata,
        EntityManagerInterface $entityManager
    ) {
        $hierarchyClasses = $rootClassMetadata->subClasses;

Accessing subClasses on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

        $hierarchyClasses[] = $rootClassMetadata->name;

Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

        $discriminators = [];
        foreach ($hierarchyClasses as $class) {
            $currentMetadata = $entityManager->getClassMetadata($class);
            $currentDiscriminator = $currentMetadata->discriminatorValue;

Accessing discriminatorValue on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

            if (null !== $currentDiscriminator) {
                $discriminators[$currentDiscriminator] = null;
            }
        }

        return $discriminators;
    }
}