Inspection of "add regression test" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — 2.6 (#7514)

by Joe

created 2018-12-08 17:06 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -133,7 +133,7 @@
 block discarded – undo
     static public function loadMetadata(\Doctrine\ORM\Mapping\ClassMetadataInfo $metadata)
     {
         $metadata->setInheritanceType(\Doctrine\ORM\Mapping\ClassMetadata::INHERITANCE_TYPE_JOINED);
-        $metadata->setTableName( 'company_contracts');
+        $metadata->setTableName('company_contracts');
         $metadata->setDiscriminatorColumn(
             [
             'name' => 'discr',

Please login to merge, or discard this patch.

tests/Doctrine/Tests/Models/Company/CompanyEvent.php 1 patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@  discard block
 block discarded – undo
  * @DiscriminatorMap({"auction"="CompanyAuction", "raffle"="CompanyRaffle"})
  */
 abstract class CompanyEvent {
-   /**
+    /**
      * @Id @Column(type="integer")
      * @GeneratedValue
      */
@@ -19,18 +19,18 @@  discard block
 block discarded – undo
      * @ManyToOne(targetEntity="CompanyOrganization", inversedBy="events", cascade={"persist"})
      * @JoinColumn(name="org_id", referencedColumnName="id")
      */
-     private $organization;
+        private $organization;
 
-     public function getId() {
-         return $this->id;
-     }
+        public function getId() {
+            return $this->id;
+        }
 
-     public function getOrganization() {
-         return $this->organization;
-     }
+        public function getOrganization() {
+            return $this->organization;
+        }
 
-     public function setOrganization(CompanyOrganization $org) {
-         $this->organization = $org;
-     }
+        public function setOrganization(CompanyOrganization $org) {
+            $this->organization = $org;
+        }
 
 }
\ No newline at end of file

Please login to merge, or discard this patch.

tests/Doctrine/Tests/Models/Company/CompanyPerson.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -122,7 +122,7 @@  discard block
 block discarded – undo
 
         $metadata->setPrimaryTable(
             [
-           'name' => 'company_person',
+            'name' => 'company_person',
             ]
         );
 
@@ -149,14 +149,14 @@  discard block
 block discarded – undo
             'entities'  => [
                 [
                 'fields' => [
-                  [
+                    [
                     'name'      => 'id',
                     'column'    => 'id',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'name',
                     'column'    => 'name',
-                  ],
+                    ],
                 ],
                 'entityClass' => CompanyPerson::class,
                 'discriminatorColumn' => 'discriminator',

Please login to merge, or discard this patch.

tests/Doctrine/Tests/Models/Company/CompanyOrganization.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -4,11 +4,11 @@
 block discarded – undo
 
 /** @Entity @Table(name="company_organizations") */
 class CompanyOrganization {
-   /**
-    * @Id @Column(type="integer")
-    * @GeneratedValue(strategy="AUTO")
-    */
-   private $id;
+    /**
+     * @Id @Column(type="integer")
+     * @GeneratedValue(strategy="AUTO")
+     */
+    private $id;
 
     /**
      * @OneToMany(targetEntity="CompanyEvent", mappedBy="organization", cascade={"persist"}, fetch="EXTRA_LAZY")

Please login to merge, or discard this patch.

tests/Doctrine/Tests/Models/Quote/Group.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
      */
     public $users;
 
-    public function __construct($name = null, Group $parent =  null)
+    public function __construct($name = null, Group $parent = null)
     {
         $this->name     = $name;
         $this->parent   = $parent;

Please login to merge, or discard this patch.

tests/Doctrine/Tests/Models/CMS/CmsUser.php 1 patch

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -273,7 +273,7 @@  discard block
 block discarded – undo
     {
         $metadata->setPrimaryTable(
             [
-           'name' => 'cms_users',
+            'name' => 'cms_users',
             ]
         );
 
@@ -332,34 +332,34 @@  discard block
 block discarded – undo
             'entities'  => [
                 [
                 'fields'=> [
-                  [
+                    [
                     'name'      => 'id',
                     'column'    => 'id',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'name',
                     'column'    => 'name',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'status',
                     'column'    => 'status',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'address.zip',
                     'column'    => 'zip',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'address.city',
                     'column'    => 'city',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'address.country',
                     'column'    => 'country',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'address.id',
                     'column'    => 'a_id',
-                  ],
+                    ],
                 ],
                 'entityClass'           => CmsUser::class,
                 'discriminatorColumn'   => null
@@ -375,22 +375,22 @@  discard block
 block discarded – undo
             'entities'  => [
                 [
                 'fields'=> [
-                  [
+                    [
                     'name'      => 'id',
                     'column'    => 'id',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'name',
                     'column'    => 'name',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'status',
                     'column'    => 'status',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'phonenumbers.phonenumber',
                     'column'    => 'number',
-                  ],
+                    ],
                 ],
                 'entityClass'   => CmsUser::class,
                 'discriminatorColumn'   => null
@@ -404,29 +404,29 @@  discard block
 block discarded – undo
             'name'      => 'mappingUserPhonenumberCount',
             'columns'   => [],
             'entities'  => [
-              [
+                [
                 'fields' => [
-                  [
+                    [
                     'name'      => 'id',
                     'column'    => 'id',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'name',
                     'column'    => 'name',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'status',
                     'column'    => 'status',
-                  ]
+                    ]
                 ],
                 'entityClass'   => CmsUser::class,
                 'discriminatorColumn'   => null
-              ]
+                ]
             ],
             'columns' => [
-                  [
+                    [
                     'name' => 'numphones',
-                  ]
+                    ]
             ]
             ]
         );

Please login to merge, or discard this patch.

tests/Doctrine/Tests/Models/CMS/CmsAddress.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -126,7 +126,7 @@  discard block
 block discarded – undo
     {
         $metadata->setPrimaryTable(
             [
-           'name' => 'company_person',
+            'name' => 'company_person',
             ]
         );
 
@@ -191,18 +191,18 @@  discard block
 block discarded – undo
             'entities'  => [
                 [
                 'fields' => [
-                  [
+                    [
                     'name'      => 'id',
                     'column'    => 'id',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'city',
                     'column'    => 'city',
-                  ],
-                  [
+                    ],
+                    [
                     'name'      => 'country',
                     'column'    => 'country',
-                  ],
+                    ],
                 ],
                 'entityClass' => CmsAddress::class,
                 ],

Please login to merge, or discard this patch.

tests/Doctrine/Tests/Models/DDC869/DDC869CreditCardPayment.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@
 block discarded – undo
     {
         $metadata->mapField(
             [
-           'fieldName'  => 'creditCardNumber',
-           'type'       => 'string',
+            'fieldName'  => 'creditCardNumber',
+            'type'       => 'string',
             ]
         );
     }

Please login to merge, or discard this patch.

tests/Doctrine/Tests/Models/DDC869/DDC869Payment.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -23,16 +23,16 @@
 block discarded – undo
     {
         $metadata->mapField(
             [
-           'id'         => true,
-           'fieldName'  => 'id',
-           'type'       => 'integer',
-           'columnName' => 'id',
+            'id'         => true,
+            'fieldName'  => 'id',
+            'type'       => 'integer',
+            'columnName' => 'id',
             ]
         );
         $metadata->mapField(
             [
-           'fieldName'  => 'value',
-           'type'       => 'float',
+            'fieldName'  => 'value',
+            'type'       => 'float',
             ]
         );
         $metadata->isMappedSuperclass = true;

Please login to merge, or discard this patch.

		@@ -133,7 +133,7 @@
		block discarded – undo
133	133	static public function loadMetadata(\Doctrine\ORM\Mapping\ClassMetadataInfo $metadata)
134	134	{
135	135	$metadata->setInheritanceType(\Doctrine\ORM\Mapping\ClassMetadata::INHERITANCE_TYPE_JOINED);
136		- $metadata->setTableName( 'company_contracts');
	136	+ $metadata->setTableName('company_contracts');
137	137	$metadata->setDiscriminatorColumn(
138	138	[
139	139	'name' => 'discr',

		@@ -122,7 +122,7 @@ discard block
		block discarded – undo
122	122
123	123	$metadata->setPrimaryTable(
124	124	[
125		- 'name' => 'company_person',
	125	+ 'name' => 'company_person',
126	126	]
127	127	);
128	128
		@@ -149,14 +149,14 @@ discard block
		block discarded – undo
149	149	'entities' => [
150	150	[
151	151	'fields' => [
152		- [
	152	+ [
153	153	'name' => 'id',
154	154	'column' => 'id',
155		- ],
156		- [
	155	+ ],
	156	+ [
157	157	'name' => 'name',
158	158	'column' => 'name',
159		- ],
	159	+ ],
160	160	],
161	161	'entityClass' => CompanyPerson::class,
162	162	'discriminatorColumn' => 'discriminator',

		@@ -273,7 +273,7 @@ discard block
		block discarded – undo
273	273	{
274	274	$metadata->setPrimaryTable(
275	275	[
276		- 'name' => 'cms_users',
	276	+ 'name' => 'cms_users',
277	277	]
278	278	);
279	279
		@@ -332,34 +332,34 @@ discard block
		block discarded – undo
332	332	'entities' => [
333	333	[
334	334	'fields'=> [
335		- [
	335	+ [
336	336	'name' => 'id',
337	337	'column' => 'id',
338		- ],
339		- [
	338	+ ],
	339	+ [
340	340	'name' => 'name',
341	341	'column' => 'name',
342		- ],
343		- [
	342	+ ],
	343	+ [
344	344	'name' => 'status',
345	345	'column' => 'status',
346		- ],
347		- [
	346	+ ],
	347	+ [
348	348	'name' => 'address.zip',
349	349	'column' => 'zip',
350		- ],
351		- [
	350	+ ],
	351	+ [
352	352	'name' => 'address.city',
353	353	'column' => 'city',
354		- ],
355		- [
	354	+ ],
	355	+ [
356	356	'name' => 'address.country',
357	357	'column' => 'country',
358		- ],
359		- [
	358	+ ],
	359	+ [
360	360	'name' => 'address.id',
361	361	'column' => 'a_id',
362		- ],
	362	+ ],
363	363	],
364	364	'entityClass' => CmsUser::class,
365	365	'discriminatorColumn' => null
		@@ -375,22 +375,22 @@ discard block
		block discarded – undo
375	375	'entities' => [
376	376	[
377	377	'fields'=> [
378		- [
	378	+ [
379	379	'name' => 'id',
380	380	'column' => 'id',
381		- ],
382		- [
	381	+ ],
	382	+ [
383	383	'name' => 'name',
384	384	'column' => 'name',
385		- ],
386		- [
	385	+ ],
	386	+ [
387	387	'name' => 'status',
388	388	'column' => 'status',
389		- ],
390		- [
	389	+ ],
	390	+ [
391	391	'name' => 'phonenumbers.phonenumber',
392	392	'column' => 'number',
393		- ],
	393	+ ],
394	394	],
395	395	'entityClass' => CmsUser::class,
396	396	'discriminatorColumn' => null
		@@ -404,29 +404,29 @@ discard block
		block discarded – undo
404	404	'name' => 'mappingUserPhonenumberCount',
405	405	'columns' => [],
406	406	'entities' => [
407		- [
	407	+ [
408	408	'fields' => [
409		- [
	409	+ [
410	410	'name' => 'id',
411	411	'column' => 'id',
412		- ],
413		- [
	412	+ ],
	413	+ [
414	414	'name' => 'name',
415	415	'column' => 'name',
416		- ],
417		- [
	416	+ ],
	417	+ [
418	418	'name' => 'status',
419	419	'column' => 'status',
420		- ]
	420	+ ]
421	421	],
422	422	'entityClass' => CmsUser::class,
423	423	'discriminatorColumn' => null
424		- ]
	424	+ ]
425	425	],
426	426	'columns' => [
427		- [
	427	+ [
428	428	'name' => 'numphones',
429		- ]
	429	+ ]
430	430	]
431	431	]
432	432	);

		@@ -126,7 +126,7 @@ discard block
		block discarded – undo
126	126	{
127	127	$metadata->setPrimaryTable(
128	128	[
129		- 'name' => 'company_person',
	129	+ 'name' => 'company_person',
130	130	]
131	131	);
132	132
		@@ -191,18 +191,18 @@ discard block
		block discarded – undo
191	191	'entities' => [
192	192	[
193	193	'fields' => [
194		- [
	194	+ [
195	195	'name' => 'id',
196	196	'column' => 'id',
197		- ],
198		- [
	197	+ ],
	198	+ [
199	199	'name' => 'city',
200	200	'column' => 'city',
201		- ],
202		- [
	201	+ ],
	202	+ [
203	203	'name' => 'country',
204	204	'column' => 'country',
205		- ],
	205	+ ],
206	206	],
207	207	'entityClass' => CmsAddress::class,
208	208	],

		@@ -9,7 +9,7 @@ discard block
		block discarded – undo
9	9	* @DiscriminatorMap({"auction"="CompanyAuction", "raffle"="CompanyRaffle"})
10	10	*/
11	11	abstract class CompanyEvent {
12		- /**
	12	+ /**
13	13	* @Id @Column(type="integer")
14	14	* @GeneratedValue
15	15	*/
		@@ -19,18 +19,18 @@ discard block
		block discarded – undo
19	19	* @ManyToOne(targetEntity="CompanyOrganization", inversedBy="events", cascade={"persist"})
20	20	* @JoinColumn(name="org_id", referencedColumnName="id")
21	21	*/
22		- private $organization;
	22	+ private $organization;
23	23
24		- public function getId() {
25		- return $this->id;
26		- }
	24	+ public function getId() {
	25	+ return $this->id;
	26	+ }
27	27
28		- public function getOrganization() {
29		- return $this->organization;
30		- }
	28	+ public function getOrganization() {
	29	+ return $this->organization;
	30	+ }
31	31
32		- public function setOrganization(CompanyOrganization $org) {
33		- $this->organization = $org;
34		- }
	32	+ public function setOrganization(CompanyOrganization $org) {
	33	+ $this->organization = $org;
	34	+ }
35	35
36	36	}
37	37	\ No newline at end of file

		@@ -4,11 +4,11 @@
		block discarded – undo
4	4
5	5	/** @Entity @Table(name="company_organizations") */
6	6	class CompanyOrganization {
7		- /**
8		- * @Id @Column(type="integer")
9		- * @GeneratedValue(strategy="AUTO")
10		- */
11		- private $id;
	7	+ /**
	8	+ * @Id @Column(type="integer")
	9	+ * @GeneratedValue(strategy="AUTO")
	10	+ */
	11	+ private $id;
12	12
13	13	/**
14	14	* @OneToMany(targetEntity="CompanyEvent", mappedBy="organization", cascade={"persist"}, fetch="EXTRA_LAZY")

		@@ -34,7 +34,7 @@
		block discarded – undo
34	34	*/
35	35	public $users;
36	36
37		- public function __construct($name = null, Group $parent = null)
	37	+ public function __construct($name = null, Group $parent = null)
38	38	{
39	39	$this->name = $name;
40	40	$this->parent = $parent;

		@@ -15,8 +15,8 @@
		block discarded – undo
15	15	{
16	16	$metadata->mapField(
17	17	[
18		- 'fieldName' => 'creditCardNumber',
19		- 'type' => 'string',
	18	+ 'fieldName' => 'creditCardNumber',
	19	+ 'type' => 'string',
20	20	]
21	21	);
22	22	}

		@@ -23,16 +23,16 @@
		block discarded – undo
23	23	{
24	24	$metadata->mapField(
25	25	[
26		- 'id' => true,
27		- 'fieldName' => 'id',
28		- 'type' => 'integer',
29		- 'columnName' => 'id',
	26	+ 'id' => true,
	27	+ 'fieldName' => 'id',
	28	+ 'type' => 'integer',
	29	+ 'columnName' => 'id',
30	30	]
31	31	);
32	32	$metadata->mapField(
33	33	[
34		- 'fieldName' => 'value',
35		- 'type' => 'float',
	34	+ 'fieldName' => 'value',
	35	+ 'type' => 'float',
36	36	]
37	37	);
38	38	$metadata->isMappedSuperclass = true;

doctrine / orm

Pull Request — 2.6 (#7514)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch