Failed Conditions
Pull Request — master (#6593)
by Thomas
16:12
created
tests/Doctrine/Tests/Models/Navigation/NavCountry.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
      */
26 26
     private $pois;
27 27
 
28
+    /**
29
+     * @param string $name
30
+     */
28 31
     function __construct($name) {
29 32
         $this->name = $name;
30 33
     }
Please login to merge, or discard this patch.
tests/Doctrine/Tests/Models/Navigation/NavPhotos.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -29,6 +29,9 @@
 block discarded – undo
29 29
      */
30 30
     private $file;
31 31
 
32
+    /**
33
+     * @param string $file
34
+     */
32 35
     function __construct($poi, $file) {
33 36
         $this->poi = $poi;
34 37
         $this->file = $file;
Please login to merge, or discard this patch.
tests/Doctrine/Tests/Models/StockExchange/Market.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -28,6 +28,9 @@
 block discarded – undo
28 28
      */
29 29
     public $stocks;
30 30
 
31
+    /**
32
+     * @param string $name
33
+     */
31 34
     public function __construct($name)
32 35
     {
33 36
         $this->name = $name;
Please login to merge, or discard this patch.
Tests/ORM/Cache/Persister/Collection/AbstractCollectionPersisterTest.php 4 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -94,6 +94,7 @@
 block discarded – undo
94 94
     }
95 95
 
96 96
     /**
97
+     * @param State $owner
97 98
      * @return \Doctrine\ORM\PersistentCollection
98 99
      */
99 100
     protected function createCollection($owner, $assoc = null, $class = null, $elements = null)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -6,11 +6,9 @@
 block discarded – undo
6 6
 use Doctrine\ORM\Cache\Persister\Collection\CachedCollectionPersister;
7 7
 use Doctrine\ORM\PersistentCollection;
8 8
 use Doctrine\Tests\OrmTestCase;
9
-
10 9
 use Doctrine\ORM\Cache\Region;
11 10
 use Doctrine\ORM\EntityManager;
12 11
 use Doctrine\ORM\Persisters\Collection\CollectionPersister;
13
-
14 12
 use Doctrine\Tests\Models\Cache\State;
15 13
 use Doctrine\Common\Collections\ArrayCollection;
16 14
 
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,8 +83,8 @@
 block discarded – undo
83 83
         $this->em                   = $this->_getTestEntityManager();
84 84
         $this->region               = $this->createRegion();
85 85
         $this->collectionPersister  = $this->getMockBuilder(CollectionPersister::class)
86
-                                           ->setMethods($this->collectionPersisterMockMethods)
87
-                                           ->getMock();
86
+                                            ->setMethods($this->collectionPersisterMockMethods)
87
+                                            ->getMock();
88 88
     }
89 89
 
90 90
     /**
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
             ->with($this->equalTo($collection), $this->equalTo(1), $this->equalTo(2))
192 192
             ->will($this->returnValue($slice));
193 193
 
194
-        $this->assertEquals($slice, $persister->slice($collection, 1 , 2));
194
+        $this->assertEquals($slice, $persister->slice($collection, 1, 2));
195 195
     }
196 196
 
197 197
     public function testInvokeContains()
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
             ->with($this->equalTo($collection), $this->equalTo($element))
209 209
             ->will($this->returnValue(false));
210 210
 
211
-        $this->assertFalse($persister->contains($collection,$element));
211
+        $this->assertFalse($persister->contains($collection, $element));
212 212
     }
213 213
 
214 214
     public function testInvokeContainsKey()
Please login to merge, or discard this patch.
Doctrine/Tests/ORM/Cache/Persister/Entity/AbstractEntityPersisterTest.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
     }
115 115
 
116 116
     /**
117
-     * @return \Doctrine\ORM\Cache\Persister\AbstractEntityPersister
117
+     * @return \Doctrine\ORM\Cache\Persister\Entity\AbstractEntityPersister
118 118
      */
119 119
     protected function createPersisterDefault()
120 120
     {
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,8 +100,8 @@
 block discarded – undo
100 100
         $this->em               = $this->_getTestEntityManager();
101 101
         $this->region           = $this->createRegion();
102 102
         $this->entityPersister  = $this->getMockBuilder(EntityPersister::class)
103
-                                       ->setMethods($this->entityPersisterMockMethods)
104
-                                       ->getMock();
103
+                                        ->setMethods($this->entityPersisterMockMethods)
104
+                                        ->getMock();
105 105
     }
106 106
 
107 107
     /**
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
             ->with($this->equalTo([]), $this->equalTo('Foo'), $this->equalTo(1), $this->equalTo(2))
381 381
             ->will($this->returnValue([$entity]));
382 382
 
383
-        $this->assertEquals([$entity], $persister->getManyToManyCollection([], 'Foo', 1 ,2));
383
+        $this->assertEquals([$entity], $persister->getManyToManyCollection([], 'Foo', 1, 2));
384 384
     }
385 385
 
386 386
     public function testInvokeGetOneToManyCollection()
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
             ->with($this->equalTo([]), $this->equalTo('Foo'), $this->equalTo(1), $this->equalTo(2))
394 394
             ->will($this->returnValue([$entity]));
395 395
 
396
-        $this->assertEquals([$entity], $persister->getOneToManyCollection([], 'Foo', 1 ,2));
396
+        $this->assertEquals([$entity], $persister->getOneToManyCollection([], 'Foo', 1, 2));
397 397
     }
398 398
 
399 399
     public function testInvokeLoadManyToManyCollection()
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/DatabaseDriverTestCase.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
     }
28 28
 
29 29
     /**
30
-     * @param  string $className
30
+     * @param  string $classNames
31 31
      * @return ClassMetadata
32 32
      */
33 33
     protected function extractClassMetadata(array $classNames)
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
         $driver = new DatabaseDriver($sm);
41 41
 
42 42
         foreach ($driver->getAllClassNames() as $className) {
43
-            if (!in_array(strtolower($className), $classNames)) {
43
+            if ( ! in_array(strtolower($className), $classNames)) {
44 44
                 continue;
45 45
             }
46 46
             $class = new ClassMetadataInfo($className);
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
         }
50 50
 
51 51
         if (count($metadatas) != count($classNames)) {
52
-            $this->fail("Have not found all classes matching the names '" . implode(", ", $classNames) . "' only tables " . implode(", ", array_keys($metadatas)));
52
+            $this->fail("Have not found all classes matching the names '".implode(", ", $classNames)."' only tables ".implode(", ", array_keys($metadatas)));
53 53
         }
54 54
         return $metadatas;
55 55
     }
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/LifecycleCallbackTest.php 3 patches
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -375,8 +375,16 @@
 block discarded – undo
375 375
     private $name;
376 376
     public function getId() {return $this->id;}
377 377
     public function getValue() {return $this->value;}
378
+
379
+    /**
380
+     * @param string $value
381
+     */
378 382
     public function setValue($value) {$this->value = $value;}
379 383
     public function getName() {return $this->name;}
384
+
385
+    /**
386
+     * @param string $name
387
+     */
380 388
     public function setName($name) {$this->name = $name;}
381 389
     /** @PreUpdate */
382 390
     public function testCallback() {$this->value = 'Hello World';}
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -302,8 +302,8 @@
 block discarded – undo
302 302
     }
303 303
 
304 304
     /**
305
-    * @group DDC-1955
306
-    */
305
+     * @group DDC-1955
306
+     */
307 307
     public function testLifecycleCallbackEventArgs()
308 308
     {
309 309
         $e = new LifecycleCallbackEventArgEntity;
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -350,13 +350,13 @@
 block discarded – undo
350 350
     private $value;
351 351
     /** @Column(type="string") */
352 352
     private $name;
353
-    public function getId() {return $this->id;}
354
-    public function getValue() {return $this->value;}
355
-    public function setValue($value) {$this->value = $value;}
356
-    public function getName() {return $this->name;}
357
-    public function setName($name) {$this->name = $name;}
353
+    public function getId() {return $this->id; }
354
+    public function getValue() {return $this->value; }
355
+    public function setValue($value) {$this->value = $value; }
356
+    public function getName() {return $this->name; }
357
+    public function setName($name) {$this->name = $name; }
358 358
     /** @PreUpdate */
359
-    public function testCallback() {$this->value = 'Hello World';}
359
+    public function testCallback() {$this->value = 'Hello World'; }
360 360
 }
361 361
 
362 362
 /**
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/MergeSharedEntitiesTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -141,6 +141,9 @@
 block discarded – undo
141 141
         return $this->session;
142 142
     }
143 143
 
144
+    /**
145
+     * @param string $session
146
+     */
144 147
     public function setSession($session)
145 148
     {
146 149
         $this->session = $session;
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/NotifyPolicyTest.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -94,6 +94,9 @@  discard block
 block discarded – undo
94 94
         $this->listeners[] = $listener;
95 95
     }
96 96
 
97
+    /**
98
+     * @param string $propName
99
+     */
97 100
     protected function onPropertyChanged($propName, $oldValue, $newValue) {
98 101
         if ($this->listeners) {
99 102
             foreach ($this->listeners as $listener) {
@@ -126,6 +129,9 @@  discard block
 block discarded – undo
126 129
         return $this->name;
127 130
     }
128 131
 
132
+    /**
133
+     * @param string $name
134
+     */
129 135
     function setName($name) {
130 136
         $this->onPropertyChanged('name', $this->name, $name);
131 137
         $this->name = $name;
@@ -159,6 +165,9 @@  discard block
 block discarded – undo
159 165
         return $this->name;
160 166
     }
161 167
 
168
+    /**
169
+     * @param string $name
170
+     */
162 171
     function setName($name) {
163 172
         $this->onPropertyChanged('name', $this->name, $name);
164 173
         $this->name = $name;
Please login to merge, or discard this patch.