View GitHub Repository orm

Schedule Inspection
Subscribe
Failed Conditions
Pull Request — develop (#6602)
by Mike
124:26 queued 59:45
created
Status
Category
Toggle Patches
Tests/ORM/Mapping/php/Doctrine.Tests.Models.DDC889.DDC889Entity.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 use Doctrine\ORM\Mapping\ClassMetadata;
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.CMS.CmsUser.php 2 patches
Indentation   +32 added lines, -32 removed lines patch added patch discarded remove patch 
@@ -66,34 +66,34 @@  discard block
 
 block discarded – undo
66 66 
     'entities'  => [
67 67 
         [
68 68 
         'fields'=> [
69 
-          [
69 
+            [
70 70 
             'name'      => 'id',
71 71 
             'column'    => 'id',
72 
-          ],
73 
-          [
72 
+            ],
73 
+            [
74 74 
             'name'      => 'name',
75 75 
             'column'    => 'name',
76 
-          ],
77 
-          [
76 
+            ],
77 
+            [
78 78 
             'name'      => 'status',
79 79 
             'column'    => 'status',
80 
-          ],
81 
-          [
80 
+            ],
81 
+            [
82 82 
             'name'      => 'address.zip',
83 83 
             'column'    => 'zip',
84 
-          ],
85 
-          [
84 
+            ],
85 
+            [
86 86 
             'name'      => 'address.city',
87 87 
             'column'    => 'city',
88 
-          ],
89 
-          [
88 
+            ],
89 
+            [
90 90 
             'name'      => 'address.country',
91 91 
             'column'    => 'country',
92 
-          ],
93 
-          [
92 
+            ],
93 
+            [
94 94 
             'name'      => 'address.id',
95 95 
             'column'    => 'a_id',
96 
-          ],
96 
+            ],
97 97 
         ],
98 98 
         'entityClass'           => '__CLASS__',
99 99 
         'discriminatorColumn'   => null
 
@@ -109,22 +109,22 @@  discard block
 
 block discarded – undo
109 109 
     'entities'  => [
110 110 
         [
111 111 
         'fields'=> [
112 
-          [
112 
+            [
113 113 
             'name'      => 'id',
114 114 
             'column'    => 'id',
115 
-          ],
116 
-          [
115 
+            ],
116 
+            [
117 117 
             'name'      => 'name',
118 118 
             'column'    => 'name',
119 
-          ],
120 
-          [
119 
+            ],
120 
+            [
121 121 
             'name'      => 'status',
122 122 
             'column'    => 'status',
123 
-          ],
124 
-          [
123 
+            ],
124 
+            [
125 125 
             'name'      => 'phonenumbers.phonenumber',
126 126 
             'column'    => 'number',
127 
-          ],
127 
+            ],
128 128 
         ],
129 129 
         'entityClass'   => CmsUser::class,
130 130 
         'discriminatorColumn'   => null
 
@@ -138,29 +138,29 @@  discard block
 
 block discarded – undo
138 138 
     'name'      => 'mappingUserPhonenumberCount',
139 139 
     'columns'   => [],
140 140 
     'entities'  => [
141 
-      [
141 
+        [
142 142 
         'fields' => [
143 
-          [
143 
+            [
144 144 
             'name'      => 'id',
145 145 
             'column'    => 'id',
146 
-          ],
147 
-          [
146 
+            ],
147 
+            [
148 148 
             'name'      => 'name',
149 149 
             'column'    => 'name',
150 
-          ],
151 
-          [
150 
+            ],
151 
+            [
152 152 
             'name'      => 'status',
153 153 
             'column'    => 'status',
154 
-          ]
154 
+            ]
155 155 
         ],
156 156 
         'entityClass'   => CmsUser::class,
157 157 
         'discriminatorColumn'   => null
158 
-      ]
158 
+        ]
159 159 
     ],
160 160 
     'columns' => [
161 
-          [
161 
+            [
162 162 
             'name' => 'numphones',
163 
-          ]
163 
+            ]
164 164 
     ]
165 165 
     ]
166 166 
 );
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 use Doctrine\ORM\Mapping;
6 6 
 use Doctrine\ORM\Mapping\ClassMetadata;
Please login to merge, or discard this patch.
Tests/ORM/Mapping/php/Doctrine.Tests.Models.Company.CompanyPerson.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -34,14 +34,14 @@
 
 block discarded – undo
34 34 
     'entities'  => [
35 35 
         [
36 36 
         'fields' => [
37 
-          [
37 
+            [
38 38 
             'name'      => 'id',
39 39 
             'column'    => 'id',
40 
-          ],
41 
-          [
40 
+            ],
41 
+            [
42 42 
             'name'      => 'name',
43 43 
             'column'    => 'name',
44 
-          ],
44 
+            ],
45 45 
         ],
46 46 
         'entityClass' => '__CLASS__',
47 47 
         'discriminatorColumn' => 'discriminator',
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 use Doctrine\ORM\Mapping;
6 6 
 use Doctrine\ORM\Mapping\ClassMetadata;
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.ORM.Mapping.PHPSLC.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 use Doctrine\ORM\Mapping;
6 6
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.Cache.City.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 use Doctrine\ORM\Mapping\ClassMetadata;
6 6 
 use Doctrine\ORM\Mapping;
Please login to merge, or discard this patch.
Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.DDC964.DDC964User.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 use Doctrine\DBAL\Types\Type;
6 6 
 use Doctrine\ORM\Mapping;
 
@@ -64,6 +64,6 @@  discard block
 
 block discarded – undo
64 64 
 $association->setJoinTable($joinTable);
65 65 
 $association->setTargetEntity(\Doctrine\Tests\Models\DDC964\DDC964Group::class);
66 66 
 $association->setInversedBy('user');
67 
-$association->setCascade(['persist','merge','detach']);
67 
+$association->setCascade(['persist', 'merge', 'detach']);
68 68
69 69 
 $metadata->addProperty($association);
Please login to merge, or discard this patch.
Doctrine/Tests/ORM/Mapping/NamingStrategy/JoinColumnClassNamingStrategy.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Mapping\NamingStrategy;
6 6 
 
@@ -17,7 +17,7 @@  discard block
 
 block discarded – undo
17 17 
     public function joinColumnName($propertyName, $className = null)
18 18 
     {
19 19 
         return strtolower($this->classToTableName($className))
20 
-            . '_' . $propertyName
21 
-            . '_' . $this->referenceColumnName();
20 
+            . '_'.$propertyName
21 
+            . '_'.$this->referenceColumnName();
22 22 
     }
23 23 
 }
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Mapping/AnnotationDriverTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Mapping;
6 6 
 
@@ -122,7 +122,7 @@  discard block
 
 block discarded – undo
122 122 
     protected function loadDriverForCMSModels()
123 123 
     {
124 124 
         $annotationDriver = $this->loadDriver();
125 
-        $annotationDriver->addPaths([__DIR__ . '/../../Models/CMS/']);
125 
+        $annotationDriver->addPaths([__DIR__.'/../../Models/CMS/']);
126 126 
         return $annotationDriver;
127 127 
     }
128 128 
 
@@ -144,7 +144,7 @@  discard block
 
 block discarded – undo
144 144 
     public function testJoinTablesWithMappedSuperclassForAnnotationDriver()
145 145 
     {
146 146 
         $annotationDriver = $this->loadDriver();
147 
-        $annotationDriver->addPaths([__DIR__ . '/../../Models/DirectoryTree/']);
147 
+        $annotationDriver->addPaths([__DIR__.'/../../Models/DirectoryTree/']);
148 148
149 149 
         $em = $this->getTestEntityManager();
150 150 
         $em->getConfiguration()->setMetadataDriverImpl($annotationDriver);
 
@@ -174,7 +174,7 @@  discard block
 
 block discarded – undo
174 174
175 175 
         $this->expectException(MappingException::class);
176 176 
         $this->expectExceptionMessage(
177 
-            "It is illegal to put an inverse side one-to-many or many-to-many association on " .
177 
+            "It is illegal to put an inverse side one-to-many or many-to-many association on ".
178 178 
             "mapped superclass 'Doctrine\Tests\ORM\Mapping\InvalidMappedSuperClass#users'"
179 179 
         );
180 180 
 
@@ -195,8 +195,8 @@  discard block
 
 block discarded – undo
195 195
196 196 
         $this->expectException(MappingException::class);
197 197 
         $this->expectExceptionMessage(
198 
-            "It is not supported to define inheritance information on a mapped " .
199 
-            "superclass '" . MappedSuperClassInheritance::class . "'."
198 
+            "It is not supported to define inheritance information on a mapped ".
199 
+            "superclass '".MappedSuperClassInheritance::class."'."
200 200 
         );
201 201
202 202 
         $usingInvalidMsc = $factory->getMetadataFor(MappedSuperClassInheritance::class);
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Mapping/Symfony/AbstractDriverTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Mapping\Symfony;
6 6 
 
@@ -54,7 +54,7 @@  discard block
 
 block discarded – undo
54 54 
     public function testFindMappingNamespaceNotFound()
55 55 
     {
56 56 
         $this->expectException(MappingException::class);
57 
-        $this->expectExceptionMessage("No mapping file found named 'Foo" . $this->getFileExtension() . "' for class 'MyOtherNamespace\MySubnamespace\Entity\Foo'.");
57 
+        $this->expectExceptionMessage("No mapping file found named 'Foo".$this->getFileExtension()."' for class 'MyOtherNamespace\MySubnamespace\Entity\Foo'.");
58 58
59 59 
         $driver = $this->getDriver(
60 60 
             [
Please login to merge, or discard this patch.