HierarchyDiscriminatorResolver::__construct() - Code Metrics - Inspection of "Merge pull request #7521 from doctrine/update-chat..." - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — 2.7 ( c036c0...266f0d )

by Jonathan

created 2018-12-12 20:11 UTC

HierarchyDiscriminatorResolver::__construct() A

↳ Parent: HierarchyDiscriminatorResolver

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	0

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	0
nc	1
nop	0
dl	0
loc	2
ccs	0
cts	1
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace Doctrine\ORM\Utility;

use Doctrine\Common\Persistence\Mapping\ClassMetadata;
use Doctrine\ORM\EntityManagerInterface;

/**
 * @internal This class exists only to avoid code duplication, do not reuse it externally
 */
final class HierarchyDiscriminatorResolver
{
    private function __construct()
    {
    }

    /**
     * This method is needed to make INSTANCEOF work correctly with inheritance: if the class at hand has inheritance,
     * it extracts all the discriminators from the child classes and returns them
     */
    public static function resolveDiscriminatorsForClass(
        ClassMetadata $rootClassMetadata,
        EntityManagerInterface $entityManager
    ): array {
        $hierarchyClasses = $rootClassMetadata->subClasses;

        $hierarchyClasses[] = $rootClassMetadata->name;


        $discriminators = [];

        foreach ($hierarchyClasses as $class) {
            $currentMetadata = $entityManager->getClassMetadata($class);
            $currentDiscriminator = $currentMetadata->discriminatorValue;


            if (null !== $currentDiscriminator) {
                $discriminators[$currentDiscriminator] = null;
            }
        }

        return $discriminators;
    }
}


1		<?php
2
3		namespace Doctrine\ORM\Utility;
4
5		use Doctrine\Common\Persistence\Mapping\ClassMetadata;
6		use Doctrine\ORM\EntityManagerInterface;
7
8		/**
9		* @internal This class exists only to avoid code duplication, do not reuse it externally
10		*/
11		final class HierarchyDiscriminatorResolver
12		{
13		private function __construct()
14		{
15		}
16
17		/**
18		* This method is needed to make INSTANCEOF work correctly with inheritance: if the class at hand has inheritance,
19		* it extracts all the discriminators from the child classes and returns them
20		*/
21	14	public static function resolveDiscriminatorsForClass(
22		ClassMetadata $rootClassMetadata,
23		EntityManagerInterface $entityManager
24		): array {
25	14	$hierarchyClasses = $rootClassMetadata->subClasses;
		0 ignored issues – show Bug introduced 2017-11-23 09:45 UTC by Report Bug Copy Issue Report Accessing `subClasses` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
26	14	$hierarchyClasses[] = $rootClassMetadata->name;
		0 ignored issues – show Bug introduced 2017-11-23 09:45 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
27
28	14	$discriminators = [];
29
30	14	foreach ($hierarchyClasses as $class) {
31	14	$currentMetadata = $entityManager->getClassMetadata($class);
32	14	$currentDiscriminator = $currentMetadata->discriminatorValue;
		0 ignored issues – show Bug introduced 2017-11-23 09:45 UTC by Report Bug Copy Issue Report Accessing `discriminatorValue` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
33
34	14	if (null !== $currentDiscriminator) {
35	14	$discriminators[$currentDiscriminator] = null;
36		}
37		}
38
39	14	return $discriminators;
40		}
41		}
42

doctrine / orm

Push — 2.7 ( c036c0...266f0d )

HierarchyDiscriminatorResolver::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like