DDC6470User::setName() - Code Metrics - Inspection of "add setCacheable" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — 2.7 (#7148)

by Vadim

created 2018-03-21 17:01 UTC

DDC6470User::setName() A

↳ Parent: DDC6470User

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\ORM\Tools\ToolsException;

/**
 */
class DDC6470Test extends \Doctrine\Tests\OrmFunctionalTestCase
{
    public function setUp()
    {
        $this->enableSecondLevelCache();
        parent::setUp();

        try {
            $this->_schemaTool->createSchema(
                [
                    $this->_em->getClassMetadata(DDC6470User::class),
                    $this->_em->getClassMetadata(DDC6470Driver::class),
                ]
            );
        } catch (ToolsException $exc) {

        }
    }

    public function testIssue()
    {
        $driver1 = new DDC6470Driver('Bar');

        $this->_em->persist($driver1);
        $this->_em->flush();
        $this->_em->clear();


        $this->assertTrue($this->_em->getCache()->containsEntity(DDC6470User::class, ['id' => $driver1->getUserProfile()->getId()]));
        $queryCount = $this->getCurrentQueryCount();
        $driver3 = $this->_em->createQueryBuilder()
            ->from(DDC6470Driver::class, 'd')
            ->select('d')
            ->where('d.id = :id')
            ->setParameter('id', $driver1->getId())
            ->setCacheable(true)
            ->getQuery()
            ->getOneOrNullResult();
        $this->assertEquals($queryCount+1, $this->getCurrentQueryCount());
        $this->assertInstanceOf(DDC6470Driver::class, $driver3);
        $this->assertInstanceOf(DDC6470User::class, $driver3->getUserProfile());
    }
}

/**
 * @Entity
 * @Table(name="ddc6470_drivers")
 * @Cache("NONSTRICT_READ_WRITE")
 */
class DDC6470Driver
{
    /**
     * @Id
     * @GeneratedValue
     * @Column(type="integer")
     */
    protected $id;

    /**
     * @Column(type="string")
     * @var string
     */
    protected $name;

    /**
     * @Cache("NONSTRICT_READ_WRITE")
     * @OneToOne(targetEntity="DDC6470User", mappedBy="user", cascade={"persist"})
     */
    protected $userProfile;

    public function __construct($name)
    {
        $this->name = $name;
        $this->userProfile = new DDC6470User('Foo', $this);
    }

    /**
     * @return integer
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @param string $name
     */
    public function setName($name)
    {
        $this->name = $name;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @param \Entities\User $userProfile
filter:
    dependency_paths: ["lib/*"]
     */
    public function setUserProfile($userProfile)
    {
        $this->userProfile = $userProfile;
    }

    /**
     * @return \Entities\User
     */
    public function getUserProfile()
    {
        return $this->userProfile;

    }
}

/**
 * @Entity
 * @Table(name="ddc6470_users")
 * @Cache("NONSTRICT_READ_WRITE")
 */
class DDC6470User
{
    /**
     * @Id
     * @GeneratedValue
     * @Column(type="integer")
     */
    protected $id;

    /**
     * @Column(type="string")
     * @var string
     */
    protected $name;
    /**
     *
     * @OneToOne(targetEntity="DDC6470Driver", inversedBy="userProfile")
     * @JoinColumn(name="user_id", referencedColumnName="id", onDelete="cascade")
     * @Cache(usage="READ_ONLY")
     */
    protected $user;

    public function __construct($name, DDC6470Driver $user)
    {
        $this->name = $name;
        $this->user = $user;
    }

    /**
     * @return integer
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @param string $name
     */
    public function setName($name)
    {
        $this->name = $name;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }
}


1			<?php
2
3			namespace Doctrine\Tests\ORM\Functional\Ticket;
4
5			use Doctrine\ORM\Tools\ToolsException;
6
7			/**
8			*/
9			class DDC6470Test extends \Doctrine\Tests\OrmFunctionalTestCase
10			{
11			public function setUp()
12			{
13			$this->enableSecondLevelCache();
14			parent::setUp();
15
16			try {
17			$this->_schemaTool->createSchema(
18			[
19			$this->_em->getClassMetadata(DDC6470User::class),
20			$this->_em->getClassMetadata(DDC6470Driver::class),
21			]
22			);
23			} catch (ToolsException $exc) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-03-21 17:11 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
24			}
25			}
26
27			public function testIssue()
28			{
29			$driver1 = new DDC6470Driver('Bar');
30
31			$this->_em->persist($driver1);
32			$this->_em->flush();
33			$this->_em->clear();
34
35
36			$this->assertTrue($this->_em->getCache()->containsEntity(DDC6470User::class, ['id' => $driver1->getUserProfile()->getId()]));
37			$queryCount = $this->getCurrentQueryCount();
38			$driver3 = $this->_em->createQueryBuilder()
39			->from(DDC6470Driver::class, 'd')
40			->select('d')
41			->where('d.id = :id')
42			->setParameter('id', $driver1->getId())
43			->setCacheable(true)
44			->getQuery()
45			->getOneOrNullResult();
46			$this->assertEquals($queryCount+1, $this->getCurrentQueryCount());
47			$this->assertInstanceOf(DDC6470Driver::class, $driver3);
48			$this->assertInstanceOf(DDC6470User::class, $driver3->getUserProfile());
49			}
50			}
51
52			/**
53			* @Entity
54			* @Table(name="ddc6470_drivers")
55			* @Cache("NONSTRICT_READ_WRITE")
56			*/
57			class DDC6470Driver
58			{
59			/**
60			* @Id
61			* @GeneratedValue
62			* @Column(type="integer")
63			*/
64			protected $id;
65
66			/**
67			* @Column(type="string")
68			* @var string
69			*/
70			protected $name;
71
72			/**
73			* @Cache("NONSTRICT_READ_WRITE")
74			* @OneToOne(targetEntity="DDC6470User", mappedBy="user", cascade={"persist"})
75			*/
76			protected $userProfile;
77
78			public function __construct($name)
79			{
80			$this->name = $name;
81			$this->userProfile = new DDC6470User('Foo', $this);
82			}
83
84			/**
85			* @return integer
86			*/
87			public function getId()
88			{
89			return $this->id;
90			}
91
92			/**
93			* @param string $name
94			*/
95			public function setName($name)
96			{
97			$this->name = $name;
98			}
99
100			/**
101			* @return string
102			*/
103			public function getName()
104			{
105			return $this->name;
106			}
107
108			/**
109			* @param \Entities\User $userProfile
			0 ignored issues – show Bug introduced 2018-03-21 17:11 UTC by Report Bug Copy Issue Report The type `Entities\User` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
110			*/
111			public function setUserProfile($userProfile)
112			{
113			$this->userProfile = $userProfile;
114			}
115
116			/**
117			* @return \Entities\User
118			*/
119			public function getUserProfile()
120			{
121			return $this->userProfile;
			0 ignored issues – show Bug Best Practice introduced 2018-03-21 17:11 UTC by Report Bug Copy Issue Report The expression `return $this->userProfile` returns the type `Doctrine\Tests\ORM\Functional\Ticket\DDC6470User` which is incompatible with the documented return type `Entities\User`. Loading history...
122			}
123			}
124
125			/**
126			* @Entity
127			* @Table(name="ddc6470_users")
128			* @Cache("NONSTRICT_READ_WRITE")
129			*/
130			class DDC6470User
131			{
132			/**
133			* @Id
134			* @GeneratedValue
135			* @Column(type="integer")
136			*/
137			protected $id;
138
139			/**
140			* @Column(type="string")
141			* @var string
142			*/
143			protected $name;
144			/**
145			*
146			* @OneToOne(targetEntity="DDC6470Driver", inversedBy="userProfile")
147			* @JoinColumn(name="user_id", referencedColumnName="id", onDelete="cascade")
148			* @Cache(usage="READ_ONLY")
149			*/
150			protected $user;
151
152			public function __construct($name, DDC6470Driver $user)
153			{
154			$this->name = $name;
155			$this->user = $user;
156			}
157
158			/**
159			* @return integer
160			*/
161			public function getId()
162			{
163			return $this->id;
164			}
165
166			/**
167			* @param string $name
168			*/
169			public function setName($name)
170			{
171			$this->name = $name;
172			}
173
174			/**
175			* @return string
176			*/
177			public function getName()
178			{
179			return $this->name;
180			}
181			}
182

doctrine / orm

Pull Request — 2.7 (#7148)

DDC6470User::setName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like