Failed Conditions
Pull Request — develop (#6719)
by Marco
79:37 queued 14:59
created
IdentityIsAssociation/NestedAssociationToToOneAssociationIdToSimpleId.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\Models\IdentityIsAssociation;
6 6
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/Models/IdentityIsAssociation/SimpleId.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\Models\IdentityIsAssociation;
6 6
 
Please login to merge, or discard this patch.
Tests/Models/IdentityIsAssociation/ToOneAssociationIdToSimpleId.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\Models\IdentityIsAssociation;
6 6
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/Models/ProxySpecifics/FuncGetArgs.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\Models\ProxySpecifics;
6 6
 
Please login to merge, or discard this patch.
tests/Doctrine/Performance/Hydration/SimpleInsertPerformanceBench.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Performance\Hydration;
6 6
 
@@ -40,8 +40,8 @@  discard block
 block discarded – undo
40 40
         for ($i = 1; $i <= 10000; ++$i) {
41 41
             $user           = new CMS\CmsUser;
42 42
             $user->status   = 'user';
43
-            $user->username = 'user' . $i;
44
-            $user->name     = 'Mr.Smith-' . $i;
43
+            $user->username = 'user'.$i;
44
+            $user->name     = 'Mr.Smith-'.$i;
45 45
 
46 46
             $this->users[$i] = $user;
47 47
         }
@@ -49,12 +49,12 @@  discard block
 block discarded – undo
49 49
 
50 50
     public function benchHydration() : void
51 51
     {
52
-        $this->entityManager->createQuery('DELETE FROM ' . CMS\CmsUser::class . ' u')->execute();
52
+        $this->entityManager->createQuery('DELETE FROM '.CMS\CmsUser::class.' u')->execute();
53 53
 
54 54
         foreach ($this->users as $key => $user) {
55 55
             $this->entityManager->persist($user);
56 56
 
57
-            if (! ($key % 20)) {
57
+            if ( ! ($key % 20)) {
58 58
                 $this->entityManager->flush();
59 59
                 $this->entityManager->clear();
60 60
             }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Configuration.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -749,7 +749,7 @@
 block discarded – undo
749 749
      *
750 750
      * @since 2.5
751 751
      *
752
-     * @param mixed  $value The value of the hint.
752
+     * @param string  $value The value of the hint.
753 753
      */
754 754
     public function setDefaultQueryHint(string $hintName, $value) : void
755 755
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\ORM;
6 6
 
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
      */
213 213
     public function newDefaultAnnotationDriver(array $paths = []) : AnnotationDriver
214 214
     {
215
-        AnnotationRegistry::registerFile(__DIR__ . '/Annotation/DoctrineAnnotations.php');
215
+        AnnotationRegistry::registerFile(__DIR__.'/Annotation/DoctrineAnnotations.php');
216 216
 
217 217
         $reader = new CachedReader(new AnnotationReader(), new ArrayCache());
218 218
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Hydration/ObjectHydratorTest.php 3 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,6 @@
 block discarded – undo
29 29
 use Doctrine\Tests\Models\Hydration\SimpleEntity;
30 30
 use ProxyManager\Configuration;
31 31
 use ProxyManager\Factory\LazyLoadingGhostFactory;
32
-use ProxyManager\Proxy\GhostObjectInterface;
33 32
 
34 33
 class ObjectHydratorTest extends HydrationTestCase
35 34
 {
Please login to merge, or discard this patch.
Indentation   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -1921,10 +1921,10 @@  discard block
 block discarded – undo
1921 1921
         $rsm->setDiscriminatorColumn('c', 'c_discr');
1922 1922
 
1923 1923
         $resultSet = [
1924
-              [
1925
-                  'c__id'   => '1',
1926
-                  'c_discr' => 'fix',
1927
-              ],
1924
+                [
1925
+                    'c__id'   => '1',
1926
+                    'c_discr' => 'fix',
1927
+                ],
1928 1928
         ];
1929 1929
 
1930 1930
         $stmt     = new HydratorMockStatement($resultSet);
@@ -1953,12 +1953,12 @@  discard block
 block discarded – undo
1953 1953
         $rsm->setDiscriminatorColumn('e', 'e_discr');
1954 1954
 
1955 1955
         $resultSet = [
1956
-              [
1957
-                  'c__id'   => '1',
1958
-                  'c_discr' => 'fix',
1959
-                  'e__id'   => '1',
1960
-                  'e__name' => 'Fabio B. Silva'
1961
-              ],
1956
+                [
1957
+                    'c__id'   => '1',
1958
+                    'c_discr' => 'fix',
1959
+                    'e__id'   => '1',
1960
+                    'e__name' => 'Fabio B. Silva'
1961
+                ],
1962 1962
         ];
1963 1963
 
1964 1964
         $stmt     = new HydratorMockStatement($resultSet);
@@ -1983,11 +1983,11 @@  discard block
 block discarded – undo
1983 1983
         $rsm->setDiscriminatorColumn('p', 'discr');
1984 1984
 
1985 1985
         $resultSet = [
1986
-              [
1987
-                  'p__id'   => '1',
1988
-                  'p__name' => 'Fabio B. Silva',
1989
-                  'discr'   => 'subworker'
1990
-              ],
1986
+                [
1987
+                    'p__id'   => '1',
1988
+                    'p__name' => 'Fabio B. Silva',
1989
+                    'discr'   => 'subworker'
1990
+                ],
1991 1991
         ];
1992 1992
 
1993 1993
         $stmt       = new HydratorMockStatement($resultSet);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Hydration;
6 6
 
@@ -1025,7 +1025,7 @@  discard block
 block discarded – undo
1025 1025
         ];
1026 1026
 
1027 1027
         $proxyInstance = (new LazyLoadingGhostFactory(new Configuration()))
1028
-            ->createProxy(ECommerceShipping::class, function () {
1028
+            ->createProxy(ECommerceShipping::class, function() {
1029 1029
                 self::fail('Proxy is not supposed to be lazy-loaded');
1030 1030
             });
1031 1031
 
@@ -1076,7 +1076,7 @@  discard block
 block discarded – undo
1076 1076
         ];
1077 1077
 
1078 1078
         $proxyInstance = (new LazyLoadingGhostFactory(new Configuration()))
1079
-            ->createProxy(ECommerceShipping::class, function () {
1079
+            ->createProxy(ECommerceShipping::class, function() {
1080 1080
                 self::fail('Proxy is not supposed to be lazy-loaded');
1081 1081
             });
1082 1082
 
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Proxy/Factory/StaticProxyFactory.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 
4
-declare(strict_types=1);
4
+declare(strict_types = 1);
5 5
 
6 6
 namespace Doctrine\ORM\Proxy\Factory;
7 7
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function generateProxyClasses(array $classes) : int
71 71
     {
72
-        $concreteClasses = \array_filter($classes, function (ClassMetadata $metadata) : bool {
72
+        $concreteClasses = \array_filter($classes, function(ClassMetadata $metadata) : bool {
73 73
             return ! ($metadata->isMappedSuperclass || $metadata->getReflectionClass()->isAbstract());
74 74
         });
75 75
 
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
                 ->proxyFactory
79 79
                 ->createProxy(
80 80
                     $metadata->getClassName(),
81
-                    function () {
81
+                    function() {
82 82
                         // empty closure, serves its purpose, for now
83 83
                     },
84 84
                     $this->skippedFieldsFqns($metadata)
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 
122 122
     private function makeInitializer(ClassMetadata $metadata, EntityPersister $persister) : \Closure
123 123
     {
124
-        return function (
124
+        return function(
125 125
             GhostObjectInterface $ghostObject,
126 126
             string $method, // we don't care
127 127
             array $parameters, // we don't care
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
             $identifier = $persister->getIdentifier($ghostObject);
135 135
 
136 136
             // @TODO how do we use `$properties` in the persister? That would be a massive optimisation
137
-            if (! $persister->loadById($identifier, $ghostObject)) {
137
+            if ( ! $persister->loadById($identifier, $ghostObject)) {
138 138
                 $initializer = $originalInitializer;
139 139
 
140 140
                 throw EntityNotFoundException::fromClassNameAndIdentifier(
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
         $transientFieldsFqns = [];
161 161
 
162 162
         foreach ($metadata->getDeclaredPropertiesIterator() as $name => $property) {
163
-            if (! $property instanceof TransientMetadata) {
163
+            if ( ! $property instanceof TransientMetadata) {
164 164
                 continue;
165 165
             }
166 166
 
@@ -195,11 +195,11 @@  discard block
 block discarded – undo
195 195
     private function propertyFqcn(\ReflectionProperty $property) : string
196 196
     {
197 197
         if ($property->isPrivate()) {
198
-            return "\0" . $property->getDeclaringClass()->getName() . "\0" . $property->getName();
198
+            return "\0".$property->getDeclaringClass()->getName()."\0".$property->getName();
199 199
         }
200 200
 
201 201
         if ($property->isProtected()) {
202
-            return "\0*\0" . $property->getName();
202
+            return "\0*\0".$property->getName();
203 203
         }
204 204
 
205 205
         return $property->getName();
Please login to merge, or discard this patch.