Completed
Pull Request — master (#5938)
by Maximilian
16:49 queued 08:43
created
lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -707,13 +707,13 @@
 block discarded – undo
707 707
         return $joinColumn;
708 708
     }
709 709
 
710
-     /**
711
-     * Parses the given field as array.
712
-     *
713
-     * @param SimpleXMLElement $fieldMapping
714
-     *
715
-     * @return array
716
-     */
710
+        /**
711
+         * Parses the given field as array.
712
+         *
713
+         * @param SimpleXMLElement $fieldMapping
714
+         *
715
+         * @return array
716
+         */
717 717
     private function columnToArray(SimpleXMLElement $fieldMapping)
718 718
     {
719 719
         $mapping = array(
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 
158 158
         if (isset($xmlRoot['inheritance-type'])) {
159 159
             $inheritanceType = (string) $xmlRoot['inheritance-type'];
160
-            $metadata->setInheritanceType(constant('Doctrine\ORM\Mapping\ClassMetadata::INHERITANCE_TYPE_' . $inheritanceType));
160
+            $metadata->setInheritanceType(constant('Doctrine\ORM\Mapping\ClassMetadata::INHERITANCE_TYPE_'.$inheritanceType));
161 161
 
162 162
             if ($metadata->inheritanceType != \Doctrine\ORM\Mapping\ClassMetadata::INHERITANCE_TYPE_NONE) {
163 163
                 // Evaluate <discriminator-column...>
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
                 }
355 355
 
356 356
                 if (isset($oneToOneElement['fetch'])) {
357
-                    $mapping['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . (string) $oneToOneElement['fetch']);
357
+                    $mapping['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_'.(string) $oneToOneElement['fetch']);
358 358
                 }
359 359
 
360 360
                 if (isset($oneToOneElement['mapped-by'])) {
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
                 );
404 404
 
405 405
                 if (isset($oneToManyElement['fetch'])) {
406
-                    $mapping['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . (string) $oneToManyElement['fetch']);
406
+                    $mapping['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_'.(string) $oneToManyElement['fetch']);
407 407
                 }
408 408
 
409 409
                 if (isset($oneToManyElement->cascade)) {
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
                 }
451 451
 
452 452
                 if (isset($manyToOneElement['fetch'])) {
453
-                    $mapping['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . (string) $manyToOneElement['fetch']);
453
+                    $mapping['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_'.(string) $manyToOneElement['fetch']);
454 454
                 }
455 455
 
456 456
                 if (isset($manyToOneElement['inversed-by'])) {
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
                 );
493 493
 
494 494
                 if (isset($manyToManyElement['fetch'])) {
495
-                    $mapping['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . (string) $manyToManyElement['fetch']);
495
+                    $mapping['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_'.(string) $manyToManyElement['fetch']);
496 496
                 }
497 497
 
498 498
                 if (isset($manyToManyElement['orphan-removal'])) {
@@ -617,7 +617,7 @@  discard block
 block discarded – undo
617 617
         // Evaluate <lifecycle-callbacks...>
618 618
         if (isset($xmlRoot->{'lifecycle-callbacks'})) {
619 619
             foreach ($xmlRoot->{'lifecycle-callbacks'}->{'lifecycle-callback'} as $lifecycleCallback) {
620
-                $metadata->addLifecycleCallback((string) $lifecycleCallback['method'], constant('Doctrine\ORM\Events::' . (string) $lifecycleCallback['type']));
620
+                $metadata->addLifecycleCallback((string) $lifecycleCallback['method'], constant('Doctrine\ORM\Events::'.(string) $lifecycleCallback['type']));
621 621
             }
622 622
         }
623 623
 
@@ -775,12 +775,12 @@  discard block
 block discarded – undo
775 775
         $region = isset($cacheMapping['region']) ? (string) $cacheMapping['region'] : null;
776 776
         $usage  = isset($cacheMapping['usage']) ? strtoupper($cacheMapping['usage']) : null;
777 777
 
778
-        if ($usage && ! defined('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_' . $usage)) {
778
+        if ($usage && ! defined('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_'.$usage)) {
779 779
             throw new \InvalidArgumentException(sprintf('Invalid cache usage "%s"', $usage));
780 780
         }
781 781
 
782 782
         if ($usage) {
783
-            $usage = constant('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_' . $usage);
783
+            $usage = constant('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_'.$usage);
784 784
         }
785 785
 
786 786
         return array(
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
         $this->reverseEngineerMappingFromDatabase();
176 176
 
177 177
         if ( ! isset($this->classToTableNames[$className])) {
178
-            throw new \InvalidArgumentException("Unknown class " . $className);
178
+            throw new \InvalidArgumentException("Unknown class ".$className);
179 179
         }
180 180
 
181 181
         $tableName = $this->classToTableNames[$className];
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
 
287 287
             if ( ! $table->hasPrimaryKey()) {
288 288
                 throw new MappingException(
289
-                    "Table " . $table->getName() . " has no primary key. Doctrine does not ".
289
+                    "Table ".$table->getName()." has no primary key. Doctrine does not ".
290 290
                     "support reverse engineering from tables that don't have a primary key."
291 291
                 );
292 292
             }
@@ -407,7 +407,7 @@  discard block
 block discarded – undo
407 407
             case Type::STRING:
408 408
             case Type::TEXT:
409 409
                 $fieldMapping['length'] = $column->getLength();
410
-                $fieldMapping['options']['fixed']  = $column->getFixed();
410
+                $fieldMapping['options']['fixed'] = $column->getFixed();
411 411
                 break;
412 412
 
413 413
             case Type::DECIMAL:
@@ -523,10 +523,10 @@  discard block
 block discarded – undo
523 523
     private function getClassNameForTable($tableName)
524 524
     {
525 525
         if (isset($this->classNamesForTables[$tableName])) {
526
-            return $this->namespace . $this->classNamesForTables[$tableName];
526
+            return $this->namespace.$this->classNamesForTables[$tableName];
527 527
         }
528 528
 
529
-        return $this->namespace . Inflector::classify(strtolower($tableName));
529
+        return $this->namespace.Inflector::classify(strtolower($tableName));
530 530
     }
531 531
 
532 532
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
             $cacheAnnot = $classAnnotations['Doctrine\ORM\Mapping\Cache'];
151 151
             $cacheMap   = array(
152 152
                 'region' => $cacheAnnot->region,
153
-                'usage'  => constant('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_' . $cacheAnnot->usage),
153
+                'usage'  => constant('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_'.$cacheAnnot->usage),
154 154
             );
155 155
 
156 156
             $metadata->enableCache($cacheMap);
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
             $inheritanceTypeAnnot = $classAnnotations['Doctrine\ORM\Mapping\InheritanceType'];
233 233
 
234 234
             $metadata->setInheritanceType(
235
-                constant('Doctrine\ORM\Mapping\ClassMetadata::INHERITANCE_TYPE_' . $inheritanceTypeAnnot->value)
235
+                constant('Doctrine\ORM\Mapping\ClassMetadata::INHERITANCE_TYPE_'.$inheritanceTypeAnnot->value)
236 236
             );
237 237
 
238 238
             if ($metadata->inheritanceType != \Doctrine\ORM\Mapping\ClassMetadata::INHERITANCE_TYPE_NONE) {
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
         // Evaluate DoctrineChangeTrackingPolicy annotation
263 263
         if (isset($classAnnotations['Doctrine\ORM\Mapping\ChangeTrackingPolicy'])) {
264 264
             $changeTrackingAnnot = $classAnnotations['Doctrine\ORM\Mapping\ChangeTrackingPolicy'];
265
-            $metadata->setChangeTrackingPolicy(constant('Doctrine\ORM\Mapping\ClassMetadata::CHANGETRACKING_' . $changeTrackingAnnot->value));
265
+            $metadata->setChangeTrackingPolicy(constant('Doctrine\ORM\Mapping\ClassMetadata::CHANGETRACKING_'.$changeTrackingAnnot->value));
266 266
         }
267 267
 
268 268
         // Evaluate annotations on properties/fields
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
             // Evaluate @Cache annotation
285 285
             if (($cacheAnnot = $this->reader->getPropertyAnnotation($property, 'Doctrine\ORM\Mapping\Cache')) !== null) {
286 286
                 $mapping['cache'] = $metadata->getAssociationCacheDefaults($mapping['fieldName'], array(
287
-                        'usage'         => constant('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_' . $cacheAnnot->usage),
287
+                        'usage'         => constant('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_'.$cacheAnnot->usage),
288 288
                         'region'        => $cacheAnnot->region,
289 289
                 ));
290 290
             }
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
                 }
314 314
 
315 315
                 if ($generatedValueAnnot = $this->reader->getPropertyAnnotation($property, 'Doctrine\ORM\Mapping\GeneratedValue')) {
316
-                    $metadata->setIdGeneratorType(constant('Doctrine\ORM\Mapping\ClassMetadata::GENERATOR_TYPE_' . $generatedValueAnnot->strategy));
316
+                    $metadata->setIdGeneratorType(constant('Doctrine\ORM\Mapping\ClassMetadata::GENERATOR_TYPE_'.$generatedValueAnnot->strategy));
317 317
                 }
318 318
 
319 319
                 if ($this->reader->getPropertyAnnotation($property, 'Doctrine\ORM\Mapping\Version')) {
@@ -497,7 +497,7 @@  discard block
 block discarded – undo
497 497
                 }
498 498
 
499 499
                 // Evaluate the listener using naming convention.
500
-                if ( ! $hasMapping ) {
500
+                if ( ! $hasMapping) {
501 501
                     EntityListenerBuilder::bindEntityListener($metadata, $listenerClassName);
502 502
                 }
503 503
             }
@@ -526,11 +526,11 @@  discard block
 block discarded – undo
526 526
      */
527 527
     private function getFetchMode($className, $fetchMode)
528 528
     {
529
-        if ( ! defined('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . $fetchMode)) {
529
+        if ( ! defined('Doctrine\ORM\Mapping\ClassMetadata::FETCH_'.$fetchMode)) {
530 530
             throw MappingException::invalidFetchMode($className, $fetchMode);
531 531
         }
532 532
 
533
-        return constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . $fetchMode);
533
+        return constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_'.$fetchMode);
534 534
     }
535 535
 
536 536
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/MappingException.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
         $message = "The mapping of field '{$field}' is invalid: The option '{$expectedOption}' is required.";
285 285
 
286 286
         if ( ! empty($hint)) {
287
-            $message .= ' (Hint: ' . $hint . ')';
287
+            $message .= ' (Hint: '.$hint.')';
288 288
         }
289 289
 
290 290
         return new self($message);
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
      */
315 315
     public static function reflectionFailure($entity, \ReflectionException $previousException)
316 316
     {
317
-        return new self('An error occurred in ' . $entity, 0, $previousException);
317
+        return new self('An error occurred in '.$entity, 0, $previousException);
318 318
     }
319 319
 
320 320
     /**
@@ -325,8 +325,8 @@  discard block
 block discarded – undo
325 325
      */
326 326
     public static function joinColumnMustPointToMappedField($className, $joinColumn)
327 327
     {
328
-        return new self('The column ' . $joinColumn . ' must be mapped to a field in class '
329
-            . $className . ' since it is referenced by a join column of another class.');
328
+        return new self('The column '.$joinColumn.' must be mapped to a field in class '
329
+            . $className.' since it is referenced by a join column of another class.');
330 330
     }
331 331
 
332 332
     /**
@@ -446,12 +446,12 @@  discard block
 block discarded – undo
446 446
     public static function fileMappingDriversRequireConfiguredDirectoryPath($path = null)
447 447
     {
448 448
         if ( ! empty($path)) {
449
-            $path = '[' . $path . ']';
449
+            $path = '['.$path.']';
450 450
         }
451 451
 
452 452
         return new self(
453
-            'File mapping drivers must have a valid directory path, ' .
454
-            'however the given path ' . $path . ' seems to be incorrect!'
453
+            'File mapping drivers must have a valid directory path, '.
454
+            'however the given path '.$path.' seems to be incorrect!'
455 455
         );
456 456
     }
457 457
 
@@ -482,11 +482,11 @@  discard block
 block discarded – undo
482 482
     public static function duplicateDiscriminatorEntry($className, array $entries, array $map)
483 483
     {
484 484
         return new self(
485
-            "The entries " . implode(', ', $entries) . " in discriminator map of class '" . $className . "' is duplicated. " .
486
-            "If the discriminator map is automatically generated you have to convert it to an explicit discriminator map now. " .
487
-            "The entries of the current map are: @DiscriminatorMap({" . implode(', ', array_map(
485
+            "The entries ".implode(', ', $entries)." in discriminator map of class '".$className."' is duplicated. ".
486
+            "If the discriminator map is automatically generated you have to convert it to an explicit discriminator map now. ".
487
+            "The entries of the current map are: @DiscriminatorMap({".implode(', ', array_map(
488 488
                 function($a, $b) { return "'$a': '$b'"; }, array_keys($map), array_values($map)
489
-            )) . "})"
489
+            ))."})"
490 490
         );
491 491
     }
492 492
 
@@ -633,7 +633,7 @@  discard block
 block discarded – undo
633 633
     public static function illegalOrphanRemoval($className, $field)
634 634
     {
635 635
         return new self("Orphan removal is only allowed on one-to-one and one-to-many ".
636
-            "associations, but " . $className."#" .$field . " is not.");
636
+            "associations, but ".$className."#".$field." is not.");
637 637
     }
638 638
 
639 639
     /**
@@ -665,7 +665,7 @@  discard block
 block discarded – undo
665 665
      */
666 666
     public static function noInheritanceOnMappedSuperClass($className)
667 667
     {
668
-        return new self("It is not supported to define inheritance information on a mapped superclass '" . $className . "'.");
668
+        return new self("It is not supported to define inheritance information on a mapped superclass '".$className."'.");
669 669
     }
670 670
 
671 671
     /**
@@ -677,8 +677,8 @@  discard block
 block discarded – undo
677 677
     public static function mappedClassNotPartOfDiscriminatorMap($className, $rootClassName)
678 678
     {
679 679
         return new self(
680
-            "Entity '" . $className . "' has to be part of the discriminator map of '" . $rootClassName . "' " .
681
-            "to be properly mapped in the inheritance hierarchy. Alternatively you can make '".$className."' an abstract class " .
680
+            "Entity '".$className."' has to be part of the discriminator map of '".$rootClassName."' ".
681
+            "to be properly mapped in the inheritance hierarchy. Alternatively you can make '".$className."' an abstract class ".
682 682
             "to avoid this exception from occurring."
683 683
         );
684 684
     }
@@ -691,7 +691,7 @@  discard block
 block discarded – undo
691 691
      */
692 692
     public static function lifecycleCallbackMethodNotFound($className, $methodName)
693 693
     {
694
-        return new self("Entity '" . $className . "' has no method '" . $methodName . "' to be registered as lifecycle callback.");
694
+        return new self("Entity '".$className."' has no method '".$methodName."' to be registered as lifecycle callback.");
695 695
     }
696 696
 
697 697
     /**
@@ -737,7 +737,7 @@  discard block
 block discarded – undo
737 737
      */
738 738
     public static function invalidFetchMode($className, $annotation)
739 739
     {
740
-        return new self("Entity '" . $className . "' has a mapping with invalid fetch mode '" . $annotation . "'");
740
+        return new self("Entity '".$className."' has a mapping with invalid fetch mode '".$annotation."'");
741 741
     }
742 742
 
743 743
     /**
@@ -747,7 +747,7 @@  discard block
 block discarded – undo
747 747
      */
748 748
     public static function compositeKeyAssignedIdGeneratorRequired($className)
749 749
     {
750
-        return new self("Entity '". $className . "' has a composite identifier but uses an ID generator other than manually assigning (Identity, Sequence). This is not supported.");
750
+        return new self("Entity '".$className."' has a composite identifier but uses an ID generator other than manually assigning (Identity, Sequence). This is not supported.");
751 751
     }
752 752
 
753 753
     /**
@@ -759,7 +759,7 @@  discard block
 block discarded – undo
759 759
      */
760 760
     public static function invalidTargetEntityClass($targetEntity, $sourceEntity, $associationName)
761 761
     {
762
-        return new self("The target-entity " . $targetEntity . " cannot be found in '" . $sourceEntity."#".$associationName."'.");
762
+        return new self("The target-entity ".$targetEntity." cannot be found in '".$sourceEntity."#".$associationName."'.");
763 763
     }
764 764
 
765 765
     /**
@@ -771,7 +771,7 @@  discard block
 block discarded – undo
771 771
      */
772 772
     public static function invalidCascadeOption(array $cascades, $className, $propertyName)
773 773
     {
774
-        $cascades = implode(", ", array_map(function ($e) { return "'" . $e . "'"; }, $cascades));
774
+        $cascades = implode(", ", array_map(function($e) { return "'".$e."'"; }, $cascades));
775 775
 
776 776
         return new self(sprintf(
777 777
             "You have specified invalid cascade options for %s::$%s: %s; available options: 'remove', 'persist', 'refresh', 'merge', and 'detach'",
@@ -803,7 +803,7 @@  discard block
 block discarded – undo
803 803
     {
804 804
         return new self(
805 805
             sprintf(
806
-                'Infinite nesting detected for embedded property %s::%s. ' .
806
+                'Infinite nesting detected for embedded property %s::%s. '.
807 807
                 'You cannot embed an embeddable from the same type inside an embeddable.',
808 808
                 $className,
809 809
                 $propertyName
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/DefaultNamingStrategy.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
      */
72 72
     public function joinColumnName($propertyName, $className = null)
73 73
     {
74
-        return $propertyName . '_' . $this->referenceColumnName();
74
+        return $propertyName.'_'.$this->referenceColumnName();
75 75
     }
76 76
 
77 77
     /**
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
      */
80 80
     public function joinTableName($sourceEntity, $targetEntity, $propertyName = null)
81 81
     {
82
-        return strtolower($this->classToTableName($sourceEntity) . '_' .
82
+        return strtolower($this->classToTableName($sourceEntity).'_'.
83 83
             $this->classToTableName($targetEntity));
84 84
     }
85 85
 
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      */
89 89
     public function joinKeyColumnName($entityName, $referencedColumnName = null)
90 90
     {
91
-        return strtolower($this->classToTableName($entityName) . '_' .
91
+        return strtolower($this->classToTableName($entityName).'_'.
92 92
             ($referencedColumnName ?: $this->referenceColumnName()));
93 93
     }
94 94
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/DefaultQuoteStrategy.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -49,10 +49,10 @@  discard block
 block discarded – undo
49 49
         $tableName = $class->table['name'];
50 50
 
51 51
         if ( ! empty($class->table['schema'])) {
52
-            $tableName = $class->table['schema'] . '.' . $class->table['name'];
52
+            $tableName = $class->table['schema'].'.'.$class->table['name'];
53 53
 
54 54
             if ( ! $platform->supportsSchemas() && $platform->canEmulateSchemas()) {
55
-                $tableName = $class->table['schema'] . '__' . $class->table['name'];
55
+                $tableName = $class->table['schema'].'__'.$class->table['name'];
56 56
             }
57 57
         }
58 58
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
         $schema = '';
100 100
 
101 101
         if (isset($association['joinTable']['schema'])) {
102
-            $schema = $association['joinTable']['schema'] . '.';
102
+            $schema = $association['joinTable']['schema'].'.';
103 103
         }
104 104
 
105 105
         $tableName = $association['joinTable']['name'];
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
             $tableName = $platform->quoteIdentifier($tableName);
109 109
         }
110 110
 
111
-        return $schema . $tableName;
111
+        return $schema.$tableName;
112 112
     }
113 113
 
114 114
     /**
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
             // Association defined as Id field
129 129
             $joinColumns            = $class->associationMappings[$fieldName]['joinColumns'];
130 130
             $assocQuotedColumnNames = array_map(
131
-                function ($joinColumn) use ($platform)
131
+                function($joinColumn) use ($platform)
132 132
                 {
133 133
                     return isset($joinColumn['quoted'])
134 134
                         ? $platform->quoteIdentifier($joinColumn['name'])
@@ -153,10 +153,10 @@  discard block
 block discarded – undo
153 153
         //     If the alias is to long, characters are cut off from the beginning.
154 154
         // 3 ) Strip non alphanumeric characters
155 155
         // 4 ) Prefix with "_" if the result its numeric
156
-        $columnName = $columnName . '_' . $counter;
156
+        $columnName = $columnName.'_'.$counter;
157 157
         $columnName = substr($columnName, -$platform->getMaxIdentifierLength());
158 158
         $columnName = preg_replace('/[^A-Za-z0-9_]/', '', $columnName);
159
-        $columnName = is_numeric($columnName) ? '_' . $columnName : $columnName;
159
+        $columnName = is_numeric($columnName) ? '_'.$columnName : $columnName;
160 160
 
161 161
         return $platform->getSQLResultCasing($columnName);
162 162
     }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/Reflection/ReflectionPropertiesGetter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -155,9 +155,9 @@
 block discarded – undo
155 155
         }
156 156
 
157 157
         if ($property->isProtected()) {
158
-            return "\0*\0" . $propertyName;
158
+            return "\0*\0".$propertyName;
159 159
         }
160 160
 
161
-        return "\0" . $property->getDeclaringClass()->getName() . "\0" . $propertyName;
161
+        return "\0".$property->getDeclaringClass()->getName()."\0".$propertyName;
162 162
     }
163 163
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1431,7 +1431,7 @@
 block discarded – undo
1431 1431
 
1432 1432
         if (Type::hasType($mapping['type']) && Type::getType($mapping['type'])->canRequireSQLConversion()) {
1433 1433
             if (isset($mapping['id']) && $mapping['id'] === true) {
1434
-                 throw MappingException::sqlConversionNotAllowedForIdentifiers($this->name, $mapping['fieldName'], $mapping['type']);
1434
+                    throw MappingException::sqlConversionNotAllowedForIdentifiers($this->name, $mapping['fieldName'], $mapping['type']);
1435 1435
             }
1436 1436
 
1437 1437
             $mapping['requireSQLConversion'] = true;
Please login to merge, or discard this patch.
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -667,7 +667,7 @@  discard block
 block discarded – undo
667 667
     /**
668 668
      * Gets the ReflectionProperties of the mapped class.
669 669
      *
670
-     * @return array An array of ReflectionProperty instances.
670
+     * @return \ReflectionProperty[] An array of ReflectionProperty instances.
671 671
      */
672 672
     public function getReflectionProperties()
673 673
     {
@@ -805,7 +805,7 @@  discard block
 block discarded – undo
805 805
      *      - reflClass (ReflectionClass)
806 806
      *      - reflFields (ReflectionProperty array)
807 807
      *
808
-     * @return array The names of all the fields that should be serialized.
808
+     * @return string[] The names of all the fields that should be serialized.
809 809
      */
810 810
     public function __sleep()
811 811
     {
@@ -1838,7 +1838,7 @@  discard block
 block discarded – undo
1838 1838
      * Sets the mapped identifier/primary key fields of this class.
1839 1839
      * Mainly used by the ClassMetadataFactory to assign inherited identifiers.
1840 1840
      *
1841
-     * @param array $identifier
1841
+     * @param string[] $identifier
1842 1842
      *
1843 1843
      * @return void
1844 1844
      */
@@ -1867,7 +1867,7 @@  discard block
 block discarded – undo
1867 1867
     /**
1868 1868
      * Gets an array containing all the column names.
1869 1869
      *
1870
-     * @param array|null $fieldNames
1870
+     * @param string[] $fieldNames
1871 1871
      *
1872 1872
      * @return array
1873 1873
      */
@@ -2085,7 +2085,7 @@  discard block
 block discarded – undo
2085 2085
     /**
2086 2086
      * Sets the mapped subclasses of this class.
2087 2087
      *
2088
-     * @param array $subclasses The names of all mapped subclasses.
2088
+     * @param string[] $subclasses The names of all mapped subclasses.
2089 2089
      *
2090 2090
      * @return void
2091 2091
      */
@@ -2101,7 +2101,7 @@  discard block
 block discarded – undo
2101 2101
      * Assumes that the class names in the passed array are in the order:
2102 2102
      * directParent -> directParentParent -> directParentParentParent ... -> root.
2103 2103
      *
2104
-     * @param array $classNames
2104
+     * @param string[] $classNames
2105 2105
      *
2106 2106
      * @return void
2107 2107
      */
@@ -2638,7 +2638,7 @@  discard block
 block discarded – undo
2638 2638
      * @deprecated Deprecated since version 2.4 in favor of \Doctrine\ORM\Event\ListenersInvoker
2639 2639
      *
2640 2640
      * @param string $lifecycleEvent The lifecycle event.
2641
-     * @param object $entity         The Entity on which the event occurred.
2641
+     * @param \Doctrine\Tests\ORM\Functional\Ticket\DDC1707Child $entity         The Entity on which the event occurred.
2642 2642
      *
2643 2643
      * @return void
2644 2644
      */
Please login to merge, or discard this patch.
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -696,7 +696,7 @@  discard block
 block discarded – undo
696 696
     public function getSingleIdReflectionProperty()
697 697
     {
698 698
         if ($this->isIdentifierComposite) {
699
-            throw new BadMethodCallException("Class " . $this->name . " has a composite identifier.");
699
+            throw new BadMethodCallException("Class ".$this->name." has a composite identifier.");
700 700
         }
701 701
 
702 702
         return $this->reflFields[$this->identifier[0]];
@@ -791,7 +791,7 @@  discard block
 block discarded – undo
791 791
      */
792 792
     public function __toString()
793 793
     {
794
-        return __CLASS__ . '@' . spl_object_hash($this);
794
+        return __CLASS__.'@'.spl_object_hash($this);
795 795
     }
796 796
 
797 797
     /**
@@ -1025,7 +1025,7 @@  discard block
 block discarded – undo
1025 1025
     public function validateAssociations()
1026 1026
     {
1027 1027
         foreach ($this->associationMappings as $mapping) {
1028
-            if ( ! ClassLoader::classExists($mapping['targetEntity']) ) {
1028
+            if ( ! ClassLoader::classExists($mapping['targetEntity'])) {
1029 1029
                 throw MappingException::invalidTargetEntityClass($mapping['targetEntity'], $this->name, $mapping['fieldName']);
1030 1030
             }
1031 1031
         }
@@ -1085,7 +1085,7 @@  discard block
 block discarded – undo
1085 1085
      */
1086 1086
     public function enableAssociationCache($fieldName, array $cache)
1087 1087
     {
1088
-        $this->associationMappings[$fieldName]['cache'] = $this->getAssociationCacheDefaults ($fieldName, $cache);
1088
+        $this->associationMappings[$fieldName]['cache'] = $this->getAssociationCacheDefaults($fieldName, $cache);
1089 1089
     }
1090 1090
 
1091 1091
     /**
@@ -1103,7 +1103,7 @@  discard block
 block discarded – undo
1103 1103
         }
1104 1104
 
1105 1105
         if ( ! isset($cache['region'])) {
1106
-            $cache['region'] = strtolower(str_replace('\\', '_', $this->rootEntityName)) . '__' . $fieldName;
1106
+            $cache['region'] = strtolower(str_replace('\\', '_', $this->rootEntityName)).'__'.$fieldName;
1107 1107
         }
1108 1108
 
1109 1109
         return $cache;
@@ -1504,7 +1504,7 @@  discard block
 block discarded – undo
1504 1504
                 $this->isIdentifierComposite = true;
1505 1505
             }
1506 1506
 
1507
-            if ($this->cache && !isset($mapping['cache'])) {
1507
+            if ($this->cache && ! isset($mapping['cache'])) {
1508 1508
                 throw CacheException::nonCacheableEntityAssociation($this->name, $mapping['fieldName']);
1509 1509
             }
1510 1510
         }
@@ -1635,7 +1635,7 @@  discard block
 block discarded – undo
1635 1635
                     throw new RuntimeException("ClassMetadataInfo::setTable() has to be called before defining a one to one relationship.");
1636 1636
                 }
1637 1637
 
1638
-                $this->table['uniqueConstraints'][$mapping['fieldName'] . "_uniq"] = array(
1638
+                $this->table['uniqueConstraints'][$mapping['fieldName']."_uniq"] = array(
1639 1639
                     'columns' => $uniqueConstraintColumns
1640 1640
                 );
1641 1641
             }
@@ -1650,7 +1650,7 @@  discard block
 block discarded – undo
1650 1650
             unset($mapping['unique']);
1651 1651
         }
1652 1652
 
1653
-        if (isset($mapping['id']) && $mapping['id'] === true && !$mapping['isOwningSide']) {
1653
+        if (isset($mapping['id']) && $mapping['id'] === true && ! $mapping['isOwningSide']) {
1654 1654
             throw MappingException::illegalInverseIdentifierAssociation($this->name, $mapping['fieldName']);
1655 1655
         }
1656 1656
 
@@ -1704,7 +1704,7 @@  discard block
 block discarded – undo
1704 1704
             }
1705 1705
 
1706 1706
             $selfReferencingEntityWithoutJoinColumns = $mapping['sourceEntity'] == $mapping['targetEntity']
1707
-                && (! (isset($mapping['joinTable']['joinColumns']) || isset($mapping['joinTable']['inverseJoinColumns'])));
1707
+                && ( ! (isset($mapping['joinTable']['joinColumns']) || isset($mapping['joinTable']['inverseJoinColumns'])));
1708 1708
 
1709 1709
             if ( ! isset($mapping['joinTable']['joinColumns'])) {
1710 1710
                 $mapping['joinTable']['joinColumns'] = array(
@@ -1893,7 +1893,7 @@  discard block
 block discarded – undo
1893 1893
 
1894 1894
             // Association defined as Id field
1895 1895
             $joinColumns      = $this->associationMappings[$idProperty]['joinColumns'];
1896
-            $assocColumnNames = array_map(function ($joinColumn) { return $joinColumn['name']; }, $joinColumns);
1896
+            $assocColumnNames = array_map(function($joinColumn) { return $joinColumn['name']; }, $joinColumns);
1897 1897
 
1898 1898
             $columnNames = array_merge($columnNames, $assocColumnNames);
1899 1899
         }
@@ -2074,7 +2074,7 @@  discard block
 block discarded – undo
2074 2074
     public function getTemporaryIdTableName()
2075 2075
     {
2076 2076
         // replace dots with underscores because PostgreSQL creates temporary tables in a special schema
2077
-        return str_replace('.', '_', $this->getTableName() . '_id_tmp');
2077
+        return str_replace('.', '_', $this->getTableName().'_id_tmp');
2078 2078
     }
2079 2079
 
2080 2080
     /**
@@ -2403,7 +2403,7 @@  discard block
 block discarded – undo
2403 2403
      */
2404 2404
     public function addNamedQuery(array $queryMapping)
2405 2405
     {
2406
-        if (!isset($queryMapping['name'])) {
2406
+        if ( ! isset($queryMapping['name'])) {
2407 2407
             throw MappingException::nameIsMandatoryForQueryMapping($this->name);
2408 2408
         }
2409 2409
 
@@ -2411,7 +2411,7 @@  discard block
 block discarded – undo
2411 2411
             throw MappingException::duplicateQueryMapping($this->name, $queryMapping['name']);
2412 2412
         }
2413 2413
 
2414
-        if (!isset($queryMapping['query'])) {
2414
+        if ( ! isset($queryMapping['query'])) {
2415 2415
             throw MappingException::emptyQueryMapping($this->name, $queryMapping['name']);
2416 2416
         }
2417 2417
 
@@ -2438,7 +2438,7 @@  discard block
 block discarded – undo
2438 2438
      */
2439 2439
     public function addNamedNativeQuery(array $queryMapping)
2440 2440
     {
2441
-        if (!isset($queryMapping['name'])) {
2441
+        if ( ! isset($queryMapping['name'])) {
2442 2442
             throw MappingException::nameIsMandatoryForQueryMapping($this->name);
2443 2443
         }
2444 2444
 
@@ -2446,11 +2446,11 @@  discard block
 block discarded – undo
2446 2446
             throw MappingException::duplicateQueryMapping($this->name, $queryMapping['name']);
2447 2447
         }
2448 2448
 
2449
-        if (!isset($queryMapping['query'])) {
2449
+        if ( ! isset($queryMapping['query'])) {
2450 2450
             throw MappingException::emptyQueryMapping($this->name, $queryMapping['name']);
2451 2451
         }
2452 2452
 
2453
-        if (!isset($queryMapping['resultClass']) && !isset($queryMapping['resultSetMapping'])) {
2453
+        if ( ! isset($queryMapping['resultClass']) && ! isset($queryMapping['resultSetMapping'])) {
2454 2454
             throw MappingException::missingQueryMapping($this->name, $queryMapping['name']);
2455 2455
         }
2456 2456
 
@@ -2482,7 +2482,7 @@  discard block
 block discarded – undo
2482 2482
      */
2483 2483
     public function addSqlResultSetMapping(array $resultMapping)
2484 2484
     {
2485
-        if (!isset($resultMapping['name'])) {
2485
+        if ( ! isset($resultMapping['name'])) {
2486 2486
             throw MappingException::nameIsMandatoryForSqlResultSetMapping($this->name);
2487 2487
         }
2488 2488
 
@@ -2492,7 +2492,7 @@  discard block
 block discarded – undo
2492 2492
 
2493 2493
         if (isset($resultMapping['entities'])) {
2494 2494
             foreach ($resultMapping['entities'] as $key => $entityResult) {
2495
-                if (!isset($entityResult['entityClass'])) {
2495
+                if ( ! isset($entityResult['entityClass'])) {
2496 2496
                     throw MappingException::missingResultSetMappingEntity($this->name, $resultMapping['name']);
2497 2497
                 }
2498 2498
 
@@ -2511,11 +2511,11 @@  discard block
 block discarded – undo
2511 2511
 
2512 2512
                 if (isset($entityResult['fields'])) {
2513 2513
                     foreach ($entityResult['fields'] as $k => $field) {
2514
-                        if (!isset($field['name'])) {
2514
+                        if ( ! isset($field['name'])) {
2515 2515
                             throw MappingException::missingResultSetMappingFieldName($this->name, $resultMapping['name']);
2516 2516
                         }
2517 2517
 
2518
-                        if (!isset($field['column'])) {
2518
+                        if ( ! isset($field['column'])) {
2519 2519
                             $fieldName = $field['name'];
2520 2520
                             if (strpos($fieldName, '.')) {
2521 2521
                                 list(, $fieldName) = explode('.', $fieldName);
@@ -3006,7 +3006,7 @@  discard block
 block discarded – undo
3006 3006
         }
3007 3007
 
3008 3008
         if ($definition['sequenceName'][0] == '`') {
3009
-            $definition['sequenceName']   = trim($definition['sequenceName'], '`');
3009
+            $definition['sequenceName'] = trim($definition['sequenceName'], '`');
3010 3010
             $definition['quoted'] = true;
3011 3011
         }
3012 3012
 
@@ -3098,7 +3098,7 @@  discard block
 block discarded – undo
3098 3098
     public function getAssociationTargetClass($assocName)
3099 3099
     {
3100 3100
         if ( ! isset($this->associationMappings[$assocName])) {
3101
-            throw new InvalidArgumentException("Association name expected, '" . $assocName ."' is not an association.");
3101
+            throw new InvalidArgumentException("Association name expected, '".$assocName."' is not an association.");
3102 3102
         }
3103 3103
 
3104 3104
         return $this->associationMappings[$assocName]['targetEntity'];
@@ -3137,7 +3137,7 @@  discard block
 block discarded – undo
3137 3137
             // Association defined as Id field
3138 3138
             $joinColumns            = $this->associationMappings[$idProperty]['joinColumns'];
3139 3139
             $assocQuotedColumnNames = array_map(
3140
-                function ($joinColumn) use ($platform) {
3140
+                function($joinColumn) use ($platform) {
3141 3141
                     return isset($joinColumn['quoted'])
3142 3142
                         ? $platform->quoteIdentifier($joinColumn['name'])
3143 3143
                         : $joinColumn['name'];
@@ -3248,7 +3248,7 @@  discard block
 block discarded – undo
3248 3248
         }
3249 3249
 
3250 3250
         if ($className !== null && strpos($className, '\\') === false && strlen($this->namespace) > 0) {
3251
-            return $this->namespace . '\\' . $className;
3251
+            return $this->namespace.'\\'.$className;
3252 3252
         }
3253 3253
 
3254 3254
         return $className;
@@ -3302,15 +3302,15 @@  discard block
 block discarded – undo
3302 3302
                 ? $fieldMapping['originalClass']
3303 3303
                 : $embeddable->name;
3304 3304
             $fieldMapping['declaredField'] = isset($fieldMapping['declaredField'])
3305
-                ? $property . '.' . $fieldMapping['declaredField']
3305
+                ? $property.'.'.$fieldMapping['declaredField']
3306 3306
                 : $property;
3307 3307
             $fieldMapping['originalField'] = isset($fieldMapping['originalField'])
3308 3308
                 ? $fieldMapping['originalField']
3309 3309
                 : $fieldMapping['fieldName'];
3310
-            $fieldMapping['fieldName'] = $property . "." . $fieldMapping['fieldName'];
3310
+            $fieldMapping['fieldName'] = $property.".".$fieldMapping['fieldName'];
3311 3311
 
3312
-            if (! empty($this->embeddedClasses[$property]['columnPrefix'])) {
3313
-                $fieldMapping['columnName'] = $this->embeddedClasses[$property]['columnPrefix'] . $fieldMapping['columnName'];
3312
+            if ( ! empty($this->embeddedClasses[$property]['columnPrefix'])) {
3313
+                $fieldMapping['columnName'] = $this->embeddedClasses[$property]['columnPrefix'].$fieldMapping['columnName'];
3314 3314
             } elseif ($this->embeddedClasses[$property]['columnPrefix'] !== false) {
3315 3315
                 $fieldMapping['columnName'] = $this->namingStrategy
3316 3316
                     ->embeddedFieldToColumnName(
@@ -3351,7 +3351,7 @@  discard block
 block discarded – undo
3351 3351
     {
3352 3352
         $sequencePrefix = $this->getSequencePrefix($platform);
3353 3353
         $columnName     = $this->getSingleIdentifierColumnName();
3354
-        $sequenceName   = $sequencePrefix . '_' . $columnName . '_seq';
3354
+        $sequenceName   = $sequencePrefix.'_'.$columnName.'_seq';
3355 3355
 
3356 3356
         return $sequenceName;
3357 3357
     }
@@ -3371,10 +3371,10 @@  discard block
 block discarded – undo
3371 3371
 
3372 3372
         // Prepend the schema name to the table name if there is one
3373 3373
         if ($schemaName = $this->getSchemaName()) {
3374
-            $sequencePrefix = $schemaName . '.' . $tableName;
3374
+            $sequencePrefix = $schemaName.'.'.$tableName;
3375 3375
 
3376 3376
             if ( ! $platform->supportsSchemas() && $platform->canEmulateSchemas()) {
3377
-                $sequencePrefix = $schemaName . '__' . $tableName;
3377
+                $sequencePrefix = $schemaName.'__'.$tableName;
3378 3378
             }
3379 3379
         }
3380 3380
 
@@ -3386,8 +3386,8 @@  discard block
 block discarded – undo
3386 3386
      */
3387 3387
     private function assertMappingOrderBy(array $mapping)
3388 3388
     {
3389
-        if (isset($mapping['orderBy']) && !is_array($mapping['orderBy'])) {
3390
-            throw new InvalidArgumentException("'orderBy' is expected to be an array, not " . gettype($mapping['orderBy']));
3389
+        if (isset($mapping['orderBy']) && ! is_array($mapping['orderBy'])) {
3390
+            throw new InvalidArgumentException("'orderBy' is expected to be an array, not ".gettype($mapping['orderBy']));
3391 3391
         }
3392 3392
     }
3393 3393
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/Builder/FieldBuilder.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@
 block discarded – undo
275 275
     {
276 276
         $cm = $this->builder->getClassMetadata();
277 277
         if ($this->generatedValue) {
278
-            $cm->setIdGeneratorType(constant('Doctrine\ORM\Mapping\ClassMetadata::GENERATOR_TYPE_' . $this->generatedValue));
278
+            $cm->setIdGeneratorType(constant('Doctrine\ORM\Mapping\ClassMetadata::GENERATOR_TYPE_'.$this->generatedValue));
279 279
         }
280 280
 
281 281
         if ($this->version) {
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -180,7 +180,7 @@
 block discarded – undo
180 180
      * Sets an option.
181 181
      *
182 182
      * @param string $name
183
-     * @param mixed  $value
183
+     * @param boolean  $value
184 184
      *
185 185
      * @return FieldBuilder
186 186
      */
Please login to merge, or discard this patch.