Completed
Pull Request — 2.6 (#8015)
by
unknown
06:46
created
lib/Doctrine/ORM/Tools/Console/Command/ConvertDoctrine1SchemaCommand.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -220,7 +220,7 @@
 block discarded – undo
220 220
             $exporter->setMetadata($metadata);
221 221
             $exporter->export();
222 222
 
223
-            $output->writeln(PHP_EOL . sprintf(
223
+            $output->writeln(PHP_EOL.sprintf(
224 224
                 'Converting Doctrine 1.X schema to "<info>%s</info>" mapping type in "<info>%s</info>"', $toType, $destPath
225 225
             ));
226 226
         } else {
Please login to merge, or discard this patch.
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -100,15 +100,15 @@
 block discarded – undo
100 100
     protected function configure()
101 101
     {
102 102
         $this->setName('orm:convert-d1-schema')
103
-             ->setAliases(['orm:convert:d1-schema'])
104
-             ->setDescription('Converts Doctrine 1.x schema into a Doctrine 2.x schema')
105
-             ->addArgument('from-path', InputArgument::REQUIRED, 'The path of Doctrine 1.X schema information.')
106
-             ->addArgument('to-type', InputArgument::REQUIRED, 'The destination Doctrine 2.X mapping type.')
107
-             ->addArgument('dest-path', InputArgument::REQUIRED, 'The path to generate your Doctrine 2.X mapping information.')
108
-             ->addOption('from', null, InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY, 'Optional paths of Doctrine 1.X schema information.', [])
109
-             ->addOption('extend', null, InputOption::VALUE_OPTIONAL, 'Defines a base class to be extended by generated entity classes.')
110
-             ->addOption('num-spaces', null, InputOption::VALUE_OPTIONAL, 'Defines the number of indentation spaces', 4)
111
-             ->setHelp('Converts Doctrine 1.x schema into a Doctrine 2.x schema.');
103
+                ->setAliases(['orm:convert:d1-schema'])
104
+                ->setDescription('Converts Doctrine 1.x schema into a Doctrine 2.x schema')
105
+                ->addArgument('from-path', InputArgument::REQUIRED, 'The path of Doctrine 1.X schema information.')
106
+                ->addArgument('to-type', InputArgument::REQUIRED, 'The destination Doctrine 2.X mapping type.')
107
+                ->addArgument('dest-path', InputArgument::REQUIRED, 'The path to generate your Doctrine 2.X mapping information.')
108
+                ->addOption('from', null, InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY, 'Optional paths of Doctrine 1.X schema information.', [])
109
+                ->addOption('extend', null, InputOption::VALUE_OPTIONAL, 'Defines a base class to be extended by generated entity classes.')
110
+                ->addOption('num-spaces', null, InputOption::VALUE_OPTIONAL, 'Defines the number of indentation spaces', 4)
111
+                ->setHelp('Converts Doctrine 1.x schema into a Doctrine 2.x schema.');
112 112
     }
113 113
 
114 114
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Internal/Hydration/HydrationException.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -48,9 +48,9 @@
 block discarded – undo
48 48
      */
49 49
     public static function emptyDiscriminatorValue($dqlAlias)
50 50
     {
51
-        return new self("The DQL alias '" . $dqlAlias . "' contains an entity ".
52
-            "of an inheritance hierarchy with an empty discriminator value. This means " .
53
-            "that the database contains inconsistent data with an empty " .
51
+        return new self("The DQL alias '".$dqlAlias."' contains an entity ".
52
+            "of an inheritance hierarchy with an empty discriminator value. This means ".
53
+            "that the database contains inconsistent data with an empty ".
54 54
             "discriminator value in a table row."
55 55
         );
56 56
     }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Internal/Hydration/IterableResult.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,6 +105,6 @@
 block discarded – undo
105 105
      */
106 106
     public function valid()
107 107
     {
108
-        return ($this->_current!=false);
108
+        return ($this->_current != false);
109 109
     }
110 110
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Query.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -715,9 +715,9 @@
 block discarded – undo
715 715
         );
716 716
     }
717 717
 
718
-     /**
719
-     * {@inheritdoc}
720
-     */
718
+        /**
719
+         * {@inheritdoc}
720
+         */
721 721
     protected function getHash()
722 722
     {
723 723
         return sha1(parent::getHash(). '-'. $this->_firstResult . '-' . $this->_maxResults);
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     /**
43 43
      * A query object is in CLEAN state when it has NO unparsed/unprocessed DQL parts.
44 44
      */
45
-    const STATE_CLEAN  = 1;
45
+    const STATE_CLEAN = 1;
46 46
 
47 47
     /**
48 48
      * A query object is in state DIRTY when it has DQL parts that have not yet been
@@ -738,11 +738,11 @@  discard block
 block discarded – undo
738 738
             ->getName();
739 739
 
740 740
         return md5(
741
-            $this->getDQL() . serialize($this->_hints) .
742
-            '&platform=' . $platform .
743
-            ($this->_em->hasFilters() ? $this->_em->getFilters()->getHash() : '') .
744
-            '&firstResult=' . $this->_firstResult . '&maxResult=' . $this->_maxResults .
745
-            '&hydrationMode=' . $this->_hydrationMode . '&types=' . serialize($this->_parsedTypes) . 'DOCTRINE_QUERY_CACHE_SALT'
741
+            $this->getDQL().serialize($this->_hints).
742
+            '&platform='.$platform.
743
+            ($this->_em->hasFilters() ? $this->_em->getFilters()->getHash() : '').
744
+            '&firstResult='.$this->_firstResult.'&maxResult='.$this->_maxResults.
745
+            '&hydrationMode='.$this->_hydrationMode.'&types='.serialize($this->_parsedTypes).'DOCTRINE_QUERY_CACHE_SALT'
746 746
         );
747 747
     }
748 748
 
@@ -751,7 +751,7 @@  discard block
 block discarded – undo
751 751
      */
752 752
     protected function getHash()
753 753
     {
754
-        return sha1(parent::getHash(). '-'. $this->_firstResult . '-' . $this->_maxResults);
754
+        return sha1(parent::getHash().'-'.$this->_firstResult.'-'.$this->_maxResults);
755 755
     }
756 756
 
757 757
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/UnderscoreNamingStrategy.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function referenceColumnName()
102 102
     {
103
-        return $this->case === CASE_UPPER ?  'ID' : 'id';
103
+        return $this->case === CASE_UPPER ? 'ID' : 'id';
104 104
     }
105 105
 
106 106
     /**
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
      */
109 109
     public function joinColumnName($propertyName, $className = null)
110 110
     {
111
-        return $this->underscore($propertyName) . '_' . $this->referenceColumnName();
111
+        return $this->underscore($propertyName).'_'.$this->referenceColumnName();
112 112
     }
113 113
 
114 114
     /**
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      */
117 117
     public function joinTableName($sourceEntity, $targetEntity, $propertyName = null)
118 118
     {
119
-        return $this->classToTableName($sourceEntity) . '_' . $this->classToTableName($targetEntity);
119
+        return $this->classToTableName($sourceEntity).'_'.$this->classToTableName($targetEntity);
120 120
     }
121 121
     
122 122
     /**
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
      */
125 125
     public function joinKeyColumnName($entityName, $referencedColumnName = null)
126 126
     {
127
-        return $this->classToTableName($entityName) . '_' .
127
+        return $this->classToTableName($entityName).'_'.
128 128
                 ($referencedColumnName ?: $this->referenceColumnName());
129 129
     }
130 130
     
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/AnsiQuoteStrategy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,6 +91,6 @@
 block discarded – undo
91 91
      */
92 92
     public function getColumnAlias($columnName, $counter, AbstractPlatform $platform, ClassMetadata $class = null)
93 93
     {
94
-        return $platform->getSQLResultCasing($columnName . '_' . $counter);
94
+        return $platform->getSQLResultCasing($columnName.'_'.$counter);
95 95
     }
96 96
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
         $this->reverseEngineerMappingFromDatabase();
176 176
 
177 177
         if ( ! isset($this->classToTableNames[$className])) {
178
-            throw new \InvalidArgumentException("Unknown class " . $className);
178
+            throw new \InvalidArgumentException("Unknown class ".$className);
179 179
         }
180 180
 
181 181
         $tableName = $this->classToTableNames[$className];
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
 
287 287
             if ( ! $table->hasPrimaryKey()) {
288 288
                 throw new MappingException(
289
-                    "Table " . $table->getName() . " has no primary key. Doctrine does not ".
289
+                    "Table ".$table->getName()." has no primary key. Doctrine does not ".
290 290
                     "support reverse engineering from tables that don't have a primary key."
291 291
                 );
292 292
             }
@@ -407,7 +407,7 @@  discard block
 block discarded – undo
407 407
             case Type::STRING:
408 408
             case Type::TEXT:
409 409
                 $fieldMapping['length'] = $column->getLength();
410
-                $fieldMapping['options']['fixed']  = $column->getFixed();
410
+                $fieldMapping['options']['fixed'] = $column->getFixed();
411 411
                 break;
412 412
 
413 413
             case Type::DECIMAL:
@@ -523,10 +523,10 @@  discard block
 block discarded – undo
523 523
     private function getClassNameForTable($tableName)
524 524
     {
525 525
         if (isset($this->classNamesForTables[$tableName])) {
526
-            return $this->namespace . $this->classNamesForTables[$tableName];
526
+            return $this->namespace.$this->classNamesForTables[$tableName];
527 527
         }
528 528
 
529
-        return $this->namespace . Inflector::classify(strtolower($tableName));
529
+        return $this->namespace.Inflector::classify(strtolower($tableName));
530 530
     }
531 531
 
532 532
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/DefaultNamingStrategy.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
      */
72 72
     public function joinColumnName($propertyName, $className = null)
73 73
     {
74
-        return $propertyName . '_' . $this->referenceColumnName();
74
+        return $propertyName.'_'.$this->referenceColumnName();
75 75
     }
76 76
 
77 77
     /**
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
      */
80 80
     public function joinTableName($sourceEntity, $targetEntity, $propertyName = null)
81 81
     {
82
-        return strtolower($this->classToTableName($sourceEntity) . '_' .
82
+        return strtolower($this->classToTableName($sourceEntity).'_'.
83 83
             $this->classToTableName($targetEntity));
84 84
     }
85 85
 
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      */
89 89
     public function joinKeyColumnName($entityName, $referencedColumnName = null)
90 90
     {
91
-        return strtolower($this->classToTableName($entityName) . '_' .
91
+        return strtolower($this->classToTableName($entityName).'_'.
92 92
             ($referencedColumnName ?: $this->referenceColumnName()));
93 93
     }
94 94
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/DefaultQuoteStrategy.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -49,10 +49,10 @@  discard block
 block discarded – undo
49 49
         $tableName = $class->table['name'];
50 50
 
51 51
         if ( ! empty($class->table['schema'])) {
52
-            $tableName = $class->table['schema'] . '.' . $class->table['name'];
52
+            $tableName = $class->table['schema'].'.'.$class->table['name'];
53 53
 
54 54
             if ( ! $platform->supportsSchemas() && $platform->canEmulateSchemas()) {
55
-                $tableName = $class->table['schema'] . '__' . $class->table['name'];
55
+                $tableName = $class->table['schema'].'__'.$class->table['name'];
56 56
             }
57 57
         }
58 58
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
         $schema = '';
100 100
 
101 101
         if (isset($association['joinTable']['schema'])) {
102
-            $schema = $association['joinTable']['schema'] . '.';
102
+            $schema = $association['joinTable']['schema'].'.';
103 103
         }
104 104
 
105 105
         $tableName = $association['joinTable']['name'];
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
             $tableName = $platform->quoteIdentifier($tableName);
109 109
         }
110 110
 
111
-        return $schema . $tableName;
111
+        return $schema.$tableName;
112 112
     }
113 113
 
114 114
     /**
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
             // Association defined as Id field
129 129
             $joinColumns            = $class->associationMappings[$fieldName]['joinColumns'];
130 130
             $assocQuotedColumnNames = array_map(
131
-                function ($joinColumn) use ($platform)
131
+                function($joinColumn) use ($platform)
132 132
                 {
133 133
                     return isset($joinColumn['quoted'])
134 134
                         ? $platform->quoteIdentifier($joinColumn['name'])
@@ -153,10 +153,10 @@  discard block
 block discarded – undo
153 153
         //     If the alias is to long, characters are cut off from the beginning.
154 154
         // 3 ) Strip non alphanumeric characters
155 155
         // 4 ) Prefix with "_" if the result its numeric
156
-        $columnName = $columnName . '_' . $counter;
156
+        $columnName = $columnName.'_'.$counter;
157 157
         $columnName = substr($columnName, -$platform->getMaxIdentifierLength());
158 158
         $columnName = preg_replace('/[^A-Za-z0-9_]/', '', $columnName);
159
-        $columnName = is_numeric($columnName) ? '_' . $columnName : $columnName;
159
+        $columnName = is_numeric($columnName) ? '_'.$columnName : $columnName;
160 160
 
161 161
         return $platform->getSQLResultCasing($columnName);
162 162
     }
Please login to merge, or discard this patch.