Failed Conditions
Pull Request — 2.6 (#7235)
by Aleksey
10:51
created
lib/Doctrine/ORM/Query/QueryExpressionVisitor.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
             $expressionList[] = $this->dispatch($child);
115 115
         }
116 116
 
117
-        switch($expr->getType()) {
117
+        switch ($expr->getType()) {
118 118
             case CompositeExpression::TYPE_AND:
119 119
                 return new Expr\Andx($expressionList);
120 120
 
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
                 return new Expr\Orx($expressionList);
123 123
 
124 124
             default:
125
-                throw new \RuntimeException("Unknown composite " . $expr->getType());
125
+                throw new \RuntimeException("Unknown composite ".$expr->getType());
126 126
         }
127 127
     }
128 128
 
@@ -136,10 +136,10 @@  discard block
 block discarded – undo
136 136
             throw new QueryException('No aliases are set before invoking walkComparison().');
137 137
         }
138 138
 
139
-        $field = $this->queryAliases[0] . '.' . $comparison->getField();
139
+        $field = $this->queryAliases[0].'.'.$comparison->getField();
140 140
 
141
-        foreach($this->queryAliases as $alias) {
142
-            if(strpos($comparison->getField() . '.', $alias . '.') === 0) {
141
+        foreach ($this->queryAliases as $alias) {
142
+            if (strpos($comparison->getField().'.', $alias.'.') === 0) {
143 143
                 $field = $comparison->getField();
144 144
                 break;
145 145
             }
@@ -149,13 +149,13 @@  discard block
 block discarded – undo
149 149
 
150 150
         foreach ($this->parameters as $parameter) {
151 151
             if ($parameter->getName() === $parameterName) {
152
-                $parameterName .= '_' . count($this->parameters);
152
+                $parameterName .= '_'.count($this->parameters);
153 153
                 break;
154 154
             }
155 155
         }
156 156
 
157 157
         $parameter = new Parameter($parameterName, $this->walkValue($comparison->getValue()));
158
-        $placeholder = ':' . $parameterName;
158
+        $placeholder = ':'.$parameterName;
159 159
 
160 160
         switch ($comparison->getOperator()) {
161 161
             case Comparison::IN:
@@ -182,17 +182,17 @@  discard block
 block discarded – undo
182 182
 
183 183
                 return $this->expr->neq($field, $placeholder);
184 184
             case Comparison::CONTAINS:
185
-                $parameter->setValue('%' . $parameter->getValue() . '%', $parameter->getType());
185
+                $parameter->setValue('%'.$parameter->getValue().'%', $parameter->getType());
186 186
                 $this->parameters[] = $parameter;
187 187
 
188 188
                 return $this->expr->like($field, $placeholder);
189 189
             case Comparison::STARTS_WITH:
190
-                $parameter->setValue($parameter->getValue() . '%', $parameter->getType());
190
+                $parameter->setValue($parameter->getValue().'%', $parameter->getType());
191 191
                 $this->parameters[] = $parameter;
192 192
 
193 193
                 return $this->expr->like($field, $placeholder);
194 194
             case Comparison::ENDS_WITH:
195
-                $parameter->setValue('%' . $parameter->getValue(), $parameter->getType());
195
+                $parameter->setValue('%'.$parameter->getValue(), $parameter->getType());
196 196
                 $this->parameters[] = $parameter;
197 197
 
198 198
                 return $this->expr->like($field, $placeholder);
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
                     );
209 209
                 }
210 210
 
211
-                throw new \RuntimeException("Unknown comparison operator: " . $comparison->getOperator());
211
+                throw new \RuntimeException("Unknown comparison operator: ".$comparison->getOperator());
212 212
         }
213 213
     }
214 214
 
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/MappingException.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
         $message = "The mapping of field '{$field}' is invalid: The option '{$expectedOption}' is required.";
285 285
 
286 286
         if ( ! empty($hint)) {
287
-            $message .= ' (Hint: ' . $hint . ')';
287
+            $message .= ' (Hint: '.$hint.')';
288 288
         }
289 289
 
290 290
         return new self($message);
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
      */
315 315
     public static function reflectionFailure($entity, \ReflectionException $previousException)
316 316
     {
317
-        return new self('An error occurred in ' . $entity, 0, $previousException);
317
+        return new self('An error occurred in '.$entity, 0, $previousException);
318 318
     }
319 319
 
320 320
     /**
@@ -325,8 +325,8 @@  discard block
 block discarded – undo
325 325
      */
326 326
     public static function joinColumnMustPointToMappedField($className, $joinColumn)
327 327
     {
328
-        return new self('The column ' . $joinColumn . ' must be mapped to a field in class '
329
-            . $className . ' since it is referenced by a join column of another class.');
328
+        return new self('The column '.$joinColumn.' must be mapped to a field in class '
329
+            . $className.' since it is referenced by a join column of another class.');
330 330
     }
331 331
 
332 332
     /**
@@ -431,7 +431,7 @@  discard block
 block discarded – undo
431 431
      */
432 432
     public static function noIdDefined($entity)
433 433
     {
434
-        return new self('No ID defined for entity ' . $entity);
434
+        return new self('No ID defined for entity '.$entity);
435 435
     }
436 436
 
437 437
     /**
@@ -456,12 +456,12 @@  discard block
 block discarded – undo
456 456
     public static function fileMappingDriversRequireConfiguredDirectoryPath($path = null)
457 457
     {
458 458
         if ( ! empty($path)) {
459
-            $path = '[' . $path . ']';
459
+            $path = '['.$path.']';
460 460
         }
461 461
 
462 462
         return new self(
463
-            'File mapping drivers must have a valid directory path, ' .
464
-            'however the given path ' . $path . ' seems to be incorrect!'
463
+            'File mapping drivers must have a valid directory path, '.
464
+            'however the given path '.$path.' seems to be incorrect!'
465 465
         );
466 466
     }
467 467
 
@@ -492,11 +492,11 @@  discard block
 block discarded – undo
492 492
     public static function duplicateDiscriminatorEntry($className, array $entries, array $map)
493 493
     {
494 494
         return new self(
495
-            "The entries " . implode(', ', $entries) . " in discriminator map of class '" . $className . "' is duplicated. " .
496
-            "If the discriminator map is automatically generated you have to convert it to an explicit discriminator map now. " .
497
-            "The entries of the current map are: @DiscriminatorMap({" . implode(', ', array_map(
495
+            "The entries ".implode(', ', $entries)." in discriminator map of class '".$className."' is duplicated. ".
496
+            "If the discriminator map is automatically generated you have to convert it to an explicit discriminator map now. ".
497
+            "The entries of the current map are: @DiscriminatorMap({".implode(', ', array_map(
498 498
                 function($a, $b) { return "'$a': '$b'"; }, array_keys($map), array_values($map)
499
-            )) . "})"
499
+            ))."})"
500 500
         );
501 501
     }
502 502
 
@@ -643,7 +643,7 @@  discard block
 block discarded – undo
643 643
     public static function illegalOrphanRemoval($className, $field)
644 644
     {
645 645
         return new self("Orphan removal is only allowed on one-to-one and one-to-many ".
646
-            "associations, but " . $className."#" .$field . " is not.");
646
+            "associations, but ".$className."#".$field." is not.");
647 647
     }
648 648
 
649 649
     /**
@@ -675,7 +675,7 @@  discard block
 block discarded – undo
675 675
      */
676 676
     public static function noInheritanceOnMappedSuperClass($className)
677 677
     {
678
-        return new self("It is not supported to define inheritance information on a mapped superclass '" . $className . "'.");
678
+        return new self("It is not supported to define inheritance information on a mapped superclass '".$className."'.");
679 679
     }
680 680
 
681 681
     /**
@@ -687,8 +687,8 @@  discard block
 block discarded – undo
687 687
     public static function mappedClassNotPartOfDiscriminatorMap($className, $rootClassName)
688 688
     {
689 689
         return new self(
690
-            "Entity '" . $className . "' has to be part of the discriminator map of '" . $rootClassName . "' " .
691
-            "to be properly mapped in the inheritance hierarchy. Alternatively you can make '".$className."' an abstract class " .
690
+            "Entity '".$className."' has to be part of the discriminator map of '".$rootClassName."' ".
691
+            "to be properly mapped in the inheritance hierarchy. Alternatively you can make '".$className."' an abstract class ".
692 692
             "to avoid this exception from occurring."
693 693
         );
694 694
     }
@@ -701,7 +701,7 @@  discard block
 block discarded – undo
701 701
      */
702 702
     public static function lifecycleCallbackMethodNotFound($className, $methodName)
703 703
     {
704
-        return new self("Entity '" . $className . "' has no method '" . $methodName . "' to be registered as lifecycle callback.");
704
+        return new self("Entity '".$className."' has no method '".$methodName."' to be registered as lifecycle callback.");
705 705
     }
706 706
 
707 707
     /**
@@ -747,7 +747,7 @@  discard block
 block discarded – undo
747 747
      */
748 748
     public static function invalidFetchMode($className, $annotation)
749 749
     {
750
-        return new self("Entity '" . $className . "' has a mapping with invalid fetch mode '" . $annotation . "'");
750
+        return new self("Entity '".$className."' has a mapping with invalid fetch mode '".$annotation."'");
751 751
     }
752 752
 
753 753
     /**
@@ -757,7 +757,7 @@  discard block
 block discarded – undo
757 757
      */
758 758
     public static function compositeKeyAssignedIdGeneratorRequired($className)
759 759
     {
760
-        return new self("Entity '". $className . "' has a composite identifier but uses an ID generator other than manually assigning (Identity, Sequence). This is not supported.");
760
+        return new self("Entity '".$className."' has a composite identifier but uses an ID generator other than manually assigning (Identity, Sequence). This is not supported.");
761 761
     }
762 762
 
763 763
     /**
@@ -769,7 +769,7 @@  discard block
 block discarded – undo
769 769
      */
770 770
     public static function invalidTargetEntityClass($targetEntity, $sourceEntity, $associationName)
771 771
     {
772
-        return new self("The target-entity " . $targetEntity . " cannot be found in '" . $sourceEntity."#".$associationName."'.");
772
+        return new self("The target-entity ".$targetEntity." cannot be found in '".$sourceEntity."#".$associationName."'.");
773 773
     }
774 774
 
775 775
     /**
@@ -781,7 +781,7 @@  discard block
 block discarded – undo
781 781
      */
782 782
     public static function invalidCascadeOption(array $cascades, $className, $propertyName)
783 783
     {
784
-        $cascades = implode(", ", array_map(function ($e) { return "'" . $e . "'"; }, $cascades));
784
+        $cascades = implode(", ", array_map(function($e) { return "'".$e."'"; }, $cascades));
785 785
 
786 786
         return new self(sprintf(
787 787
             "You have specified invalid cascade options for %s::$%s: %s; available options: 'remove', 'persist', 'refresh', 'merge', and 'detach'",
@@ -813,7 +813,7 @@  discard block
 block discarded – undo
813 813
     {
814 814
         return new self(
815 815
             sprintf(
816
-                'Infinite nesting detected for embedded property %s::%s. ' .
816
+                'Infinite nesting detected for embedded property %s::%s. '.
817 817
                 'You cannot embed an embeddable from the same type inside an embeddable.',
818 818
                 $className,
819 819
                 $propertyName
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Persisters/Entity/AbstractEntityInheritancePersister.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
             $sql    = $type->convertToPHPValueSQL($sql, $this->platform);
77 77
         }
78 78
 
79
-        return $sql . ' AS ' . $columnAlias;
79
+        return $sql.' AS '.$columnAlias;
80 80
     }
81 81
 
82 82
     /**
@@ -94,6 +94,6 @@  discard block
 block discarded – undo
94 94
 
95 95
         $this->currentPersisterContext->rsm->addMetaResult('r', $columnAlias, $joinColumnName, false, $type);
96 96
 
97
-        return $tableAlias . '.' . $quotedColumnName . ' AS ' . $columnAlias;
97
+        return $tableAlias.'.'.$quotedColumnName.' AS '.$columnAlias;
98 98
     }
99 99
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/DefaultCacheFactory.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -215,12 +215,12 @@  discard block
 block discarded – undo
215 215
                 null === $this->fileLockRegionDirectory
216 216
             ) {
217 217
                 throw new \LogicException(
218
-                    'If you want to use a "READ_WRITE" cache an implementation of "Doctrine\ORM\Cache\ConcurrentRegion" is required, ' .
218
+                    'If you want to use a "READ_WRITE" cache an implementation of "Doctrine\ORM\Cache\ConcurrentRegion" is required, '.
219 219
                     'The default implementation provided by doctrine is "Doctrine\ORM\Cache\Region\FileLockRegion" if you want to use it please provide a valid directory, DefaultCacheFactory#setFileLockRegionDirectory(). '
220 220
                 );
221 221
             }
222 222
 
223
-            $directory = $this->fileLockRegionDirectory . DIRECTORY_SEPARATOR . $cache['region'];
223
+            $directory = $this->fileLockRegionDirectory.DIRECTORY_SEPARATOR.$cache['region'];
224 224
             $region    = new FileLockRegion($region, $directory, $this->regionsConfig->getLockLifetime($cache['region']));
225 225
         }
226 226
 
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
     {
237 237
         $cacheAdapter = clone $this->cache;
238 238
 
239
-        if (!$cacheAdapter instanceof CacheProvider) {
239
+        if ( ! $cacheAdapter instanceof CacheProvider) {
240 240
             return $cacheAdapter;
241 241
         }
242 242
 
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
             $namespace .= ':';
247 247
         }
248 248
 
249
-        $cacheAdapter->setNamespace($namespace . $name);
249
+        $cacheAdapter->setNamespace($namespace.$name);
250 250
 
251 251
         return $cacheAdapter;
252 252
     }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
             $cacheAnnot = $classAnnotations[Mapping\Cache::class];
150 150
             $cacheMap   = [
151 151
                 'region' => $cacheAnnot->region,
152
-                'usage'  => constant('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_' . $cacheAnnot->usage),
152
+                'usage'  => constant('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_'.$cacheAnnot->usage),
153 153
             ];
154 154
 
155 155
             $metadata->enableCache($cacheMap);
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
             $inheritanceTypeAnnot = $classAnnotations[Mapping\InheritanceType::class];
238 238
 
239 239
             $metadata->setInheritanceType(
240
-                constant('Doctrine\ORM\Mapping\ClassMetadata::INHERITANCE_TYPE_' . $inheritanceTypeAnnot->value)
240
+                constant('Doctrine\ORM\Mapping\ClassMetadata::INHERITANCE_TYPE_'.$inheritanceTypeAnnot->value)
241 241
             );
242 242
 
243 243
             if ($metadata->inheritanceType != Mapping\ClassMetadata::INHERITANCE_TYPE_NONE) {
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
         // Evaluate DoctrineChangeTrackingPolicy annotation
270 270
         if (isset($classAnnotations[Mapping\ChangeTrackingPolicy::class])) {
271 271
             $changeTrackingAnnot = $classAnnotations[Mapping\ChangeTrackingPolicy::class];
272
-            $metadata->setChangeTrackingPolicy(constant('Doctrine\ORM\Mapping\ClassMetadata::CHANGETRACKING_' . $changeTrackingAnnot->value));
272
+            $metadata->setChangeTrackingPolicy(constant('Doctrine\ORM\Mapping\ClassMetadata::CHANGETRACKING_'.$changeTrackingAnnot->value));
273 273
         }
274 274
 
275 275
         // Evaluate annotations on properties/fields
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
                 $mapping['cache'] = $metadata->getAssociationCacheDefaults(
294 294
                     $mapping['fieldName'],
295 295
                     [
296
-                        'usage'  => constant('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_' . $cacheAnnot->usage),
296
+                        'usage'  => constant('Doctrine\ORM\Mapping\ClassMetadata::CACHE_USAGE_'.$cacheAnnot->usage),
297 297
                         'region' => $cacheAnnot->region,
298 298
                     ]
299 299
                 );
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
                 }
324 324
 
325 325
                 if ($generatedValueAnnot = $this->reader->getPropertyAnnotation($property, Mapping\GeneratedValue::class)) {
326
-                    $metadata->setIdGeneratorType(constant('Doctrine\ORM\Mapping\ClassMetadata::GENERATOR_TYPE_' . $generatedValueAnnot->strategy));
326
+                    $metadata->setIdGeneratorType(constant('Doctrine\ORM\Mapping\ClassMetadata::GENERATOR_TYPE_'.$generatedValueAnnot->strategy));
327 327
                 }
328 328
 
329 329
                 if ($this->reader->getPropertyAnnotation($property, Mapping\Version::class)) {
@@ -472,7 +472,7 @@  discard block
 block discarded – undo
472 472
 
473 473
                 // Check for `fetch`
474 474
                 if ($associationOverride->fetch) {
475
-                    $override['fetch'] = constant(Mapping\ClassMetadata::class . '::FETCH_' . $associationOverride->fetch);
475
+                    $override['fetch'] = constant(Mapping\ClassMetadata::class.'::FETCH_'.$associationOverride->fetch);
476 476
                 }
477 477
 
478 478
                 $metadata->setAssociationOverride($fieldName, $override);
@@ -516,7 +516,7 @@  discard block
 block discarded – undo
516 516
                 }
517 517
 
518 518
                 // Evaluate the listener using naming convention.
519
-                if ( ! $hasMapping ) {
519
+                if ( ! $hasMapping) {
520 520
                     EntityListenerBuilder::bindEntityListener($metadata, $listenerClassName);
521 521
                 }
522 522
             }
@@ -545,11 +545,11 @@  discard block
 block discarded – undo
545 545
      */
546 546
     private function getFetchMode($className, $fetchMode)
547 547
     {
548
-        if ( ! defined('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . $fetchMode)) {
548
+        if ( ! defined('Doctrine\ORM\Mapping\ClassMetadata::FETCH_'.$fetchMode)) {
549 549
             throw MappingException::invalidFetchMode($className, $fetchMode);
550 550
         }
551 551
 
552
-        return constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . $fetchMode);
552
+        return constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_'.$fetchMode);
553 553
     }
554 554
 
555 555
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Persisters/Entity/JoinedSubclassPersister.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
                 }
208 208
 
209 209
                 foreach ($data as $columnName => $value) {
210
-                    if (!is_array($id) || !isset($id[$columnName])) {
210
+                    if ( ! is_array($id) || ! isset($id[$columnName])) {
211 211
                         $stmt->bindValue($paramIndex++, $value, $this->columnTypes[$columnName]);
212 212
                     }
213 213
                 }
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
         // If the current class in the root entity, add the filters
323 323
         if ($filterSql = $this->generateFilterConditionSQL($this->em->getClassMetadata($this->class->rootEntityName), $this->getSQLTableAlias($this->class->rootEntityName))) {
324 324
             $conditionSql .= $conditionSql
325
-                ? ' AND ' . $filterSql
325
+                ? ' AND '.$filterSql
326 326
                 : $filterSql;
327 327
         }
328 328
 
@@ -341,29 +341,29 @@  discard block
 block discarded – undo
341 341
         switch ($lockMode) {
342 342
             case LockMode::PESSIMISTIC_READ:
343 343
 
344
-                $lockSql = ' ' . $this->platform->getReadLockSQL();
344
+                $lockSql = ' '.$this->platform->getReadLockSQL();
345 345
 
346 346
                 break;
347 347
 
348 348
             case LockMode::PESSIMISTIC_WRITE:
349 349
 
350
-                $lockSql = ' ' . $this->platform->getWriteLockSQL();
350
+                $lockSql = ' '.$this->platform->getWriteLockSQL();
351 351
 
352 352
                 break;
353 353
         }
354 354
 
355 355
         $tableName  = $this->quoteStrategy->getTableName($this->class, $this->platform);
356
-        $from       = ' FROM ' . $tableName . ' ' . $baseTableAlias;
357
-        $where      = $conditionSql != '' ? ' WHERE ' . $conditionSql : '';
356
+        $from       = ' FROM '.$tableName.' '.$baseTableAlias;
357
+        $where      = $conditionSql != '' ? ' WHERE '.$conditionSql : '';
358 358
         $lock       = $this->platform->appendLockHint($from, $lockMode);
359 359
         $columnList = $this->getSelectColumnsSQL();
360
-        $query      = 'SELECT '  . $columnList
360
+        $query      = 'SELECT '.$columnList
361 361
                     . $lock
362 362
                     . $joinSql
363 363
                     . $where
364 364
                     . $orderBySql;
365 365
 
366
-        return $this->platform->modifyLimitQuery($query, $limit, $offset) . $lockSql;
366
+        return $this->platform->modifyLimitQuery($query, $limit, $offset).$lockSql;
367 367
     }
368 368
 
369 369
     /**
@@ -383,14 +383,14 @@  discard block
 block discarded – undo
383 383
 
384 384
         if ('' !== $filterSql) {
385 385
             $conditionSql = $conditionSql
386
-                ? $conditionSql . ' AND ' . $filterSql
386
+                ? $conditionSql.' AND '.$filterSql
387 387
                 : $filterSql;
388 388
         }
389 389
 
390 390
         $sql = 'SELECT COUNT(*) '
391
-            . 'FROM ' . $tableName . ' ' . $baseTableAlias
391
+            . 'FROM '.$tableName.' '.$baseTableAlias
392 392
             . $joinSql
393
-            . (empty($conditionSql) ? '' : ' WHERE ' . $conditionSql);
393
+            . (empty($conditionSql) ? '' : ' WHERE '.$conditionSql);
394 394
 
395 395
         return $sql;
396 396
     }
@@ -409,16 +409,16 @@  discard block
 block discarded – undo
409 409
             $conditions     = [];
410 410
             $tableAlias     = $this->getSQLTableAlias($parentClassName);
411 411
             $parentClass    = $this->em->getClassMetadata($parentClassName);
412
-            $joinSql       .= ' INNER JOIN ' . $this->quoteStrategy->getTableName($parentClass, $this->platform) . ' ' . $tableAlias . ' ON ';
412
+            $joinSql       .= ' INNER JOIN '.$this->quoteStrategy->getTableName($parentClass, $this->platform).' '.$tableAlias.' ON ';
413 413
 
414 414
             foreach ($identifierColumns as $idColumn) {
415
-                $conditions[] = $baseTableAlias . '.' . $idColumn . ' = ' . $tableAlias . '.' . $idColumn;
415
+                $conditions[] = $baseTableAlias.'.'.$idColumn.' = '.$tableAlias.'.'.$idColumn;
416 416
             }
417 417
 
418 418
             $joinSql .= implode(' AND ', $conditions);
419 419
         }
420 420
 
421
-        return parent::getLockTablesSql($lockMode) . $joinSql;
421
+        return parent::getLockTablesSql($lockMode).$joinSql;
422 422
     }
423 423
 
424 424
     /**
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
             ? $baseTableAlias
480 480
             : $this->getSQLTableAlias($this->class->rootEntityName);
481 481
 
482
-        $columnList[] = $tableAlias . '.' . $discrColumn;
482
+        $columnList[] = $tableAlias.'.'.$discrColumn;
483 483
 
484 484
         // sub tables
485 485
         foreach ($this->class->subClasses as $subClassName) {
@@ -586,11 +586,11 @@  discard block
 block discarded – undo
586 586
             $conditions   = [];
587 587
             $parentClass  = $this->em->getClassMetadata($parentClassName);
588 588
             $tableAlias   = $this->getSQLTableAlias($parentClassName);
589
-            $joinSql     .= ' INNER JOIN ' . $this->quoteStrategy->getTableName($parentClass, $this->platform) . ' ' . $tableAlias . ' ON ';
589
+            $joinSql     .= ' INNER JOIN '.$this->quoteStrategy->getTableName($parentClass, $this->platform).' '.$tableAlias.' ON ';
590 590
 
591 591
 
592 592
             foreach ($identifierColumn as $idColumn) {
593
-                $conditions[] = $baseTableAlias . '.' . $idColumn . ' = ' . $tableAlias . '.' . $idColumn;
593
+                $conditions[] = $baseTableAlias.'.'.$idColumn.' = '.$tableAlias.'.'.$idColumn;
594 594
             }
595 595
 
596 596
             $joinSql .= implode(' AND ', $conditions);
@@ -601,10 +601,10 @@  discard block
 block discarded – undo
601 601
             $conditions  = [];
602 602
             $subClass    = $this->em->getClassMetadata($subClassName);
603 603
             $tableAlias  = $this->getSQLTableAlias($subClassName);
604
-            $joinSql    .= ' LEFT JOIN ' . $this->quoteStrategy->getTableName($subClass, $this->platform) . ' ' . $tableAlias . ' ON ';
604
+            $joinSql    .= ' LEFT JOIN '.$this->quoteStrategy->getTableName($subClass, $this->platform).' '.$tableAlias.' ON ';
605 605
 
606 606
             foreach ($identifierColumn as $idColumn) {
607
-                $conditions[] = $baseTableAlias . '.' . $idColumn . ' = ' . $tableAlias . '.' . $idColumn;
607
+                $conditions[] = $baseTableAlias.'.'.$idColumn.' = '.$tableAlias.'.'.$idColumn;
608 608
             }
609 609
 
610 610
             $joinSql .= implode(' AND ', $conditions);
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
             $class->reflFields[$fieldName]->setValue($entity, $value);
200 200
             $this->_uow->setOriginalEntityProperty($oid, $fieldName, $value);
201 201
 
202
-            $this->initializedCollections[$oid . $fieldName] = $value;
202
+            $this->initializedCollections[$oid.$fieldName] = $value;
203 203
         } else if (
204 204
             isset($this->_hints[Query::HINT_REFRESH]) ||
205 205
             isset($this->_hints['fetched'][$parentDqlAlias][$fieldName]) &&
@@ -210,10 +210,10 @@  discard block
 block discarded – undo
210 210
             $value->setInitialized(true);
211 211
             $value->unwrap()->clear();
212 212
 
213
-            $this->initializedCollections[$oid . $fieldName] = $value;
213
+            $this->initializedCollections[$oid.$fieldName] = $value;
214 214
         } else {
215 215
             // Is already PersistentCollection, and DON'T REFRESH or FETCH-JOIN!
216
-            $this->existingCollections[$oid . $fieldName] = $value;
216
+            $this->existingCollections[$oid.$fieldName] = $value;
217 217
         }
218 218
 
219 219
         return $value;
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
             $idHash = '';
288 288
 
289 289
             foreach ($class->identifier as $fieldName) {
290
-                $idHash .= ' ' . (isset($class->associationMappings[$fieldName])
290
+                $idHash .= ' '.(isset($class->associationMappings[$fieldName])
291 291
                     ? $data[$class->associationMappings[$fieldName]['joinColumns'][0]['name']]
292 292
                     : $data[$fieldName]);
293 293
             }
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
                 $parentAlias = $this->_rsm->parentAliasMap[$dqlAlias];
344 344
                 // we need the $path to save into the identifier map which entities were already
345 345
                 // seen for this parent-child relationship
346
-                $path = $parentAlias . '.' . $dqlAlias;
346
+                $path = $parentAlias.'.'.$dqlAlias;
347 347
 
348 348
                 // We have a RIGHT JOIN result here. Doctrine cannot hydrate RIGHT JOIN Object-Graphs
349 349
                 if ( ! isset($nonemptyComponents[$parentAlias])) {
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
                     $reflFieldValue = $reflField->getValue($parentObject);
384 384
 
385 385
                     if (isset($nonemptyComponents[$dqlAlias])) {
386
-                        $collKey = $oid . $relationField;
386
+                        $collKey = $oid.$relationField;
387 387
                         if (isset($this->initializedCollections[$collKey])) {
388 388
                             $reflFieldValue = $this->initializedCollections[$collKey];
389 389
                         } else if ( ! isset($this->existingCollections[$collKey])) {
@@ -431,7 +431,7 @@  discard block
 block discarded – undo
431 431
                     // PATH B: Single-valued association
432 432
                     $reflFieldValue = $reflField->getValue($parentObject);
433 433
 
434
-                    if ( ! $reflFieldValue || isset($this->_hints[Query::HINT_REFRESH]) || ($reflFieldValue instanceof Proxy && !$reflFieldValue->__isInitialized__)) {
434
+                    if ( ! $reflFieldValue || isset($this->_hints[Query::HINT_REFRESH]) || ($reflFieldValue instanceof Proxy && ! $reflFieldValue->__isInitialized__)) {
435 435
                         // we only need to take action if this value is null,
436 436
                         // we refresh the entity or its an uninitialized proxy.
437 437
                         if (isset($nonemptyComponents[$dqlAlias])) {
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
                 $entityKey = $this->_rsm->entityMappings[$dqlAlias] ?: 0;
477 477
 
478 478
                 // if this row has a NULL value for the root result id then make it a null result.
479
-                if ( ! isset($nonemptyComponents[$dqlAlias]) ) {
479
+                if ( ! isset($nonemptyComponents[$dqlAlias])) {
480 480
                     if ($this->_rsm->isMixed) {
481 481
                         $result[] = [$entityKey => null];
482 482
                     } else {
@@ -532,13 +532,13 @@  discard block
 block discarded – undo
532 532
             }
533 533
         }
534 534
 
535
-        if ( ! isset($resultKey) ) {
535
+        if ( ! isset($resultKey)) {
536 536
             $this->resultCounter++;
537 537
         }
538 538
 
539 539
         // Append scalar values to mixed result sets
540 540
         if (isset($rowData['scalars'])) {
541
-            if ( ! isset($resultKey) ) {
541
+            if ( ! isset($resultKey)) {
542 542
                 $resultKey = (isset($this->_rsm->indexByMap['scalars']))
543 543
                     ? $row[$this->_rsm->indexByMap['scalars']]
544 544
                     : $this->resultCounter - 1;
@@ -551,19 +551,19 @@  discard block
 block discarded – undo
551 551
 
552 552
         // Append new object to mixed result sets
553 553
         if (isset($rowData['newObjects'])) {
554
-            if ( ! isset($resultKey) ) {
554
+            if ( ! isset($resultKey)) {
555 555
                 $resultKey = $this->resultCounter - 1;
556 556
             }
557 557
 
558 558
 
559
-            $scalarCount = (isset($rowData['scalars'])? count($rowData['scalars']): 0);
559
+            $scalarCount = (isset($rowData['scalars']) ? count($rowData['scalars']) : 0);
560 560
 
561 561
             foreach ($rowData['newObjects'] as $objIndex => $newObject) {
562 562
                 $class  = $newObject['class'];
563 563
                 $args   = $newObject['args'];
564 564
                 $obj    = $class->newInstanceArgs($args);
565 565
 
566
-                if ($scalarCount == 0 && count($rowData['newObjects']) == 1 ) {
566
+                if ($scalarCount == 0 && count($rowData['newObjects']) == 1) {
567 567
                     $result[$resultKey] = $obj;
568 568
 
569 569
                     continue;
Please login to merge, or discard this patch.
bin/doctrine-pear.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,13 +25,13 @@
 block discarded – undo
25 25
 $classLoader = new \Doctrine\Common\ClassLoader('Symfony');
26 26
 $classLoader->register();
27 27
 
28
-$configFile = getcwd() . DIRECTORY_SEPARATOR . 'cli-config.php';
28
+$configFile = getcwd().DIRECTORY_SEPARATOR.'cli-config.php';
29 29
 
30 30
 $helperSet = null;
31 31
 if (file_exists($configFile)) {
32 32
     if ( ! is_readable($configFile)) {
33 33
         trigger_error(
34
-            'Configuration file [' . $configFile . '] does not have read permission.', E_USER_ERROR
34
+            'Configuration file ['.$configFile.'] does not have read permission.', E_USER_ERROR
35 35
         );
36 36
     }
37 37
 
Please login to merge, or discard this patch.
bin/doctrine.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -21,8 +21,8 @@  discard block
 block discarded – undo
21 21
 use Doctrine\ORM\Tools\Console\ConsoleRunner;
22 22
 
23 23
 $autoloadFiles = [
24
-    __DIR__ . '/../vendor/autoload.php',
25
-    __DIR__ . '/../../../autoload.php'
24
+    __DIR__.'/../vendor/autoload.php',
25
+    __DIR__.'/../../../autoload.php'
26 26
 ];
27 27
 
28 28
 foreach ($autoloadFiles as $autoloadFile) {
@@ -32,11 +32,11 @@  discard block
 block discarded – undo
32 32
     }
33 33
 }
34 34
 
35
-$directories = [getcwd(), getcwd() . DIRECTORY_SEPARATOR . 'config'];
35
+$directories = [getcwd(), getcwd().DIRECTORY_SEPARATOR.'config'];
36 36
 
37 37
 $configFile = null;
38 38
 foreach ($directories as $directory) {
39
-    $configFile = $directory . DIRECTORY_SEPARATOR . 'cli-config.php';
39
+    $configFile = $directory.DIRECTORY_SEPARATOR.'cli-config.php';
40 40
 
41 41
     if (file_exists($configFile)) {
42 42
         break;
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 }
50 50
 
51 51
 if ( ! is_readable($configFile)) {
52
-    echo 'Configuration file [' . $configFile . '] does not have read permission.' . "\n";
52
+    echo 'Configuration file ['.$configFile.'] does not have read permission.'."\n";
53 53
     exit(1);
54 54
 }
55 55
 
Please login to merge, or discard this patch.