Passed
Pull Request — master (#7448)
by Ilya
14:31
created
lib/Doctrine/ORM/Query/Filter/SQLFilter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,8 +83,8 @@
 block discarded – undo
83 83
      */
84 84
     final public function getParameter($name)
85 85
     {
86
-        if (! isset($this->parameters[$name])) {
87
-            throw new InvalidArgumentException("Parameter '" . $name . "' does not exist.");
86
+        if ( ! isset($this->parameters[$name])) {
87
+            throw new InvalidArgumentException("Parameter '".$name."' does not exist.");
88 88
         }
89 89
 
90 90
         return $this->em->getConnection()->quote($this->parameters[$name]['value'], $this->parameters[$name]['type']);
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Query/Exec/MultiTableDeleteExecutor.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -57,8 +57,8 @@  discard block
 block discarded – undo
57 57
         // 1. Create an INSERT INTO temptable ... SELECT identifiers WHERE $AST->getWhereClause()
58 58
         $sqlWalker->setSQLTableAlias($primaryClass->getTableName(), 'i0', $primaryDqlAlias);
59 59
 
60
-        $this->insertSql = 'INSERT INTO ' . $tempTable . ' (' . $idColumnNameList . ')'
61
-                . ' SELECT i0.' . implode(', i0.', array_keys($idColumns));
60
+        $this->insertSql = 'INSERT INTO '.$tempTable.' ('.$idColumnNameList.')'
61
+                . ' SELECT i0.'.implode(', i0.', array_keys($idColumns));
62 62
 
63 63
         $rangeDecl        = new AST\RangeVariableDeclaration($primaryClass->getClassName(), $primaryDqlAlias);
64 64
         $fromClause       = new AST\FromClause([new AST\IdentificationVariableDeclaration($rangeDecl, null, [])]);
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         // 3. Create and store DELETE statements
81 81
         $hierarchyClasses = array_merge(
82 82
             array_map(
83
-                static function ($className) use ($em) {
83
+                static function($className) use ($em) {
84 84
                     return $em->getClassMetadata($className);
85 85
                 },
86 86
                 array_reverse($primaryClass->getSubClasses())
@@ -103,8 +103,8 @@  discard block
 block discarded – undo
103 103
             ];
104 104
         }
105 105
 
106
-        $this->createTempTableSql = $platform->getCreateTemporaryTableSnippetSQL() . ' ' . $tempTable . ' ('
107
-                . $platform->getColumnDeclarationListSQL($columnDefinitions) . ')';
106
+        $this->createTempTableSql = $platform->getCreateTemporaryTableSnippetSQL().' '.$tempTable.' ('
107
+                . $platform->getColumnDeclarationListSQL($columnDefinitions).')';
108 108
 
109 109
         $this->dropTempTableSql = $platform->getDropTemporaryTableSQL($tempTable);
110 110
     }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Query/Exec/MultiTableUpdateExecutor.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -67,8 +67,8 @@  discard block
 block discarded – undo
67 67
         // 1. Create an INSERT INTO temptable ... SELECT identifiers WHERE $AST->getWhereClause()
68 68
         $sqlWalker->setSQLTableAlias($primaryClass->getTableName(), 'i0', $updateClause->aliasIdentificationVariable);
69 69
 
70
-        $this->insertSql = 'INSERT INTO ' . $tempTable . ' (' . $idColumnNameList . ')'
71
-                . ' SELECT i0.' . implode(', i0.', array_keys($idColumns));
70
+        $this->insertSql = 'INSERT INTO '.$tempTable.' ('.$idColumnNameList.')'
71
+                . ' SELECT i0.'.implode(', i0.', array_keys($idColumns));
72 72
 
73 73
         $rangeDecl  = new AST\RangeVariableDeclaration($primaryClass->getClassName(), $updateClause->aliasIdentificationVariable);
74 74
         $fromClause = new AST\FromClause([new AST\IdentificationVariableDeclaration($rangeDecl, null, [])]);
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
         // 3. Create and store UPDATE statements
87 87
         $hierarchyClasses = array_merge(
88 88
             array_map(
89
-                static function ($className) use ($em) {
89
+                static function($className) use ($em) {
90 90
                     return $em->getClassMetadata($className);
91 91
                 },
92 92
                 array_reverse($primaryClass->getSubClasses())
@@ -142,8 +142,8 @@  discard block
 block discarded – undo
142 142
             ];
143 143
         }
144 144
 
145
-        $this->createTempTableSql = $platform->getCreateTemporaryTableSnippetSQL() . ' ' . $tempTable . ' ('
146
-                . $platform->getColumnDeclarationListSQL($columnDefinitions) . ')';
145
+        $this->createTempTableSql = $platform->getCreateTemporaryTableSnippetSQL().' '.$tempTable.' ('
146
+                . $platform->getColumnDeclarationListSQL($columnDefinitions).')';
147 147
 
148 148
         $this->dropTempTableSql = $platform->getDropTemporaryTableSQL($tempTable);
149 149
     }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Query/ResultSetMappingBuilder.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         $classMetadata = $this->em->getClassMetadata($class);
123 123
         $platform      = $this->em->getConnection()->getDatabasePlatform();
124 124
 
125
-        if (! $this->isInheritanceSupported($classMetadata)) {
125
+        if ( ! $this->isInheritanceSupported($classMetadata)) {
126 126
             throw new InvalidArgumentException(
127 127
                 'ResultSetMapping builder does not currently support your inheritance scheme.'
128 128
             );
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
                             );
163 163
                         }
164 164
 
165
-                        if (! $joinColumn->getType()) {
165
+                        if ( ! $joinColumn->getType()) {
166 166
                             $joinColumn->setType(PersisterHelper::getTypeOfColumn($referencedColumnName, $targetClass, $this->em));
167 167
                         }
168 168
 
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     {
202 202
         switch ($mode) {
203 203
             case self::COLUMN_RENAMING_INCREMENT:
204
-                return $columnName . $this->sqlCounter++;
204
+                return $columnName.$this->sqlCounter++;
205 205
 
206 206
             case self::COLUMN_RENAMING_CUSTOM:
207 207
                 return $customRenameColumns[$columnName] ?? $columnName;
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
                 $sql .= ', ';
233 233
             }
234 234
 
235
-            $sql .= $tableAlias . '.';
235
+            $sql .= $tableAlias.'.';
236 236
 
237 237
             if (isset($this->fieldMappings[$columnName])) {
238 238
                 $class = $this->em->getClassMetadata($this->declaringClasses[$columnName]);
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
                 $sql .= $this->discriminatorColumns[$dqlAlias];
245 245
             }
246 246
 
247
-            $sql .= ' AS ' . $columnName;
247
+            $sql .= ' AS '.$columnName;
248 248
         }
249 249
 
250 250
         return $sql;
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Query/QueryExpressionVisitor.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
                 return new Expr\Orx($expressionList);
97 97
 
98 98
             default:
99
-                throw new RuntimeException('Unknown composite ' . $expr->getType());
99
+                throw new RuntimeException('Unknown composite '.$expr->getType());
100 100
         }
101 101
     }
102 102
 
@@ -105,14 +105,14 @@  discard block
 block discarded – undo
105 105
      */
106 106
     public function walkComparison(Comparison $comparison)
107 107
     {
108
-        if (! isset($this->queryAliases[0])) {
108
+        if ( ! isset($this->queryAliases[0])) {
109 109
             throw new QueryException('No aliases are set before invoking walkComparison().');
110 110
         }
111 111
 
112
-        $field = $this->queryAliases[0] . '.' . $comparison->getField();
112
+        $field = $this->queryAliases[0].'.'.$comparison->getField();
113 113
 
114 114
         foreach ($this->queryAliases as $alias) {
115
-            if (strpos($comparison->getField() . '.', $alias . '.') === 0) {
115
+            if (strpos($comparison->getField().'.', $alias.'.') === 0) {
116 116
                 $field = $comparison->getField();
117 117
                 break;
118 118
             }
@@ -123,13 +123,13 @@  discard block
 block discarded – undo
123 123
 
124 124
         foreach ($this->parameters as $parameter) {
125 125
             if ($parameter->getName() === $parameterName) {
126
-                $parameterName .= '_' . $parameterCount;
126
+                $parameterName .= '_'.$parameterCount;
127 127
                 break;
128 128
             }
129 129
         }
130 130
 
131 131
         $parameter   = new Parameter($parameterName, $this->walkValue($comparison->getValue()));
132
-        $placeholder = ':' . $parameterName;
132
+        $placeholder = ':'.$parameterName;
133 133
 
134 134
         switch ($comparison->getOperator()) {
135 135
             case Comparison::IN:
@@ -156,17 +156,17 @@  discard block
 block discarded – undo
156 156
 
157 157
                 return $this->expr->neq($field, $placeholder);
158 158
             case Comparison::CONTAINS:
159
-                $parameter->setValue('%' . $parameter->getValue() . '%', $parameter->getType());
159
+                $parameter->setValue('%'.$parameter->getValue().'%', $parameter->getType());
160 160
                 $this->parameters[] = $parameter;
161 161
 
162 162
                 return $this->expr->like($field, $placeholder);
163 163
             case Comparison::STARTS_WITH:
164
-                $parameter->setValue($parameter->getValue() . '%', $parameter->getType());
164
+                $parameter->setValue($parameter->getValue().'%', $parameter->getType());
165 165
                 $this->parameters[] = $parameter;
166 166
 
167 167
                 return $this->expr->like($field, $placeholder);
168 168
             case Comparison::ENDS_WITH:
169
-                $parameter->setValue('%' . $parameter->getValue(), $parameter->getType());
169
+                $parameter->setValue('%'.$parameter->getValue(), $parameter->getType());
170 170
                 $this->parameters[] = $parameter;
171 171
 
172 172
                 return $this->expr->like($field, $placeholder);
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
                     );
183 183
                 }
184 184
 
185
-                throw new RuntimeException('Unknown comparison operator: ' . $comparison->getOperator());
185
+                throw new RuntimeException('Unknown comparison operator: '.$comparison->getOperator());
186 186
         }
187 187
     }
188 188
 
Please login to merge, or discard this patch.
lib/Doctrine/ORM/EntityManager.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
     {
294 294
         $query = new Query($this);
295 295
 
296
-        if (! empty($dql)) {
296
+        if ( ! empty($dql)) {
297 297
             $query->setDQL($dql);
298 298
         }
299 299
 
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
             $this->checkLockRequirements($lockMode, $class);
385 385
         }
386 386
 
387
-        if (! is_array($id)) {
387
+        if ( ! is_array($id)) {
388 388
             if ($class->isIdentifierComposite()) {
389 389
                 throw ORMInvalidArgumentException::invalidCompositeIdentifier();
390 390
             }
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
         $sortedId = [];
406 406
 
407 407
         foreach ($class->identifier as $identifier) {
408
-            if (! isset($id[$identifier])) {
408
+            if ( ! isset($id[$identifier])) {
409 409
                 throw MissingIdentifierField::fromFieldAndClass($identifier, $className);
410 410
             }
411 411
 
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
         // Check identity map first
423 423
         $entity = $unitOfWork->tryGetById($sortedId, $class->getRootClassName());
424 424
         if ($entity !== false) {
425
-            if (! ($entity instanceof $className)) {
425
+            if ( ! ($entity instanceof $className)) {
426 426
                 return null;
427 427
             }
428 428
 
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
         $class     = $this->metadataFactory->getMetadataFor(ltrim($entityName, '\\'));
468 468
         $className = $class->getClassName();
469 469
 
470
-        if (! is_array($id)) {
470
+        if ( ! is_array($id)) {
471 471
             if ($class->isIdentifierComposite()) {
472 472
                 throw ORMInvalidArgumentException::invalidCompositeIdentifier();
473 473
             }
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
         $sortedId = [];
493 493
 
494 494
         foreach ($class->identifier as $identifier) {
495
-            if (! isset($scalarId[$identifier])) {
495
+            if ( ! isset($scalarId[$identifier])) {
496 496
                 throw MissingIdentifierField::fromFieldAndClass($identifier, $className);
497 497
             }
498 498
 
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
         $class     = $this->metadataFactory->getMetadataFor(ltrim($entityName, '\\'));
534 534
         $className = $class->getClassName();
535 535
 
536
-        if (! is_array($id)) {
536
+        if ( ! is_array($id)) {
537 537
             if ($class->isIdentifierComposite()) {
538 538
                 throw ORMInvalidArgumentException::invalidCompositeIdentifier();
539 539
             }
@@ -554,7 +554,7 @@  discard block
 block discarded – undo
554 554
         $sortedId = [];
555 555
 
556 556
         foreach ($class->identifier as $identifier) {
557
-            if (! isset($id[$identifier])) {
557
+            if ( ! isset($id[$identifier])) {
558 558
                 throw MissingIdentifierField::fromFieldAndClass($identifier, $className);
559 559
             }
560 560
 
@@ -626,7 +626,7 @@  discard block
 block discarded – undo
626 626
      */
627 627
     public function persist($entity)
628 628
     {
629
-        if (! is_object($entity)) {
629
+        if ( ! is_object($entity)) {
630 630
             throw ORMInvalidArgumentException::invalidObject('EntityManager#persist()', $entity);
631 631
         }
632 632
 
@@ -648,7 +648,7 @@  discard block
 block discarded – undo
648 648
      */
649 649
     public function remove($entity)
650 650
     {
651
-        if (! is_object($entity)) {
651
+        if ( ! is_object($entity)) {
652 652
             throw ORMInvalidArgumentException::invalidObject('EntityManager#remove()', $entity);
653 653
         }
654 654
 
@@ -668,7 +668,7 @@  discard block
 block discarded – undo
668 668
      */
669 669
     public function refresh($entity)
670 670
     {
671
-        if (! is_object($entity)) {
671
+        if ( ! is_object($entity)) {
672 672
             throw ORMInvalidArgumentException::invalidObject('EntityManager#refresh()', $entity);
673 673
         }
674 674
 
@@ -823,7 +823,7 @@  discard block
 block discarded – undo
823 823
      */
824 824
     public static function create($connection, Configuration $config, ?EventManager $eventManager = null)
825 825
     {
826
-        if (! $config->getMetadataDriverImpl()) {
826
+        if ( ! $config->getMetadataDriverImpl()) {
827 827
             throw MissingMappingDriverImplementation::create();
828 828
         }
829 829
 
@@ -850,12 +850,12 @@  discard block
 block discarded – undo
850 850
             return DriverManager::getConnection($connection, $config, $eventManager ?: new EventManager());
851 851
         }
852 852
 
853
-        if (! $connection instanceof Connection) {
853
+        if ( ! $connection instanceof Connection) {
854 854
             throw new InvalidArgumentException(
855 855
                 sprintf(
856 856
                     'Invalid $connection argument of type %s given%s.',
857 857
                     is_object($connection) ? get_class($connection) : gettype($connection),
858
-                    is_object($connection) ? '' : ': "' . $connection . '"'
858
+                    is_object($connection) ? '' : ': "'.$connection.'"'
859 859
                 )
860 860
             );
861 861
         }
@@ -903,13 +903,13 @@  discard block
 block discarded – undo
903 903
     {
904 904
         switch ($lockMode) {
905 905
             case LockMode::OPTIMISTIC:
906
-                if (! $class->isVersioned()) {
906
+                if ( ! $class->isVersioned()) {
907 907
                     throw OptimisticLockException::notVersioned($class->getClassName());
908 908
                 }
909 909
                 break;
910 910
             case LockMode::PESSIMISTIC_READ:
911 911
             case LockMode::PESSIMISTIC_WRITE:
912
-                if (! $this->getConnection()->isTransactionActive()) {
912
+                if ( ! $this->getConnection()->isTransactionActive()) {
913 913
                     throw TransactionRequiredException::transactionRequired();
914 914
                 }
915 915
         }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Event/PreUpdateEventArgs.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
      */
101 101
     private function assertValidField($field)
102 102
     {
103
-        if (! isset($this->entityChangeSet[$field])) {
103
+        if ( ! isset($this->entityChangeSet[$field])) {
104 104
             throw new InvalidArgumentException(sprintf(
105 105
                 'Field "%s" is not a valid field of the entity "%s" in PreUpdateEventArgs.',
106 106
                 $field,
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryWalker.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 
55 55
         if ($property instanceof AssociationMetadata) {
56 56
             throw new RuntimeException(
57
-                'Paginating an entity with foreign key as identifier only works when using the Output Walkers. ' .
57
+                'Paginating an entity with foreign key as identifier only works when using the Output Walkers. '.
58 58
                 'Call Paginator#setUseOutputWalkers(true) before iterating the paginator.'
59 59
             );
60 60
         }
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $AST->selectClause->selectExpressions = [new SelectExpression($pathExpression, '_dctrn_id')];
73 73
         $AST->selectClause->isDistinct        = true;
74 74
 
75
-        if (! isset($AST->orderByClause)) {
75
+        if ( ! isset($AST->orderByClause)) {
76 76
             return;
77 77
         }
78 78
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
             if ($item->expression instanceof PathExpression) {
81 81
                 $AST->selectClause->selectExpressions[] = new SelectExpression(
82 82
                     $this->createSelectExpressionItem($item->expression),
83
-                    '_dctrn_ord' . $this->aliasCounter++
83
+                    '_dctrn_ord'.$this->aliasCounter++
84 84
                 );
85 85
 
86 86
                 continue;
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -191,13 +191,13 @@  discard block
 block discarded – undo
191 191
 
192 192
         $innerSql           = $this->getInnerSQL($AST);
193 193
         $sqlIdentifier      = $this->getSQLIdentifier($AST);
194
-        $sqlAliasIdentifier = array_map(static function ($info) {
194
+        $sqlAliasIdentifier = array_map(static function($info) {
195 195
             return $info['alias'];
196 196
         }, $sqlIdentifier);
197 197
 
198 198
         if ($hasOrderBy) {
199
-            $orderGroupBy = ' GROUP BY ' . implode(', ', $sqlAliasIdentifier);
200
-            $sqlPiece     = 'MIN(' . $this->walkResultVariable('dctrn_rownum') . ') AS dctrn_minrownum';
199
+            $orderGroupBy = ' GROUP BY '.implode(', ', $sqlAliasIdentifier);
200
+            $sqlPiece     = 'MIN('.$this->walkResultVariable('dctrn_rownum').') AS dctrn_minrownum';
201 201
 
202 202
             $sqlAliasIdentifier[] = $sqlPiece;
203 203
             $sqlIdentifier[]      = [
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
         $sql = sprintf('SELECT DISTINCT %s FROM (%s) dctrn_result', implode(', ', $sqlAliasIdentifier), $innerSql);
211 211
 
212 212
         if ($hasOrderBy) {
213
-            $sql .= $orderGroupBy . $outerOrderBy;
213
+            $sql .= $orderGroupBy.$outerOrderBy;
214 214
         }
215 215
 
216 216
         // Apply the limit and offset.
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 
255 255
         $innerSql           = $this->getInnerSQL($AST);
256 256
         $sqlIdentifier      = $this->getSQLIdentifier($AST);
257
-        $sqlAliasIdentifier = array_map(static function ($info) {
257
+        $sqlAliasIdentifier = array_map(static function($info) {
258 258
             return $info['alias'];
259 259
         }, $sqlIdentifier);
260 260
 
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
             $idVar = $pathExpression->identificationVariable;
312 312
             $field = $pathExpression->field;
313 313
 
314
-            if (! isset($selects[$idVar])) {
314
+            if ( ! isset($selects[$idVar])) {
315 315
                 $selects[$idVar] = [];
316 316
             }
317 317
 
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
             if ($selectExpression instanceof SelectExpression) {
325 325
                 $idVar = $selectExpression->expression;
326 326
 
327
-                if (! is_string($idVar)) {
327
+                if ( ! is_string($idVar)) {
328 328
                     continue;
329 329
                 }
330 330
 
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
359 359
         ?OrderByClause $orderByClause
360 360
     ) : string {
361 361
         // If the sql statement has an order by clause, we need to wrap it in a new select distinct statement
362
-        if (! $orderByClause) {
362
+        if ( ! $orderByClause) {
363 363
             return $sql;
364 364
         }
365 365
 
@@ -397,7 +397,7 @@  discard block
 block discarded – undo
397 397
             $orderByItems[] = $orderByItemString;
398 398
             $identifier     = substr($orderByItemString, 0, strrpos($orderByItemString, ' '));
399 399
 
400
-            if (! in_array($identifier, $identifiers, true)) {
400
+            if ( ! in_array($identifier, $identifiers, true)) {
401 401
                 $identifiers[] = $identifier;
402 402
             }
403 403
         }
@@ -550,7 +550,7 @@  discard block
 block discarded – undo
550 550
      */
551 551
     public function walkPathExpression($pathExpr)
552 552
     {
553
-        if (! $this->inSubSelect && ! $this->platformSupportsRowNumber() && ! in_array($pathExpr, $this->orderByPathExpressions, true)) {
553
+        if ( ! $this->inSubSelect && ! $this->platformSupportsRowNumber() && ! in_array($pathExpr, $this->orderByPathExpressions, true)) {
554 554
             $this->orderByPathExpressions[] = $pathExpr;
555 555
         }
556 556
 
Please login to merge, or discard this patch.