Passed
Pull Request — master (#7448)
by Ilya
14:31
created
lib/Doctrine/ORM/Cache/Persister/Entity/AbstractEntityPersister.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
             ? $this->persister->expandCriteriaParameters($criteria)
260 260
             : $this->persister->expandParameters($criteria);
261 261
 
262
-        return sha1($query . serialize($params) . serialize($orderBy) . $limit . $offset);
262
+        return sha1($query.serialize($params).serialize($orderBy).$limit.$offset);
263 263
     }
264 264
 
265 265
     /**
@@ -557,7 +557,7 @@  discard block
 block discarded – undo
557 557
         $hasCache  = ($persister instanceof CachedPersister);
558 558
         $key       = null;
559 559
 
560
-        if (! $hasCache) {
560
+        if ( ! $hasCache) {
561 561
             return $this->persister->loadManyToManyCollection($association, $sourceEntity, $collection);
562 562
         }
563 563
 
@@ -596,7 +596,7 @@  discard block
 block discarded – undo
596 596
         $persister = $uow->getCollectionPersister($association);
597 597
         $hasCache  = ($persister instanceof CachedPersister);
598 598
 
599
-        if (! $hasCache) {
599
+        if ( ! $hasCache) {
600 600
             return $this->persister->loadOneToManyCollection($association, $sourceEntity, $collection);
601 601
         }
602 602
 
Please login to merge, or discard this patch.
Cache/Persister/Collection/NonStrictReadWriteCachedCollectionPersister.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
         $isInitialized = $collection->isInitialized();
62 62
         $isDirty       = $collection->isDirty();
63 63
 
64
-        if (! $isInitialized && ! $isDirty) {
64
+        if ( ! $isInitialized && ! $isDirty) {
65 65
             return;
66 66
         }
67 67
 
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/Persister/Collection/AbstractCollectionPersister.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
         $targetHydrator  = $targetPersister->getEntityHydrator();
144 144
 
145 145
         // Only preserve ordering if association configured it
146
-        if (! ($association instanceof ToManyAssociationMetadata && $association->getIndexedBy())) {
146
+        if ( ! ($association instanceof ToManyAssociationMetadata && $association->getIndexedBy())) {
147 147
             // Elements may be an array or a Collection
148 148
             $elements = array_values($elements instanceof Collection ? $elements->getValues() : $elements);
149 149
         }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/CollectionCacheKey.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,6 +47,6 @@
 block discarded – undo
47 47
         $this->ownerIdentifier = $ownerIdentifier;
48 48
         $this->entityClass     = (string) $entityClass;
49 49
         $this->association     = (string) $association;
50
-        $this->hash            = str_replace('\\', '.', strtolower($entityClass)) . '_' . implode(' ', $ownerIdentifier) . '__' . $association;
50
+        $this->hash            = str_replace('\\', '.', strtolower($entityClass)).'_'.implode(' ', $ownerIdentifier).'__'.$association;
51 51
     }
52 52
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/Exception/MetadataCacheUsesNonPersistentCache.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     public static function fromDriver(Cache $cache) : self
13 13
     {
14 14
         return new self(
15
-            'Metadata Cache uses a non-persistent cache driver, ' . get_class($cache) . '.'
15
+            'Metadata Cache uses a non-persistent cache driver, '.get_class($cache).'.'
16 16
         );
17 17
     }
18 18
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/Exception/QueryCacheUsesNonPersistentCache.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     public static function fromDriver(Cache $cache) : self
13 13
     {
14 14
         return new self(
15
-            'Query Cache uses a non-persistent cache driver, ' . get_class($cache) . '.'
15
+            'Query Cache uses a non-persistent cache driver, '.get_class($cache).'.'
16 16
         );
17 17
     }
18 18
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/DefaultCache.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         $metadata  = $this->em->getClassMetadata($className);
56 56
         $persister = $this->uow->getEntityPersister($metadata->getRootClassName());
57 57
 
58
-        if (! ($persister instanceof CachedPersister)) {
58
+        if ( ! ($persister instanceof CachedPersister)) {
59 59
             return null;
60 60
         }
61 61
 
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         $metadata  = $this->em->getClassMetadata($className);
71 71
         $persister = $this->uow->getCollectionPersister($metadata->getProperty($association));
72 72
 
73
-        if (! ($persister instanceof CachedPersister)) {
73
+        if ( ! ($persister instanceof CachedPersister)) {
74 74
             return null;
75 75
         }
76 76
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         $metadata  = $this->em->getClassMetadata($className);
86 86
         $persister = $this->uow->getEntityPersister($metadata->getRootClassName());
87 87
 
88
-        if (! ($persister instanceof CachedPersister)) {
88
+        if ( ! ($persister instanceof CachedPersister)) {
89 89
             return false;
90 90
         }
91 91
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         $metadata  = $this->em->getClassMetadata($className);
101 101
         $persister = $this->uow->getEntityPersister($metadata->getRootClassName());
102 102
 
103
-        if (! ($persister instanceof CachedPersister)) {
103
+        if ( ! ($persister instanceof CachedPersister)) {
104 104
             return;
105 105
         }
106 106
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         $metadata  = $this->em->getClassMetadata($className);
116 116
         $persister = $this->uow->getEntityPersister($metadata->getRootClassName());
117 117
 
118
-        if (! ($persister instanceof CachedPersister)) {
118
+        if ( ! ($persister instanceof CachedPersister)) {
119 119
             return;
120 120
         }
121 121
 
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
         foreach ($metadatas as $metadata) {
133 133
             $persister = $this->uow->getEntityPersister($metadata->getRootClassName());
134 134
 
135
-            if (! ($persister instanceof CachedPersister)) {
135
+            if ( ! ($persister instanceof CachedPersister)) {
136 136
                 continue;
137 137
             }
138 138
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         $metadata  = $this->em->getClassMetadata($className);
149 149
         $persister = $this->uow->getCollectionPersister($metadata->getProperty($association));
150 150
 
151
-        if (! ($persister instanceof CachedPersister)) {
151
+        if ( ! ($persister instanceof CachedPersister)) {
152 152
             return false;
153 153
         }
154 154
 
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
         $metadata  = $this->em->getClassMetadata($className);
164 164
         $persister = $this->uow->getCollectionPersister($metadata->getProperty($association));
165 165
 
166
-        if (! ($persister instanceof CachedPersister)) {
166
+        if ( ! ($persister instanceof CachedPersister)) {
167 167
             return;
168 168
         }
169 169
 
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
         $metadata  = $this->em->getClassMetadata($className);
179 179
         $persister = $this->uow->getCollectionPersister($metadata->getProperty($association));
180 180
 
181
-        if (! ($persister instanceof CachedPersister)) {
181
+        if ( ! ($persister instanceof CachedPersister)) {
182 182
             return;
183 183
         }
184 184
 
@@ -194,13 +194,13 @@  discard block
 block discarded – undo
194 194
 
195 195
         foreach ($metadatas as $metadata) {
196 196
             foreach ($metadata->getDeclaredPropertiesIterator() as $association) {
197
-                if (! $association instanceof ToManyAssociationMetadata) {
197
+                if ( ! $association instanceof ToManyAssociationMetadata) {
198 198
                     continue;
199 199
                 }
200 200
 
201 201
                 $persister = $this->uow->getCollectionPersister($association);
202 202
 
203
-                if (! ($persister instanceof CachedPersister)) {
203
+                if ( ! ($persister instanceof CachedPersister)) {
204 204
                     continue;
205 205
                 }
206 206
 
@@ -251,11 +251,10 @@  discard block
 block discarded – undo
251 251
     public function getQueryCache($regionName = null)
252 252
     {
253 253
         if ($regionName === null) {
254
-            return $this->defaultQueryCache ?:
255
-                $this->defaultQueryCache = $this->cacheFactory->buildQueryCache($this->em);
254
+            return $this->defaultQueryCache ?: $this->defaultQueryCache = $this->cacheFactory->buildQueryCache($this->em);
256 255
         }
257 256
 
258
-        if (! isset($this->queryCaches[$regionName])) {
257
+        if ( ! isset($this->queryCaches[$regionName])) {
259 258
             $this->queryCaches[$regionName] = $this->cacheFactory->buildQueryCache($this->em, $regionName);
260 259
         }
261 260
 
@@ -270,7 +269,7 @@  discard block
 block discarded – undo
270 269
      */
271 270
     private function buildEntityCacheKey(ClassMetadata $metadata, $identifier)
272 271
     {
273
-        if (! is_array($identifier)) {
272
+        if ( ! is_array($identifier)) {
274 273
             $identifier = $this->toIdentifierArray($metadata, $identifier);
275 274
         }
276 275
 
@@ -286,7 +285,7 @@  discard block
 block discarded – undo
286 285
      */
287 286
     private function buildCollectionCacheKey(ClassMetadata $metadata, $association, $ownerIdentifier)
288 287
     {
289
-        if (! is_array($ownerIdentifier)) {
288
+        if ( ! is_array($ownerIdentifier)) {
290 289
             $ownerIdentifier = $this->toIdentifierArray($metadata, $ownerIdentifier);
291 290
         }
292 291
 
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/DefaultEntityHydrator.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -54,11 +54,11 @@  discard block
 block discarded – undo
54 54
         }
55 55
 
56 56
         foreach ($metadata->getDeclaredPropertiesIterator() as $name => $association) {
57
-            if (! isset($data[$name]) || $association instanceof FieldMetadata) {
57
+            if ( ! isset($data[$name]) || $association instanceof FieldMetadata) {
58 58
                 continue;
59 59
             }
60 60
 
61
-            if (! $association instanceof ToOneAssociationMetadata) {
61
+            if ( ! $association instanceof ToOneAssociationMetadata) {
62 62
                 unset($data[$name]);
63 63
 
64 64
                 continue;
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
             $targetClassMetadata = $this->em->getClassMetadata($targetEntity);
69 69
             $targetPersister     = $this->uow->getEntityPersister($targetEntity);
70 70
 
71
-            if (! $association->getCache()) {
71
+            if ( ! $association->getCache()) {
72 72
                 $owningAssociation = ! $association->isOwningSide()
73 73
                     ? $targetClassMetadata->getProperty($association->getMappedBy())
74 74
                     : $association;
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
                 continue;
117 117
             }
118 118
 
119
-            if (! $association->isPrimaryKey()) {
119
+            if ( ! $association->isPrimaryKey()) {
120 120
                 $targetClass = StaticClassNameConverter::getClass($data[$name]);
121 121
                 $targetId    = $this->uow->getEntityIdentifier($data[$name]);
122 122
                 $data[$name] = new AssociationCacheEntry($targetClass, $targetId);
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
                 ($association instanceof OneToOneAssociationMetadata && ! $association->isOwningSide())
166 166
             );
167 167
 
168
-            if (! $isEagerLoad) {
168
+            if ( ! $isEagerLoad) {
169 169
                 $data[$name] = $this->em->getReference($assocClass, $assocId);
170 170
 
171 171
                 continue;
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Reflection/StaticReflectionService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
     public function getClassShortName(string $className) : string
29 29
     {
30 30
         if (strpos($className, '\\') !== false) {
31
-            $className = substr($className, strrpos($className, '\\')+1);
31
+            $className = substr($className, strrpos($className, '\\') + 1);
32 32
         }
33 33
         return $className;
34 34
     }
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
         $namespace = '';
42 42
 
43 43
         if (strpos($className, '\\') !== false) {
44
-            $namespace = strrev(substr(strrev($className), strpos(strrev($className), '\\')+1));
44
+            $namespace = strrev(substr(strrev($className), strpos(strrev($className), '\\') + 1));
45 45
         }
46 46
 
47 47
         return $namespace;
Please login to merge, or discard this patch.