Failed Conditions
Pull Request — develop (#6935)
by Michael
65:23
created
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC618Test.php 3 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -155,6 +155,9 @@  discard block
 block discarded – undo
155 155
         $this->books = new \Doctrine\Common\Collections\ArrayCollection;
156 156
     }
157 157
 
158
+    /**
159
+     * @param string $title
160
+     */
158 161
     public function addBook($title)
159 162
     {
160 163
         $book = new DDC618Book($title, $this);
@@ -179,6 +182,9 @@  discard block
 block discarded – undo
179 182
     /** @ORM\ManyToOne(targetEntity="DDC618Author", inversedBy="books") */
180 183
     public $author;
181 184
 
185
+    /**
186
+     * @param DDC618Author $author
187
+     */
182 188
     function __construct($title, $author)
183 189
     {
184 190
         $this->title = $title;
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     public function testIndexByJoin()
76 76
     {
77 77
         $dql = 'SELECT A, B FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Author A '.
78
-               'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
78
+                'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
79 79
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_OBJECT);
80 80
 
81 81
         self::assertCount(3, $result[0]->books); // Alice, Joe doesn't appear because he has no books.
@@ -99,14 +99,14 @@  discard block
 block discarded – undo
99 99
     public function testIndexByToOneJoinSilentlyIgnored()
100 100
     {
101 101
         $dql = 'SELECT B, A FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Book B '.
102
-               'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
102
+                'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
103 103
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_OBJECT);
104 104
 
105 105
         self::assertInstanceOf(DDC618Book::class, $result[0]);
106 106
         self::assertInstanceOf(DDC618Author::class, $result[0]->author);
107 107
 
108 108
         $dql = 'SELECT B, A FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Book B '.
109
-               'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
109
+                'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
110 110
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_ARRAY);
111 111
 
112 112
         self::assertEquals("Alice", $result[0]['author']['name']);
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     public function testCombineIndexBy()
119 119
     {
120 120
         $dql = 'SELECT A, B FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Author A INDEX BY A.id '.
121
-               'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
121
+                'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
122 122
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_OBJECT);
123 123
 
124 124
         self::assertArrayHasKey(11, $result); // Alice
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional\Ticket;
6 6
 
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 
41 41
             $this->em->flush();
42 42
             $this->em->clear();
43
-        } catch(\Exception $e) {
43
+        } catch (\Exception $e) {
44 44
 
45 45
         }
46 46
     }
@@ -80,17 +80,17 @@  discard block
 block discarded – undo
80 80
 
81 81
         self::assertCount(3, $result[0]->books); // Alice, Joe doesn't appear because he has no books.
82 82
         self::assertEquals('Alice', $result[0]->name);
83
-        self::assertTrue( isset($result[0]->books["In Wonderland"] ), "Indexing by title should have books by title.");
84
-        self::assertTrue( isset($result[0]->books["Reloaded"] ), "Indexing by title should have books by title.");
85
-        self::assertTrue( isset($result[0]->books["Test"] ), "Indexing by title should have books by title.");
83
+        self::assertTrue(isset($result[0]->books["In Wonderland"]), "Indexing by title should have books by title.");
84
+        self::assertTrue(isset($result[0]->books["Reloaded"]), "Indexing by title should have books by title.");
85
+        self::assertTrue(isset($result[0]->books["Test"]), "Indexing by title should have books by title.");
86 86
 
87 87
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_ARRAY);
88 88
 
89 89
         self::assertCount(3, $result[0]['books']); // Alice, Joe doesn't appear because he has no books.
90 90
         self::assertEquals('Alice', $result[0]['name']);
91
-        self::assertTrue( isset($result[0]['books']["In Wonderland"] ), "Indexing by title should have books by title.");
92
-        self::assertTrue( isset($result[0]['books']["Reloaded"] ), "Indexing by title should have books by title.");
93
-        self::assertTrue( isset($result[0]['books']["Test"] ), "Indexing by title should have books by title.");
91
+        self::assertTrue(isset($result[0]['books']["In Wonderland"]), "Indexing by title should have books by title.");
92
+        self::assertTrue(isset($result[0]['books']["Reloaded"]), "Indexing by title should have books by title.");
93
+        self::assertTrue(isset($result[0]['books']["Test"]), "Indexing by title should have books by title.");
94 94
     }
95 95
 
96 96
     /**
@@ -125,9 +125,9 @@  discard block
 block discarded – undo
125 125
 
126 126
         self::assertCount(3, $result[11]->books); // Alice, Joe doesn't appear because he has no books.
127 127
         self::assertEquals('Alice', $result[11]->name);
128
-        self::assertTrue( isset($result[11]->books["In Wonderland"] ), "Indexing by title should have books by title.");
129
-        self::assertTrue( isset($result[11]->books["Reloaded"] ), "Indexing by title should have books by title.");
130
-        self::assertTrue( isset($result[11]->books["Test"] ), "Indexing by title should have books by title.");
128
+        self::assertTrue(isset($result[11]->books["In Wonderland"]), "Indexing by title should have books by title.");
129
+        self::assertTrue(isset($result[11]->books["Reloaded"]), "Indexing by title should have books by title.");
130
+        self::assertTrue(isset($result[11]->books["Test"]), "Indexing by title should have books by title.");
131 131
     }
132 132
 }
133 133
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC832Test.php 2 patches
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -167,6 +167,9 @@  discard block
 block discarded – undo
167 167
      */
168 168
     public $version;
169 169
 
170
+    /**
171
+     * @param string $word
172
+     */
170 173
     public function __construct($word)
171 174
     {
172 175
         $this->word = $word;
@@ -196,6 +199,9 @@  discard block
 block discarded – undo
196 199
      */
197 200
     public $version;
198 201
 
202
+    /**
203
+     * @param string $name
204
+     */
199 205
     public function __construct($name)
200 206
     {
201 207
         $this->name = $name;
@@ -214,6 +220,11 @@  discard block
 block discarded – undo
214 220
     /** @ORM\Column(type="integer") */
215 221
     public $rgt;
216 222
 
223
+    /**
224
+     * @param string $name
225
+     * @param integer $lft
226
+     * @param integer $rgt
227
+     */
217 228
     public function __construct($name, $lft, $rgt)
218 229
     {
219 230
         $this->name = $name;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional\Ticket;
6 6
 
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
                     $this->em->getClassMetadata(DDC832Like::class),
29 29
                 ]
30 30
             );
31
-        } catch(\Exception $e) {
31
+        } catch (\Exception $e) {
32 32
         }
33 33
     }
34 34
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/ValueObjectsTest.php 2 patches
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -353,6 +353,9 @@  discard block
 block discarded – undo
353 353
     /** @ORM\Embedded(class = "DDC93Timestamps") */
354 354
     public $timestamps;
355 355
 
356
+    /**
357
+     * @param string $name
358
+     */
356 359
     public function __construct($name = null, DDC93Address $address = null)
357 360
     {
358 361
         $this->name = $name;
@@ -415,6 +418,9 @@  discard block
 block discarded – undo
415 418
      */
416 419
     public $name;
417 420
 
421
+    /**
422
+     * @param string $name
423
+     */
418 424
     public function __construct($name = null)
419 425
     {
420 426
         $this->name = $name;
@@ -441,6 +447,11 @@  discard block
 block discarded – undo
441 447
     /** @ORM\Embedded(class = "DDC93Country") */
442 448
     public $country;
443 449
 
450
+    /**
451
+     * @param string $street
452
+     * @param string $zip
453
+     * @param string $city
454
+     */
444 455
     public function __construct($street = null, $zip = null, $city = null, DDC93Country $country = null)
445 456
     {
446 457
         $this->street = $street;
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional;
6 6
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
                 $this->em->getClassMetadata(DDC3027Dog::class),
33 33
                 ]
34 34
             );
35
-        } catch(\Exception $e) {
35
+        } catch (\Exception $e) {
36 36
         }
37 37
     }
38 38
 
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         $this->em->flush();
112 112
         $this->em->clear();
113 113
 
114
-        $dql = "SELECT p FROM " . __NAMESPACE__ . "\DDC93Person p";
114
+        $dql = "SELECT p FROM ".__NAMESPACE__."\DDC93Person p";
115 115
         $persons = $this->em->createQuery($dql)->getResult();
116 116
 
117 117
         self::assertCount(3, $persons);
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
             self::assertEquals('United States of America', $person->address->country->name);
125 125
         }
126 126
 
127
-        $dql = "SELECT p FROM " . __NAMESPACE__ . "\DDC93Person p";
127
+        $dql = "SELECT p FROM ".__NAMESPACE__."\DDC93Person p";
128 128
         $persons = $this->em->createQuery($dql)->getArrayResult();
129 129
 
130 130
         foreach ($persons as $person) {
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
         $this->em->flush();
150 150
 
151 151
         // SELECT
152
-        $selectDql = "SELECT p FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country";
152
+        $selectDql = "SELECT p FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country";
153 153
         $loadedPerson = $this->em->createQuery($selectDql)
154 154
             ->setParameter('city', 'Karlsruhe')
155 155
             ->setParameter('country', 'Germany')
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
         );
165 165
 
166 166
         // UPDATE
167
-        $updateDql = "UPDATE " . __NAMESPACE__ . "\\DDC93Person p SET p.address.street = :street, p.address.country.name = :country WHERE p.address.city = :city";
167
+        $updateDql = "UPDATE ".__NAMESPACE__."\\DDC93Person p SET p.address.street = :street, p.address.country.name = :country WHERE p.address.city = :city";
168 168
         $this->em->createQuery($updateDql)
169 169
             ->setParameter('street', 'Boo')
170 170
             ->setParameter('country', 'DE')
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
         self::assertEquals('DE', $person->address->country->name);
177 177
 
178 178
         // DELETE
179
-        $this->em->createQuery("DELETE " . __NAMESPACE__ . "\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country")
179
+        $this->em->createQuery("DELETE ".__NAMESPACE__."\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country")
180 180
             ->setParameter('city', 'Karlsruhe')
181 181
             ->setParameter('country', 'DE')
182 182
             ->execute();
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
         $this->em->clear();
194 194
 
195 195
         // Prove that the entity was persisted correctly.
196
-        $dql = "SELECT p FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.name = :name";
196
+        $dql = "SELECT p FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.name = :name";
197 197
 
198 198
         $person = $this->em->createQuery($dql)
199 199
             ->setParameter('name', 'Karl')
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
         // Clear the EM and prove that the embeddable can be the subject of a partial query.
208 208
         $this->em->clear();
209 209
 
210
-        $dql = "SELECT PARTIAL p.{id,address.city} FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.name = :name";
210
+        $dql = "SELECT PARTIAL p.{id,address.city} FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.name = :name";
211 211
 
212 212
         $person = $this->em->createQuery($dql)
213 213
             ->setParameter('name', 'Karl')
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
         // Clear the EM and prove that the embeddable can be the subject of a partial query regardless of attributes positions.
224 224
         $this->em->clear();
225 225
 
226
-        $dql = "SELECT PARTIAL p.{address.city, id} FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.name = :name";
226
+        $dql = "SELECT PARTIAL p.{address.city, id} FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.name = :name";
227 227
 
228 228
         $person = $this->em->createQuery($dql)
229 229
             ->setParameter('name', 'Karl')
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
         $this->expectException(QueryException::class);
243 243
         $this->expectExceptionMessage('no field or association named address.asdfasdf');
244 244
 
245
-        $this->em->createQuery("SELECT p FROM " . __NAMESPACE__ . "\\DDC93Person p WHERE p.address.asdfasdf IS NULL")
245
+        $this->em->createQuery("SELECT p FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.address.asdfasdf IS NULL")
246 246
             ->execute();
247 247
     }
248 248
 
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
         $this->expectException(QueryException::class);
252 252
         $this->expectExceptionMessage("no mapped field named 'address.asdfasdf'");
253 253
 
254
-        $this->em->createQuery("SELECT PARTIAL p.{id,address.asdfasdf} FROM " . __NAMESPACE__ . "\\DDC93Person p")
254
+        $this->em->createQuery("SELECT PARTIAL p.{id,address.asdfasdf} FROM ".__NAMESPACE__."\\DDC93Person p")
255 255
             ->execute();
256 256
     }
257 257
 
@@ -313,15 +313,15 @@  discard block
 block discarded – undo
313 313
         $this->expectException(MappingException::class);
314 314
         $this->expectExceptionMessage(
315 315
             sprintf(
316
-                'Infinite nesting detected for embedded property %s::nested. ' .
316
+                'Infinite nesting detected for embedded property %s::nested. '.
317 317
                 'You cannot embed an embeddable from the same type inside an embeddable.',
318
-                __NAMESPACE__ . '\\' . $declaredEmbeddableClassName
318
+                __NAMESPACE__.'\\'.$declaredEmbeddableClassName
319 319
             )
320 320
         );
321 321
 
322 322
         $this->schemaTool->createSchema(
323 323
             [
324
-            $this->em->getClassMetadata(__NAMESPACE__ . '\\' . $embeddableClassName),
324
+            $this->em->getClassMetadata(__NAMESPACE__.'\\'.$embeddableClassName),
325 325
             ]
326 326
         );
327 327
     }
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Performance/SecondLevelCacheTest.php 2 patches
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -127,6 +127,9 @@  discard block
 block discarded – undo
127 127
         self::assertEquals(503, $this->countQuery($em));
128 128
     }
129 129
 
130
+    /**
131
+     * @param string $label
132
+     */
130 133
     private function queryEntity(EntityManagerInterface $em, $label)
131 134
     {
132 135
         $times        = 100;
@@ -158,6 +161,9 @@  discard block
 block discarded – undo
158 161
         printf("\n%s\n", str_repeat('-', 50));
159 162
     }
160 163
 
164
+    /**
165
+     * @param string $label
166
+     */
161 167
     public function findEntityOneToMany(EntityManagerInterface $em, $label)
162 168
     {
163 169
         $times        = 50;
@@ -217,6 +223,9 @@  discard block
 block discarded – undo
217 223
         printf("\n%s\n", str_repeat('-', 50));
218 224
     }
219 225
 
226
+    /**
227
+     * @param string $label
228
+     */
220 229
     private function findEntity(EntityManagerInterface $em, $label)
221 230
     {
222 231
         $times        = 10;
@@ -252,6 +261,9 @@  discard block
 block discarded – undo
252 261
         printf("\n%s\n", str_repeat('-', 50));
253 262
     }
254 263
 
264
+    /**
265
+     * @param string $label
266
+     */
255 267
     private function findAllEntity(EntityManagerInterface $em, $label)
256 268
     {
257 269
         $times        = 100;
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Performance;
6 6
 
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
         $size         = 500;
134 134
         $startPersist = microtime(true);
135 135
 
136
-        echo PHP_EOL . $label;
136
+        echo PHP_EOL.$label;
137 137
 
138 138
         for ($i = 0; $i < $size; $i++) {
139 139
             $em->persist(new Country("Country $i"));
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
         $startPersist = microtime(true);
168 168
         $country      = new Country("Country");
169 169
 
170
-        echo PHP_EOL . $label;
170
+        echo PHP_EOL.$label;
171 171
 
172 172
         $em->persist($country);
173 173
         $em->flush();
@@ -197,9 +197,9 @@  discard block
 block discarded – undo
197 197
         $em->flush();
198 198
         $em->clear();
199 199
 
200
-        printf("\n[%s] persist %s states and %s cities", number_format( microtime(true) - $startPersist, 6), count($states), count($cities));
200
+        printf("\n[%s] persist %s states and %s cities", number_format(microtime(true) - $startPersist, 6), count($states), count($cities));
201 201
 
202
-        $startFind  = microtime(true);
202
+        $startFind = microtime(true);
203 203
 
204 204
         for ($i = 0; $i < $times; $i++) {
205 205
 
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
         $countries    = [];
225 225
         $startPersist = microtime(true);
226 226
 
227
-        echo PHP_EOL . $label;
227
+        echo PHP_EOL.$label;
228 228
 
229 229
         for ($i = 0; $i < $size; $i++) {
230 230
             $country = new Country("Country $i");
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
 
240 240
         printf("\n[%s] persist %s countries", number_format(microtime(true) - $startPersist, 6), $size);
241 241
 
242
-        $startFind  = microtime(true);
242
+        $startFind = microtime(true);
243 243
 
244 244
         for ($i = 0; $i <= $times; $i++) {
245 245
             foreach ($countries as $country) {
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
         $startPersist = microtime(true);
260 260
         $rep          = $em->getRepository(Country::class);
261 261
 
262
-        echo PHP_EOL . $label;
262
+        echo PHP_EOL.$label;
263 263
 
264 264
         for ($i = 0; $i < $size; $i++) {
265 265
             $em->persist(new Country("Country $i"));
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 
271 271
         printf("\n[%s] persist %s countries", number_format(microtime(true) - $startPersist, 6), $size);
272 272
 
273
-        $startFind  = microtime(true);
273
+        $startFind = microtime(true);
274 274
 
275 275
         for ($i = 0; $i <= $times; $i++) {
276 276
             $list = $rep->findAll();
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Query/CustomTreeWalkersJoinTest.php 3 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -25,6 +25,10 @@
 block discarded – undo
25 25
         $this->em = $this->getTestEntityManager();
26 26
     }
27 27
 
28
+    /**
29
+     * @param string $dqlToBeTested
30
+     * @param string $sqlToBeConfirmed
31
+     */
28 32
     public function assertSqlGeneration($dqlToBeTested, $sqlToBeConfirmed)
29 33
     {
30 34
         try {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         try {
31 31
             $query = $this->em->createQuery($dqlToBeTested);
32 32
             $query->setHint(Query::HINT_CUSTOM_TREE_WALKERS, [CustomTreeWalkerJoin::class])
33
-                  ->useQueryCache(false);
33
+                    ->useQueryCache(false);
34 34
 
35 35
             $sqlGenerated = $query->getSql();
36 36
 
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Query;
6 6
 
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
             $query->free();
38 38
         } catch (\Exception $e) {
39
-            $this->fail($e->getMessage() . ' at "' . $e->getFile() . '" on line ' . $e->getLine());
39
+            $this->fail($e->getMessage().' at "'.$e->getFile().'" on line '.$e->getLine());
40 40
         }
41 41
 
42 42
         self::assertEquals($sqlToBeConfirmed, $sqlGenerated);
@@ -78,9 +78,9 @@  discard block
 block discarded – undo
78 78
     {
79 79
         $rangeVariableDecl       = $identificationVariableDecl->rangeVariableDeclaration;
80 80
         $joinAssocPathExpression = new Query\AST\JoinAssociationPathExpression($rangeVariableDecl->aliasIdentificationVariable, 'address');
81
-        $joinAssocDeclaration    = new Query\AST\JoinAssociationDeclaration($joinAssocPathExpression, $rangeVariableDecl->aliasIdentificationVariable . 'a', null);
81
+        $joinAssocDeclaration    = new Query\AST\JoinAssociationDeclaration($joinAssocPathExpression, $rangeVariableDecl->aliasIdentificationVariable.'a', null);
82 82
         $join                    = new Query\AST\Join(Query\AST\Join::JOIN_TYPE_LEFT, $joinAssocDeclaration);
83
-        $selectExpression        = new Query\AST\SelectExpression($rangeVariableDecl->aliasIdentificationVariable . 'a', null, false);
83
+        $selectExpression        = new Query\AST\SelectExpression($rangeVariableDecl->aliasIdentificationVariable.'a', null, false);
84 84
 
85 85
         $identificationVariableDecl->joins[]                = $join;
86 86
         $selectStatement->selectClause->selectExpressions[] = $selectExpression;
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         $userMetadata    = $entityManager->getClassMetadata(CmsUser::class);
90 90
         $addressMetadata = $entityManager->getClassMetadata(CmsAddress::class);
91 91
 
92
-        $this->setQueryComponent($rangeVariableDecl->aliasIdentificationVariable . 'a',
92
+        $this->setQueryComponent($rangeVariableDecl->aliasIdentificationVariable.'a',
93 93
             [
94 94
                 'metadata'     => $addressMetadata,
95 95
                 'parent'       => $rangeVariableDecl->aliasIdentificationVariable,
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/QueryBuilderTest.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -37,6 +37,9 @@
 block discarded – undo
37 37
         $this->em = $this->getTestEntityManager();
38 38
     }
39 39
 
40
+    /**
41
+     * @param string $expectedDql
42
+     */
40 43
     protected function assertValidQueryBuilder(QueryBuilder $qb, $expectedDql)
41 44
     {
42 45
         $dql = $qb->getDQL();
Please login to merge, or discard this patch.
Indentation   +37 added lines, -37 removed lines patch added patch discarded remove patch
@@ -274,12 +274,12 @@  discard block
 block discarded – undo
274 274
     {
275 275
         $qb = $this->em->createQueryBuilder();
276 276
         $qb->select('u')
277
-           ->from(CmsUser::class, 'u')
278
-           ->where('u.id = :uid')
279
-           ->orWhere('u.id = :uid2')
280
-           ->andWhere('u.id = :uid3')
281
-           ->orWhere('u.name = :name1', 'u.name = :name2')
282
-           ->andWhere('u.name <> :noname');
277
+            ->from(CmsUser::class, 'u')
278
+            ->where('u.id = :uid')
279
+            ->orWhere('u.id = :uid2')
280
+            ->andWhere('u.id = :uid3')
281
+            ->orWhere('u.name = :name1', 'u.name = :name2')
282
+            ->andWhere('u.name <> :noname');
283 283
 
284 284
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE (((u.id = :uid OR u.id = :uid2) AND u.id = :uid3) OR u.name = :name1 OR u.name = :name2) AND u.name <> :noname');
285 285
     }
@@ -288,9 +288,9 @@  discard block
 block discarded – undo
288 288
     {
289 289
         $qb = $this->em->createQueryBuilder();
290 290
         $qb->select('u')
291
-           ->from(CmsUser::class, 'u')
292
-           ->where('u.id = :uid')
293
-           ->andWhere($qb->expr()->in('u.id', [1, 2, 3]));
291
+            ->from(CmsUser::class, 'u')
292
+            ->where('u.id = :uid')
293
+            ->andWhere($qb->expr()->in('u.id', [1, 2, 3]));
294 294
 
295 295
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid AND u.id IN(1, 2, 3)');
296 296
     }
@@ -299,9 +299,9 @@  discard block
 block discarded – undo
299 299
     {
300 300
         $qb = $this->em->createQueryBuilder();
301 301
         $qb->select('u')
302
-           ->from(CmsUser::class, 'u')
303
-           ->where('u.id = :uid')
304
-           ->orWhere($qb->expr()->in('u.id', [1, 2, 3]));
302
+            ->from(CmsUser::class, 'u')
303
+            ->where('u.id = :uid')
304
+            ->orWhere($qb->expr()->in('u.id', [1, 2, 3]));
305 305
 
306 306
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid OR u.id IN(1, 2, 3)');
307 307
     }
@@ -310,9 +310,9 @@  discard block
 block discarded – undo
310 310
     {
311 311
         $qb = $this->em->createQueryBuilder();
312 312
         $qb->select('u')
313
-           ->from(CmsUser::class, 'u')
314
-           ->where('u.id = :uid')
315
-           ->andWhere($qb->expr()->notIn('u.id', [1, 2, 3]));
313
+            ->from(CmsUser::class, 'u')
314
+            ->where('u.id = :uid')
315
+            ->andWhere($qb->expr()->notIn('u.id', [1, 2, 3]));
316 316
 
317 317
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid AND u.id NOT IN(1, 2, 3)');
318 318
     }
@@ -321,9 +321,9 @@  discard block
 block discarded – undo
321 321
     {
322 322
         $qb = $this->em->createQueryBuilder();
323 323
         $qb->select('u')
324
-           ->from(CmsUser::class, 'u')
325
-           ->where('u.id = :uid')
326
-           ->orWhere($qb->expr()->notIn('u.id', [1, 2, 3]));
324
+            ->from(CmsUser::class, 'u')
325
+            ->where('u.id = :uid')
326
+            ->orWhere($qb->expr()->notIn('u.id', [1, 2, 3]));
327 327
 
328 328
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid OR u.id NOT IN(1, 2, 3)');
329 329
     }
@@ -619,8 +619,8 @@  discard block
 block discarded – undo
619 619
     {
620 620
         $qb = $this->em->createQueryBuilder();
621 621
         $qb->select('u')
622
-           ->from(CmsUser::class, 'u')
623
-           ->where($qb->expr()->orX('u.username = :username', 'u.username = :username2'));
622
+            ->from(CmsUser::class, 'u')
623
+            ->where($qb->expr()->orX('u.username = :username', 'u.username = :username2'));
624 624
 
625 625
         $parameters = new ArrayCollection();
626 626
         $parameters->add(new Parameter('username', 'jwage'));
@@ -636,8 +636,8 @@  discard block
 block discarded – undo
636 636
     {
637 637
         $qb = $this->em->createQueryBuilder();
638 638
         $qb->select('u')
639
-           ->from(CmsUser::class, 'u')
640
-           ->where('u.id = :id');
639
+            ->from(CmsUser::class, 'u')
640
+            ->where('u.id = :id');
641 641
 
642 642
         $parameters = new ArrayCollection();
643 643
         $parameters->add(new Parameter('id', 1));
@@ -686,8 +686,8 @@  discard block
 block discarded – undo
686 686
     {
687 687
         $qb = $this->em->createQueryBuilder();
688 688
         $qb->select('u')
689
-           ->from(CmsUser::class, 'u')
690
-           ->orWhere('u.id = :uid', $qb->expr()->eq('u.id', ':uid2'));
689
+            ->from(CmsUser::class, 'u')
690
+            ->orWhere('u.id = :uid', $qb->expr()->eq('u.id', ':uid2'));
691 691
 
692 692
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid OR u.id = :uid2');
693 693
     }
@@ -700,8 +700,8 @@  discard block
 block discarded – undo
700 700
         $orExpr->add($qb->expr()->in('u.id', [1]));
701 701
 
702 702
         $qb->select('u')
703
-           ->from(CmsUser::class, 'u')
704
-           ->where($orExpr);
703
+            ->from(CmsUser::class, 'u')
704
+            ->where($orExpr);
705 705
 
706 706
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid3 OR u.id IN(1)');
707 707
     }
@@ -710,8 +710,8 @@  discard block
 block discarded – undo
710 710
     {
711 711
         $qb = $this->em->createQueryBuilder();
712 712
         $qb->select('u')
713
-           ->from(CmsUser::class, 'u')
714
-           ->where($qb->expr()->in('u.name', ['one', 'two', 'three']));
713
+            ->from(CmsUser::class, 'u')
714
+            ->where($qb->expr()->in('u.name', ['one', 'two', 'three']));
715 715
 
716 716
         self::assertValidQueryBuilder($qb, "SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.name IN('one', 'two', 'three')");
717 717
 
@@ -725,8 +725,8 @@  discard block
 block discarded – undo
725 725
         $qb = $this->em->createQueryBuilder();
726 726
         $expr = $this->em->getExpressionBuilder();
727 727
         $qb->select('u')
728
-           ->from(CmsUser::class, 'u')
729
-           ->where($expr->in('u.name', [$expr->literal('one'), $expr->literal('two'), $expr->literal('three')]));
728
+            ->from(CmsUser::class, 'u')
729
+            ->where($expr->in('u.name', [$expr->literal('one'), $expr->literal('two'), $expr->literal('three')]));
730 730
 
731 731
         self::assertValidQueryBuilder($qb, "SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.name IN('one', 'two', 'three')");
732 732
 
@@ -744,8 +744,8 @@  discard block
 block discarded – undo
744 744
 
745 745
         $qb = $this->em->createQueryBuilder();
746 746
         $qb->select('u')
747
-           ->from(CmsUser::class, 'u')
748
-           ->where($orExpr);
747
+            ->from(CmsUser::class, 'u')
748
+            ->where($orExpr);
749 749
 
750 750
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid3 OR NOT(u.id IN(1))');
751 751
     }
@@ -756,8 +756,8 @@  discard block
 block discarded – undo
756 756
         $expr = $this->em->getExpressionBuilder();
757 757
 
758 758
         $qb->select('u')
759
-           ->from(CmsUser::class, 'u')
760
-           ->where($expr->gt('u.id', $expr->all('select a.id from Doctrine\Tests\Models\CMS\CmsArticle a')));
759
+            ->from(CmsUser::class, 'u')
760
+            ->where($expr->gt('u.id', $expr->all('select a.id from Doctrine\Tests\Models\CMS\CmsArticle a')));
761 761
 
762 762
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id > ALL(select a.id from Doctrine\Tests\Models\CMS\CmsArticle a)');
763 763
 
@@ -1123,9 +1123,9 @@  discard block
 block discarded – undo
1123 1123
     public function testRebuildsFromParts()
1124 1124
     {
1125 1125
         $qb = $this->em->createQueryBuilder()
1126
-          ->select('u')
1127
-          ->from(CmsUser::class, 'u')
1128
-          ->join('u.article', 'a');
1126
+            ->select('u')
1127
+            ->from(CmsUser::class, 'u')
1128
+            ->join('u.article', 'a');
1129 1129
 
1130 1130
         $dqlParts = $qb->getDQLParts();
1131 1131
         $dql = $qb->getDQL();
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM;
6 6
 
@@ -549,7 +549,7 @@  discard block
 block discarded – undo
549 549
         $qb = $this->em->createQueryBuilder();
550 550
         $qb->select('u')
551 551
             ->from(CmsUser::class, 'u')
552
-            ->join('u.article','a');
552
+            ->join('u.article', 'a');
553 553
 
554 554
         $criteria = new Criteria();
555 555
         $criteria->orderBy(['a.field' => Criteria::DESC]);
@@ -826,7 +826,7 @@  discard block
 block discarded – undo
826 826
             ->from(CmsUser::class, 'u')
827 827
             ->where('u.username = ?1')->orderBy('u.username');
828 828
 
829
-        self::assertEquals('u.username = ?1', (string)$qb->getDQLPart('where'));
829
+        self::assertEquals('u.username = ?1', (string) $qb->getDQLPart('where'));
830 830
         self::assertCount(1, $qb->getDQLPart('orderBy'));
831 831
 
832 832
         $qb->resetDQLPart('where')->resetDQLPart('orderBy');
@@ -890,7 +890,7 @@  discard block
 block discarded – undo
890 890
     {
891 891
         $qb = $this->em->createQueryBuilder();
892 892
         $qb->select('alias1')->from(CmsUser::class, 'alias1');
893
-        $qb->join('alias1.articles','alias2');
893
+        $qb->join('alias1.articles', 'alias2');
894 894
 
895 895
         $criteria = new Criteria();
896 896
         $criteria->where($criteria->expr()->eq('field', 'value1'));
@@ -910,7 +910,7 @@  discard block
 block discarded – undo
910 910
     {
911 911
         $qb = $this->em->createQueryBuilder();
912 912
         $qb->select('alias1')->from(CmsUser::class, 'alias1');
913
-        $qb->join('alias1.articles','alias2');
913
+        $qb->join('alias1.articles', 'alias2');
914 914
 
915 915
         $criteria = new Criteria();
916 916
         $criteria->where($criteria->expr()->eq('alias1.field', 'value1'));
@@ -930,7 +930,7 @@  discard block
 block discarded – undo
930 930
     {
931 931
         $qb = $this->em->createQueryBuilder();
932 932
         $qb->select('alias1')->from(CmsUser::class, 'alias1');
933
-        $qb->join('alias1.articles','alias2');
933
+        $qb->join('alias1.articles', 'alias2');
934 934
 
935 935
         $criteria = new Criteria();
936 936
         $criteria->where($criteria->expr()->eq('alias1.field', 'value1'));
@@ -1046,7 +1046,7 @@  discard block
 block discarded – undo
1046 1046
     {
1047 1047
         $qb = $this->em->createQueryBuilder()
1048 1048
             ->add('select', 'u')
1049
-            ->add('from', CmsUser::class . ' u');
1049
+            ->add('from', CmsUser::class.' u');
1050 1050
 
1051 1051
         self::assertEquals('SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u', $qb->getDQL());
1052 1052
     }
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/UnitOfWorkTest.php 2 patches
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -654,6 +654,9 @@  discard block
 block discarded – undo
654 654
         return $this->items;
655 655
     }
656 656
 
657
+    /**
658
+     * @param string $value
659
+     */
657 660
     public function setTransient($value) {
658 661
         if ($value != $this->transient) {
659 662
             $this->onPropertyChanged('transient', $this->transient, $value);
@@ -665,6 +668,9 @@  discard block
 block discarded – undo
665 668
         return $this->data;
666 669
     }
667 670
 
671
+    /**
672
+     * @param string $data
673
+     */
668 674
     public function setData($data) {
669 675
         if ($data != $this->data) {
670 676
             $this->onPropertyChanged('data', $this->data, $data);
@@ -677,6 +683,9 @@  discard block
 block discarded – undo
677 683
         $this->listeners[] = $listener;
678 684
     }
679 685
 
686
+    /**
687
+     * @param string $propName
688
+     */
680 689
     protected function onPropertyChanged($propName, $oldValue, $newValue) {
681 690
         if ($this->listeners) {
682 691
             foreach ($this->listeners as $listener) {
@@ -707,6 +716,9 @@  discard block
 block discarded – undo
707 716
         return $this->owner;
708 717
     }
709 718
 
719
+    /**
720
+     * @param NotifyChangedEntity|null $owner
721
+     */
710 722
     public function setOwner($owner) {
711 723
         $this->owner = $owner;
712 724
     }
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM;
6 6
 
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
             'empty string, single field'     => [$emptyString, ''],
451 451
             'non-empty string, single field' => [$nonEmptyString, $nonEmptyString->id],
452 452
             'empty strings, two fields'      => [$emptyStrings, ' '],
453
-            'non-empty strings, two fields'  => [$nonEmptyStrings, $nonEmptyStrings->id1 . ' ' . $nonEmptyStrings->id2],
453
+            'non-empty strings, two fields'  => [$nonEmptyStrings, $nonEmptyStrings->id1.' '.$nonEmptyStrings->id2],
454 454
             'boolean true'                   => [$booleanTrue, '1'],
455 455
             'boolean false'                  => [$booleanFalse, ''],
456 456
         ];
@@ -481,7 +481,7 @@  discard block
 block discarded – undo
481 481
 
482 482
     public function entitiesWithInvalidIdentifiersProvider()
483 483
     {
484
-        $firstNullString  = new EntityWithCompositeStringIdentifier();
484
+        $firstNullString = new EntityWithCompositeStringIdentifier();
485 485
 
486 486
         $firstNullString->id2 = uniqid('id2', true);
487 487
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/TestInit.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -2,28 +2,28 @@
 block discarded – undo
2 2
 /*
3 3
  * This file bootstraps the test environment.
4 4
  */
5
-declare(strict_types=1);
5
+declare(strict_types = 1);
6 6
 
7 7
 namespace Doctrine\Tests;
8 8
 
9 9
 error_reporting(E_ALL | E_STRICT);
10 10
 date_default_timezone_set('UTC');
11 11
 
12
-if (file_exists(__DIR__ . '/../../../vendor/autoload.php')) {
12
+if (file_exists(__DIR__.'/../../../vendor/autoload.php')) {
13 13
     // dependencies were installed via composer - this is the main project
14
-    require __DIR__ . '/../../../vendor/autoload.php';
15
-} elseif (file_exists(__DIR__ . '/../../../../../autoload.php')) {
14
+    require __DIR__.'/../../../vendor/autoload.php';
15
+} elseif (file_exists(__DIR__.'/../../../../../autoload.php')) {
16 16
     // installed as a dependency in `vendor`
17
-    require __DIR__ . '/../../../../../autoload.php';
17
+    require __DIR__.'/../../../../../autoload.php';
18 18
 } else {
19 19
     throw new \Exception('Can\'t find autoload.php. Did you install dependencies via composer?');
20 20
 }
21 21
 
22
-if ( ! file_exists(__DIR__ . '/Proxies') && ! mkdir(__DIR__ . '/Proxies')) {
23
-    throw new \Exception("Could not create " . __DIR__."/Proxies Folder.");
22
+if ( ! file_exists(__DIR__.'/Proxies') && ! mkdir(__DIR__.'/Proxies')) {
23
+    throw new \Exception("Could not create ".__DIR__."/Proxies Folder.");
24 24
 }
25 25
 
26
-if ( ! file_exists(__DIR__ . '/ORM/Proxy/generated') &&  ! mkdir(__DIR__ . '/ORM/Proxy/generated')) {
27
-    throw new \Exception('Could not create ' . __DIR__ . '/ORM/Proxy/generated Folder.');
26
+if ( ! file_exists(__DIR__.'/ORM/Proxy/generated') && ! mkdir(__DIR__.'/ORM/Proxy/generated')) {
27
+    throw new \Exception('Could not create '.__DIR__.'/ORM/Proxy/generated Folder.');
28 28
 }
29 29
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DbalTestCase.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests;
6 6
 
Please login to merge, or discard this patch.